From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 1/3] xfs: consider freeze levels in xfs_fs_writable()
Date: Fri, 26 Sep 2014 02:44:36 -0700 [thread overview]
Message-ID: <20140926094436.GA10692@infradead.org> (raw)
In-Reply-To: <20140925210330.GG4945@dastard>
On Fri, Sep 26, 2014 at 07:03:30AM +1000, Dave Chinner wrote:
> I can mention it, but it's so trivial I didn't think it was worth
> it.
It does change behavior, so it should document why that was changed.
> The changelog says "Hence allow the caller to pass in the freeze
> level it is allowed to write" which is exactly what this code is
> doing.
The changelog says the you can pass the argument now. It doesn't
say that it did change a caller to pass a different argument, and more
importanly why.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-09-26 9:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 12:20 [PATCH 0/3 v2] xfs: superblock logging rework Dave Chinner
2014-09-25 12:20 ` [PATCH 1/3] xfs: consider freeze levels in xfs_fs_writable() Dave Chinner
2014-09-25 16:17 ` Christoph Hellwig
2014-09-25 21:03 ` Dave Chinner
2014-09-26 9:44 ` Christoph Hellwig [this message]
2014-09-29 12:18 ` Brian Foster
2014-09-25 12:20 ` [PATCH 2/3] xfs: remove bitfield based superblock updates Dave Chinner
2014-09-26 9:45 ` Christoph Hellwig
2014-09-26 23:01 ` Dave Chinner
2014-09-26 10:00 ` Christoph Hellwig
2014-09-26 23:02 ` Dave Chinner
2014-09-25 12:20 ` [PATCH 3/3] xfs: consolidate superblock logging functions Dave Chinner
2014-09-29 13:20 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140926094436.GA10692@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.