From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/3] xfs: remove bitfield based superblock updates
Date: Sat, 27 Sep 2014 09:02:35 +1000 [thread overview]
Message-ID: <20140926230235.GP4945@dastard> (raw)
In-Reply-To: <20140926100027.GG10692@infradead.org>
On Fri, Sep 26, 2014 at 03:00:27AM -0700, Christoph Hellwig wrote:
> > + to->sb_uquotino = cpu_to_be64(from->sb_uquotino);
> > + if (xfs_sb_version_has_pquotino(from)) {
> > + to->sb_qflags = be16_to_cpu(from->sb_qflags);
> > + to->sb_gquotino = cpu_to_be64(from->sb_gquotino);
> > + to->sb_pquotino = cpu_to_be64(from->sb_pquotino);
> > + return;
> > + }
>
> sparse complains that the be16_to_cpu should be a cpu_to_be16 for
> sb_qflags..
Good catch. Fixed.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-09-26 23:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 12:20 [PATCH 0/3 v2] xfs: superblock logging rework Dave Chinner
2014-09-25 12:20 ` [PATCH 1/3] xfs: consider freeze levels in xfs_fs_writable() Dave Chinner
2014-09-25 16:17 ` Christoph Hellwig
2014-09-25 21:03 ` Dave Chinner
2014-09-26 9:44 ` Christoph Hellwig
2014-09-29 12:18 ` Brian Foster
2014-09-25 12:20 ` [PATCH 2/3] xfs: remove bitfield based superblock updates Dave Chinner
2014-09-26 9:45 ` Christoph Hellwig
2014-09-26 23:01 ` Dave Chinner
2014-09-26 10:00 ` Christoph Hellwig
2014-09-26 23:02 ` Dave Chinner [this message]
2014-09-25 12:20 ` [PATCH 3/3] xfs: consolidate superblock logging functions Dave Chinner
2014-09-29 13:20 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140926230235.GP4945@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.