* Re: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add CLK_OF_DECLARE support
@ 2014-09-25 20:08 ` Scott Wood
0 siblings, 0 replies; 37+ messages in thread
From: Scott Wood @ 2014-09-25 20:08 UTC (permalink / raw)
To: Lu Jingchang-B35083
Cc: mturquette@linaro.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Well, like I said, I'd rather see the CLK_OF_DECLARE stuff be made to
work on PPC rather than have the driver carry around two binding
methods.
-Scott
On Thu, 2014-09-25 at 04:47 -0500, Lu Jingchang-B35083 wrote:
> Hi, Scott and Mike,
>
> Could you please help review this patch and give an ACK if ok. Thanks.
>
> Best Regards,
> Jingchang
>
> >-----Original Message-----
> >From: Jingchang Lu [mailto:jingchang.lu@freescale.com]
> >Sent: Tuesday, September 23, 2014 2:47 PM
> >To: mturquette@linaro.org
> >Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; linux-
> >kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Lu
> >Jingchang-B35083
> >Subject: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add
> >CLK_OF_DECLARE support
> >
> >The IP is shared by PPC and ARM, this renames it to qoriq for better
> >represention, and this also adds the CLK_OF_DECLARE support for being
> >initialized by of_clk_init() on ARM.
> >
> >Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com>
> >---
> >changes in v4:
> > remove "corenet" literals omitted in v3 remove.
> >
> >changes in v3:
> > generate the patch with -M -C option
> >
> >changes in v2:
> > rename the driver name to ppc-qoriq.c for shared on PPC and ARM.
> >
> > drivers/clk/Kconfig | 9 +++++----
> > drivers/clk/Makefile | 2 +-
> > drivers/clk/{clk-ppc-corenet.c => clk-qoriq.c} | 27 +++++++++++++++------
> >-----
> > 3 files changed, 22 insertions(+), 16 deletions(-) rename
> >drivers/clk/{clk-ppc-corenet.c => clk-qoriq.c} (89%)
> >
> >diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index
> >85131ae..f5f76cb 100644
> >--- a/drivers/clk/Kconfig
> >+++ b/drivers/clk/Kconfig
> >@@ -92,12 +92,13 @@ config COMMON_CLK_AXI_CLKGEN
> > Support for the Analog Devices axi-clkgen pcore clock generator
> >for Xilinx
> > FPGAs. It is commonly used in Analog Devices' reference designs.
> >
> >-config CLK_PPC_CORENET
> >- bool "Clock driver for PowerPC corenet platforms"
> >- depends on PPC_E500MC && OF
> >+config CLK_QORIQ
> >+ bool "Clock driver for PowerPC corenet and compatible ARM-based
> >platforms"
> >+ depends on (PPC_E500MC || ARM) && OF
> > ---help---
> > This adds the clock driver support for Freescale PowerPC corenet
> >- platforms using common clock framework.
> >+ platforms and compatible Freescale ARM based platforms using
> >common
> >+ clock framework.
> >
> > config COMMON_CLK_XGENE
> > bool "Clock driver for APM XGene SoC"
> >diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile index
> >27c542b..20f42e9 100644
> >--- a/drivers/clk/Makefile
> >+++ b/drivers/clk/Makefile
> >@@ -29,7 +29,7 @@ obj-$(CONFIG_ARCH_MOXART) += clk-moxart.o
> > obj-$(CONFIG_ARCH_NOMADIK) += clk-nomadik.o
> > obj-$(CONFIG_ARCH_NSPIRE) += clk-nspire.o
> > obj-$(CONFIG_COMMON_CLK_PALMAS) += clk-palmas.o
> >-obj-$(CONFIG_CLK_PPC_CORENET) += clk-ppc-corenet.o
> >+obj-$(CONFIG_CLK_QORIQ) += clk-qoriq.o
> > obj-$(CONFIG_COMMON_CLK_S2MPS11) += clk-s2mps11.o
> > obj-$(CONFIG_COMMON_CLK_SI5351) += clk-si5351.o
> > obj-$(CONFIG_COMMON_CLK_SI570) += clk-si570.o
> >diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-qoriq.c
> >similarity index 89% rename from drivers/clk/clk-ppc-corenet.c rename to
> >drivers/clk/clk-qoriq.c index 8e58edf..cba8abe 100644
> >--- a/drivers/clk/clk-ppc-corenet.c
> >+++ b/drivers/clk/clk-qoriq.c
> >@@ -155,7 +155,7 @@ static void __init core_pll_init(struct device_node
> >*np)
> >
> > base = of_iomap(np, 0);
> > if (!base) {
> >- pr_err("clk-ppc: iomap error\n");
> >+ pr_err("clk-qoriq: iomap error\n");
> > return;
> > }
> >
> >@@ -252,7 +252,7 @@ static void __init sysclk_init(struct device_node
> >*node)
> > u32 rate;
> >
> > if (!np) {
> >- pr_err("ppc-clk: could not get parent node\n");
> >+ pr_err("qoriq-clk: could not get parent node\n");
> > return;
> > }
> >
> >@@ -278,30 +278,35 @@ static const struct of_device_id clk_match[]
> >__initconst = {
> > {}
> > };
> >
> >-static int __init ppc_corenet_clk_probe(struct platform_device *pdev)
> >+static int __init qoriq_clk_probe(struct platform_device *pdev)
> > {
> > of_clk_init(clk_match);
> >
> > return 0;
> > }
> >
> >-static const struct of_device_id ppc_clk_ids[] __initconst = {
> >+static const struct of_device_id qoriq_clk_ids[] __initconst = {
> > { .compatible = "fsl,qoriq-clockgen-1.0", },
> > { .compatible = "fsl,qoriq-clockgen-2.0", },
> > {}
> > };
> >
> >-static struct platform_driver ppc_corenet_clk_driver __initdata = {
> >+static struct platform_driver qoriq_clk_driver __initdata = {
> > .driver = {
> >- .name = "ppc_corenet_clock",
> >+ .name = "qoriq_clock",
> > .owner = THIS_MODULE,
> >- .of_match_table = ppc_clk_ids,
> >+ .of_match_table = qoriq_clk_ids,
> > },
> >- .probe = ppc_corenet_clk_probe,
> >+ .probe = qoriq_clk_probe,
> > };
> >
> >-static int __init ppc_corenet_clk_init(void)
> >+static int __init qoriq_clk_init(void)
> > {
> >- return platform_driver_register(&ppc_corenet_clk_driver);
> >+ return platform_driver_register(&qoriq_clk_driver);
> > }
> >-subsys_initcall(ppc_corenet_clk_init);
> >+subsys_initcall(qoriq_clk_init);
> >+
> >+CLK_OF_DECLARE(qoriq_core_pll_v1, "fsl,qoriq-core-pll-1.0",
> >+core_pll_init); CLK_OF_DECLARE(qoriq_core_pll_v2,
> >+"fsl,qoriq-core-pll-2.0", core_pll_init);
> >+CLK_OF_DECLARE(qoriq_core_mux_v1, "fsl,qoriq-core-mux-1.0",
> >+core_mux_init); CLK_OF_DECLARE(qoriq_core_mux_v2,
> >+"fsl,qoriq-core-mux-2.0", core_mux_init);
> >--
> >1.8.0
>
^ permalink raw reply [flat|nested] 37+ messages in thread* [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add CLK_OF_DECLARE support
@ 2014-09-25 20:08 ` Scott Wood
0 siblings, 0 replies; 37+ messages in thread
From: Scott Wood @ 2014-09-25 20:08 UTC (permalink / raw)
To: linux-arm-kernel
Well, like I said, I'd rather see the CLK_OF_DECLARE stuff be made to
work on PPC rather than have the driver carry around two binding
methods.
-Scott
On Thu, 2014-09-25 at 04:47 -0500, Lu Jingchang-B35083 wrote:
> Hi, Scott and Mike,
>
> Could you please help review this patch and give an ACK if ok. Thanks.
>
> Best Regards,
> Jingchang
>
> >-----Original Message-----
> >From: Jingchang Lu [mailto:jingchang.lu at freescale.com]
> >Sent: Tuesday, September 23, 2014 2:47 PM
> >To: mturquette at linaro.org
> >Cc: Wood Scott-B07421; linuxppc-dev at lists.ozlabs.org; linux-
> >kernel at vger.kernel.org; linux-arm-kernel at lists.infradead.org; Lu
> >Jingchang-B35083
> >Subject: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add
> >CLK_OF_DECLARE support
> >
> >The IP is shared by PPC and ARM, this renames it to qoriq for better
> >represention, and this also adds the CLK_OF_DECLARE support for being
> >initialized by of_clk_init() on ARM.
> >
> >Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com>
> >---
> >changes in v4:
> > remove "corenet" literals omitted in v3 remove.
> >
> >changes in v3:
> > generate the patch with -M -C option
> >
> >changes in v2:
> > rename the driver name to ppc-qoriq.c for shared on PPC and ARM.
> >
> > drivers/clk/Kconfig | 9 +++++----
> > drivers/clk/Makefile | 2 +-
> > drivers/clk/{clk-ppc-corenet.c => clk-qoriq.c} | 27 +++++++++++++++------
> >-----
> > 3 files changed, 22 insertions(+), 16 deletions(-) rename
> >drivers/clk/{clk-ppc-corenet.c => clk-qoriq.c} (89%)
> >
> >diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index
> >85131ae..f5f76cb 100644
> >--- a/drivers/clk/Kconfig
> >+++ b/drivers/clk/Kconfig
> >@@ -92,12 +92,13 @@ config COMMON_CLK_AXI_CLKGEN
> > Support for the Analog Devices axi-clkgen pcore clock generator
> >for Xilinx
> > FPGAs. It is commonly used in Analog Devices' reference designs.
> >
> >-config CLK_PPC_CORENET
> >- bool "Clock driver for PowerPC corenet platforms"
> >- depends on PPC_E500MC && OF
> >+config CLK_QORIQ
> >+ bool "Clock driver for PowerPC corenet and compatible ARM-based
> >platforms"
> >+ depends on (PPC_E500MC || ARM) && OF
> > ---help---
> > This adds the clock driver support for Freescale PowerPC corenet
> >- platforms using common clock framework.
> >+ platforms and compatible Freescale ARM based platforms using
> >common
> >+ clock framework.
> >
> > config COMMON_CLK_XGENE
> > bool "Clock driver for APM XGene SoC"
> >diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile index
> >27c542b..20f42e9 100644
> >--- a/drivers/clk/Makefile
> >+++ b/drivers/clk/Makefile
> >@@ -29,7 +29,7 @@ obj-$(CONFIG_ARCH_MOXART) += clk-moxart.o
> > obj-$(CONFIG_ARCH_NOMADIK) += clk-nomadik.o
> > obj-$(CONFIG_ARCH_NSPIRE) += clk-nspire.o
> > obj-$(CONFIG_COMMON_CLK_PALMAS) += clk-palmas.o
> >-obj-$(CONFIG_CLK_PPC_CORENET) += clk-ppc-corenet.o
> >+obj-$(CONFIG_CLK_QORIQ) += clk-qoriq.o
> > obj-$(CONFIG_COMMON_CLK_S2MPS11) += clk-s2mps11.o
> > obj-$(CONFIG_COMMON_CLK_SI5351) += clk-si5351.o
> > obj-$(CONFIG_COMMON_CLK_SI570) += clk-si570.o
> >diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-qoriq.c
> >similarity index 89% rename from drivers/clk/clk-ppc-corenet.c rename to
> >drivers/clk/clk-qoriq.c index 8e58edf..cba8abe 100644
> >--- a/drivers/clk/clk-ppc-corenet.c
> >+++ b/drivers/clk/clk-qoriq.c
> >@@ -155,7 +155,7 @@ static void __init core_pll_init(struct device_node
> >*np)
> >
> > base = of_iomap(np, 0);
> > if (!base) {
> >- pr_err("clk-ppc: iomap error\n");
> >+ pr_err("clk-qoriq: iomap error\n");
> > return;
> > }
> >
> >@@ -252,7 +252,7 @@ static void __init sysclk_init(struct device_node
> >*node)
> > u32 rate;
> >
> > if (!np) {
> >- pr_err("ppc-clk: could not get parent node\n");
> >+ pr_err("qoriq-clk: could not get parent node\n");
> > return;
> > }
> >
> >@@ -278,30 +278,35 @@ static const struct of_device_id clk_match[]
> >__initconst = {
> > {}
> > };
> >
> >-static int __init ppc_corenet_clk_probe(struct platform_device *pdev)
> >+static int __init qoriq_clk_probe(struct platform_device *pdev)
> > {
> > of_clk_init(clk_match);
> >
> > return 0;
> > }
> >
> >-static const struct of_device_id ppc_clk_ids[] __initconst = {
> >+static const struct of_device_id qoriq_clk_ids[] __initconst = {
> > { .compatible = "fsl,qoriq-clockgen-1.0", },
> > { .compatible = "fsl,qoriq-clockgen-2.0", },
> > {}
> > };
> >
> >-static struct platform_driver ppc_corenet_clk_driver __initdata = {
> >+static struct platform_driver qoriq_clk_driver __initdata = {
> > .driver = {
> >- .name = "ppc_corenet_clock",
> >+ .name = "qoriq_clock",
> > .owner = THIS_MODULE,
> >- .of_match_table = ppc_clk_ids,
> >+ .of_match_table = qoriq_clk_ids,
> > },
> >- .probe = ppc_corenet_clk_probe,
> >+ .probe = qoriq_clk_probe,
> > };
> >
> >-static int __init ppc_corenet_clk_init(void)
> >+static int __init qoriq_clk_init(void)
> > {
> >- return platform_driver_register(&ppc_corenet_clk_driver);
> >+ return platform_driver_register(&qoriq_clk_driver);
> > }
> >-subsys_initcall(ppc_corenet_clk_init);
> >+subsys_initcall(qoriq_clk_init);
> >+
> >+CLK_OF_DECLARE(qoriq_core_pll_v1, "fsl,qoriq-core-pll-1.0",
> >+core_pll_init); CLK_OF_DECLARE(qoriq_core_pll_v2,
> >+"fsl,qoriq-core-pll-2.0", core_pll_init);
> >+CLK_OF_DECLARE(qoriq_core_mux_v1, "fsl,qoriq-core-mux-1.0",
> >+core_mux_init); CLK_OF_DECLARE(qoriq_core_mux_v2,
> >+"fsl,qoriq-core-mux-2.0", core_mux_init);
> >--
> >1.8.0
>
^ permalink raw reply [flat|nested] 37+ messages in thread* Re: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add CLK_OF_DECLARE support
2014-09-25 20:08 ` Scott Wood
(?)
@ 2014-09-25 22:54 ` Mike Turquette
-1 siblings, 0 replies; 37+ messages in thread
From: Mike Turquette @ 2014-09-25 22:54 UTC (permalink / raw)
To: Scott Wood, Lu Jingchang-B35083
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Quoting Scott Wood (2014-09-25 13:08:00)
> Well, like I said, I'd rather see the CLK_OF_DECLARE stuff be made to
> work on PPC rather than have the driver carry around two binding
> methods.
I guess that is an existing problem, and not related directly to this
patch? This patch is essentially just renames (though the V1.0/V2.0
stuff seems weird).
Regards,
Mike
> =
> -Scott
> =
> On Thu, 2014-09-25 at 04:47 -0500, Lu Jingchang-B35083 wrote:
> > Hi, Scott and Mike,
> > =
> > Could you please help review this patch and give an ACK if ok. Thanks.
> > =
> > Best Regards,
> > Jingchang
> > =
> > >-----Original Message-----
> > >From: Jingchang Lu [mailto:jingchang.lu@freescale.com]
> > >Sent: Tuesday, September 23, 2014 2:47 PM
> > >To: mturquette@linaro.org
> > >Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; linux-
> > >kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Lu
> > >Jingchang-B35083
> > >Subject: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add
> > >CLK_OF_DECLARE support
> > >
> > >The IP is shared by PPC and ARM, this renames it to qoriq for better
> > >represention, and this also adds the CLK_OF_DECLARE support for being
> > >initialized by of_clk_init() on ARM.
> > >
> > >Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com>
> > >---
> > >changes in v4:
> > > remove "corenet" literals omitted in v3 remove.
> > >
> > >changes in v3:
> > > generate the patch with -M -C option
> > >
> > >changes in v2:
> > > rename the driver name to ppc-qoriq.c for shared on PPC and ARM.
> > >
> > > drivers/clk/Kconfig | 9 +++++----
> > > drivers/clk/Makefile | 2 +-
> > > drivers/clk/{clk-ppc-corenet.c =3D> clk-qoriq.c} | 27 +++++++++++++++=
------
> > >-----
> > > 3 files changed, 22 insertions(+), 16 deletions(-) rename
> > >drivers/clk/{clk-ppc-corenet.c =3D> clk-qoriq.c} (89%)
> > >
> > >diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index
> > >85131ae..f5f76cb 100644
> > >--- a/drivers/clk/Kconfig
> > >+++ b/drivers/clk/Kconfig
> > >@@ -92,12 +92,13 @@ config COMMON_CLK_AXI_CLKGEN
> > > Support for the Analog Devices axi-clkgen pcore clock generator
> > >for Xilinx
> > > FPGAs. It is commonly used in Analog Devices' reference designs.
> > >
> > >-config CLK_PPC_CORENET
> > >- bool "Clock driver for PowerPC corenet platforms"
> > >- depends on PPC_E500MC && OF
> > >+config CLK_QORIQ
> > >+ bool "Clock driver for PowerPC corenet and compatible ARM-based
> > >platforms"
> > >+ depends on (PPC_E500MC || ARM) && OF
> > > ---help---
> > > This adds the clock driver support for Freescale PowerPC corenet
> > >- platforms using common clock framework.
> > >+ platforms and compatible Freescale ARM based platforms using
> > >common
> > >+ clock framework.
> > >
> > > config COMMON_CLK_XGENE
> > > bool "Clock driver for APM XGene SoC"
> > >diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile index
> > >27c542b..20f42e9 100644
> > >--- a/drivers/clk/Makefile
> > >+++ b/drivers/clk/Makefile
> > >@@ -29,7 +29,7 @@ obj-$(CONFIG_ARCH_MOXART) +=3D clk-moxart.o
> > > obj-$(CONFIG_ARCH_NOMADIK) +=3D clk-nomadik.o
> > > obj-$(CONFIG_ARCH_NSPIRE) +=3D clk-nspire.o
> > > obj-$(CONFIG_COMMON_CLK_PALMAS) +=3D clk-palmas.o
> > >-obj-$(CONFIG_CLK_PPC_CORENET) +=3D clk-ppc-corenet.o
> > >+obj-$(CONFIG_CLK_QORIQ) +=3D clk-qoriq.o
> > > obj-$(CONFIG_COMMON_CLK_S2MPS11) +=3D clk-s2mps11.o
> > > obj-$(CONFIG_COMMON_CLK_SI5351) +=3D clk-si5351.o
> > > obj-$(CONFIG_COMMON_CLK_SI570) +=3D clk-si570.o
> > >diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-qoriq.c
> > >similarity index 89% rename from drivers/clk/clk-ppc-corenet.c rename =
to
> > >drivers/clk/clk-qoriq.c index 8e58edf..cba8abe 100644
> > >--- a/drivers/clk/clk-ppc-corenet.c
> > >+++ b/drivers/clk/clk-qoriq.c
> > >@@ -155,7 +155,7 @@ static void __init core_pll_init(struct device_node
> > >*np)
> > >
> > > base =3D of_iomap(np, 0);
> > > if (!base) {
> > >- pr_err("clk-ppc: iomap error\n");
> > >+ pr_err("clk-qoriq: iomap error\n");
> > > return;
> > > }
> > >
> > >@@ -252,7 +252,7 @@ static void __init sysclk_init(struct device_node
> > >*node)
> > > u32 rate;
> > >
> > > if (!np) {
> > >- pr_err("ppc-clk: could not get parent node\n");
> > >+ pr_err("qoriq-clk: could not get parent node\n");
> > > return;
> > > }
> > >
> > >@@ -278,30 +278,35 @@ static const struct of_device_id clk_match[]
> > >__initconst =3D {
> > > {}
> > > };
> > >
> > >-static int __init ppc_corenet_clk_probe(struct platform_device *pdev)
> > >+static int __init qoriq_clk_probe(struct platform_device *pdev)
> > > {
> > > of_clk_init(clk_match);
> > >
> > > return 0;
> > > }
> > >
> > >-static const struct of_device_id ppc_clk_ids[] __initconst =3D {
> > >+static const struct of_device_id qoriq_clk_ids[] __initconst =3D {
> > > { .compatible =3D "fsl,qoriq-clockgen-1.0", },
> > > { .compatible =3D "fsl,qoriq-clockgen-2.0", },
> > > {}
> > > };
> > >
> > >-static struct platform_driver ppc_corenet_clk_driver __initdata =3D {
> > >+static struct platform_driver qoriq_clk_driver __initdata =3D {
> > > .driver =3D {
> > >- .name =3D "ppc_corenet_clock",
> > >+ .name =3D "qoriq_clock",
> > > .owner =3D THIS_MODULE,
> > >- .of_match_table =3D ppc_clk_ids,
> > >+ .of_match_table =3D qoriq_clk_ids,
> > > },
> > >- .probe =3D ppc_corenet_clk_probe,
> > >+ .probe =3D qoriq_clk_probe,
> > > };
> > >
> > >-static int __init ppc_corenet_clk_init(void)
> > >+static int __init qoriq_clk_init(void)
> > > {
> > >- return platform_driver_register(&ppc_corenet_clk_driver);
> > >+ return platform_driver_register(&qoriq_clk_driver);
> > > }
> > >-subsys_initcall(ppc_corenet_clk_init);
> > >+subsys_initcall(qoriq_clk_init);
> > >+
> > >+CLK_OF_DECLARE(qoriq_core_pll_v1, "fsl,qoriq-core-pll-1.0",
> > >+core_pll_init); CLK_OF_DECLARE(qoriq_core_pll_v2,
> > >+"fsl,qoriq-core-pll-2.0", core_pll_init);
> > >+CLK_OF_DECLARE(qoriq_core_mux_v1, "fsl,qoriq-core-mux-1.0",
> > >+core_mux_init); CLK_OF_DECLARE(qoriq_core_mux_v2,
> > >+"fsl,qoriq-core-mux-2.0", core_mux_init);
> > >--
> > >1.8.0
> > =
> =
>=20
^ permalink raw reply [flat|nested] 37+ messages in thread* Re: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add CLK_OF_DECLARE support
@ 2014-09-25 22:54 ` Mike Turquette
0 siblings, 0 replies; 37+ messages in thread
From: Mike Turquette @ 2014-09-25 22:54 UTC (permalink / raw)
To: Scott Wood, Lu Jingchang-B35083
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Quoting Scott Wood (2014-09-25 13:08:00)
> Well, like I said, I'd rather see the CLK_OF_DECLARE stuff be made to
> work on PPC rather than have the driver carry around two binding
> methods.
I guess that is an existing problem, and not related directly to this
patch? This patch is essentially just renames (though the V1.0/V2.0
stuff seems weird).
Regards,
Mike
>
> -Scott
>
> On Thu, 2014-09-25 at 04:47 -0500, Lu Jingchang-B35083 wrote:
> > Hi, Scott and Mike,
> >
> > Could you please help review this patch and give an ACK if ok. Thanks.
> >
> > Best Regards,
> > Jingchang
> >
> > >-----Original Message-----
> > >From: Jingchang Lu [mailto:jingchang.lu@freescale.com]
> > >Sent: Tuesday, September 23, 2014 2:47 PM
> > >To: mturquette@linaro.org
> > >Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; linux-
> > >kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Lu
> > >Jingchang-B35083
> > >Subject: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add
> > >CLK_OF_DECLARE support
> > >
> > >The IP is shared by PPC and ARM, this renames it to qoriq for better
> > >represention, and this also adds the CLK_OF_DECLARE support for being
> > >initialized by of_clk_init() on ARM.
> > >
> > >Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com>
> > >---
> > >changes in v4:
> > > remove "corenet" literals omitted in v3 remove.
> > >
> > >changes in v3:
> > > generate the patch with -M -C option
> > >
> > >changes in v2:
> > > rename the driver name to ppc-qoriq.c for shared on PPC and ARM.
> > >
> > > drivers/clk/Kconfig | 9 +++++----
> > > drivers/clk/Makefile | 2 +-
> > > drivers/clk/{clk-ppc-corenet.c => clk-qoriq.c} | 27 +++++++++++++++------
> > >-----
> > > 3 files changed, 22 insertions(+), 16 deletions(-) rename
> > >drivers/clk/{clk-ppc-corenet.c => clk-qoriq.c} (89%)
> > >
> > >diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index
> > >85131ae..f5f76cb 100644
> > >--- a/drivers/clk/Kconfig
> > >+++ b/drivers/clk/Kconfig
> > >@@ -92,12 +92,13 @@ config COMMON_CLK_AXI_CLKGEN
> > > Support for the Analog Devices axi-clkgen pcore clock generator
> > >for Xilinx
> > > FPGAs. It is commonly used in Analog Devices' reference designs.
> > >
> > >-config CLK_PPC_CORENET
> > >- bool "Clock driver for PowerPC corenet platforms"
> > >- depends on PPC_E500MC && OF
> > >+config CLK_QORIQ
> > >+ bool "Clock driver for PowerPC corenet and compatible ARM-based
> > >platforms"
> > >+ depends on (PPC_E500MC || ARM) && OF
> > > ---help---
> > > This adds the clock driver support for Freescale PowerPC corenet
> > >- platforms using common clock framework.
> > >+ platforms and compatible Freescale ARM based platforms using
> > >common
> > >+ clock framework.
> > >
> > > config COMMON_CLK_XGENE
> > > bool "Clock driver for APM XGene SoC"
> > >diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile index
> > >27c542b..20f42e9 100644
> > >--- a/drivers/clk/Makefile
> > >+++ b/drivers/clk/Makefile
> > >@@ -29,7 +29,7 @@ obj-$(CONFIG_ARCH_MOXART) += clk-moxart.o
> > > obj-$(CONFIG_ARCH_NOMADIK) += clk-nomadik.o
> > > obj-$(CONFIG_ARCH_NSPIRE) += clk-nspire.o
> > > obj-$(CONFIG_COMMON_CLK_PALMAS) += clk-palmas.o
> > >-obj-$(CONFIG_CLK_PPC_CORENET) += clk-ppc-corenet.o
> > >+obj-$(CONFIG_CLK_QORIQ) += clk-qoriq.o
> > > obj-$(CONFIG_COMMON_CLK_S2MPS11) += clk-s2mps11.o
> > > obj-$(CONFIG_COMMON_CLK_SI5351) += clk-si5351.o
> > > obj-$(CONFIG_COMMON_CLK_SI570) += clk-si570.o
> > >diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-qoriq.c
> > >similarity index 89% rename from drivers/clk/clk-ppc-corenet.c rename to
> > >drivers/clk/clk-qoriq.c index 8e58edf..cba8abe 100644
> > >--- a/drivers/clk/clk-ppc-corenet.c
> > >+++ b/drivers/clk/clk-qoriq.c
> > >@@ -155,7 +155,7 @@ static void __init core_pll_init(struct device_node
> > >*np)
> > >
> > > base = of_iomap(np, 0);
> > > if (!base) {
> > >- pr_err("clk-ppc: iomap error\n");
> > >+ pr_err("clk-qoriq: iomap error\n");
> > > return;
> > > }
> > >
> > >@@ -252,7 +252,7 @@ static void __init sysclk_init(struct device_node
> > >*node)
> > > u32 rate;
> > >
> > > if (!np) {
> > >- pr_err("ppc-clk: could not get parent node\n");
> > >+ pr_err("qoriq-clk: could not get parent node\n");
> > > return;
> > > }
> > >
> > >@@ -278,30 +278,35 @@ static const struct of_device_id clk_match[]
> > >__initconst = {
> > > {}
> > > };
> > >
> > >-static int __init ppc_corenet_clk_probe(struct platform_device *pdev)
> > >+static int __init qoriq_clk_probe(struct platform_device *pdev)
> > > {
> > > of_clk_init(clk_match);
> > >
> > > return 0;
> > > }
> > >
> > >-static const struct of_device_id ppc_clk_ids[] __initconst = {
> > >+static const struct of_device_id qoriq_clk_ids[] __initconst = {
> > > { .compatible = "fsl,qoriq-clockgen-1.0", },
> > > { .compatible = "fsl,qoriq-clockgen-2.0", },
> > > {}
> > > };
> > >
> > >-static struct platform_driver ppc_corenet_clk_driver __initdata = {
> > >+static struct platform_driver qoriq_clk_driver __initdata = {
> > > .driver = {
> > >- .name = "ppc_corenet_clock",
> > >+ .name = "qoriq_clock",
> > > .owner = THIS_MODULE,
> > >- .of_match_table = ppc_clk_ids,
> > >+ .of_match_table = qoriq_clk_ids,
> > > },
> > >- .probe = ppc_corenet_clk_probe,
> > >+ .probe = qoriq_clk_probe,
> > > };
> > >
> > >-static int __init ppc_corenet_clk_init(void)
> > >+static int __init qoriq_clk_init(void)
> > > {
> > >- return platform_driver_register(&ppc_corenet_clk_driver);
> > >+ return platform_driver_register(&qoriq_clk_driver);
> > > }
> > >-subsys_initcall(ppc_corenet_clk_init);
> > >+subsys_initcall(qoriq_clk_init);
> > >+
> > >+CLK_OF_DECLARE(qoriq_core_pll_v1, "fsl,qoriq-core-pll-1.0",
> > >+core_pll_init); CLK_OF_DECLARE(qoriq_core_pll_v2,
> > >+"fsl,qoriq-core-pll-2.0", core_pll_init);
> > >+CLK_OF_DECLARE(qoriq_core_mux_v1, "fsl,qoriq-core-mux-1.0",
> > >+core_mux_init); CLK_OF_DECLARE(qoriq_core_mux_v2,
> > >+"fsl,qoriq-core-mux-2.0", core_mux_init);
> > >--
> > >1.8.0
> >
>
>
^ permalink raw reply [flat|nested] 37+ messages in thread* [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add CLK_OF_DECLARE support
@ 2014-09-25 22:54 ` Mike Turquette
0 siblings, 0 replies; 37+ messages in thread
From: Mike Turquette @ 2014-09-25 22:54 UTC (permalink / raw)
To: linux-arm-kernel
Quoting Scott Wood (2014-09-25 13:08:00)
> Well, like I said, I'd rather see the CLK_OF_DECLARE stuff be made to
> work on PPC rather than have the driver carry around two binding
> methods.
I guess that is an existing problem, and not related directly to this
patch? This patch is essentially just renames (though the V1.0/V2.0
stuff seems weird).
Regards,
Mike
>
> -Scott
>
> On Thu, 2014-09-25 at 04:47 -0500, Lu Jingchang-B35083 wrote:
> > Hi, Scott and Mike,
> >
> > Could you please help review this patch and give an ACK if ok. Thanks.
> >
> > Best Regards,
> > Jingchang
> >
> > >-----Original Message-----
> > >From: Jingchang Lu [mailto:jingchang.lu at freescale.com]
> > >Sent: Tuesday, September 23, 2014 2:47 PM
> > >To: mturquette at linaro.org
> > >Cc: Wood Scott-B07421; linuxppc-dev at lists.ozlabs.org; linux-
> > >kernel at vger.kernel.org; linux-arm-kernel at lists.infradead.org; Lu
> > >Jingchang-B35083
> > >Subject: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add
> > >CLK_OF_DECLARE support
> > >
> > >The IP is shared by PPC and ARM, this renames it to qoriq for better
> > >represention, and this also adds the CLK_OF_DECLARE support for being
> > >initialized by of_clk_init() on ARM.
> > >
> > >Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com>
> > >---
> > >changes in v4:
> > > remove "corenet" literals omitted in v3 remove.
> > >
> > >changes in v3:
> > > generate the patch with -M -C option
> > >
> > >changes in v2:
> > > rename the driver name to ppc-qoriq.c for shared on PPC and ARM.
> > >
> > > drivers/clk/Kconfig | 9 +++++----
> > > drivers/clk/Makefile | 2 +-
> > > drivers/clk/{clk-ppc-corenet.c => clk-qoriq.c} | 27 +++++++++++++++------
> > >-----
> > > 3 files changed, 22 insertions(+), 16 deletions(-) rename
> > >drivers/clk/{clk-ppc-corenet.c => clk-qoriq.c} (89%)
> > >
> > >diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index
> > >85131ae..f5f76cb 100644
> > >--- a/drivers/clk/Kconfig
> > >+++ b/drivers/clk/Kconfig
> > >@@ -92,12 +92,13 @@ config COMMON_CLK_AXI_CLKGEN
> > > Support for the Analog Devices axi-clkgen pcore clock generator
> > >for Xilinx
> > > FPGAs. It is commonly used in Analog Devices' reference designs.
> > >
> > >-config CLK_PPC_CORENET
> > >- bool "Clock driver for PowerPC corenet platforms"
> > >- depends on PPC_E500MC && OF
> > >+config CLK_QORIQ
> > >+ bool "Clock driver for PowerPC corenet and compatible ARM-based
> > >platforms"
> > >+ depends on (PPC_E500MC || ARM) && OF
> > > ---help---
> > > This adds the clock driver support for Freescale PowerPC corenet
> > >- platforms using common clock framework.
> > >+ platforms and compatible Freescale ARM based platforms using
> > >common
> > >+ clock framework.
> > >
> > > config COMMON_CLK_XGENE
> > > bool "Clock driver for APM XGene SoC"
> > >diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile index
> > >27c542b..20f42e9 100644
> > >--- a/drivers/clk/Makefile
> > >+++ b/drivers/clk/Makefile
> > >@@ -29,7 +29,7 @@ obj-$(CONFIG_ARCH_MOXART) += clk-moxart.o
> > > obj-$(CONFIG_ARCH_NOMADIK) += clk-nomadik.o
> > > obj-$(CONFIG_ARCH_NSPIRE) += clk-nspire.o
> > > obj-$(CONFIG_COMMON_CLK_PALMAS) += clk-palmas.o
> > >-obj-$(CONFIG_CLK_PPC_CORENET) += clk-ppc-corenet.o
> > >+obj-$(CONFIG_CLK_QORIQ) += clk-qoriq.o
> > > obj-$(CONFIG_COMMON_CLK_S2MPS11) += clk-s2mps11.o
> > > obj-$(CONFIG_COMMON_CLK_SI5351) += clk-si5351.o
> > > obj-$(CONFIG_COMMON_CLK_SI570) += clk-si570.o
> > >diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-qoriq.c
> > >similarity index 89% rename from drivers/clk/clk-ppc-corenet.c rename to
> > >drivers/clk/clk-qoriq.c index 8e58edf..cba8abe 100644
> > >--- a/drivers/clk/clk-ppc-corenet.c
> > >+++ b/drivers/clk/clk-qoriq.c
> > >@@ -155,7 +155,7 @@ static void __init core_pll_init(struct device_node
> > >*np)
> > >
> > > base = of_iomap(np, 0);
> > > if (!base) {
> > >- pr_err("clk-ppc: iomap error\n");
> > >+ pr_err("clk-qoriq: iomap error\n");
> > > return;
> > > }
> > >
> > >@@ -252,7 +252,7 @@ static void __init sysclk_init(struct device_node
> > >*node)
> > > u32 rate;
> > >
> > > if (!np) {
> > >- pr_err("ppc-clk: could not get parent node\n");
> > >+ pr_err("qoriq-clk: could not get parent node\n");
> > > return;
> > > }
> > >
> > >@@ -278,30 +278,35 @@ static const struct of_device_id clk_match[]
> > >__initconst = {
> > > {}
> > > };
> > >
> > >-static int __init ppc_corenet_clk_probe(struct platform_device *pdev)
> > >+static int __init qoriq_clk_probe(struct platform_device *pdev)
> > > {
> > > of_clk_init(clk_match);
> > >
> > > return 0;
> > > }
> > >
> > >-static const struct of_device_id ppc_clk_ids[] __initconst = {
> > >+static const struct of_device_id qoriq_clk_ids[] __initconst = {
> > > { .compatible = "fsl,qoriq-clockgen-1.0", },
> > > { .compatible = "fsl,qoriq-clockgen-2.0", },
> > > {}
> > > };
> > >
> > >-static struct platform_driver ppc_corenet_clk_driver __initdata = {
> > >+static struct platform_driver qoriq_clk_driver __initdata = {
> > > .driver = {
> > >- .name = "ppc_corenet_clock",
> > >+ .name = "qoriq_clock",
> > > .owner = THIS_MODULE,
> > >- .of_match_table = ppc_clk_ids,
> > >+ .of_match_table = qoriq_clk_ids,
> > > },
> > >- .probe = ppc_corenet_clk_probe,
> > >+ .probe = qoriq_clk_probe,
> > > };
> > >
> > >-static int __init ppc_corenet_clk_init(void)
> > >+static int __init qoriq_clk_init(void)
> > > {
> > >- return platform_driver_register(&ppc_corenet_clk_driver);
> > >+ return platform_driver_register(&qoriq_clk_driver);
> > > }
> > >-subsys_initcall(ppc_corenet_clk_init);
> > >+subsys_initcall(qoriq_clk_init);
> > >+
> > >+CLK_OF_DECLARE(qoriq_core_pll_v1, "fsl,qoriq-core-pll-1.0",
> > >+core_pll_init); CLK_OF_DECLARE(qoriq_core_pll_v2,
> > >+"fsl,qoriq-core-pll-2.0", core_pll_init);
> > >+CLK_OF_DECLARE(qoriq_core_mux_v1, "fsl,qoriq-core-mux-1.0",
> > >+core_mux_init); CLK_OF_DECLARE(qoriq_core_mux_v2,
> > >+"fsl,qoriq-core-mux-2.0", core_mux_init);
> > >--
> > >1.8.0
> >
>
>
^ permalink raw reply [flat|nested] 37+ messages in thread* Re: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add CLK_OF_DECLARE support
2014-09-25 22:54 ` Mike Turquette
(?)
@ 2014-09-25 22:56 ` Scott Wood
-1 siblings, 0 replies; 37+ messages in thread
From: Scott Wood @ 2014-09-25 22:56 UTC (permalink / raw)
To: Mike Turquette
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Lu Jingchang-B35083
On Thu, 2014-09-25 at 15:54 -0700, Mike Turquette wrote:
> Quoting Scott Wood (2014-09-25 13:08:00)
> > Well, like I said, I'd rather see the CLK_OF_DECLARE stuff be made to
> > work on PPC rather than have the driver carry around two binding
> > methods.
>
> I guess that is an existing problem, and not related directly to this
> patch? This patch is essentially just renames (though the V1.0/V2.0
> stuff seems weird).
This patch is adding CLK_OF_DECLARE.
-Scott
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add CLK_OF_DECLARE support
@ 2014-09-25 22:56 ` Scott Wood
0 siblings, 0 replies; 37+ messages in thread
From: Scott Wood @ 2014-09-25 22:56 UTC (permalink / raw)
To: Mike Turquette
Cc: Lu Jingchang-B35083, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
On Thu, 2014-09-25 at 15:54 -0700, Mike Turquette wrote:
> Quoting Scott Wood (2014-09-25 13:08:00)
> > Well, like I said, I'd rather see the CLK_OF_DECLARE stuff be made to
> > work on PPC rather than have the driver carry around two binding
> > methods.
>
> I guess that is an existing problem, and not related directly to this
> patch? This patch is essentially just renames (though the V1.0/V2.0
> stuff seems weird).
This patch is adding CLK_OF_DECLARE.
-Scott
^ permalink raw reply [flat|nested] 37+ messages in thread
* [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add CLK_OF_DECLARE support
@ 2014-09-25 22:56 ` Scott Wood
0 siblings, 0 replies; 37+ messages in thread
From: Scott Wood @ 2014-09-25 22:56 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 2014-09-25 at 15:54 -0700, Mike Turquette wrote:
> Quoting Scott Wood (2014-09-25 13:08:00)
> > Well, like I said, I'd rather see the CLK_OF_DECLARE stuff be made to
> > work on PPC rather than have the driver carry around two binding
> > methods.
>
> I guess that is an existing problem, and not related directly to this
> patch? This patch is essentially just renames (though the V1.0/V2.0
> stuff seems weird).
This patch is adding CLK_OF_DECLARE.
-Scott
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add CLK_OF_DECLARE support
2014-09-25 22:56 ` Scott Wood
@ 2014-09-26 23:29 ` Mike Turquette
-1 siblings, 0 replies; 37+ messages in thread
From: Mike Turquette @ 2014-09-26 23:29 UTC (permalink / raw)
To: Scott Wood
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Lu Jingchang-B35083
Quoting Scott Wood (2014-09-25 15:56:20)
> On Thu, 2014-09-25 at 15:54 -0700, Mike Turquette wrote:
> > Quoting Scott Wood (2014-09-25 13:08:00)
> > > Well, like I said, I'd rather see the CLK_OF_DECLARE stuff be made to
> > > work on PPC rather than have the driver carry around two binding
> > > methods.
> > =
> > I guess that is an existing problem, and not related directly to this
> > patch? This patch is essentially just renames (though the V1.0/V2.0
> > stuff seems weird).
> =
> This patch is adding CLK_OF_DECLARE.
I'm fine taking this patch but your comments are still unresolved. What
do you think needs to be done to fix the problems that you see?
Regards,
Mike
> =
> -Scott
> =
>=20
^ permalink raw reply [flat|nested] 37+ messages in thread
* [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add CLK_OF_DECLARE support
@ 2014-09-26 23:29 ` Mike Turquette
0 siblings, 0 replies; 37+ messages in thread
From: Mike Turquette @ 2014-09-26 23:29 UTC (permalink / raw)
To: linux-arm-kernel
Quoting Scott Wood (2014-09-25 15:56:20)
> On Thu, 2014-09-25 at 15:54 -0700, Mike Turquette wrote:
> > Quoting Scott Wood (2014-09-25 13:08:00)
> > > Well, like I said, I'd rather see the CLK_OF_DECLARE stuff be made to
> > > work on PPC rather than have the driver carry around two binding
> > > methods.
> >
> > I guess that is an existing problem, and not related directly to this
> > patch? This patch is essentially just renames (though the V1.0/V2.0
> > stuff seems weird).
>
> This patch is adding CLK_OF_DECLARE.
I'm fine taking this patch but your comments are still unresolved. What
do you think needs to be done to fix the problems that you see?
Regards,
Mike
>
> -Scott
>
>
^ permalink raw reply [flat|nested] 37+ messages in thread
* RE: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add CLK_OF_DECLARE support
2014-09-26 23:29 ` Mike Turquette
(?)
@ 2014-09-28 2:18 ` Yuantian Tang
-1 siblings, 0 replies; 37+ messages in thread
From: Yuantian Tang @ 2014-09-28 2:18 UTC (permalink / raw)
To: Mike Turquette, Scott Wood
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Jingchang Lu
PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBMaW51eHBwYy1kZXYNCj4gW21h
aWx0bzpsaW51eHBwYy1kZXYtYm91bmNlcytiMjk5ODM9ZnJlZXNjYWxlLmNvbUBsaXN0cy5vemxh
YnMub3JnXSBPbg0KPiBCZWhhbGYgT2YgTWlrZSBUdXJxdWV0dGUNCj4gU2VudDogU2F0dXJkYXks
IFNlcHRlbWJlciAyNywgMjAxNCA3OjI5IEFNDQo+IFRvOiBXb29kIFNjb3R0LUIwNzQyMQ0KPiBD
YzogbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5l
bC5vcmc7DQo+IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZzsgTHUgSmluZ2No
YW5nLUIzNTA4Mw0KPiBTdWJqZWN0OiBSZTogW1BBVENIdjRdIGNsazogcHBjLWNvcmVuZXQ6IHJl
bmFtZSB0byBwcGMtcW9yaXEgYW5kIGFkZA0KPiBDTEtfT0ZfREVDTEFSRSBzdXBwb3J0DQo+IA0K
PiBRdW90aW5nIFNjb3R0IFdvb2QgKDIwMTQtMDktMjUgMTU6NTY6MjApDQo+ID4gT24gVGh1LCAy
MDE0LTA5LTI1IGF0IDE1OjU0IC0wNzAwLCBNaWtlIFR1cnF1ZXR0ZSB3cm90ZToNCj4gPiA+IFF1
b3RpbmcgU2NvdHQgV29vZCAoMjAxNC0wOS0yNSAxMzowODowMCkNCj4gPiA+ID4gV2VsbCwgbGlr
ZSBJIHNhaWQsIEknZCByYXRoZXIgc2VlIHRoZSBDTEtfT0ZfREVDTEFSRSBzdHVmZiBiZSBtYWRl
DQo+ID4gPiA+IHRvIHdvcmsgb24gUFBDIHJhdGhlciB0aGFuIGhhdmUgdGhlIGRyaXZlciBjYXJy
eSBhcm91bmQgdHdvDQo+ID4gPiA+IGJpbmRpbmcgbWV0aG9kcy4NCj4gPiA+DQo+ID4gPiBJIGd1
ZXNzIHRoYXQgaXMgYW4gZXhpc3RpbmcgcHJvYmxlbSwgYW5kIG5vdCByZWxhdGVkIGRpcmVjdGx5
IHRvDQo+ID4gPiB0aGlzIHBhdGNoPyBUaGlzIHBhdGNoIGlzIGVzc2VudGlhbGx5IGp1c3QgcmVu
YW1lcyAodGhvdWdoIHRoZQ0KPiA+ID4gVjEuMC9WMi4wIHN0dWZmIHNlZW1zIHdlaXJkKS4NCj4g
Pg0KPiA+IFRoaXMgcGF0Y2ggaXMgYWRkaW5nIENMS19PRl9ERUNMQVJFLg0KPiANCj4gSSdtIGZp
bmUgdGFraW5nIHRoaXMgcGF0Y2ggYnV0IHlvdXIgY29tbWVudHMgYXJlIHN0aWxsIHVucmVzb2x2
ZWQuIFdoYXQgZG8geW91DQo+IHRoaW5rIG5lZWRzIHRvIGJlIGRvbmUgdG8gZml4IHRoZSBwcm9i
bGVtcyB0aGF0IHlvdSBzZWU/DQo+IA0KQ0xLX09GX0RFQ0xBUkUgaXMgdG90YWxseSB3b3JrZWQg
b24gUFBDLiBJIHdpbGwgZG8gaXQgaW4gYSBzZXBhcmF0ZSBwYXRjaC4NClJlZ2FyZGluZyBWMS4w
IGFuZCBWMi4wLCBpdCBpcyBub3Qgd2lyZWQganVzdCBzYW1lIGZvciBub3cuIEJ1dCB3ZSBhcmUg
bm90IHN1cmUgaWYgaXQgaXMgc2FtZSBmb3IgdjMuMCBpbiB0aGUgZnV0dXJlLg0KDQpCZXNpZGVz
IHVwZGF0aW5nIGRyaXZlcnMvY3B1ZnJlcS9LY29uZmlnLnBvd2VycGMsIHRoZXJlIGlzIG9uZSBt
b3JlIHRoaW5nIEkgYW0gbm90IGNvbWZvcnRhYmxlIHdpdGg6DQpUaGlzIHBhdGNoIHVzZXMgIiBm
aXhlZC1jbG9jayIgYXMgc3lzY2xrJ3MgY29tcGF0aWJsZSBzdHJpbmcsIHdoaWxlIG9uIFBQQyB3
ZSB0cmVhdGVkIGl0IGFzICIgZnNsLHFvcmlxLXN5c2Nsay1bMS0yXS4wIi4NClRoYXQncyBpbmNv
bnNpc3RlbnQgb24gYm90aCBBUk0gYW5kIFBQQyBwbGF0Zm9ybXMsIG5laXRoZXIgZGlkIG9uIGJp
bmRpbmdzLg0KDQpUaGFua3MsDQpZdWFudGlhbg0KDQo+IFJlZ2FyZHMsDQo+IE1pa2UNCj4gDQo+
ID4NCj4gPiAtU2NvdHQNCj4gPg0KPiA+DQo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fDQo+IExpbnV4cHBjLWRldiBtYWlsaW5nIGxpc3QNCj4gTGludXhw
cGMtZGV2QGxpc3RzLm96bGFicy5vcmcNCj4gaHR0cHM6Ly9saXN0cy5vemxhYnMub3JnL2xpc3Rp
bmZvL2xpbnV4cHBjLWRldg0K
^ permalink raw reply [flat|nested] 37+ messages in thread
* RE: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add CLK_OF_DECLARE support
@ 2014-09-28 2:18 ` Yuantian Tang
0 siblings, 0 replies; 37+ messages in thread
From: Yuantian Tang @ 2014-09-28 2:18 UTC (permalink / raw)
To: Mike Turquette, Scott Wood
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Jingchang Lu
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2011 bytes --]
> -----Original Message-----
> From: Linuxppc-dev
> [mailto:linuxppc-dev-bounces+b29983=freescale.com@lists.ozlabs.org] On
> Behalf Of Mike Turquette
> Sent: Saturday, September 27, 2014 7:29 AM
> To: Wood Scott-B07421
> Cc: linuxppc-dev@lists.ozlabs.org; linux-kernel@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; Lu Jingchang-B35083
> Subject: Re: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add
> CLK_OF_DECLARE support
>
> Quoting Scott Wood (2014-09-25 15:56:20)
> > On Thu, 2014-09-25 at 15:54 -0700, Mike Turquette wrote:
> > > Quoting Scott Wood (2014-09-25 13:08:00)
> > > > Well, like I said, I'd rather see the CLK_OF_DECLARE stuff be made
> > > > to work on PPC rather than have the driver carry around two
> > > > binding methods.
> > >
> > > I guess that is an existing problem, and not related directly to
> > > this patch? This patch is essentially just renames (though the
> > > V1.0/V2.0 stuff seems weird).
> >
> > This patch is adding CLK_OF_DECLARE.
>
> I'm fine taking this patch but your comments are still unresolved. What do you
> think needs to be done to fix the problems that you see?
>
CLK_OF_DECLARE is totally worked on PPC. I will do it in a separate patch.
Regarding V1.0 and V2.0, it is not wired just same for now. But we are not sure if it is same for v3.0 in the future.
Besides updating drivers/cpufreq/Kconfig.powerpc, there is one more thing I am not comfortable with:
This patch uses " fixed-clock" as sysclk's compatible string, while on PPC we treated it as " fsl,qoriq-sysclk-[1-2].0".
That's inconsistent on both ARM and PPC platforms, neither did on bindings.
Thanks,
Yuantian
> Regards,
> Mike
>
> >
> > -Scott
> >
> >
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 37+ messages in thread* [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add CLK_OF_DECLARE support
@ 2014-09-28 2:18 ` Yuantian Tang
0 siblings, 0 replies; 37+ messages in thread
From: Yuantian Tang @ 2014-09-28 2:18 UTC (permalink / raw)
To: linux-arm-kernel
> -----Original Message-----
> From: Linuxppc-dev
> [mailto:linuxppc-dev-bounces+b29983=freescale.com at lists.ozlabs.org] On
> Behalf Of Mike Turquette
> Sent: Saturday, September 27, 2014 7:29 AM
> To: Wood Scott-B07421
> Cc: linuxppc-dev at lists.ozlabs.org; linux-kernel at vger.kernel.org;
> linux-arm-kernel at lists.infradead.org; Lu Jingchang-B35083
> Subject: Re: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add
> CLK_OF_DECLARE support
>
> Quoting Scott Wood (2014-09-25 15:56:20)
> > On Thu, 2014-09-25 at 15:54 -0700, Mike Turquette wrote:
> > > Quoting Scott Wood (2014-09-25 13:08:00)
> > > > Well, like I said, I'd rather see the CLK_OF_DECLARE stuff be made
> > > > to work on PPC rather than have the driver carry around two
> > > > binding methods.
> > >
> > > I guess that is an existing problem, and not related directly to
> > > this patch? This patch is essentially just renames (though the
> > > V1.0/V2.0 stuff seems weird).
> >
> > This patch is adding CLK_OF_DECLARE.
>
> I'm fine taking this patch but your comments are still unresolved. What do you
> think needs to be done to fix the problems that you see?
>
CLK_OF_DECLARE is totally worked on PPC. I will do it in a separate patch.
Regarding V1.0 and V2.0, it is not wired just same for now. But we are not sure if it is same for v3.0 in the future.
Besides updating drivers/cpufreq/Kconfig.powerpc, there is one more thing I am not comfortable with:
This patch uses " fixed-clock" as sysclk's compatible string, while on PPC we treated it as " fsl,qoriq-sysclk-[1-2].0".
That's inconsistent on both ARM and PPC platforms, neither did on bindings.
Thanks,
Yuantian
> Regards,
> Mike
>
> >
> > -Scott
> >
> >
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add CLK_OF_DECLARE support
2014-09-28 2:18 ` Yuantian Tang
(?)
@ 2014-09-29 23:57 ` Scott Wood
-1 siblings, 0 replies; 37+ messages in thread
From: Scott Wood @ 2014-09-29 23:57 UTC (permalink / raw)
To: Tang Yuantian-B29983
Cc: linuxppc-dev@lists.ozlabs.org, Mike Turquette,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Lu Jingchang-B35083
On Sat, 2014-09-27 at 21:18 -0500, Tang Yuantian-B29983 wrote:
> > -----Original Message-----
> > From: Linuxppc-dev
> > [mailto:linuxppc-dev-bounces+b29983=freescale.com@lists.ozlabs.org] On
> > Behalf Of Mike Turquette
> > Sent: Saturday, September 27, 2014 7:29 AM
> > To: Wood Scott-B07421
> > Cc: linuxppc-dev@lists.ozlabs.org; linux-kernel@vger.kernel.org;
> > linux-arm-kernel@lists.infradead.org; Lu Jingchang-B35083
> > Subject: Re: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add
> > CLK_OF_DECLARE support
> >
> > Quoting Scott Wood (2014-09-25 15:56:20)
> > > On Thu, 2014-09-25 at 15:54 -0700, Mike Turquette wrote:
> > > > Quoting Scott Wood (2014-09-25 13:08:00)
> > > > > Well, like I said, I'd rather see the CLK_OF_DECLARE stuff be made
> > > > > to work on PPC rather than have the driver carry around two
> > > > > binding methods.
> > > >
> > > > I guess that is an existing problem, and not related directly to
> > > > this patch? This patch is essentially just renames (though the
> > > > V1.0/V2.0 stuff seems weird).
> > >
> > > This patch is adding CLK_OF_DECLARE.
> >
> > I'm fine taking this patch but your comments are still unresolved. What do you
> > think needs to be done to fix the problems that you see?
> >
> CLK_OF_DECLARE is totally worked on PPC. I will do it in a separate patch.
> Regarding V1.0 and V2.0, it is not wired just same for now. But we are not sure if it is same for v3.0 in the future.
>
> Besides updating drivers/cpufreq/Kconfig.powerpc, there is one more thing I am not comfortable with:
> This patch uses " fixed-clock" as sysclk's compatible string, while on PPC we treated it as " fsl,qoriq-sysclk-[1-2].0".
> That's inconsistent on both ARM and PPC platforms, neither did on bindings.
fsl,qoriq-sysclk-XXX is the way it is because of compatibility with the
fixups in existing U-Boots. It shouldn't be used as a model.
That said, I don't think you really mean "this patch", as it doesn't
contain the device tree updates, and "fixed-clock" does not appear.
-Scott
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add CLK_OF_DECLARE support
@ 2014-09-29 23:57 ` Scott Wood
0 siblings, 0 replies; 37+ messages in thread
From: Scott Wood @ 2014-09-29 23:57 UTC (permalink / raw)
To: Tang Yuantian-B29983
Cc: Mike Turquette, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Lu Jingchang-B35083
On Sat, 2014-09-27 at 21:18 -0500, Tang Yuantian-B29983 wrote:
> > -----Original Message-----
> > From: Linuxppc-dev
> > [mailto:linuxppc-dev-bounces+b29983=freescale.com@lists.ozlabs.org] On
> > Behalf Of Mike Turquette
> > Sent: Saturday, September 27, 2014 7:29 AM
> > To: Wood Scott-B07421
> > Cc: linuxppc-dev@lists.ozlabs.org; linux-kernel@vger.kernel.org;
> > linux-arm-kernel@lists.infradead.org; Lu Jingchang-B35083
> > Subject: Re: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add
> > CLK_OF_DECLARE support
> >
> > Quoting Scott Wood (2014-09-25 15:56:20)
> > > On Thu, 2014-09-25 at 15:54 -0700, Mike Turquette wrote:
> > > > Quoting Scott Wood (2014-09-25 13:08:00)
> > > > > Well, like I said, I'd rather see the CLK_OF_DECLARE stuff be made
> > > > > to work on PPC rather than have the driver carry around two
> > > > > binding methods.
> > > >
> > > > I guess that is an existing problem, and not related directly to
> > > > this patch? This patch is essentially just renames (though the
> > > > V1.0/V2.0 stuff seems weird).
> > >
> > > This patch is adding CLK_OF_DECLARE.
> >
> > I'm fine taking this patch but your comments are still unresolved. What do you
> > think needs to be done to fix the problems that you see?
> >
> CLK_OF_DECLARE is totally worked on PPC. I will do it in a separate patch.
> Regarding V1.0 and V2.0, it is not wired just same for now. But we are not sure if it is same for v3.0 in the future.
>
> Besides updating drivers/cpufreq/Kconfig.powerpc, there is one more thing I am not comfortable with:
> This patch uses " fixed-clock" as sysclk's compatible string, while on PPC we treated it as " fsl,qoriq-sysclk-[1-2].0".
> That's inconsistent on both ARM and PPC platforms, neither did on bindings.
fsl,qoriq-sysclk-XXX is the way it is because of compatibility with the
fixups in existing U-Boots. It shouldn't be used as a model.
That said, I don't think you really mean "this patch", as it doesn't
contain the device tree updates, and "fixed-clock" does not appear.
-Scott
^ permalink raw reply [flat|nested] 37+ messages in thread
* [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add CLK_OF_DECLARE support
@ 2014-09-29 23:57 ` Scott Wood
0 siblings, 0 replies; 37+ messages in thread
From: Scott Wood @ 2014-09-29 23:57 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, 2014-09-27 at 21:18 -0500, Tang Yuantian-B29983 wrote:
> > -----Original Message-----
> > From: Linuxppc-dev
> > [mailto:linuxppc-dev-bounces+b29983=freescale.com at lists.ozlabs.org] On
> > Behalf Of Mike Turquette
> > Sent: Saturday, September 27, 2014 7:29 AM
> > To: Wood Scott-B07421
> > Cc: linuxppc-dev at lists.ozlabs.org; linux-kernel at vger.kernel.org;
> > linux-arm-kernel at lists.infradead.org; Lu Jingchang-B35083
> > Subject: Re: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add
> > CLK_OF_DECLARE support
> >
> > Quoting Scott Wood (2014-09-25 15:56:20)
> > > On Thu, 2014-09-25 at 15:54 -0700, Mike Turquette wrote:
> > > > Quoting Scott Wood (2014-09-25 13:08:00)
> > > > > Well, like I said, I'd rather see the CLK_OF_DECLARE stuff be made
> > > > > to work on PPC rather than have the driver carry around two
> > > > > binding methods.
> > > >
> > > > I guess that is an existing problem, and not related directly to
> > > > this patch? This patch is essentially just renames (though the
> > > > V1.0/V2.0 stuff seems weird).
> > >
> > > This patch is adding CLK_OF_DECLARE.
> >
> > I'm fine taking this patch but your comments are still unresolved. What do you
> > think needs to be done to fix the problems that you see?
> >
> CLK_OF_DECLARE is totally worked on PPC. I will do it in a separate patch.
> Regarding V1.0 and V2.0, it is not wired just same for now. But we are not sure if it is same for v3.0 in the future.
>
> Besides updating drivers/cpufreq/Kconfig.powerpc, there is one more thing I am not comfortable with:
> This patch uses " fixed-clock" as sysclk's compatible string, while on PPC we treated it as " fsl,qoriq-sysclk-[1-2].0".
> That's inconsistent on both ARM and PPC platforms, neither did on bindings.
fsl,qoriq-sysclk-XXX is the way it is because of compatibility with the
fixups in existing U-Boots. It shouldn't be used as a model.
That said, I don't think you really mean "this patch", as it doesn't
contain the device tree updates, and "fixed-clock" does not appear.
-Scott
^ permalink raw reply [flat|nested] 37+ messages in thread
* RE: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add CLK_OF_DECLARE support
2014-09-29 23:57 ` Scott Wood
(?)
@ 2014-10-08 3:28 ` Yuantian Tang
-1 siblings, 0 replies; 37+ messages in thread
From: Yuantian Tang @ 2014-10-08 3:28 UTC (permalink / raw)
To: Scott Wood
Cc: linuxppc-dev@lists.ozlabs.org, Mike Turquette,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Jingchang Lu
PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0K
PiBTZW50OiBUdWVzZGF5LCBTZXB0ZW1iZXIgMzAsIDIwMTQgNzo1OCBBTQ0KPiBUbzogVGFuZyBZ
dWFudGlhbi1CMjk5ODMNCj4gQ2M6IE1pa2UgVHVycXVldHRlOyBsaW51eHBwYy1kZXZAbGlzdHMu
b3psYWJzLm9yZzsgbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZzsNCj4gbGludXgtYXJtLWtl
cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnOyBMdSBKaW5nY2hhbmctQjM1MDgzDQo+IFN1YmplY3Q6
IFJlOiBbUEFUQ0h2NF0gY2xrOiBwcGMtY29yZW5ldDogcmVuYW1lIHRvIHBwYy1xb3JpcSBhbmQg
YWRkDQo+IENMS19PRl9ERUNMQVJFIHN1cHBvcnQNCj4gDQo+IE9uIFNhdCwgMjAxNC0wOS0yNyBh
dCAyMToxOCAtMDUwMCwgVGFuZyBZdWFudGlhbi1CMjk5ODMgd3JvdGU6DQo+ID4gPiAtLS0tLU9y
aWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4gRnJvbTogTGludXhwcGMtZGV2DQo+ID4gPiBbbWFp
bHRvOmxpbnV4cHBjLWRldi1ib3VuY2VzK2IyOTk4Mz1mcmVlc2NhbGUuY29tQGxpc3RzLm96bGFi
cy5vcmddDQo+ID4gPiBPbiBCZWhhbGYgT2YgTWlrZSBUdXJxdWV0dGUNCj4gPiA+IFNlbnQ6IFNh
dHVyZGF5LCBTZXB0ZW1iZXIgMjcsIDIwMTQgNzoyOSBBTQ0KPiA+ID4gVG86IFdvb2QgU2NvdHQt
QjA3NDIxDQo+ID4gPiBDYzogbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7IGxpbnV4LWtl
cm5lbEB2Z2VyLmtlcm5lbC5vcmc7DQo+ID4gPiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh
ZGVhZC5vcmc7IEx1IEppbmdjaGFuZy1CMzUwODMNCj4gPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0h2
NF0gY2xrOiBwcGMtY29yZW5ldDogcmVuYW1lIHRvIHBwYy1xb3JpcSBhbmQgYWRkDQo+ID4gPiBD
TEtfT0ZfREVDTEFSRSBzdXBwb3J0DQo+ID4gPg0KPiA+ID4gUXVvdGluZyBTY290dCBXb29kICgy
MDE0LTA5LTI1IDE1OjU2OjIwKQ0KPiA+ID4gPiBPbiBUaHUsIDIwMTQtMDktMjUgYXQgMTU6NTQg
LTA3MDAsIE1pa2UgVHVycXVldHRlIHdyb3RlOg0KPiA+ID4gPiA+IFF1b3RpbmcgU2NvdHQgV29v
ZCAoMjAxNC0wOS0yNSAxMzowODowMCkNCj4gPiA+ID4gPiA+IFdlbGwsIGxpa2UgSSBzYWlkLCBJ
J2QgcmF0aGVyIHNlZSB0aGUgQ0xLX09GX0RFQ0xBUkUgc3R1ZmYgYmUNCj4gPiA+ID4gPiA+IG1h
ZGUgdG8gd29yayBvbiBQUEMgcmF0aGVyIHRoYW4gaGF2ZSB0aGUgZHJpdmVyIGNhcnJ5IGFyb3Vu
ZA0KPiA+ID4gPiA+ID4gdHdvIGJpbmRpbmcgbWV0aG9kcy4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+
IEkgZ3Vlc3MgdGhhdCBpcyBhbiBleGlzdGluZyBwcm9ibGVtLCBhbmQgbm90IHJlbGF0ZWQgZGly
ZWN0bHkgdG8NCj4gPiA+ID4gPiB0aGlzIHBhdGNoPyBUaGlzIHBhdGNoIGlzIGVzc2VudGlhbGx5
IGp1c3QgcmVuYW1lcyAodGhvdWdoIHRoZQ0KPiA+ID4gPiA+IFYxLjAvVjIuMCBzdHVmZiBzZWVt
cyB3ZWlyZCkuDQo+ID4gPiA+DQo+ID4gPiA+IFRoaXMgcGF0Y2ggaXMgYWRkaW5nIENMS19PRl9E
RUNMQVJFLg0KPiA+ID4NCj4gPiA+IEknbSBmaW5lIHRha2luZyB0aGlzIHBhdGNoIGJ1dCB5b3Vy
IGNvbW1lbnRzIGFyZSBzdGlsbCB1bnJlc29sdmVkLg0KPiA+ID4gV2hhdCBkbyB5b3UgdGhpbmsg
bmVlZHMgdG8gYmUgZG9uZSB0byBmaXggdGhlIHByb2JsZW1zIHRoYXQgeW91IHNlZT8NCj4gPiA+
DQo+ID4gQ0xLX09GX0RFQ0xBUkUgaXMgdG90YWxseSB3b3JrZWQgb24gUFBDLiBJIHdpbGwgZG8g
aXQgaW4gYSBzZXBhcmF0ZSBwYXRjaC4NCj4gPiBSZWdhcmRpbmcgVjEuMCBhbmQgVjIuMCwgaXQg
aXMgbm90IHdpcmVkIGp1c3Qgc2FtZSBmb3Igbm93LiBCdXQgd2UgYXJlIG5vdCBzdXJlDQo+IGlm
IGl0IGlzIHNhbWUgZm9yIHYzLjAgaW4gdGhlIGZ1dHVyZS4NCj4gPg0KPiA+IEJlc2lkZXMgdXBk
YXRpbmcgZHJpdmVycy9jcHVmcmVxL0tjb25maWcucG93ZXJwYywgdGhlcmUgaXMgb25lIG1vcmUg
dGhpbmcgSQ0KPiBhbSBub3QgY29tZm9ydGFibGUgd2l0aDoNCj4gPiBUaGlzIHBhdGNoIHVzZXMg
IiBmaXhlZC1jbG9jayIgYXMgc3lzY2xrJ3MgY29tcGF0aWJsZSBzdHJpbmcsIHdoaWxlIG9uIFBQ
QyB3ZQ0KPiB0cmVhdGVkIGl0IGFzICIgZnNsLHFvcmlxLXN5c2Nsay1bMS0yXS4wIi4NCj4gPiBU
aGF0J3MgaW5jb25zaXN0ZW50IG9uIGJvdGggQVJNIGFuZCBQUEMgcGxhdGZvcm1zLCBuZWl0aGVy
IGRpZCBvbiBiaW5kaW5ncy4NCj4gDQo+IGZzbCxxb3JpcS1zeXNjbGstWFhYIGlzIHRoZSB3YXkg
aXQgaXMgYmVjYXVzZSBvZiBjb21wYXRpYmlsaXR5IHdpdGggdGhlIGZpeHVwcyBpbg0KPiBleGlz
dGluZyBVLUJvb3RzLiAgSXQgc2hvdWxkbid0IGJlIHVzZWQgYXMgYSBtb2RlbC4NCj4gDQo+IFRo
YXQgc2FpZCwgSSBkb24ndCB0aGluayB5b3UgcmVhbGx5IG1lYW4gInRoaXMgcGF0Y2giLCBhcyBp
dCBkb2Vzbid0IGNvbnRhaW4gdGhlDQo+IGRldmljZSB0cmVlIHVwZGF0ZXMsIGFuZCAiZml4ZWQt
Y2xvY2siIGRvZXMgbm90IGFwcGVhci4NCj4gDQoiZml4ZWQtY2xvY2siIHdpbGwgYXBwZWFyIHdo
ZW4gbHMxMDJ4IHBsYXRmb3JtIERUUyBnZXRzIHVwc3RyZWFtZWQgZXZlbnR1YWxseS4NClRoYXQg
d291bGQgYmUgZmluZSBpZiB5b3UgZG9uJ3QgdGhpbmsgImZzbCxxb3JpcS1zeXNjbGsteHh4IiBo
YXZpbmcgZGlmZmVyZW50IG1lYW5pbmcgb24gQVJNIGFuZCBQb3dlclBDIGlzIGEgaXNzdWUuDQoN
ClRoYW5rcywNCll1YW50aWFuDQo+IC1TY290dA0KPiANCg0K
^ permalink raw reply [flat|nested] 37+ messages in thread
* RE: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add CLK_OF_DECLARE support
@ 2014-10-08 3:28 ` Yuantian Tang
0 siblings, 0 replies; 37+ messages in thread
From: Yuantian Tang @ 2014-10-08 3:28 UTC (permalink / raw)
To: Scott Wood
Cc: Mike Turquette, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Jingchang Lu
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2871 bytes --]
> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Tuesday, September 30, 2014 7:58 AM
> To: Tang Yuantian-B29983
> Cc: Mike Turquette; linuxppc-dev@lists.ozlabs.org; linux-kernel@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; Lu Jingchang-B35083
> Subject: Re: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add
> CLK_OF_DECLARE support
>
> On Sat, 2014-09-27 at 21:18 -0500, Tang Yuantian-B29983 wrote:
> > > -----Original Message-----
> > > From: Linuxppc-dev
> > > [mailto:linuxppc-dev-bounces+b29983=freescale.com@lists.ozlabs.org]
> > > On Behalf Of Mike Turquette
> > > Sent: Saturday, September 27, 2014 7:29 AM
> > > To: Wood Scott-B07421
> > > Cc: linuxppc-dev@lists.ozlabs.org; linux-kernel@vger.kernel.org;
> > > linux-arm-kernel@lists.infradead.org; Lu Jingchang-B35083
> > > Subject: Re: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add
> > > CLK_OF_DECLARE support
> > >
> > > Quoting Scott Wood (2014-09-25 15:56:20)
> > > > On Thu, 2014-09-25 at 15:54 -0700, Mike Turquette wrote:
> > > > > Quoting Scott Wood (2014-09-25 13:08:00)
> > > > > > Well, like I said, I'd rather see the CLK_OF_DECLARE stuff be
> > > > > > made to work on PPC rather than have the driver carry around
> > > > > > two binding methods.
> > > > >
> > > > > I guess that is an existing problem, and not related directly to
> > > > > this patch? This patch is essentially just renames (though the
> > > > > V1.0/V2.0 stuff seems weird).
> > > >
> > > > This patch is adding CLK_OF_DECLARE.
> > >
> > > I'm fine taking this patch but your comments are still unresolved.
> > > What do you think needs to be done to fix the problems that you see?
> > >
> > CLK_OF_DECLARE is totally worked on PPC. I will do it in a separate patch.
> > Regarding V1.0 and V2.0, it is not wired just same for now. But we are not sure
> if it is same for v3.0 in the future.
> >
> > Besides updating drivers/cpufreq/Kconfig.powerpc, there is one more thing I
> am not comfortable with:
> > This patch uses " fixed-clock" as sysclk's compatible string, while on PPC we
> treated it as " fsl,qoriq-sysclk-[1-2].0".
> > That's inconsistent on both ARM and PPC platforms, neither did on bindings.
>
> fsl,qoriq-sysclk-XXX is the way it is because of compatibility with the fixups in
> existing U-Boots. It shouldn't be used as a model.
>
> That said, I don't think you really mean "this patch", as it doesn't contain the
> device tree updates, and "fixed-clock" does not appear.
>
"fixed-clock" will appear when ls102x platform DTS gets upstreamed eventually.
That would be fine if you don't think "fsl,qoriq-sysclk-xxx" having different meaning on ARM and PowerPC is a issue.
Thanks,
Yuantian
> -Scott
>
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 37+ messages in thread* [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add CLK_OF_DECLARE support
@ 2014-10-08 3:28 ` Yuantian Tang
0 siblings, 0 replies; 37+ messages in thread
From: Yuantian Tang @ 2014-10-08 3:28 UTC (permalink / raw)
To: linux-arm-kernel
> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Tuesday, September 30, 2014 7:58 AM
> To: Tang Yuantian-B29983
> Cc: Mike Turquette; linuxppc-dev at lists.ozlabs.org; linux-kernel at vger.kernel.org;
> linux-arm-kernel at lists.infradead.org; Lu Jingchang-B35083
> Subject: Re: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add
> CLK_OF_DECLARE support
>
> On Sat, 2014-09-27 at 21:18 -0500, Tang Yuantian-B29983 wrote:
> > > -----Original Message-----
> > > From: Linuxppc-dev
> > > [mailto:linuxppc-dev-bounces+b29983=freescale.com at lists.ozlabs.org]
> > > On Behalf Of Mike Turquette
> > > Sent: Saturday, September 27, 2014 7:29 AM
> > > To: Wood Scott-B07421
> > > Cc: linuxppc-dev at lists.ozlabs.org; linux-kernel at vger.kernel.org;
> > > linux-arm-kernel at lists.infradead.org; Lu Jingchang-B35083
> > > Subject: Re: [PATCHv4] clk: ppc-corenet: rename to ppc-qoriq and add
> > > CLK_OF_DECLARE support
> > >
> > > Quoting Scott Wood (2014-09-25 15:56:20)
> > > > On Thu, 2014-09-25 at 15:54 -0700, Mike Turquette wrote:
> > > > > Quoting Scott Wood (2014-09-25 13:08:00)
> > > > > > Well, like I said, I'd rather see the CLK_OF_DECLARE stuff be
> > > > > > made to work on PPC rather than have the driver carry around
> > > > > > two binding methods.
> > > > >
> > > > > I guess that is an existing problem, and not related directly to
> > > > > this patch? This patch is essentially just renames (though the
> > > > > V1.0/V2.0 stuff seems weird).
> > > >
> > > > This patch is adding CLK_OF_DECLARE.
> > >
> > > I'm fine taking this patch but your comments are still unresolved.
> > > What do you think needs to be done to fix the problems that you see?
> > >
> > CLK_OF_DECLARE is totally worked on PPC. I will do it in a separate patch.
> > Regarding V1.0 and V2.0, it is not wired just same for now. But we are not sure
> if it is same for v3.0 in the future.
> >
> > Besides updating drivers/cpufreq/Kconfig.powerpc, there is one more thing I
> am not comfortable with:
> > This patch uses " fixed-clock" as sysclk's compatible string, while on PPC we
> treated it as " fsl,qoriq-sysclk-[1-2].0".
> > That's inconsistent on both ARM and PPC platforms, neither did on bindings.
>
> fsl,qoriq-sysclk-XXX is the way it is because of compatibility with the fixups in
> existing U-Boots. It shouldn't be used as a model.
>
> That said, I don't think you really mean "this patch", as it doesn't contain the
> device tree updates, and "fixed-clock" does not appear.
>
"fixed-clock" will appear when ls102x platform DTS gets upstreamed eventually.
That would be fine if you don't think "fsl,qoriq-sysclk-xxx" having different meaning on ARM and PowerPC is a issue.
Thanks,
Yuantian
> -Scott
>
^ permalink raw reply [flat|nested] 37+ messages in thread