From: Mark Rutland <mark.rutland@arm.com>
To: Kiran Padwal <kiran.padwal@smartplayin.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Kumar Gala <galak@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <Pawel.Moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Russell King <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"arm@kernel.org" <arm@kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"bjorn.andersson@sonymobile.com" <bjorn.andersson@sonymobile.com>
Subject: Re: [PATCH 3/4] ARM: DT: apq8064: Add USB OTG support
Date: Mon, 29 Sep 2014 11:53:29 +0100 [thread overview]
Message-ID: <20140929105329.GA2432@leverpostej> (raw)
In-Reply-To: <542933E1.8010809@smartplayin.com>
On Mon, Sep 29, 2014 at 11:26:41AM +0100, Kiran Padwal wrote:
> Hi Srinivas,
>
> Some review are comments inline.
>
> On Monday 29 September 2014 02:45 PM, Srinivas Kandagatla wrote:
> > This patch adds USB OTG support on USB1 of APQ8064 SOC.
> > Tested on IFC6410 with ethernet gadget.
> >
> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> > ---
> > arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 14 +++++++++
> > arch/arm/boot/dts/qcom-apq8064.dtsi | 46 ++++++++++++++++++++++++++++++
> > 2 files changed, 60 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> > index d6036b8..f41fb39 100644
> > --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> > +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> > @@ -40,6 +40,11 @@
> > };
> > };
> >
> > + /* OTG */
> > + usb1_phy:phy@12500000 {
> > + status = "ok";
>
> Its canonical value is "okay" (although in practice anything
> other than "disabled" should work).
That's not quite true, there are other "bad" values like "fail" and
"fail-sss" documented by ePAPR. In Linux, of_device_is_available errs on
the side of caution and checks for either "okay" or "ok", failing
otherwise
Regardless, please use the canonical "okay".
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] ARM: DT: apq8064: Add USB OTG support
Date: Mon, 29 Sep 2014 11:53:29 +0100 [thread overview]
Message-ID: <20140929105329.GA2432@leverpostej> (raw)
In-Reply-To: <542933E1.8010809@smartplayin.com>
On Mon, Sep 29, 2014 at 11:26:41AM +0100, Kiran Padwal wrote:
> Hi Srinivas,
>
> Some review are comments inline.
>
> On Monday 29 September 2014 02:45 PM, Srinivas Kandagatla wrote:
> > This patch adds USB OTG support on USB1 of APQ8064 SOC.
> > Tested on IFC6410 with ethernet gadget.
> >
> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> > ---
> > arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 14 +++++++++
> > arch/arm/boot/dts/qcom-apq8064.dtsi | 46 ++++++++++++++++++++++++++++++
> > 2 files changed, 60 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> > index d6036b8..f41fb39 100644
> > --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> > +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> > @@ -40,6 +40,11 @@
> > };
> > };
> >
> > + /* OTG */
> > + usb1_phy:phy at 12500000 {
> > + status = "ok";
>
> Its canonical value is "okay" (although in practice anything
> other than "disabled" should work).
That's not quite true, there are other "bad" values like "fail" and
"fail-sss" documented by ePAPR. In Linux, of_device_is_available errs on
the side of caution and checks for either "okay" or "ok", failing
otherwise
Regardless, please use the canonical "okay".
Mark.
next prev parent reply other threads:[~2014-09-29 10:53 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 9:14 [PATCH 0/4] ARM: DT: apq8064 DT patches Srinivas Kandagatla
2014-09-29 9:14 ` Srinivas Kandagatla
2014-09-29 9:14 ` Srinivas Kandagatla
2014-09-29 9:14 ` [PATCH 1/4] ARM: DT: apq8064: add rpm support Srinivas Kandagatla
2014-09-29 9:14 ` Srinivas Kandagatla
2014-09-29 22:17 ` Stephen Boyd
2014-09-29 22:17 ` Stephen Boyd
2014-09-30 5:02 ` Bjorn Andersson
2014-09-30 5:02 ` Bjorn Andersson
2014-09-30 18:27 ` Stephen Boyd
2014-09-30 18:27 ` Stephen Boyd
2014-09-30 19:00 ` Bjorn Andersson
2014-09-30 19:00 ` Bjorn Andersson
2014-09-30 19:13 ` Stephen Boyd
2014-09-30 19:13 ` Stephen Boyd
2014-09-30 19:56 ` Bjorn Andersson
2014-09-30 19:56 ` Bjorn Andersson
2014-09-30 7:44 ` Srinivas Kandagatla
2014-09-30 7:44 ` Srinivas Kandagatla
[not found] ` <1411982092-7922-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-09-30 5:11 ` Bjorn Andersson
2014-09-30 5:11 ` Bjorn Andersson
2014-09-30 5:11 ` Bjorn Andersson
[not found] ` <20140930051138.GH28481-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org>
2014-09-30 7:49 ` Srinivas Kandagatla
2014-09-30 7:49 ` Srinivas Kandagatla
2014-09-30 7:49 ` Srinivas Kandagatla
2014-09-29 9:15 ` [PATCH 2/4] ARM: DT: apq8064: Add usb host support Srinivas Kandagatla
2014-09-29 9:15 ` Srinivas Kandagatla
[not found] ` <1411982100-7964-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-09-30 5:17 ` Bjorn Andersson
2014-09-30 5:17 ` Bjorn Andersson
2014-09-30 5:17 ` Bjorn Andersson
2014-09-30 8:16 ` Srinivas Kandagatla
2014-09-30 8:16 ` Srinivas Kandagatla
2014-09-29 9:15 ` [PATCH 3/4] ARM: DT: apq8064: Add USB OTG support Srinivas Kandagatla
2014-09-29 9:15 ` Srinivas Kandagatla
2014-09-29 10:26 ` Kiran Padwal
2014-09-29 10:26 ` Kiran Padwal
2014-09-29 10:53 ` Mark Rutland [this message]
2014-09-29 10:53 ` Mark Rutland
2014-09-29 11:27 ` Srinivas Kandagatla
2014-09-29 11:27 ` Srinivas Kandagatla
2014-09-29 9:15 ` [PATCH 4/4] ARM: DT: apq8064: Add SATA controller support Srinivas Kandagatla
2014-09-29 9:15 ` Srinivas Kandagatla
2014-09-29 22:20 ` Stephen Boyd
2014-09-29 22:20 ` Stephen Boyd
[not found] ` <5429DB3D.5080701-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-09-30 8:18 ` Srinivas Kandagatla
2014-09-30 8:18 ` Srinivas Kandagatla
2014-09-30 8:18 ` Srinivas Kandagatla
2014-09-30 14:09 ` [PATCH v2 0/4] ARM: dts: apq8064 DT patches Srinivas Kandagatla
2014-09-30 14:09 ` Srinivas Kandagatla
2014-09-30 14:09 ` [PATCH v2 1/4] ARM: dts: apq8064: add RPM regulators support Srinivas Kandagatla
2014-09-30 14:09 ` Srinivas Kandagatla
2014-09-30 15:14 ` Bjorn Andersson
2014-09-30 15:14 ` Bjorn Andersson
2014-09-30 15:48 ` Srinivas Kandagatla
2014-09-30 15:48 ` Srinivas Kandagatla
2014-09-30 14:09 ` [PATCH v2 2/4] ARM: dts: apq8064: Add usb host support Srinivas Kandagatla
2014-09-30 14:09 ` Srinivas Kandagatla
2014-09-30 14:10 ` [PATCH v2 3/4] ARM: dts: apq8064: Add USB OTG support Srinivas Kandagatla
2014-09-30 14:10 ` Srinivas Kandagatla
2014-09-30 14:10 ` [PATCH v2 4/4] ARM: dts: apq8064: Add SATA controller support Srinivas Kandagatla
2014-09-30 14:10 ` Srinivas Kandagatla
2014-09-30 18:45 ` [PATCH v2 0/4] ARM: dts: apq8064 DT patches Kevin Hilman
2014-09-30 18:45 ` Kevin Hilman
2014-10-01 9:05 ` [PATCH v3 " Srinivas Kandagatla
2014-10-01 9:05 ` Srinivas Kandagatla
[not found] ` <1412154355-2639-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-10-01 9:06 ` [PATCH v3 1/4] ARM: dts: apq8064: add RPM regulators support Srinivas Kandagatla
2014-10-01 9:06 ` Srinivas Kandagatla
2014-10-01 9:06 ` Srinivas Kandagatla
2014-10-01 9:06 ` [PATCH v3 4/4] ARM: dts: apq8064: Add SATA controller support Srinivas Kandagatla
2014-10-01 9:06 ` Srinivas Kandagatla
2014-10-01 9:06 ` Srinivas Kandagatla
2014-10-01 9:06 ` [PATCH v3 2/4] ARM: dts: apq8064: Add usb host support Srinivas Kandagatla
2014-10-01 9:06 ` Srinivas Kandagatla
2014-10-01 9:06 ` [PATCH v3 3/4] ARM: dts: apq8064: Add USB OTG support Srinivas Kandagatla
2014-10-01 9:06 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929105329.GA2432@leverpostej \
--to=mark.rutland@arm.com \
--cc=Pawel.Moll@arm.com \
--cc=arm@kernel.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kiran.padwal@smartplayin.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.