From: Greg KH <gregkh@linuxfoundation.org>
To: Kevin Hilman <khilman@kernel.org>
Cc: Sudhir Sreedharan <ssreedharan@mvista.com>,
linux-serial@vger.kernel.org, jslaby@suse.cz,
lkml <linux-kernel@vger.kernel.org>,
olof@lixom.net,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] serial/core: Initialize the console pm state
Date: Thu, 2 Oct 2014 21:35:13 -0700 [thread overview]
Message-ID: <20141003043513.GA21327@kroah.com> (raw)
In-Reply-To: <CAMAWPa9R5HtGKkV=Ya-ekynY5maespZ0Q6BjwJcX3LN3857ZjQ@mail.gmail.com>
On Wed, Oct 01, 2014 at 10:27:20AM -0700, Kevin Hilman wrote:
> On Sun, Sep 21, 2014 at 11:30 PM, Sudhir Sreedharan
> <ssreedharan@mvista.com> wrote:
> > For console devices having UART_CAP_SLEEP capability, the uart_pm_state has
> > to be initialized to UART_PM_STATE_ON. Otherwise the LCR regiser values
> > are reinitialized when uart_change_pm is called from uart_configure_port.
> >
> > Signed-off-by: Sudhir Sreedharan <ssreedharan@mvista.com>
>
> Multiple boot failures on ARM[1] were bisected down to this patch.
>
> How was this patch tested, and on which platforms?
>
> Also, the changelog states that this should be done only for
> UART_CAP_SLEEP, but the patch does it for every UART.
>
> Greg, I suggest this patch be dropped from tty-next until it has been
> better described and tested.
Now reverted, thanks for letting me know.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial/core: Initialize the console pm state
Date: Thu, 2 Oct 2014 21:35:13 -0700 [thread overview]
Message-ID: <20141003043513.GA21327@kroah.com> (raw)
In-Reply-To: <CAMAWPa9R5HtGKkV=Ya-ekynY5maespZ0Q6BjwJcX3LN3857ZjQ@mail.gmail.com>
On Wed, Oct 01, 2014 at 10:27:20AM -0700, Kevin Hilman wrote:
> On Sun, Sep 21, 2014 at 11:30 PM, Sudhir Sreedharan
> <ssreedharan@mvista.com> wrote:
> > For console devices having UART_CAP_SLEEP capability, the uart_pm_state has
> > to be initialized to UART_PM_STATE_ON. Otherwise the LCR regiser values
> > are reinitialized when uart_change_pm is called from uart_configure_port.
> >
> > Signed-off-by: Sudhir Sreedharan <ssreedharan@mvista.com>
>
> Multiple boot failures on ARM[1] were bisected down to this patch.
>
> How was this patch tested, and on which platforms?
>
> Also, the changelog states that this should be done only for
> UART_CAP_SLEEP, but the patch does it for every UART.
>
> Greg, I suggest this patch be dropped from tty-next until it has been
> better described and tested.
Now reverted, thanks for letting me know.
greg k-h
next prev parent reply other threads:[~2014-10-03 4:36 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 6:30 [PATCH] serial/core: Initialize the console pm state Sudhir Sreedharan
2014-10-01 17:27 ` Kevin Hilman
2014-10-01 17:27 ` Kevin Hilman
2014-10-03 4:35 ` Greg KH [this message]
2014-10-03 4:35 ` Greg KH
2014-10-03 12:22 ` Geert Uytterhoeven
2014-10-03 12:22 ` Geert Uytterhoeven
2014-10-06 9:48 ` Sudhir Sreedharan
2014-10-06 9:48 ` Sudhir Sreedharan
2014-10-06 9:27 ` Sudhir Sreedharan
2014-10-06 9:27 ` Sudhir Sreedharan
2014-10-09 13:42 ` Sudhir Sreedharan
2014-10-09 13:42 ` Sudhir Sreedharan
2014-10-09 13:45 ` [PATCH] tty: serial: 8250_core: Do not call set_sleep for console port Sudhir Sreedharan
2014-10-09 13:45 ` Sudhir Sreedharan
2014-10-09 14:45 ` Peter Hurley
2014-10-09 14:45 ` Peter Hurley
2014-10-15 6:43 ` [PATCH] tty: serial: 8250_core: restore the LCR register in set_sleep Sudhir Sreedharan
2014-10-15 6:43 ` Sudhir Sreedharan
2014-10-16 7:21 ` Kevin Hilman
2014-10-16 7:21 ` Kevin Hilman
2014-10-16 10:15 ` Sudhir Sreedharan
2014-10-16 10:15 ` Sudhir Sreedharan
2014-10-16 12:35 ` Peter Hurley
2014-10-16 12:35 ` Peter Hurley
2014-10-17 10:25 ` Sudhir Sreedharan
2014-10-17 10:25 ` Sudhir Sreedharan
2014-10-17 12:39 ` [PATCH v1] " Sudhir Sreedharan
2014-10-17 12:39 ` Sudhir Sreedharan
2014-10-17 12:46 ` Peter Hurley
2014-10-17 12:46 ` Peter Hurley
2014-10-20 15:01 ` Kevin Hilman
2014-10-20 15:01 ` Kevin Hilman
2014-10-21 6:45 ` Sudhir Sreedharan
2014-10-21 6:45 ` Sudhir Sreedharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141003043513.GA21327@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=olof@lixom.net \
--cc=ssreedharan@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.