All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@kernel.org>
To: Sudhir Sreedharan <ssreedharan@mvista.com>
Cc: peter@hurleysoftware.com, gregkh@linuxfoundation.org,
	linux-serial@vger.kernel.org, jslaby@suse.cz,
	linux-kernel@vger.kernel.org, olof@lixom.net,
	linux-arm-kernel@lists.infradead.org, geert@linux-m68k.org
Subject: Re: [PATCH] tty: serial: 8250_core: restore the LCR register in set_sleep
Date: Thu, 16 Oct 2014 00:21:17 -0700	[thread overview]
Message-ID: <7hwq80h442.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1413355395-5871-1-git-send-email-ssreedharan@mvista.com> (Sudhir Sreedharan's message of "Wed, 15 Oct 2014 12:13:15 +0530")

Sudhir Sreedharan <ssreedharan@mvista.com> writes:

> In ST16650V2 based serial uarts, while initalizing the PM state,
> LCR registers are being initialized to 0 in serial8250_set_sleep().
> If console port is already initialized and being used, this will
> throws garbage in the console.
>
> Signed-off-by: Sudhir Sreedharan <ssreedharan@mvista.com>

Since this caused regressions in -next last time, could you describe how
this was tested, and on what platforms?

Thanks,

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@kernel.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] tty: serial: 8250_core: restore the LCR register in set_sleep
Date: Thu, 16 Oct 2014 00:21:17 -0700	[thread overview]
Message-ID: <7hwq80h442.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1413355395-5871-1-git-send-email-ssreedharan@mvista.com> (Sudhir Sreedharan's message of "Wed, 15 Oct 2014 12:13:15 +0530")

Sudhir Sreedharan <ssreedharan@mvista.com> writes:

> In ST16650V2 based serial uarts, while initalizing the PM state,
> LCR registers are being initialized to 0 in serial8250_set_sleep().
> If console port is already initialized and being used, this will
> throws garbage in the console.
>
> Signed-off-by: Sudhir Sreedharan <ssreedharan@mvista.com>

Since this caused regressions in -next last time, could you describe how
this was tested, and on what platforms?

Thanks,

Kevin

  reply	other threads:[~2014-10-16  7:21 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-22  6:30 [PATCH] serial/core: Initialize the console pm state Sudhir Sreedharan
2014-10-01 17:27 ` Kevin Hilman
2014-10-01 17:27   ` Kevin Hilman
2014-10-03  4:35   ` Greg KH
2014-10-03  4:35     ` Greg KH
2014-10-03 12:22   ` Geert Uytterhoeven
2014-10-03 12:22     ` Geert Uytterhoeven
2014-10-06  9:48     ` Sudhir Sreedharan
2014-10-06  9:48       ` Sudhir Sreedharan
2014-10-06  9:27   ` Sudhir Sreedharan
2014-10-06  9:27     ` Sudhir Sreedharan
2014-10-09 13:42     ` Sudhir Sreedharan
2014-10-09 13:42       ` Sudhir Sreedharan
2014-10-09 13:45       ` [PATCH] tty: serial: 8250_core: Do not call set_sleep for console port Sudhir Sreedharan
2014-10-09 13:45         ` Sudhir Sreedharan
2014-10-09 14:45         ` Peter Hurley
2014-10-09 14:45           ` Peter Hurley
2014-10-15  6:43           ` [PATCH] tty: serial: 8250_core: restore the LCR register in set_sleep Sudhir Sreedharan
2014-10-15  6:43             ` Sudhir Sreedharan
2014-10-16  7:21             ` Kevin Hilman [this message]
2014-10-16  7:21               ` Kevin Hilman
2014-10-16 10:15               ` Sudhir Sreedharan
2014-10-16 10:15                 ` Sudhir Sreedharan
2014-10-16 12:35             ` Peter Hurley
2014-10-16 12:35               ` Peter Hurley
2014-10-17 10:25               ` Sudhir Sreedharan
2014-10-17 10:25                 ` Sudhir Sreedharan
2014-10-17 12:39                 ` [PATCH v1] " Sudhir Sreedharan
2014-10-17 12:39                   ` Sudhir Sreedharan
2014-10-17 12:46                   ` Peter Hurley
2014-10-17 12:46                     ` Peter Hurley
2014-10-20 15:01                   ` Kevin Hilman
2014-10-20 15:01                     ` Kevin Hilman
2014-10-21  6:45                     ` Sudhir Sreedharan
2014-10-21  6:45                       ` Sudhir Sreedharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7hwq80h442.fsf@deeprootsystems.com \
    --to=khilman@kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=peter@hurleysoftware.com \
    --cc=ssreedharan@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.