From: Mark Rutland <mark.rutland@arm.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "atull@opensource.altera.com" <atull@opensource.altera.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"jdelvare@suse.de" <jdelvare@suse.de>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Pawel Moll <Pawel.Moll@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"delicious.quinoa@gmail.com" <delicious.quinoa@gmail.com>,
"dinguyen@opensource.altera.com" <dinguyen@opensource.altera.com>,
"yvanderv@opensource.altera.com" <yvanderv@opensource.altera.com>
Subject: Re: [lm-sensors] [PATCH v5 1/4] hwmon: ltc2978: device tree bindings documentation
Date: Fri, 03 Oct 2014 13:05:59 +0000 [thread overview]
Message-ID: <20141003130559.GJ26643@leverpostej> (raw)
In-Reply-To: <542E9E9B.4090307@roeck-us.net>
On Fri, Oct 03, 2014 at 02:03:23PM +0100, Guenter Roeck wrote:
> On 10/03/2014 05:27 AM, Mark Rutland wrote:
> > On Thu, Oct 02, 2014 at 07:37:48PM +0100, atull@opensource.altera.com wrote:
> >> From: Alan Tull <atull@opensource.altera.com>
> >>
> >> Add device tree bindings documentation for ltc2978.
> >>
> >> Signed-off-by: Alan Tull <atull@opensource.altera.com>
> >> ---
> >> v2: clean whitespace
> >> ---
> >> .../devicetree/bindings/hwmon/ltc2978.txt | 41 ++++++++++++++++++++
> >> 1 file changed, 41 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/hwmon/ltc2978.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/hwmon/ltc2978.txt b/Documentation/devicetree/bindings/hwmon/ltc2978.txt
> >> new file mode 100644
> >> index 0000000..b2d9c4d
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/hwmon/ltc2978.txt
> >> @@ -0,0 +1,41 @@
> >> +ltc2978
> >> +
> >> +Required properties:
> >> + - compatible: one of: ltc2974, ltc2977, ltc2978, ltc3880, ltc3883, ltm4676
> >
> > Could we please format this like:
> >
> > - compatible: should contain one of:
> > * "ltc2974"
> > * "ltc2977"
> > * "ltc2978"
> > * "ltc3880"
> > * "ltc3883"
> > * "ltm4676"
> >
> > Given the file name, are these all variants of ltc2978?
> >
>
> All the chips supported by the ltc2978 driver. Some are variants
> of the ltc2978, some have different functionality.
Ok.
>
> [ should those be "linear,ltc2974" and so on ? ]
Good point; yes they should. That will need a vendor-prefixes.txt
addition.
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
To: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
Cc: "atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org"
<atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>,
"broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"jdelvare-l3A5Bk7waGM@public.gmane.org"
<jdelvare-l3A5Bk7waGM@public.gmane.org>,
"lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org"
<lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org>,
"lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>,
"ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org"
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
"galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org"
<galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"delicious.quinoa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<delicious.quinoa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org"
<dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>,
"yvanderv-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org"
<yvanderv-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
Subject: Re: [PATCH v5 1/4] hwmon: ltc2978: device tree bindings documentation
Date: Fri, 3 Oct 2014 14:05:59 +0100 [thread overview]
Message-ID: <20141003130559.GJ26643@leverpostej> (raw)
In-Reply-To: <542E9E9B.4090307-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
On Fri, Oct 03, 2014 at 02:03:23PM +0100, Guenter Roeck wrote:
> On 10/03/2014 05:27 AM, Mark Rutland wrote:
> > On Thu, Oct 02, 2014 at 07:37:48PM +0100, atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org wrote:
> >> From: Alan Tull <atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
> >>
> >> Add device tree bindings documentation for ltc2978.
> >>
> >> Signed-off-by: Alan Tull <atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
> >> ---
> >> v2: clean whitespace
> >> ---
> >> .../devicetree/bindings/hwmon/ltc2978.txt | 41 ++++++++++++++++++++
> >> 1 file changed, 41 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/hwmon/ltc2978.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/hwmon/ltc2978.txt b/Documentation/devicetree/bindings/hwmon/ltc2978.txt
> >> new file mode 100644
> >> index 0000000..b2d9c4d
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/hwmon/ltc2978.txt
> >> @@ -0,0 +1,41 @@
> >> +ltc2978
> >> +
> >> +Required properties:
> >> + - compatible: one of: ltc2974, ltc2977, ltc2978, ltc3880, ltc3883, ltm4676
> >
> > Could we please format this like:
> >
> > - compatible: should contain one of:
> > * "ltc2974"
> > * "ltc2977"
> > * "ltc2978"
> > * "ltc3880"
> > * "ltc3883"
> > * "ltm4676"
> >
> > Given the file name, are these all variants of ltc2978?
> >
>
> All the chips supported by the ltc2978 driver. Some are variants
> of the ltc2978, some have different functionality.
Ok.
>
> [ should those be "linear,ltc2974" and so on ? ]
Good point; yes they should. That will need a vendor-prefixes.txt
addition.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "atull@opensource.altera.com" <atull@opensource.altera.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"jdelvare@suse.de" <jdelvare@suse.de>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Pawel Moll <Pawel.Moll@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"delicious.quinoa@gmail.com" <delicious.quinoa@gmail.com>,
"dinguyen@opensource.altera.com" <dinguyen@opensource.altera.com>,
"yvanderv@opensource.altera.com" <yvanderv@opensource.altera.com>
Subject: Re: [PATCH v5 1/4] hwmon: ltc2978: device tree bindings documentation
Date: Fri, 3 Oct 2014 14:05:59 +0100 [thread overview]
Message-ID: <20141003130559.GJ26643@leverpostej> (raw)
In-Reply-To: <542E9E9B.4090307@roeck-us.net>
On Fri, Oct 03, 2014 at 02:03:23PM +0100, Guenter Roeck wrote:
> On 10/03/2014 05:27 AM, Mark Rutland wrote:
> > On Thu, Oct 02, 2014 at 07:37:48PM +0100, atull@opensource.altera.com wrote:
> >> From: Alan Tull <atull@opensource.altera.com>
> >>
> >> Add device tree bindings documentation for ltc2978.
> >>
> >> Signed-off-by: Alan Tull <atull@opensource.altera.com>
> >> ---
> >> v2: clean whitespace
> >> ---
> >> .../devicetree/bindings/hwmon/ltc2978.txt | 41 ++++++++++++++++++++
> >> 1 file changed, 41 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/hwmon/ltc2978.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/hwmon/ltc2978.txt b/Documentation/devicetree/bindings/hwmon/ltc2978.txt
> >> new file mode 100644
> >> index 0000000..b2d9c4d
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/hwmon/ltc2978.txt
> >> @@ -0,0 +1,41 @@
> >> +ltc2978
> >> +
> >> +Required properties:
> >> + - compatible: one of: ltc2974, ltc2977, ltc2978, ltc3880, ltc3883, ltm4676
> >
> > Could we please format this like:
> >
> > - compatible: should contain one of:
> > * "ltc2974"
> > * "ltc2977"
> > * "ltc2978"
> > * "ltc3880"
> > * "ltc3883"
> > * "ltm4676"
> >
> > Given the file name, are these all variants of ltc2978?
> >
>
> All the chips supported by the ltc2978 driver. Some are variants
> of the ltc2978, some have different functionality.
Ok.
>
> [ should those be "linear,ltc2974" and so on ? ]
Good point; yes they should. That will need a vendor-prefixes.txt
addition.
next prev parent reply other threads:[~2014-10-03 13:05 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 18:37 [lm-sensors] [PATCH v5 0/4] This set of patches adds regulator support for pmbus_core.c and ltc2978 atull
2014-10-02 18:37 ` [PATCH v5 0/4] This set of patches adds regulator support for pmbus_core.c and ltc2978.c atull
2014-10-02 18:37 ` atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
2014-10-02 18:37 ` [lm-sensors] [PATCH v5 1/4] hwmon: ltc2978: device tree bindings documentation atull
2014-10-02 18:37 ` atull
2014-10-02 18:37 ` atull
2014-10-03 12:27 ` [lm-sensors] " Mark Rutland
2014-10-03 12:27 ` Mark Rutland
2014-10-03 12:27 ` Mark Rutland
2014-10-03 13:03 ` [lm-sensors] " Guenter Roeck
2014-10-03 13:03 ` Guenter Roeck
2014-10-03 13:03 ` Guenter Roeck
2014-10-03 13:05 ` Mark Rutland [this message]
2014-10-03 13:05 ` Mark Rutland
2014-10-03 13:05 ` Mark Rutland
2014-10-03 15:21 ` [lm-sensors] " Guenter Roeck
2014-10-03 15:21 ` Guenter Roeck
2014-10-03 17:28 ` [lm-sensors] " Guenter Roeck
2014-10-03 17:28 ` Guenter Roeck
2014-10-03 23:13 ` [lm-sensors] " Mark Brown
2014-10-03 23:13 ` Mark Brown
2014-10-03 23:23 ` [lm-sensors] " Guenter Roeck
2014-10-03 23:23 ` Guenter Roeck
2014-10-04 9:53 ` [lm-sensors] " Mark Brown
2014-10-04 9:53 ` Mark Brown
2014-10-04 9:53 ` Mark Brown
2014-10-05 0:13 ` [lm-sensors] " Guenter Roeck
2014-10-05 0:13 ` Guenter Roeck
2014-10-06 17:28 ` [lm-sensors] " Guenter Roeck
2014-10-06 17:28 ` Guenter Roeck
2014-10-08 16:12 ` [lm-sensors] " atull
2014-10-08 16:12 ` atull
2014-10-08 16:12 ` atull
2014-10-08 20:12 ` [lm-sensors] " Guenter Roeck
2014-10-08 20:12 ` Guenter Roeck
2014-10-08 20:12 ` Guenter Roeck
2014-10-08 20:21 ` [lm-sensors] " Mark Brown
2014-10-08 20:21 ` Mark Brown
2014-10-08 20:21 ` Mark Brown
2014-10-02 18:37 ` [lm-sensors] [PATCH v5 2/4] pmbus: core: add helpers for byte write and read modify write atull
2014-10-02 18:37 ` atull
2014-10-02 18:37 ` atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
2014-10-02 18:37 ` [lm-sensors] [PATCH v5 3/4] pmbus: add regulator support atull
2014-10-02 18:37 ` atull
2014-10-02 18:37 ` atull
2014-10-03 14:27 ` [lm-sensors] " Mark Brown
2014-10-03 14:27 ` Mark Brown
2014-10-03 14:27 ` Mark Brown
2014-10-03 15:23 ` [lm-sensors] " Guenter Roeck
2014-10-03 15:23 ` Guenter Roeck
2014-10-03 15:23 ` Guenter Roeck
2014-10-03 16:42 ` [lm-sensors] " Mark Brown
2014-10-03 16:42 ` Mark Brown
2014-10-07 14:38 ` [lm-sensors] " atull
2014-10-07 14:38 ` atull
2014-10-07 14:38 ` atull
2014-10-02 18:37 ` [lm-sensors] [PATCH v5 4/4] pmbus: ltc2978: " atull
2014-10-02 18:37 ` atull
2014-10-02 18:37 ` atull
2014-10-03 3:12 ` [lm-sensors] " Guenter Roeck
2014-10-03 3:12 ` Guenter Roeck
2014-10-03 3:12 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141003130559.GJ26643@leverpostej \
--to=mark.rutland@arm.com \
--cc=Pawel.Moll@arm.com \
--cc=atull@opensource.altera.com \
--cc=broonie@kernel.org \
--cc=delicious.quinoa@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@opensource.altera.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jdelvare@suse.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=robh+dt@kernel.org \
--cc=yvanderv@opensource.altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.