All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Mark Brown <broonie@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"atull@opensource.altera.com" <atull@opensource.altera.com>,
	"jdelvare@suse.de" <jdelvare@suse.de>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	Pawel Moll <Pawel.Moll@arm.com>,
	"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
	"galak@codeaurora.org" <galak@codeaurora.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"delicious.quinoa@gmail.com" <delicious.quinoa@gmail.com>,
	"dinguyen@opensource.altera.com" <dinguyen@opensource.altera.com>,
	"yvanderv@opensource.altera.com" <yvanderv@opensource.altera.com>
Subject: Re: [lm-sensors] [PATCH v5 1/4] hwmon: ltc2978: device tree bindings documentation
Date: Sun, 05 Oct 2014 00:13:53 +0000	[thread overview]
Message-ID: <54308D41.9070806@roeck-us.net> (raw)
In-Reply-To: <20141004095349.GB4609@sirena.org.uk>

On 10/04/2014 02:53 AM, Mark Brown wrote:
> On Fri, Oct 03, 2014 at 04:23:15PM -0700, Guenter Roeck wrote:
>> On 10/03/2014 04:13 PM, Mark Brown wrote:
>
>>> Nope, nothing to do with regulator that I'm aware of and I've not seen
>>> any examples (but I don't tend to review users too often).
>
>> Many examples, really. Just picking one.
>
>> Documentation/devicetree/bindings/mfd/tps6507x.txt
>
> OK, that's not an actual DTS...  I'm not seeing anything in the code.
>
>> 	regulators {
>>                  #address-cells = <1>;
>>                  #size-cells = <0>;
>> 		...
>
>> This also uses the reg property for the regulator index
>> (without explaining it further). Seems to be pretty common.
>
> If it's doing that it's nothing to do with the regulator API.
>
Since the code does not use those values either, presumably they don't have
to be specified in the first place. I'll test that with a real system
next week.

Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Mark Brown <broonie@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"atull@opensource.altera.com" <atull@opensource.altera.com>,
	"jdelvare@suse.de" <jdelvare@suse.de>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	Pawel Moll <Pawel.Moll@arm.com>,
	"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
	"galak@codeaurora.org" <galak@codeaurora.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"delicious.quinoa@gmail.com" <delicious.quinoa@gmail.com>,
	"dinguyen@opensource.altera.com" <dinguyen@opensource.altera.com>,
	"yvanderv@opensource.altera.com" <yvanderv@opensource.altera.com>
Subject: Re: [PATCH v5 1/4] hwmon: ltc2978: device tree bindings documentation
Date: Sat, 04 Oct 2014 17:13:53 -0700	[thread overview]
Message-ID: <54308D41.9070806@roeck-us.net> (raw)
In-Reply-To: <20141004095349.GB4609@sirena.org.uk>

On 10/04/2014 02:53 AM, Mark Brown wrote:
> On Fri, Oct 03, 2014 at 04:23:15PM -0700, Guenter Roeck wrote:
>> On 10/03/2014 04:13 PM, Mark Brown wrote:
>
>>> Nope, nothing to do with regulator that I'm aware of and I've not seen
>>> any examples (but I don't tend to review users too often).
>
>> Many examples, really. Just picking one.
>
>> Documentation/devicetree/bindings/mfd/tps6507x.txt
>
> OK, that's not an actual DTS...  I'm not seeing anything in the code.
>
>> 	regulators {
>>                  #address-cells = <1>;
>>                  #size-cells = <0>;
>> 		...
>
>> This also uses the reg property for the regulator index
>> (without explaining it further). Seems to be pretty common.
>
> If it's doing that it's nothing to do with the regulator API.
>
Since the code does not use those values either, presumably they don't have
to be specified in the first place. I'll test that with a real system
next week.

Guenter

  reply	other threads:[~2014-10-05  0:13 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-02 18:37 [lm-sensors] [PATCH v5 0/4] This set of patches adds regulator support for pmbus_core.c and ltc2978 atull
2014-10-02 18:37 ` [PATCH v5 0/4] This set of patches adds regulator support for pmbus_core.c and ltc2978.c atull
2014-10-02 18:37 ` atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
2014-10-02 18:37 ` [lm-sensors] [PATCH v5 1/4] hwmon: ltc2978: device tree bindings documentation atull
2014-10-02 18:37   ` atull
2014-10-02 18:37   ` atull
2014-10-03 12:27   ` [lm-sensors] " Mark Rutland
2014-10-03 12:27     ` Mark Rutland
2014-10-03 12:27     ` Mark Rutland
2014-10-03 13:03     ` [lm-sensors] " Guenter Roeck
2014-10-03 13:03       ` Guenter Roeck
2014-10-03 13:03       ` Guenter Roeck
2014-10-03 13:05       ` [lm-sensors] " Mark Rutland
2014-10-03 13:05         ` Mark Rutland
2014-10-03 13:05         ` Mark Rutland
2014-10-03 15:21         ` [lm-sensors] " Guenter Roeck
2014-10-03 15:21           ` Guenter Roeck
2014-10-03 17:28     ` [lm-sensors] " Guenter Roeck
2014-10-03 17:28       ` Guenter Roeck
2014-10-03 23:13       ` [lm-sensors] " Mark Brown
2014-10-03 23:13         ` Mark Brown
2014-10-03 23:23         ` [lm-sensors] " Guenter Roeck
2014-10-03 23:23           ` Guenter Roeck
2014-10-04  9:53           ` [lm-sensors] " Mark Brown
2014-10-04  9:53             ` Mark Brown
2014-10-04  9:53             ` Mark Brown
2014-10-05  0:13             ` Guenter Roeck [this message]
2014-10-05  0:13               ` Guenter Roeck
2014-10-06 17:28   ` [lm-sensors] " Guenter Roeck
2014-10-06 17:28     ` Guenter Roeck
2014-10-08 16:12     ` [lm-sensors] " atull
2014-10-08 16:12       ` atull
2014-10-08 16:12       ` atull
2014-10-08 20:12       ` [lm-sensors] " Guenter Roeck
2014-10-08 20:12         ` Guenter Roeck
2014-10-08 20:12         ` Guenter Roeck
2014-10-08 20:21         ` [lm-sensors] " Mark Brown
2014-10-08 20:21           ` Mark Brown
2014-10-08 20:21           ` Mark Brown
2014-10-02 18:37 ` [lm-sensors] [PATCH v5 2/4] pmbus: core: add helpers for byte write and read modify write atull
2014-10-02 18:37   ` atull
2014-10-02 18:37   ` atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
2014-10-02 18:37 ` [lm-sensors] [PATCH v5 3/4] pmbus: add regulator support atull
2014-10-02 18:37   ` atull
2014-10-02 18:37   ` atull
2014-10-03 14:27   ` [lm-sensors] " Mark Brown
2014-10-03 14:27     ` Mark Brown
2014-10-03 14:27     ` Mark Brown
2014-10-03 15:23     ` [lm-sensors] " Guenter Roeck
2014-10-03 15:23       ` Guenter Roeck
2014-10-03 15:23       ` Guenter Roeck
2014-10-03 16:42       ` [lm-sensors] " Mark Brown
2014-10-03 16:42         ` Mark Brown
2014-10-07 14:38     ` [lm-sensors] " atull
2014-10-07 14:38       ` atull
2014-10-07 14:38       ` atull
2014-10-02 18:37 ` [lm-sensors] [PATCH v5 4/4] pmbus: ltc2978: " atull
2014-10-02 18:37   ` atull
2014-10-02 18:37   ` atull
2014-10-03  3:12   ` [lm-sensors] " Guenter Roeck
2014-10-03  3:12     ` Guenter Roeck
2014-10-03  3:12     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54308D41.9070806@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=Pawel.Moll@arm.com \
    --cc=atull@opensource.altera.com \
    --cc=broonie@kernel.org \
    --cc=delicious.quinoa@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@opensource.altera.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jdelvare@suse.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=yvanderv@opensource.altera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.