From: "Michael S. Tsirkin" <mst@redhat.com>
To: arei.gonglei@huawei.com
Cc: qemu-trivial@nongnu.org, luonengjun@huawei.com,
weidong.huang@huawei.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] pcie: change confused comment clearer
Date: Tue, 7 Oct 2014 10:33:11 +0300 [thread overview]
Message-ID: <20141007073311.GA3231@redhat.com> (raw)
In-Reply-To: <1412664828-6852-1-git-send-email-arei.gonglei@huawei.com>
On Tue, Oct 07, 2014 at 02:53:48PM +0800, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> This comment applies to all functions below it.
> It is not appropriate that called capability allocation
> functions, change it into capability list management functions.
>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Applied, thanks!
> ---
> hw/pci/pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
> index 1babddf..d17bd27 100644
> --- a/hw/pci/pcie.c
> +++ b/hw/pci/pcie.c
> @@ -529,7 +529,7 @@ bool pcie_cap_is_arifwd_enabled(const PCIDevice *dev)
> }
>
> /**************************************************************************
> - * pci express extended capability allocation functions
> + * pci express extended capability list management functions
> * uint16_t ext_cap_id (16 bit)
> * uint8_t cap_ver (4 bit)
> * uint16_t cap_offset (12 bit)
> --
> 1.7.12.4
>
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: arei.gonglei@huawei.com
Cc: qemu-trivial@nongnu.org, luonengjun@huawei.com,
weidong.huang@huawei.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] pcie: change confused comment clearer
Date: Tue, 7 Oct 2014 10:33:11 +0300 [thread overview]
Message-ID: <20141007073311.GA3231@redhat.com> (raw)
In-Reply-To: <1412664828-6852-1-git-send-email-arei.gonglei@huawei.com>
On Tue, Oct 07, 2014 at 02:53:48PM +0800, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> This comment applies to all functions below it.
> It is not appropriate that called capability allocation
> functions, change it into capability list management functions.
>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Applied, thanks!
> ---
> hw/pci/pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
> index 1babddf..d17bd27 100644
> --- a/hw/pci/pcie.c
> +++ b/hw/pci/pcie.c
> @@ -529,7 +529,7 @@ bool pcie_cap_is_arifwd_enabled(const PCIDevice *dev)
> }
>
> /**************************************************************************
> - * pci express extended capability allocation functions
> + * pci express extended capability list management functions
> * uint16_t ext_cap_id (16 bit)
> * uint8_t cap_ver (4 bit)
> * uint16_t cap_offset (12 bit)
> --
> 1.7.12.4
>
next prev parent reply other threads:[~2014-10-07 7:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 6:53 [Qemu-trivial] [PATCH] pcie: change confused comment clearer arei.gonglei
2014-10-07 6:53 ` [Qemu-devel] " arei.gonglei
2014-10-07 7:33 ` Michael S. Tsirkin [this message]
2014-10-07 7:33 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007073311.GA3231@redhat.com \
--to=mst@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=luonengjun@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.