* [Qemu-trivial] [PATCH] pcie: change confused comment clearer
@ 2014-10-07 6:53 ` arei.gonglei
0 siblings, 0 replies; 4+ messages in thread
From: arei.gonglei @ 2014-10-07 6:53 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, luonengjun, Gonglei, weidong.huang, mst
From: Gonglei <arei.gonglei@huawei.com>
This comment applies to all functions below it.
It is not appropriate that called capability allocation
functions, change it into capability list management functions.
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
hw/pci/pcie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index 1babddf..d17bd27 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -529,7 +529,7 @@ bool pcie_cap_is_arifwd_enabled(const PCIDevice *dev)
}
/**************************************************************************
- * pci express extended capability allocation functions
+ * pci express extended capability list management functions
* uint16_t ext_cap_id (16 bit)
* uint8_t cap_ver (4 bit)
* uint16_t cap_offset (12 bit)
--
1.7.12.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Qemu-devel] [PATCH] pcie: change confused comment clearer
@ 2014-10-07 6:53 ` arei.gonglei
0 siblings, 0 replies; 4+ messages in thread
From: arei.gonglei @ 2014-10-07 6:53 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, luonengjun, Gonglei, weidong.huang, mst
From: Gonglei <arei.gonglei@huawei.com>
This comment applies to all functions below it.
It is not appropriate that called capability allocation
functions, change it into capability list management functions.
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
hw/pci/pcie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index 1babddf..d17bd27 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -529,7 +529,7 @@ bool pcie_cap_is_arifwd_enabled(const PCIDevice *dev)
}
/**************************************************************************
- * pci express extended capability allocation functions
+ * pci express extended capability list management functions
* uint16_t ext_cap_id (16 bit)
* uint8_t cap_ver (4 bit)
* uint16_t cap_offset (12 bit)
--
1.7.12.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-trivial] [PATCH] pcie: change confused comment clearer
2014-10-07 6:53 ` [Qemu-devel] " arei.gonglei
@ 2014-10-07 7:33 ` Michael S. Tsirkin
-1 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2014-10-07 7:33 UTC (permalink / raw)
To: arei.gonglei; +Cc: qemu-trivial, luonengjun, weidong.huang, qemu-devel
On Tue, Oct 07, 2014 at 02:53:48PM +0800, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> This comment applies to all functions below it.
> It is not appropriate that called capability allocation
> functions, change it into capability list management functions.
>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Applied, thanks!
> ---
> hw/pci/pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
> index 1babddf..d17bd27 100644
> --- a/hw/pci/pcie.c
> +++ b/hw/pci/pcie.c
> @@ -529,7 +529,7 @@ bool pcie_cap_is_arifwd_enabled(const PCIDevice *dev)
> }
>
> /**************************************************************************
> - * pci express extended capability allocation functions
> + * pci express extended capability list management functions
> * uint16_t ext_cap_id (16 bit)
> * uint8_t cap_ver (4 bit)
> * uint16_t cap_offset (12 bit)
> --
> 1.7.12.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] pcie: change confused comment clearer
@ 2014-10-07 7:33 ` Michael S. Tsirkin
0 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2014-10-07 7:33 UTC (permalink / raw)
To: arei.gonglei; +Cc: qemu-trivial, luonengjun, weidong.huang, qemu-devel
On Tue, Oct 07, 2014 at 02:53:48PM +0800, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> This comment applies to all functions below it.
> It is not appropriate that called capability allocation
> functions, change it into capability list management functions.
>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Applied, thanks!
> ---
> hw/pci/pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
> index 1babddf..d17bd27 100644
> --- a/hw/pci/pcie.c
> +++ b/hw/pci/pcie.c
> @@ -529,7 +529,7 @@ bool pcie_cap_is_arifwd_enabled(const PCIDevice *dev)
> }
>
> /**************************************************************************
> - * pci express extended capability allocation functions
> + * pci express extended capability list management functions
> * uint16_t ext_cap_id (16 bit)
> * uint8_t cap_ver (4 bit)
> * uint16_t cap_offset (12 bit)
> --
> 1.7.12.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-07 7:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-07 6:53 [Qemu-trivial] [PATCH] pcie: change confused comment clearer arei.gonglei
2014-10-07 6:53 ` [Qemu-devel] " arei.gonglei
2014-10-07 7:33 ` [Qemu-trivial] " Michael S. Tsirkin
2014-10-07 7:33 ` [Qemu-devel] " Michael S. Tsirkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.