From: Lee Jones <lee.jones@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Pramod Gurav <pramod.gurav@smartplayin.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alexandre Courbot <gnurou@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 2/2] mfd: remove use of gpiochip_remove() retval
Date: Tue, 7 Oct 2014 11:02:28 +0100 [thread overview]
Message-ID: <20141007100228.GZ25331@lee--X1> (raw)
In-Reply-To: <CACRpkdayTNQNUDw_eZ9brDBAbd-iSLumJrQrrVnABt=C92kUOA@mail.gmail.com>
On Tue, 07 Oct 2014, Linus Walleij wrote:
> On Tue, Oct 7, 2014 at 11:14 AM, Lee Jones <lee.jones@linaro.org> wrote:
> > On Wed, 01 Oct 2014, Linus Walleij wrote:
> >
> >> On Tue, Sep 30, 2014 at 4:15 PM, Pramod Gurav
> >> <pramod.gurav@smartplayin.com> wrote:
> >>
> >> > Get rid of using return value from gpiochip_remove() as it returns
> >> > void.
> >> >
> >> > Cc: Linus Walleij <linus.walleij@linaro.org>
> >> > Cc: Alexandre Courbot <gnurou@gmail.com>
> >> > Cc: Samuel Ortiz <sameo@linux.intel.com>
> >> > CC: Lee Jones <lee.jones@linaro.org>
> >> > Cc: linux-gpio@vger.kernel.org
> >> >
> >> > Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com>
> >>
> >> Already fixed in the GPIO tree.
> >
> > What does that mean? That it doesn't need fixing here?
>
> No. I think you already ACKed the patch fixing it in the GPIO
> tree...
No I don't need to apply the patch 'cos it's already fixed? Or, no
it's not already fixed and I need to apply the patch?
> There has been some misunderstanding and duplicate patches
> fixing already fixed problems are flying around.
I'm guessing from this commend that it _is_ already fixed and I _do
not_ need to apply this patch.
So for now I'm not applying this patch unless told otherwise.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Pramod Gurav <pramod.gurav@smartplayin.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alexandre Courbot <gnurou@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 2/2] mfd: remove use of gpiochip_remove() retval
Date: Tue, 7 Oct 2014 11:02:28 +0100 [thread overview]
Message-ID: <20141007100228.GZ25331@lee--X1> (raw)
In-Reply-To: <CACRpkdayTNQNUDw_eZ9brDBAbd-iSLumJrQrrVnABt=C92kUOA@mail.gmail.com>
On Tue, 07 Oct 2014, Linus Walleij wrote:
> On Tue, Oct 7, 2014 at 11:14 AM, Lee Jones <lee.jones@linaro.org> wrote:
> > On Wed, 01 Oct 2014, Linus Walleij wrote:
> >
> >> On Tue, Sep 30, 2014 at 4:15 PM, Pramod Gurav
> >> <pramod.gurav@smartplayin.com> wrote:
> >>
> >> > Get rid of using return value from gpiochip_remove() as it returns
> >> > void.
> >> >
> >> > Cc: Linus Walleij <linus.walleij@linaro.org>
> >> > Cc: Alexandre Courbot <gnurou@gmail.com>
> >> > Cc: Samuel Ortiz <sameo@linux.intel.com>
> >> > CC: Lee Jones <lee.jones@linaro.org>
> >> > Cc: linux-gpio@vger.kernel.org
> >> >
> >> > Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com>
> >>
> >> Already fixed in the GPIO tree.
> >
> > What does that mean? That it doesn't need fixing here?
>
> No. I think you already ACKed the patch fixing it in the GPIO
> tree...
No I don't need to apply the patch 'cos it's already fixed? Or, no
it's not already fixed and I need to apply the patch?
> There has been some misunderstanding and duplicate patches
> fixing already fixed problems are flying around.
I'm guessing from this commend that it _is_ already fixed and I _do
not_ need to apply this patch.
So for now I'm not applying this patch unless told otherwise.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-10-07 10:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 14:15 [PATCH 1/2] gpio: remove remaining users of gpiochip_remove() retval Pramod Gurav
2014-09-30 14:15 ` [PATCH 2/2] mfd: remove use " Pramod Gurav
2014-10-01 7:45 ` Linus Walleij
2014-10-07 9:14 ` Lee Jones
2014-10-07 9:14 ` Lee Jones
2014-10-07 9:19 ` Linus Walleij
2014-10-07 10:02 ` Lee Jones [this message]
2014-10-07 10:02 ` Lee Jones
2014-10-01 7:43 ` [PATCH 1/2] gpio: remove remaining users " Linus Walleij
2014-10-01 7:52 ` Pramod Gurav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007100228.GZ25331@lee--X1 \
--to=lee.jones@linaro.org \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pramod.gurav@smartplayin.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.