All of lore.kernel.org
 help / color / mirror / Atom feed
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] regulator: Add ena_gpio_valid config
Date: Tue, 7 Oct 2014 17:19:33 +0100	[thread overview]
Message-ID: <20141007161933.GH4609@sirena.org.uk> (raw)
In-Reply-To: <20141007130320.GF5042@pengutronix.de>

On Tue, Oct 07, 2014 at 03:03:20PM +0200, Markus Pargmann wrote:
> On Tue, Oct 07, 2014 at 12:53:35PM +0100, Mark Brown wrote:

> > This should be part of the patch adding meaningful behaviour for the
> > flag, it's pointless separately.

> I tried to keep the series bisectable while having different patches for
> the drivers and the core. By splitting this 'ena_gpio_valid' field into
> a seperate patch, the rest of the drivers will still compile and work
> until the core condition was changed to ena_gpio_valid.

> But I can squash the three patches into one.

No, I think this is missing the point a bit - if we need to introduce
this such that all drivers are instantly buggy without an update that's
probably an indication that we're introducing compatibility problems.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141007/2dcfa233/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 1/5] regulator: Add ena_gpio_valid config
Date: Tue, 7 Oct 2014 17:19:33 +0100	[thread overview]
Message-ID: <20141007161933.GH4609@sirena.org.uk> (raw)
In-Reply-To: <20141007130320.GF5042@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 779 bytes --]

On Tue, Oct 07, 2014 at 03:03:20PM +0200, Markus Pargmann wrote:
> On Tue, Oct 07, 2014 at 12:53:35PM +0100, Mark Brown wrote:

> > This should be part of the patch adding meaningful behaviour for the
> > flag, it's pointless separately.

> I tried to keep the series bisectable while having different patches for
> the drivers and the core. By splitting this 'ena_gpio_valid' field into
> a seperate patch, the rest of the drivers will still compile and work
> until the core condition was changed to ena_gpio_valid.

> But I can squash the three patches into one.

No, I think this is missing the point a bit - if we need to introduce
this such that all drivers are instantly buggy without an update that's
probably an indication that we're introducing compatibility problems.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2014-10-07 16:19 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-06 20:17 [PATCH 0/5] regulator: Fix core behaviour for gpio 0 Markus Pargmann
2014-10-06 20:17 ` Markus Pargmann
2014-10-06 20:17 ` [PATCH 1/5] regulator: Add ena_gpio_valid config Markus Pargmann
2014-10-06 20:17   ` Markus Pargmann
2014-10-07 11:53   ` Mark Brown
2014-10-07 11:53     ` Mark Brown
2014-10-07 13:03     ` Markus Pargmann
2014-10-07 13:03       ` Markus Pargmann
2014-10-07 16:19       ` Mark Brown [this message]
2014-10-07 16:19         ` Mark Brown
2014-10-07 19:18         ` Markus Pargmann
2014-10-07 19:18           ` Markus Pargmann
2014-10-06 20:17 ` [PATCH 2/5] regulator: Set ena_gpio_valid in regulator drivers Markus Pargmann
2014-10-06 20:17   ` Markus Pargmann
2014-10-07  8:46   ` Krzysztof Kozłowski
2014-10-07  8:46     ` Krzysztof Kozłowski
2014-10-07  9:10     ` Markus Pargmann
2014-10-07  9:10       ` Markus Pargmann
2014-10-07 11:58   ` Mark Brown
2014-10-07 11:58     ` Mark Brown
2014-10-07 13:05     ` Markus Pargmann
2014-10-07 13:05       ` Markus Pargmann
2014-10-06 20:17 ` [PATCH 3/5] regulator: Fix ena_gpio check Markus Pargmann
2014-10-06 20:17   ` Markus Pargmann
2014-10-06 20:17 ` [PATCH 4/5] regulator: Use gpio_is_valid Markus Pargmann
2014-10-06 20:17   ` Markus Pargmann
2014-10-07 12:01   ` Mark Brown
2014-10-07 12:01     ` Mark Brown
2014-10-07 13:07     ` Markus Pargmann
2014-10-07 13:07       ` Markus Pargmann
2014-10-07 16:20       ` Mark Brown
2014-10-07 16:20         ` Mark Brown
2014-10-06 20:17 ` [PATCH 5/5] regulator: Remove unnecessary ena_gpio initializations Markus Pargmann
2014-10-06 20:17   ` Markus Pargmann
2014-10-07  8:52   ` Krzysztof Kozłowski
2014-10-07  8:52     ` Krzysztof Kozłowski
2014-10-07  9:14     ` Markus Pargmann
2014-10-07  9:14       ` Markus Pargmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141007161933.GH4609@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.