* [PATCH 1/2] ASoC: fsl: imx-wm8962: Delete unneeded test before of_node_put
@ 2014-10-07 18:13 Fabio Estevam
2014-10-07 18:13 ` [PATCH 2/2] ASoC: fsl: imx-sgtl5000: " Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fabio Estevam @ 2014-10-07 18:13 UTC (permalink / raw)
To: broonie; +Cc: nicoleotsuka, Fabio Estevam, alsa-devel
of_node_put() supports NULL as its argument, so the initial test is not
necessary.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
sound/soc/fsl/imx-wm8962.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/sound/soc/fsl/imx-wm8962.c b/sound/soc/fsl/imx-wm8962.c
index 3a3d17c..48179ff 100644
--- a/sound/soc/fsl/imx-wm8962.c
+++ b/sound/soc/fsl/imx-wm8962.c
@@ -281,10 +281,8 @@ static int imx_wm8962_probe(struct platform_device *pdev)
clk_fail:
clk_disable_unprepare(data->codec_clk);
fail:
- if (ssi_np)
- of_node_put(ssi_np);
- if (codec_np)
- of_node_put(codec_np);
+ of_node_put(ssi_np);
+ of_node_put(codec_np);
return ret;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] ASoC: fsl: imx-sgtl5000: Delete unneeded test before of_node_put
2014-10-07 18:13 [PATCH 1/2] ASoC: fsl: imx-wm8962: Delete unneeded test before of_node_put Fabio Estevam
@ 2014-10-07 18:13 ` Fabio Estevam
2014-10-07 18:17 ` [PATCH 1/2] ASoC: fsl: imx-wm8962: " Mark Brown
2014-10-07 18:18 ` Nicolin Chen
2 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2014-10-07 18:13 UTC (permalink / raw)
To: broonie; +Cc: nicoleotsuka, Fabio Estevam, alsa-devel
of_node_put() supports NULL as its argument, so the initial test is not
necessary.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
sound/soc/fsl/imx-sgtl5000.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/sound/soc/fsl/imx-sgtl5000.c b/sound/soc/fsl/imx-sgtl5000.c
index 1cb22dd..1dab963 100644
--- a/sound/soc/fsl/imx-sgtl5000.c
+++ b/sound/soc/fsl/imx-sgtl5000.c
@@ -175,10 +175,8 @@ static int imx_sgtl5000_probe(struct platform_device *pdev)
fail:
if (data && !IS_ERR(data->codec_clk))
clk_put(data->codec_clk);
- if (ssi_np)
- of_node_put(ssi_np);
- if (codec_np)
- of_node_put(codec_np);
+ of_node_put(ssi_np);
+ of_node_put(codec_np);
return ret;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] ASoC: fsl: imx-wm8962: Delete unneeded test before of_node_put
2014-10-07 18:13 [PATCH 1/2] ASoC: fsl: imx-wm8962: Delete unneeded test before of_node_put Fabio Estevam
2014-10-07 18:13 ` [PATCH 2/2] ASoC: fsl: imx-sgtl5000: " Fabio Estevam
@ 2014-10-07 18:17 ` Mark Brown
2014-10-07 18:18 ` Nicolin Chen
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2014-10-07 18:17 UTC (permalink / raw)
To: Fabio Estevam; +Cc: nicoleotsuka, alsa-devel
[-- Attachment #1.1: Type: text/plain, Size: 173 bytes --]
On Tue, Oct 07, 2014 at 03:13:24PM -0300, Fabio Estevam wrote:
> of_node_put() supports NULL as its argument, so the initial test is not
> necessary.
Applied both, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] ASoC: fsl: imx-wm8962: Delete unneeded test before of_node_put
2014-10-07 18:13 [PATCH 1/2] ASoC: fsl: imx-wm8962: Delete unneeded test before of_node_put Fabio Estevam
2014-10-07 18:13 ` [PATCH 2/2] ASoC: fsl: imx-sgtl5000: " Fabio Estevam
2014-10-07 18:17 ` [PATCH 1/2] ASoC: fsl: imx-wm8962: " Mark Brown
@ 2014-10-07 18:18 ` Nicolin Chen
2 siblings, 0 replies; 4+ messages in thread
From: Nicolin Chen @ 2014-10-07 18:18 UTC (permalink / raw)
To: Fabio Estevam; +Cc: alsa-devel, broonie
On Tue, Oct 07, 2014 at 03:13:24PM -0300, Fabio Estevam wrote:
> of_node_put() supports NULL as its argument, so the initial test is not
> necessary.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
For both two patches:
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Thank you
Nic
> ---
> sound/soc/fsl/imx-wm8962.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/fsl/imx-wm8962.c b/sound/soc/fsl/imx-wm8962.c
> index 3a3d17c..48179ff 100644
> --- a/sound/soc/fsl/imx-wm8962.c
> +++ b/sound/soc/fsl/imx-wm8962.c
> @@ -281,10 +281,8 @@ static int imx_wm8962_probe(struct platform_device *pdev)
> clk_fail:
> clk_disable_unprepare(data->codec_clk);
> fail:
> - if (ssi_np)
> - of_node_put(ssi_np);
> - if (codec_np)
> - of_node_put(codec_np);
> + of_node_put(ssi_np);
> + of_node_put(codec_np);
>
> return ret;
> }
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-07 18:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-07 18:13 [PATCH 1/2] ASoC: fsl: imx-wm8962: Delete unneeded test before of_node_put Fabio Estevam
2014-10-07 18:13 ` [PATCH 2/2] ASoC: fsl: imx-sgtl5000: " Fabio Estevam
2014-10-07 18:17 ` [PATCH 1/2] ASoC: fsl: imx-wm8962: " Mark Brown
2014-10-07 18:18 ` Nicolin Chen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.