[PATCH] drm/crtc: Fix two typos

[PATCH] drm/crtc: Fix two typos

[Chuck Ebbert]

Fix:

  ioclt -> ioctl in comment
  wrong variable name in debug message

Signed-off-by: Chuck Ebbert <cebbert.lkml@gmail.com>
---

--- drivers/gpu/drm/drm_crtc.c.orig	2014-10-08 11:29:50.948406186 -0500
+++ drivers/gpu/drm/drm_crtc.c	2014-10-08 11:30:55.781479300 -0500
@@ -2913,7 +2913,7 @@ EXPORT_SYMBOL(drm_mode_legacy_fb_format)
  * @file_priv: drm file for the ioctl call
  *
  * Add a new FB to the specified CRTC, given a user request. This is the
- * original addfb ioclt which only supported RGB formats.
+ * original addfb ioctl which only supported RGB formats.
  *
  * Called by the user via ioctl.
  *
@@ -3033,7 +3033,7 @@ static int framebuffer_check(const struc
 	num_planes = drm_format_num_planes(r->pixel_format);
 
 	if (r->width == 0 || r->width % hsub) {
-		DRM_DEBUG_KMS("bad framebuffer width %u\n", r->height);
+		DRM_DEBUG_KMS("bad framebuffer width %u\n", r->width);
 		return -EINVAL;
 	}

Re: [PATCH] drm/crtc: Fix two typos

[Ville Syrjälä]

On Wed, Oct 08, 2014 at 11:37:20AM -0500, Chuck Ebbert wrote:
> Fix:
> 
>   ioclt -> ioctl in comment
>   wrong variable name in debug message
> 
> Signed-off-by: Chuck Ebbert <cebbert.lkml@gmail.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
> 
> --- drivers/gpu/drm/drm_crtc.c.orig	2014-10-08 11:29:50.948406186 -0500
> +++ drivers/gpu/drm/drm_crtc.c	2014-10-08 11:30:55.781479300 -0500
> @@ -2913,7 +2913,7 @@ EXPORT_SYMBOL(drm_mode_legacy_fb_format)
>   * @file_priv: drm file for the ioctl call
>   *
>   * Add a new FB to the specified CRTC, given a user request. This is the
> - * original addfb ioclt which only supported RGB formats.
> + * original addfb ioctl which only supported RGB formats.
>   *
>   * Called by the user via ioctl.
>   *
> @@ -3033,7 +3033,7 @@ static int framebuffer_check(const struc
>  	num_planes = drm_format_num_planes(r->pixel_format);
>  
>  	if (r->width == 0 || r->width % hsub) {
> -		DRM_DEBUG_KMS("bad framebuffer width %u\n", r->height);
> +		DRM_DEBUG_KMS("bad framebuffer width %u\n", r->width);
>  		return -EINVAL;
>  	}
>  
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Ville Syrjälä
Intel OTC

Re: [PATCH] drm/crtc: Fix two typos

[Daniel Vetter]

On Tue, Oct 21, 2014 at 05:01:41PM +0300, Ville Syrjälä wrote:
> On Wed, Oct 08, 2014 at 11:37:20AM -0500, Chuck Ebbert wrote:
> > Fix:
> > 
> >   ioclt -> ioctl in comment
> >   wrong variable name in debug message
> > 
> > Signed-off-by: Chuck Ebbert <cebbert.lkml@gmail.com>
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> > ---
> > 
> > --- drivers/gpu/drm/drm_crtc.c.orig	2014-10-08 11:29:50.948406186 -0500
> > +++ drivers/gpu/drm/drm_crtc.c	2014-10-08 11:30:55.781479300 -0500

This diff was manually generated and failed to apply using the usual
tooling. Please generate patches using git format-patch and send it
using git send-email, they get all the details right.

I've fixed it up while applying.
-Daniel

> > @@ -2913,7 +2913,7 @@ EXPORT_SYMBOL(drm_mode_legacy_fb_format)
> >   * @file_priv: drm file for the ioctl call
> >   *
> >   * Add a new FB to the specified CRTC, given a user request. This is the
> > - * original addfb ioclt which only supported RGB formats.
> > + * original addfb ioctl which only supported RGB formats.
> >   *
> >   * Called by the user via ioctl.
> >   *
> > @@ -3033,7 +3033,7 @@ static int framebuffer_check(const struc
> >  	num_planes = drm_format_num_planes(r->pixel_format);
> >  
> >  	if (r->width == 0 || r->width % hsub) {
> > -		DRM_DEBUG_KMS("bad framebuffer width %u\n", r->height);
> > +		DRM_DEBUG_KMS("bad framebuffer width %u\n", r->width);
> >  		return -EINVAL;
> >  	}
> >  
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
> -- 
> Ville Syrjälä
> Intel OTC
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch