From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Yu Zhao <yuzhao@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
Ingo Molnar <mingo@kernel.org>, Hugh Dickins <hughd@google.com>,
Sasha Levin <sasha.levin@oracle.com>, Bob Liu <lliubbo@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
David Rientjes <rientjes@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm: free compound page with correct order
Date: Wed, 15 Oct 2014 12:13:41 +0300 [thread overview]
Message-ID: <20141015091341.GB12538@node.dhcp.inet.fi> (raw)
In-Reply-To: <1413317800-25450-1-git-send-email-yuzhao@google.com>
On Tue, Oct 14, 2014 at 01:16:39PM -0700, Yu Zhao wrote:
> Compound page should be freed by put_page() or free_pages() with
> correct order. Not doing so with causing the tail pages leaked.
>
> The compound order can be obtained by compound_order() or use
> HPAGE_PMD_ORDER in our case. Some people would argue the latter
> is faster but I prefer the former which is more general.
>
> Signed-off-by: Yu Zhao <yuzhao@google.com>
Urghh.. Sorry about that.
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Fixes: 97ae17497e99 ("thp: implement refcounting for huge zero page")
Cc: stable@vger.kernel.org # v3.8+
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Yu Zhao <yuzhao@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
Ingo Molnar <mingo@kernel.org>, Hugh Dickins <hughd@google.com>,
Sasha Levin <sasha.levin@oracle.com>, Bob Liu <lliubbo@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
David Rientjes <rientjes@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm: free compound page with correct order
Date: Wed, 15 Oct 2014 12:13:41 +0300 [thread overview]
Message-ID: <20141015091341.GB12538@node.dhcp.inet.fi> (raw)
In-Reply-To: <1413317800-25450-1-git-send-email-yuzhao@google.com>
On Tue, Oct 14, 2014 at 01:16:39PM -0700, Yu Zhao wrote:
> Compound page should be freed by put_page() or free_pages() with
> correct order. Not doing so with causing the tail pages leaked.
>
> The compound order can be obtained by compound_order() or use
> HPAGE_PMD_ORDER in our case. Some people would argue the latter
> is faster but I prefer the former which is more general.
>
> Signed-off-by: Yu Zhao <yuzhao@google.com>
Urghh.. Sorry about that.
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Fixes: 97ae17497e99 ("thp: implement refcounting for huge zero page")
Cc: stable@vger.kernel.org # v3.8+
--
Kirill A. Shutemov
next prev parent reply other threads:[~2014-10-15 9:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 20:16 [PATCH 1/2] mm: free compound page with correct order Yu Zhao
2014-10-14 20:16 ` Yu Zhao
2014-10-14 20:16 ` [PATCH 2/2] mm: verify compound order when freeing a page Yu Zhao
2014-10-14 20:16 ` Yu Zhao
2014-10-14 20:29 ` David Cohen
2014-10-14 20:29 ` David Cohen
2014-10-14 23:08 ` Sasha Levin
2014-10-14 23:08 ` Sasha Levin
2014-10-14 23:35 ` David Cohen
2014-10-14 23:35 ` David Cohen
2014-10-15 9:14 ` Kirill A. Shutemov
2014-10-15 9:14 ` Kirill A. Shutemov
2014-10-15 9:13 ` Kirill A. Shutemov [this message]
2014-10-15 9:13 ` [PATCH 1/2] mm: free compound page with correct order Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141015091341.GB12538@node.dhcp.inet.fi \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=sasha.levin@oracle.com \
--cc=vbabka@suse.cz \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.