From: Sasha Levin <sasha.levin@oracle.com>
To: David Cohen <david.a.cohen@linux.intel.com>, Yu Zhao <yuzhao@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
Ingo Molnar <mingo@kernel.org>, Hugh Dickins <hughd@google.com>,
Bob Liu <lliubbo@gmail.com>, Johannes Weiner <hannes@cmpxchg.org>,
David Rientjes <rientjes@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: verify compound order when freeing a page
Date: Tue, 14 Oct 2014 19:08:43 -0400 [thread overview]
Message-ID: <543DACFB.2060405@oracle.com> (raw)
In-Reply-To: <20141014202955.GA2889@psi-dev26.jf.intel.com>
On 10/14/2014 04:29 PM, David Cohen wrote:
>> + VM_BUG_ON(PageTail(page));
>> > + VM_BUG_ON(PageHead(page) && compound_order(page) != order);
> It may be too severe. AFAIU we're not talking about a fatal error.
> How about VM_WARN_ON()?
VM_BUG_ON() should catch anything which is not "supposed" to happen,
and not just the severe stuff. Unlike BUG_ON, VM_BUG_ON only gets
hit with mm debugging enabled.
Thanks,
Sasha
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin <sasha.levin@oracle.com>
To: David Cohen <david.a.cohen@linux.intel.com>, Yu Zhao <yuzhao@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
Ingo Molnar <mingo@kernel.org>, Hugh Dickins <hughd@google.com>,
Bob Liu <lliubbo@gmail.com>, Johannes Weiner <hannes@cmpxchg.org>,
David Rientjes <rientjes@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: verify compound order when freeing a page
Date: Tue, 14 Oct 2014 19:08:43 -0400 [thread overview]
Message-ID: <543DACFB.2060405@oracle.com> (raw)
In-Reply-To: <20141014202955.GA2889@psi-dev26.jf.intel.com>
On 10/14/2014 04:29 PM, David Cohen wrote:
>> + VM_BUG_ON(PageTail(page));
>> > + VM_BUG_ON(PageHead(page) && compound_order(page) != order);
> It may be too severe. AFAIU we're not talking about a fatal error.
> How about VM_WARN_ON()?
VM_BUG_ON() should catch anything which is not "supposed" to happen,
and not just the severe stuff. Unlike BUG_ON, VM_BUG_ON only gets
hit with mm debugging enabled.
Thanks,
Sasha
next prev parent reply other threads:[~2014-10-14 23:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 20:16 [PATCH 1/2] mm: free compound page with correct order Yu Zhao
2014-10-14 20:16 ` Yu Zhao
2014-10-14 20:16 ` [PATCH 2/2] mm: verify compound order when freeing a page Yu Zhao
2014-10-14 20:16 ` Yu Zhao
2014-10-14 20:29 ` David Cohen
2014-10-14 20:29 ` David Cohen
2014-10-14 23:08 ` Sasha Levin [this message]
2014-10-14 23:08 ` Sasha Levin
2014-10-14 23:35 ` David Cohen
2014-10-14 23:35 ` David Cohen
2014-10-15 9:14 ` Kirill A. Shutemov
2014-10-15 9:14 ` Kirill A. Shutemov
2014-10-15 9:13 ` [PATCH 1/2] mm: free compound page with correct order Kirill A. Shutemov
2014-10-15 9:13 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543DACFB.2060405@oracle.com \
--to=sasha.levin@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david.a.cohen@linux.intel.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.