From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, "Anup Patel" <anup.patel@linaro.org>,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
"Arve Hjønnevåg" <arve@android.com>,
"John Stultz" <john.stultz@linaro.org>,
"Rebecca Schultz Zavin" <rebecca@android.com>,
"Santosh Shilimkar" <santosh.shilimkar@ti.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christoffer Dall" <christoffer.dall@linaro.org>
Subject: Re: [PATCH] staging: android: binder: move to the "real" part of the kernel
Date: Mon, 20 Oct 2014 06:05:47 +0800 [thread overview]
Message-ID: <20141019220547.GC3780@kroah.com> (raw)
In-Reply-To: <20141017092601.GH23154@mwanda>
On Fri, Oct 17, 2014 at 12:26:01PM +0300, Dan Carpenter wrote:
> The code isn't very beautiful and there are lots of details wrong like
> the error codes.
Really, what is wrong with the existing error code usages?
> Al had some critical things to say about it but it looks like most of
> those issues have been fixed.
All of the ones that can be fixed, have, as far as I know.
We are stuck with some that we can't fix, which is ok as it is safe in
the Android user model.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
linux-api@vger.kernel.org, "Anup Patel" <anup.patel@linaro.org>,
"Arve Hjønnevåg" <arve@android.com>,
"John Stultz" <john.stultz@linaro.org>,
"Rebecca Schultz Zavin" <rebecca@android.com>,
"Santosh Shilimkar" <santosh.shilimkar@ti.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christoffer Dall" <christoffer.dall@linaro.org>
Subject: Re: [PATCH] staging: android: binder: move to the "real" part of the kernel
Date: Mon, 20 Oct 2014 06:05:47 +0800 [thread overview]
Message-ID: <20141019220547.GC3780@kroah.com> (raw)
In-Reply-To: <20141017092601.GH23154@mwanda>
On Fri, Oct 17, 2014 at 12:26:01PM +0300, Dan Carpenter wrote:
> The code isn't very beautiful and there are lots of details wrong like
> the error codes.
Really, what is wrong with the existing error code usages?
> Al had some critical things to say about it but it looks like most of
> those issues have been fixed.
All of the ones that can be fixed, have, as far as I know.
We are stuck with some that we can't fix, which is ok as it is safe in
the Android user model.
thanks,
greg k-h
next prev parent reply other threads:[~2014-10-19 22:05 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 12:47 [PATCH] staging: android: binder: move to the "real" part of the kernel Greg Kroah-Hartman
2014-10-16 12:47 ` Greg Kroah-Hartman
[not found] ` <20141016124741.GA3832-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2014-10-16 14:18 ` Michael Kerrisk (man-pages)
2014-10-16 14:18 ` Michael Kerrisk (man-pages)
2014-10-16 23:14 ` Greg Kroah-Hartman
2014-10-16 23:14 ` Greg Kroah-Hartman
2014-10-20 12:45 ` Dan Carpenter
2014-10-20 12:45 ` Dan Carpenter
2014-10-21 10:01 ` Pavel Machek
2014-10-21 10:01 ` Pavel Machek
2014-10-20 17:06 ` Arnd Bergmann
2014-10-20 17:06 ` Arnd Bergmann
2014-10-16 17:09 ` John Stultz
[not found] ` <CALAqxLU05D8qQA47E77PiuuN7eVt66WEq1qn+PqdE-tpEUzFpw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-16 23:12 ` Greg Kroah-Hartman
2014-10-16 23:12 ` Greg Kroah-Hartman
[not found] ` <20141016231221.GA13592-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2014-10-17 3:25 ` John Stultz
2014-10-17 3:25 ` John Stultz
2014-10-17 8:01 ` Greg Kroah-Hartman
2014-10-17 8:01 ` Greg Kroah-Hartman
2014-10-21 10:36 ` Pavel Machek
2014-10-21 10:36 ` Pavel Machek
2014-10-21 14:12 ` Arnd Bergmann
2014-10-21 14:12 ` Arnd Bergmann
2014-10-21 20:05 ` Pavel Machek
2014-10-21 20:05 ` Pavel Machek
2014-10-18 21:36 ` One Thousand Gnomes
2014-10-19 22:01 ` Greg Kroah-Hartman
2014-10-19 22:01 ` Greg Kroah-Hartman
2014-10-17 9:26 ` Dan Carpenter
2014-10-17 9:26 ` Dan Carpenter
2014-10-19 22:05 ` Greg Kroah-Hartman [this message]
2014-10-19 22:05 ` Greg Kroah-Hartman
2014-10-20 9:20 ` Dan Carpenter
2014-10-20 23:32 ` Arve Hjønnevåg
2014-10-20 23:32 ` Arve Hjønnevåg
[not found] ` <CAMP5Xgcm-sxd3rf3VA1ZO44bUT1+u_QG1AAdjzK39q0ynfsZGQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-22 3:10 ` Rom Lemarchand
2014-10-22 3:10 ` Rom Lemarchand
2014-10-22 3:16 ` Joe Perches
2014-10-24 5:00 ` Dan Carpenter
2014-10-24 5:00 ` Dan Carpenter
2014-10-17 9:43 ` Christoph Hellwig
2014-10-17 9:43 ` Christoph Hellwig
2014-10-19 22:04 ` Greg Kroah-Hartman
[not found] ` <20141019220450.GB3780-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2014-10-21 10:46 ` Christoph Hellwig
2014-10-21 10:46 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141019220547.GC3780@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=anup.patel@linaro.org \
--cc=arve@android.com \
--cc=christoffer.dall@linaro.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=john.stultz@linaro.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rebecca@android.com \
--cc=santosh.shilimkar@ti.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.