All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, "Anup Patel" <anup.patel@linaro.org>,
	"Linux API" <linux-api@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>,
	"Arve Hjønnevåg" <arve@android.com>,
	"John Stultz" <john.stultz@linaro.org>,
	"Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>,
	"Rebecca Schultz Zavin" <rebecca@android.com>,
	"Santosh Shilimkar" <santosh.shilimkar@ti.com>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Christoffer Dall" <christoffer.dall@linaro.org>
Subject: Re: [PATCH] staging: android: binder: move to the "real" part of the kernel
Date: Tue, 21 Oct 2014 12:01:21 +0200	[thread overview]
Message-ID: <20141021100121.GA23161@amd> (raw)
In-Reply-To: <20141016231457.GB13592@kroah.com>

On Fri 2014-10-17 01:14:57, Greg Kroah-Hartman wrote:
> On Thu, Oct 16, 2014 at 04:18:02PM +0200, Michael Kerrisk (man-pages) wrote:
> > On Thu, Oct 16, 2014 at 2:47 PM, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > >
> > > The Android binder code has been "stable" for many years now.  No matter
> > > what comes in the future, we are going to have to support this API, so
> > > might as well move it to the "real" part of the kernel as there's no
> > > real work that needs to be done to the existing code.
> > 
> > Where does one find the canonical documentation of the user-space API?
> 
> There really is only one "canonical" thing, and that is in the libbinder
> code in the Android userspace repository.  And it's not really
> "documentation" so much as, "a C file that interacts with the ioctls in
> the binder kernel code" :(
> 
> Think of this as just a random character driver with some funny ioctls
> that will never get really documented as there is only one user of it.

This is not random character driver, it is communication mechanism. It
should _not_ be a character driver.

And it should really be documented.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>,
	lkml <linux-kernel@vger.kernel.org>,
	devel@driverdev.osuosl.org,
	"Linux API" <linux-api@vger.kernel.org>,
	"Santosh Shilimkar" <santosh.shilimkar@ti.com>,
	"John Stultz" <john.stultz@linaro.org>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Rebecca Schultz Zavin" <rebecca@android.com>,
	"Christoffer Dall" <christoffer.dall@linaro.org>,
	"Anup Patel" <anup.patel@linaro.org>
Subject: Re: [PATCH] staging: android: binder: move to the "real" part of the kernel
Date: Tue, 21 Oct 2014 12:01:21 +0200	[thread overview]
Message-ID: <20141021100121.GA23161@amd> (raw)
In-Reply-To: <20141016231457.GB13592@kroah.com>

On Fri 2014-10-17 01:14:57, Greg Kroah-Hartman wrote:
> On Thu, Oct 16, 2014 at 04:18:02PM +0200, Michael Kerrisk (man-pages) wrote:
> > On Thu, Oct 16, 2014 at 2:47 PM, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > >
> > > The Android binder code has been "stable" for many years now.  No matter
> > > what comes in the future, we are going to have to support this API, so
> > > might as well move it to the "real" part of the kernel as there's no
> > > real work that needs to be done to the existing code.
> > 
> > Where does one find the canonical documentation of the user-space API?
> 
> There really is only one "canonical" thing, and that is in the libbinder
> code in the Android userspace repository.  And it's not really
> "documentation" so much as, "a C file that interacts with the ioctls in
> the binder kernel code" :(
> 
> Think of this as just a random character driver with some funny ioctls
> that will never get really documented as there is only one user of it.

This is not random character driver, it is communication mechanism. It
should _not_ be a character driver.

And it should really be documented.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2014-10-21 10:01 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-16 12:47 [PATCH] staging: android: binder: move to the "real" part of the kernel Greg Kroah-Hartman
2014-10-16 12:47 ` Greg Kroah-Hartman
     [not found] ` <20141016124741.GA3832-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2014-10-16 14:18   ` Michael Kerrisk (man-pages)
2014-10-16 14:18     ` Michael Kerrisk (man-pages)
2014-10-16 23:14     ` Greg Kroah-Hartman
2014-10-16 23:14       ` Greg Kroah-Hartman
2014-10-20 12:45       ` Dan Carpenter
2014-10-20 12:45         ` Dan Carpenter
2014-10-21 10:01       ` Pavel Machek [this message]
2014-10-21 10:01         ` Pavel Machek
2014-10-20 17:06   ` Arnd Bergmann
2014-10-20 17:06     ` Arnd Bergmann
2014-10-16 17:09 ` John Stultz
     [not found]   ` <CALAqxLU05D8qQA47E77PiuuN7eVt66WEq1qn+PqdE-tpEUzFpw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-16 23:12     ` Greg Kroah-Hartman
2014-10-16 23:12       ` Greg Kroah-Hartman
     [not found]       ` <20141016231221.GA13592-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2014-10-17  3:25         ` John Stultz
2014-10-17  3:25           ` John Stultz
2014-10-17  8:01           ` Greg Kroah-Hartman
2014-10-17  8:01             ` Greg Kroah-Hartman
2014-10-21 10:36         ` Pavel Machek
2014-10-21 10:36           ` Pavel Machek
2014-10-21 14:12           ` Arnd Bergmann
2014-10-21 14:12             ` Arnd Bergmann
2014-10-21 20:05             ` Pavel Machek
2014-10-21 20:05               ` Pavel Machek
2014-10-18 21:36       ` One Thousand Gnomes
2014-10-19 22:01         ` Greg Kroah-Hartman
2014-10-19 22:01           ` Greg Kroah-Hartman
2014-10-17  9:26 ` Dan Carpenter
2014-10-17  9:26   ` Dan Carpenter
2014-10-19 22:05   ` Greg Kroah-Hartman
2014-10-19 22:05     ` Greg Kroah-Hartman
2014-10-20  9:20     ` Dan Carpenter
2014-10-20 23:32       ` Arve Hjønnevåg
2014-10-20 23:32         ` Arve Hjønnevåg
     [not found]         ` <CAMP5Xgcm-sxd3rf3VA1ZO44bUT1+u_QG1AAdjzK39q0ynfsZGQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-22  3:10           ` Rom Lemarchand
2014-10-22  3:10             ` Rom Lemarchand
2014-10-22  3:16             ` Joe Perches
2014-10-24  5:00             ` Dan Carpenter
2014-10-24  5:00               ` Dan Carpenter
2014-10-17  9:43 ` Christoph Hellwig
2014-10-17  9:43   ` Christoph Hellwig
2014-10-19 22:04   ` Greg Kroah-Hartman
     [not found]     ` <20141019220450.GB3780-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2014-10-21 10:46       ` Christoph Hellwig
2014-10-21 10:46         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141021100121.GA23161@amd \
    --to=pavel@ucw.cz \
    --cc=anup.patel@linaro.org \
    --cc=arve@android.com \
    --cc=christoffer.dall@linaro.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.stultz@linaro.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=rebecca@android.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.