[PATCH] README: remove requirement for udev

[PATCH] README: remove requirement for udev

[Olaf Hering]

There is no requirement for udev during package build. It may be
required at runtime even with libxl with run_hotplug_scripts=yes
in xl.conf.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
---
 README | 1 -
 1 file changed, 1 deletion(-)

diff --git a/README b/README
index a746259..412607a 100644
--- a/README
+++ b/README
@@ -57,7 +57,6 @@ provided by your OS distributor:
     * pkg-config
     * bridge-utils package (/sbin/brctl)
     * iproute package (/sbin/ip)
-    * udev
     * GNU bison and GNU flex
     * GNU gettext
     * 16-bit x86 assembler, loader and compiler (dev86 rpm or bin86 & bcc debs)

Re: [PATCH] README: remove requirement for udev

[Wei Liu]

On Tue, Oct 21, 2014 at 03:30:44PM +0200, Olaf Hering wrote:
> There is no requirement for udev during package build. It may be
> required at runtime even with libxl with run_hotplug_scripts=yes
> in xl.conf.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> ---
>  README | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/README b/README
> index a746259..412607a 100644
> --- a/README
> +++ b/README
> @@ -57,7 +57,6 @@ provided by your OS distributor:
>      * pkg-config
>      * bridge-utils package (/sbin/brctl)
>      * iproute package (/sbin/ip)

These two don't look like requirement for package build either.

> -    * udev
>      * GNU bison and GNU flex
>      * GNU gettext
>      * 16-bit x86 assembler, loader and compiler (dev86 rpm or bin86 & bcc debs)
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

Re: [PATCH] README: remove requirement for udev

[Olaf Hering]

On Tue, Oct 21, Wei Liu wrote:

> On Tue, Oct 21, 2014 at 03:30:44PM +0200, Olaf Hering wrote:
> > There is no requirement for udev during package build. It may be
> > required at runtime even with libxl with run_hotplug_scripts=yes
> > in xl.conf.
> > 
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > Cc: Ian Campbell <ian.campbell@citrix.com>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > ---
> >  README | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/README b/README
> > index a746259..412607a 100644
> > --- a/README
> > +++ b/README
> > @@ -57,7 +57,6 @@ provided by your OS distributor:
> >      * pkg-config
> >      * bridge-utils package (/sbin/brctl)
> >      * iproute package (/sbin/ip)
> 
> These two don't look like requirement for package build either.

The ones below neither, but I left them alone because last time this
came up the conclusion was that its fine to have a mix or run and
compile time requirements.

If its now the time to clean this up I can spent some time and move this
to the INSTALL file, as suggested in another thread.

> > -    * udev
> >      * GNU bison and GNU flex
> >      * GNU gettext
> >      * 16-bit x86 assembler, loader and compiler (dev86 rpm or bin86 & bcc debs)


Olaf

Re: [PATCH] README: remove requirement for udev

[Andrew Cooper]

On 21/10/14 15:52, Olaf Hering wrote:
> On Tue, Oct 21, Wei Liu wrote:
>
>> On Tue, Oct 21, 2014 at 03:30:44PM +0200, Olaf Hering wrote:
>>> There is no requirement for udev during package build. It may be
>>> required at runtime even with libxl with run_hotplug_scripts=yes
>>> in xl.conf.
>>>
>>> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>>> Cc: Ian Campbell <ian.campbell@citrix.com>
>>> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
>>> ---
>>>  README | 1 -
>>>  1 file changed, 1 deletion(-)
>>>
>>> diff --git a/README b/README
>>> index a746259..412607a 100644
>>> --- a/README
>>> +++ b/README
>>> @@ -57,7 +57,6 @@ provided by your OS distributor:
>>>      * pkg-config
>>>      * bridge-utils package (/sbin/brctl)
>>>      * iproute package (/sbin/ip)
>> These two don't look like requirement for package build either.
> The ones below neither, but I left them alone because last time this
> came up the conclusion was that its fine to have a mix or run and
> compile time requirements.
>
> If its now the time to clean this up I can spent some time and move this
> to the INSTALL file, as suggested in another thread.

GNU bison and GNU flex are build requirements.

despite the targets being committed locally, git checkout will touch the
source files after the generated targets, at which point make(1) will
insist in rebuilding them.

~Andrew

Re: [PATCH] README: remove requirement for udev

[Wei Liu]

On Tue, Oct 21, 2014 at 04:52:58PM +0200, Olaf Hering wrote:
> On Tue, Oct 21, Wei Liu wrote:
> 
> > On Tue, Oct 21, 2014 at 03:30:44PM +0200, Olaf Hering wrote:
> > > There is no requirement for udev during package build. It may be
> > > required at runtime even with libxl with run_hotplug_scripts=yes
> > > in xl.conf.
> > > 
> > > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > > Cc: Ian Campbell <ian.campbell@citrix.com>
> > > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > > ---
> > >  README | 1 -
> > >  1 file changed, 1 deletion(-)
> > > 
> > > diff --git a/README b/README
> > > index a746259..412607a 100644
> > > --- a/README
> > > +++ b/README
> > > @@ -57,7 +57,6 @@ provided by your OS distributor:
> > >      * pkg-config
> > >      * bridge-utils package (/sbin/brctl)
> > >      * iproute package (/sbin/ip)
> > 
> > These two don't look like requirement for package build either.
> 
> The ones below neither, but I left them alone because last time this
> came up the conclusion was that its fine to have a mix or run and
> compile time requirements.
> 

I don't have strong opinion on this. If you've come to conclusion in
other threads please go ahead. The ones I mentioned can always be dealt
with in the future.

> If its now the time to clean this up I can spent some time and move this
> to the INSTALL file, as suggested in another thread.
> 
> > > -    * udev
> > >      * GNU bison and GNU flex
> > >      * GNU gettext
> > >      * 16-bit x86 assembler, loader and compiler (dev86 rpm or bin86 & bcc debs)
> 
> 
> Olaf

Re: [PATCH] README: remove requirement for udev

[Ian Campbell]

On Tue, 2014-10-21 at 15:30 +0200, Olaf Hering wrote:
> There is no requirement for udev during package build. It may be
> required at runtime even with libxl with run_hotplug_scripts=yes
> in xl.conf.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
Acked-by: Ian Campbell <ian.campbell@citrix.com>

Re: [PATCH] README: remove requirement for udev

[Ian Campbell]

On Wed, 2014-10-22 at 12:15 +0100, Ian Campbell wrote:
> On Tue, 2014-10-21 at 15:30 +0200, Olaf Hering wrote:
> > There is no requirement for udev during package build. It may be
> > required at runtime even with libxl with run_hotplug_scripts=yes
> > in xl.conf.
> > 
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>

There were some comments but none of them seemed to invalidate the basic
premise of this patch so I've applied. Any other cleanups can be done
separately.