From: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v2 3/4] ARM: dts: sun5i: Add lradc node
Date: Tue, 21 Oct 2014 09:21:59 -0700 [thread overview]
Message-ID: <20141021162159.GC8609@dtor-ws> (raw)
In-Reply-To: <1413879890-7254-4-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Hi Hans,
On Tue, Oct 21, 2014 at 10:24:49AM +0200, Hans de Goede wrote:
> + button@98 {
> + label = "Home";
> + linux,code = <KEY_HOME>;
I do not think you really want KEY_HOME (go to the beginning of the
line) here, KEY_HOMEPAGE or similar would suit better.
> + channel = <0>;
> + voltage = <987387>;
> + };
> + };
Thanks.
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/4] ARM: dts: sun5i: Add lradc node
Date: Tue, 21 Oct 2014 09:21:59 -0700 [thread overview]
Message-ID: <20141021162159.GC8609@dtor-ws> (raw)
In-Reply-To: <1413879890-7254-4-git-send-email-hdegoede@redhat.com>
Hi Hans,
On Tue, Oct 21, 2014 at 10:24:49AM +0200, Hans de Goede wrote:
> + button at 98 {
> + label = "Home";
> + linux,code = <KEY_HOME>;
I do not think you really want KEY_HOME (go to the beginning of the
line) here, KEY_HOMEPAGE or similar would suit better.
> + channel = <0>;
> + voltage = <987387>;
> + };
> + };
Thanks.
--
Dmitry
next prev parent reply other threads:[~2014-10-21 16:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 8:24 [PATCH v2 0/4] input: Add new sun4i-lradc-keys driver Hans de Goede
2014-10-21 8:24 ` Hans de Goede
[not found] ` <1413879890-7254-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-10-21 8:24 ` [PATCH v2 1/4] " Hans de Goede
2014-10-21 8:24 ` Hans de Goede
[not found] ` <1413879890-7254-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-10-21 17:04 ` Maxime Ripard
2014-10-21 17:04 ` Maxime Ripard
2014-10-22 10:45 ` Hans de Goede
2014-10-22 10:45 ` Hans de Goede
2014-10-21 8:24 ` [PATCH v2 2/4] ARM: dts: sun4i: Add lradc node Hans de Goede
2014-10-21 8:24 ` Hans de Goede
2014-10-21 8:24 ` [PATCH v2 3/4] ARM: dts: sun5i: " Hans de Goede
2014-10-21 8:24 ` Hans de Goede
[not found] ` <1413879890-7254-4-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-10-21 16:21 ` Dmitry Torokhov [this message]
2014-10-21 16:21 ` Dmitry Torokhov
2014-10-21 20:29 ` Hans de Goede
2014-10-21 20:29 ` Hans de Goede
[not found] ` <5446C23F.3040604-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-10-22 10:42 ` Hans de Goede
2014-10-22 10:42 ` [linux-sunxi] " Hans de Goede
2014-10-21 8:24 ` [PATCH v2 4/4] ARM: dts: sun7i: " Hans de Goede
2014-10-21 8:24 ` Hans de Goede
[not found] ` <1413879890-7254-5-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-10-22 8:38 ` Maxime Ripard
2014-10-22 8:38 ` Maxime Ripard
2014-10-22 8:46 ` Hans de Goede
2014-10-22 8:46 ` [linux-sunxi] " Hans de Goede
-- strict thread matches above, loose matches on Subject: below --
2014-01-02 9:58 [PATCH v2 0/4] input: Add new sun4i-lradc-keys driver Hans de Goede
[not found] ` <1388656707-16181-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-01-02 9:58 ` [PATCH v2 3/4] ARM: dts: sun5i: Add lradc node Hans de Goede
2014-01-02 9:58 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141021162159.GC8609@dtor-ws \
--to=dmitry.torokhov-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.