From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Dmitry Torokhov
<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: Re: [PATCH v2 4/4] ARM: dts: sun7i: Add lradc node
Date: Wed, 22 Oct 2014 10:46:27 +0200 [thread overview]
Message-ID: <54476EE3.6060401@redhat.com> (raw)
In-Reply-To: <20141022083802.GE7893@lukather>
Hi,
On 10/22/2014 10:38 AM, Maxime Ripard wrote:
> Hi Hans,
>
> On Tue, Oct 21, 2014 at 10:24:50AM +0200, Hans de Goede wrote:
>> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>> ---
>> arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 48 +++++++++++++++++++++++++
>> arch/arm/boot/dts/sun7i-a20.dtsi | 7 ++++
>> 2 files changed, 55 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts
>> index 9d669cdf..85e7194 100644
>> --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts
>> +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts
>> @@ -14,6 +14,7 @@
>> /dts-v1/;
>> /include/ "sun7i-a20.dtsi"
>> /include/ "sunxi-common-regulators.dtsi"
>> +#include <dt-bindings/input/input.h>
>
> I'm just wondering... Weren't we supposed to switch all includes to
> the preprocessor syntax in such a case?
I've just checked other in tree users of dt-bindings/input/input.h and you
seem to be right, I will fix this for the next version.
Regards,
Hans
WARNING: multiple messages have this Message-ID (diff)
From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] Re: [PATCH v2 4/4] ARM: dts: sun7i: Add lradc node
Date: Wed, 22 Oct 2014 10:46:27 +0200 [thread overview]
Message-ID: <54476EE3.6060401@redhat.com> (raw)
In-Reply-To: <20141022083802.GE7893@lukather>
Hi,
On 10/22/2014 10:38 AM, Maxime Ripard wrote:
> Hi Hans,
>
> On Tue, Oct 21, 2014 at 10:24:50AM +0200, Hans de Goede wrote:
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 48 +++++++++++++++++++++++++
>> arch/arm/boot/dts/sun7i-a20.dtsi | 7 ++++
>> 2 files changed, 55 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts
>> index 9d669cdf..85e7194 100644
>> --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts
>> +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts
>> @@ -14,6 +14,7 @@
>> /dts-v1/;
>> /include/ "sun7i-a20.dtsi"
>> /include/ "sunxi-common-regulators.dtsi"
>> +#include <dt-bindings/input/input.h>
>
> I'm just wondering... Weren't we supposed to switch all includes to
> the preprocessor syntax in such a case?
I've just checked other in tree users of dt-bindings/input/input.h and you
seem to be right, I will fix this for the next version.
Regards,
Hans
next prev parent reply other threads:[~2014-10-22 8:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 8:24 [PATCH v2 0/4] input: Add new sun4i-lradc-keys driver Hans de Goede
2014-10-21 8:24 ` Hans de Goede
[not found] ` <1413879890-7254-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-10-21 8:24 ` [PATCH v2 1/4] " Hans de Goede
2014-10-21 8:24 ` Hans de Goede
[not found] ` <1413879890-7254-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-10-21 17:04 ` Maxime Ripard
2014-10-21 17:04 ` Maxime Ripard
2014-10-22 10:45 ` Hans de Goede
2014-10-22 10:45 ` Hans de Goede
2014-10-21 8:24 ` [PATCH v2 2/4] ARM: dts: sun4i: Add lradc node Hans de Goede
2014-10-21 8:24 ` Hans de Goede
2014-10-21 8:24 ` [PATCH v2 3/4] ARM: dts: sun5i: " Hans de Goede
2014-10-21 8:24 ` Hans de Goede
[not found] ` <1413879890-7254-4-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-10-21 16:21 ` Dmitry Torokhov
2014-10-21 16:21 ` Dmitry Torokhov
2014-10-21 20:29 ` Hans de Goede
2014-10-21 20:29 ` Hans de Goede
[not found] ` <5446C23F.3040604-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-10-22 10:42 ` Hans de Goede
2014-10-22 10:42 ` [linux-sunxi] " Hans de Goede
2014-10-21 8:24 ` [PATCH v2 4/4] ARM: dts: sun7i: " Hans de Goede
2014-10-21 8:24 ` Hans de Goede
[not found] ` <1413879890-7254-5-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-10-22 8:38 ` Maxime Ripard
2014-10-22 8:38 ` Maxime Ripard
2014-10-22 8:46 ` Hans de Goede [this message]
2014-10-22 8:46 ` [linux-sunxi] " Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54476EE3.6060401@redhat.com \
--to=hdegoede-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.