From: Marek Vasut <marex@denx.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: monstr@monstr.eu, Geert Uytterhoeven <geert+renesas@glider.be>,
Michal Simek <michal.simek@xilinx.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Huang Shijie <b32955@freescale.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
Harini Katakam <harini.katakam@xilinx.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: spi-nor: Add support for SST spi flash
Date: Wed, 22 Oct 2014 00:08:51 +0200 [thread overview]
Message-ID: <201410220008.51848.marex@denx.de> (raw)
In-Reply-To: <CACna6rzp1anqhLc-CfYmD4QA4ghYMWWjXmO9DnHHo824QobaMQ@mail.gmail.com>
On Tuesday, October 21, 2014 at 06:43:50 PM, Rafał Miłecki wrote:
> On 21 October 2014 13:37, Michal Simek <michal.simek@xilinx.com> wrote:
> > From: Harini Katakam <harini.katakam@xilinx.com>
> >
> > Add sst25wf080 to the spi-nor device id table.
>
> I guess commit message could include some details. We already support
> plenty of SST flashes without this patch, don't we?
This change is so trivial that saying "we're adding this new flash chip ID to
the ID table", which is what Michal did, is completely sufficient in my opinion.
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex@denx.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Michal Simek <michal.simek@xilinx.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
monstr@monstr.eu, Harini Katakam <harini.katakam@xilinx.com>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Huang Shijie <b32955@freescale.com>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH] mtd: spi-nor: Add support for SST spi flash
Date: Wed, 22 Oct 2014 00:08:51 +0200 [thread overview]
Message-ID: <201410220008.51848.marex@denx.de> (raw)
In-Reply-To: <CACna6rzp1anqhLc-CfYmD4QA4ghYMWWjXmO9DnHHo824QobaMQ@mail.gmail.com>
On Tuesday, October 21, 2014 at 06:43:50 PM, Rafał Miłecki wrote:
> On 21 October 2014 13:37, Michal Simek <michal.simek@xilinx.com> wrote:
> > From: Harini Katakam <harini.katakam@xilinx.com>
> >
> > Add sst25wf080 to the spi-nor device id table.
>
> I guess commit message could include some details. We already support
> plenty of SST flashes without this patch, don't we?
This change is so trivial that saying "we're adding this new flash chip ID to
the ID table", which is what Michal did, is completely sufficient in my opinion.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-10-21 22:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 11:37 [PATCH] mtd: spi-nor: Add support for SST spi flash Michal Simek
2014-10-21 11:37 ` Michal Simek
2014-10-21 11:57 ` Marek Vasut
2014-10-21 11:57 ` Marek Vasut
2014-10-21 16:43 ` Rafał Miłecki
2014-10-21 16:43 ` Rafał Miłecki
2014-10-21 22:08 ` Marek Vasut [this message]
2014-10-21 22:08 ` Marek Vasut
2014-11-05 21:06 ` Brian Norris
2014-11-05 21:06 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201410220008.51848.marex@denx.de \
--to=marex@denx.de \
--cc=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=geert+renesas@glider.be \
--cc=harini.katakam@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=peter.crosthwaite@xilinx.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.