* [PATCH 0/3] tools: systemd patches
@ 2014-10-21 9:56 Wei Liu
2014-10-21 9:56 ` [PATCH 1/3] systemd: fix clean target in Makefile Wei Liu
` (2 more replies)
0 siblings, 3 replies; 13+ messages in thread
From: Wei Liu @ 2014-10-21 9:56 UTC (permalink / raw)
To: xen-devel; +Cc: olaf, Wei Liu, ian.campbell
This small series tries to fix some problems in systemd stuffs.
The first patch was based on one of Olaf's email on fixing the clean target.
Patch 2 and 3 add a missing service to run xen-init-dom0. The basic thing is
that we need to run xen-init-dom0 to generate JSON config stub for Dom0 before
xendomains. xen-init-dom0 only needs to run once.
Wei.
Wei Liu (3):
systemd: fix clean target in Makefile
systemd: add xen-init-dom0 service
systemd: xendomains now depends on xen-init-dom0
tools/configure.ac | 1 +
tools/hotplug/Linux/systemd/Makefile | 2 ++
tools/hotplug/Linux/systemd/xen-init-dom0.service.in | 14 ++++++++++++++
tools/hotplug/Linux/systemd/xendomains.service.in | 2 +-
tools/hotplug/Linux/systemd/xenstored.service.in | 2 --
5 files changed, 18 insertions(+), 3 deletions(-)
create mode 100644 tools/hotplug/Linux/systemd/xen-init-dom0.service.in
--
1.7.10.4
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/3] systemd: fix clean target in Makefile
2014-10-21 9:56 [PATCH 0/3] tools: systemd patches Wei Liu
@ 2014-10-21 9:56 ` Wei Liu
2014-10-22 11:22 ` Ian Campbell
2014-10-21 9:56 ` [PATCH 2/3] systemd: add xen-init-dom0 service Wei Liu
2014-10-21 9:56 ` [PATCH 3/3] systemd: xendomains now depends on xen-init-dom0 Wei Liu
2 siblings, 1 reply; 13+ messages in thread
From: Wei Liu @ 2014-10-21 9:56 UTC (permalink / raw)
To: xen-devel; +Cc: olaf, Wei Liu, ian.campbell
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
tools/hotplug/Linux/systemd/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/hotplug/Linux/systemd/Makefile b/tools/hotplug/Linux/systemd/Makefile
index 9c58b33..0c40a73 100644
--- a/tools/hotplug/Linux/systemd/Makefile
+++ b/tools/hotplug/Linux/systemd/Makefile
@@ -25,6 +25,7 @@ all: $(ALL_XEN_SYSTEMD)
.PHONY: clean
clean:
+ rm -f $(XEN_SYSTEMD_MODULES)
.PHONY: install
install: $(ALL_XEN_SYSTEMD)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/3] systemd: add xen-init-dom0 service
2014-10-21 9:56 [PATCH 0/3] tools: systemd patches Wei Liu
2014-10-21 9:56 ` [PATCH 1/3] systemd: fix clean target in Makefile Wei Liu
@ 2014-10-21 9:56 ` Wei Liu
2014-10-22 11:23 ` Ian Campbell
2014-10-23 16:05 ` Anthony PERARD
2014-10-21 9:56 ` [PATCH 3/3] systemd: xendomains now depends on xen-init-dom0 Wei Liu
2 siblings, 2 replies; 13+ messages in thread
From: Wei Liu @ 2014-10-21 9:56 UTC (permalink / raw)
To: xen-devel; +Cc: olaf, Wei Liu, ian.campbell
Also prevent xenstored.service from writing Dom0 nodes The
initialisation is now done with xen-init-dom0.
Please rerun autoconf after applying this patch.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
tools/configure.ac | 1 +
tools/hotplug/Linux/systemd/Makefile | 1 +
tools/hotplug/Linux/systemd/xen-init-dom0.service.in | 14 ++++++++++++++
tools/hotplug/Linux/systemd/xenstored.service.in | 2 --
4 files changed, 16 insertions(+), 2 deletions(-)
create mode 100644 tools/hotplug/Linux/systemd/xen-init-dom0.service.in
diff --git a/tools/configure.ac b/tools/configure.ac
index f584798..62ccf47 100644
--- a/tools/configure.ac
+++ b/tools/configure.ac
@@ -15,6 +15,7 @@ hotplug/Linux/init.d/xendomains
hotplug/Linux/systemd/proc-xen.mount
hotplug/Linux/systemd/var-lib-xenstored.mount
hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service
+hotplug/Linux/systemd/xen-init-dom0.service
hotplug/Linux/systemd/xen-watchdog.service
hotplug/Linux/systemd/xenconsoled.service
hotplug/Linux/systemd/xendomains.service
diff --git a/tools/hotplug/Linux/systemd/Makefile b/tools/hotplug/Linux/systemd/Makefile
index 0c40a73..51c10fe 100644
--- a/tools/hotplug/Linux/systemd/Makefile
+++ b/tools/hotplug/Linux/systemd/Makefile
@@ -14,6 +14,7 @@ XEN_SYSTEMD_SERVICE += xenconsoled.service
XEN_SYSTEMD_SERVICE += xen-qemu-dom0-disk-backend.service
XEN_SYSTEMD_SERVICE += xendomains.service
XEN_SYSTEMD_SERVICE += xen-watchdog.service
+XEN_SYSTEMD_SERVICE += xen-init-dom0.service
ALL_XEN_SYSTEMD = $(XEN_SYSTEMD_MODULES) \
$(XEN_SYSTEMD_MOUNT) \
diff --git a/tools/hotplug/Linux/systemd/xen-init-dom0.service.in b/tools/hotplug/Linux/systemd/xen-init-dom0.service.in
new file mode 100644
index 0000000..e947760
--- /dev/null
+++ b/tools/hotplug/Linux/systemd/xen-init-dom0.service.in
@@ -0,0 +1,14 @@
+[Unit]
+Description=xen-init-dom0, initialise Dom0 configuration (xenstore nodes, JSON configuration stub)
+Requires=xenstored.socket
+After=xenstored.service
+ConditionPathExists=/proc/xen/capabilities
+
+[Service]
+Type=oneshot
+RemainAfterExit=true
+ExecStartPre=/bin/grep -q control_d /proc/xen/capabilities
+ExecStart=@LIBEXEC_BIN@/xen-init-dom0
+
+[Install]
+WantedBy=multi-user.target
diff --git a/tools/hotplug/Linux/systemd/xenstored.service.in b/tools/hotplug/Linux/systemd/xenstored.service.in
index 013e69e..e3bf837 100644
--- a/tools/hotplug/Linux/systemd/xenstored.service.in
+++ b/tools/hotplug/Linux/systemd/xenstored.service.in
@@ -17,8 +17,6 @@ ExecStartPre=/bin/grep -q control_d /proc/xen/capabilities
ExecStartPre=-/bin/rm -f @XEN_LIB_STORED@/tdb*
ExecStartPre=/bin/mkdir -p @XEN_RUN_DIR@
ExecStart=/bin/sh -c "exec $XENSTORED --no-fork $XENSTORED_ARGS"
-ExecStartPost=-@bindir@/xenstore-write "/local/domain/0/name" "Domain-0"
-ExecStartPost=-@bindir@/xenstore-write "/local/domain/0/domid" 0
[Install]
WantedBy=multi-user.target
--
1.7.10.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 3/3] systemd: xendomains now depends on xen-init-dom0
2014-10-21 9:56 [PATCH 0/3] tools: systemd patches Wei Liu
2014-10-21 9:56 ` [PATCH 1/3] systemd: fix clean target in Makefile Wei Liu
2014-10-21 9:56 ` [PATCH 2/3] systemd: add xen-init-dom0 service Wei Liu
@ 2014-10-21 9:56 ` Wei Liu
2014-10-22 11:23 ` Ian Campbell
2014-10-22 11:57 ` Anthony PERARD
2 siblings, 2 replies; 13+ messages in thread
From: Wei Liu @ 2014-10-21 9:56 UTC (permalink / raw)
To: xen-devel; +Cc: olaf, Wei Liu, ian.campbell
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
tools/hotplug/Linux/systemd/xendomains.service.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/hotplug/Linux/systemd/xendomains.service.in b/tools/hotplug/Linux/systemd/xendomains.service.in
index f88c336..8577317 100644
--- a/tools/hotplug/Linux/systemd/xendomains.service.in
+++ b/tools/hotplug/Linux/systemd/xendomains.service.in
@@ -1,7 +1,7 @@
[Unit]
Description=Xendomains - start and stop guests on boot and shutdown
Requires=xenstored.socket
-After=xenstored.service xenconsoled.service
+After=xenstored.service xenconsoled.service xen-init-dom0.service
ConditionVirtualization=xen
[Service]
--
1.7.10.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 1/3] systemd: fix clean target in Makefile
2014-10-21 9:56 ` [PATCH 1/3] systemd: fix clean target in Makefile Wei Liu
@ 2014-10-22 11:22 ` Ian Campbell
2014-10-22 20:23 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 13+ messages in thread
From: Ian Campbell @ 2014-10-22 11:22 UTC (permalink / raw)
To: Wei Liu; +Cc: olaf, xen-devel
On Tue, 2014-10-21 at 10:56 +0100, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
I just acked the first copy of this before I noticed this newer one.
Anyway:
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Are you going to make a case for a release exception (for some or all of
the series) to Konrad?
> ---
> tools/hotplug/Linux/systemd/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/hotplug/Linux/systemd/Makefile b/tools/hotplug/Linux/systemd/Makefile
> index 9c58b33..0c40a73 100644
> --- a/tools/hotplug/Linux/systemd/Makefile
> +++ b/tools/hotplug/Linux/systemd/Makefile
> @@ -25,6 +25,7 @@ all: $(ALL_XEN_SYSTEMD)
>
> .PHONY: clean
> clean:
> + rm -f $(XEN_SYSTEMD_MODULES)
>
> .PHONY: install
> install: $(ALL_XEN_SYSTEMD)
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/3] systemd: add xen-init-dom0 service
2014-10-21 9:56 ` [PATCH 2/3] systemd: add xen-init-dom0 service Wei Liu
@ 2014-10-22 11:23 ` Ian Campbell
2014-10-23 16:05 ` Anthony PERARD
1 sibling, 0 replies; 13+ messages in thread
From: Ian Campbell @ 2014-10-22 11:23 UTC (permalink / raw)
To: Wei Liu; +Cc: olaf, xen-devel
On Tue, 2014-10-21 at 10:56 +0100, Wei Liu wrote:
> Also prevent xenstored.service from writing Dom0 nodes The
> initialisation is now done with xen-init-dom0.
>
> Please rerun autoconf after applying this patch.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
(didn't Olaf ack the previous?)
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/3] systemd: xendomains now depends on xen-init-dom0
2014-10-21 9:56 ` [PATCH 3/3] systemd: xendomains now depends on xen-init-dom0 Wei Liu
@ 2014-10-22 11:23 ` Ian Campbell
2014-10-22 11:57 ` Anthony PERARD
1 sibling, 0 replies; 13+ messages in thread
From: Ian Campbell @ 2014-10-22 11:23 UTC (permalink / raw)
To: Wei Liu; +Cc: olaf, xen-devel
On Tue, 2014-10-21 at 10:56 +0100, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/3] systemd: xendomains now depends on xen-init-dom0
2014-10-21 9:56 ` [PATCH 3/3] systemd: xendomains now depends on xen-init-dom0 Wei Liu
2014-10-22 11:23 ` Ian Campbell
@ 2014-10-22 11:57 ` Anthony PERARD
2014-10-22 12:07 ` Wei Liu
1 sibling, 1 reply; 13+ messages in thread
From: Anthony PERARD @ 2014-10-22 11:57 UTC (permalink / raw)
To: Wei Liu; +Cc: olaf, ian.campbell, xen-devel
On Tue, Oct 21, 2014 at 10:56:12AM +0100, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> tools/hotplug/Linux/systemd/xendomains.service.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/hotplug/Linux/systemd/xendomains.service.in b/tools/hotplug/Linux/systemd/xendomains.service.in
> index f88c336..8577317 100644
> --- a/tools/hotplug/Linux/systemd/xendomains.service.in
> +++ b/tools/hotplug/Linux/systemd/xendomains.service.in
> @@ -1,7 +1,7 @@
> [Unit]
> Description=Xendomains - start and stop guests on boot and shutdown
> Requires=xenstored.socket
> -After=xenstored.service xenconsoled.service
> +After=xenstored.service xenconsoled.service xen-init-dom0.service
> ConditionVirtualization=xen
Having a service listed in After does not mean a service depends on the
other. It just mean: run xendomains.service after xen-init-dom0.service,
but xen-init-dom0.service might not run at all..
If xen-init-dom0.service needs to be run before xendomains.service, you
also need to add it to the Requires list.
So the patch should probably look like this:
-Requires=xenstored.socket
-After=xenstored.service xenconsoled.service
+Requires=xenstored.socket xen-init-dom0.service
+After=xenstored.service xenconsoled.service xen-init-dom0.service
(This also means, if xen-init-dom0 fail, xendomains will not be started
at all.)
--
Anthony PERARD
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/3] systemd: xendomains now depends on xen-init-dom0
2014-10-22 11:57 ` Anthony PERARD
@ 2014-10-22 12:07 ` Wei Liu
0 siblings, 0 replies; 13+ messages in thread
From: Wei Liu @ 2014-10-22 12:07 UTC (permalink / raw)
To: Anthony PERARD; +Cc: olaf, Wei Liu, ian.campbell, xen-devel
On Wed, Oct 22, 2014 at 12:57:24PM +0100, Anthony PERARD wrote:
> On Tue, Oct 21, 2014 at 10:56:12AM +0100, Wei Liu wrote:
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > ---
> > tools/hotplug/Linux/systemd/xendomains.service.in | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/hotplug/Linux/systemd/xendomains.service.in b/tools/hotplug/Linux/systemd/xendomains.service.in
> > index f88c336..8577317 100644
> > --- a/tools/hotplug/Linux/systemd/xendomains.service.in
> > +++ b/tools/hotplug/Linux/systemd/xendomains.service.in
> > @@ -1,7 +1,7 @@
> > [Unit]
> > Description=Xendomains - start and stop guests on boot and shutdown
> > Requires=xenstored.socket
> > -After=xenstored.service xenconsoled.service
> > +After=xenstored.service xenconsoled.service xen-init-dom0.service
> > ConditionVirtualization=xen
>
> Having a service listed in After does not mean a service depends on the
> other. It just mean: run xendomains.service after xen-init-dom0.service,
> but xen-init-dom0.service might not run at all..
>
> If xen-init-dom0.service needs to be run before xendomains.service, you
> also need to add it to the Requires list.
>
Then I must have misread the manual
"After= ensures that the configured unit is started after the listed
unit finished starting up"
Looks like "finished starting up" doesn't guarantee it exits with
success?
> So the patch should probably look like this:
> -Requires=xenstored.socket
> -After=xenstored.service xenconsoled.service
> +Requires=xenstored.socket xen-init-dom0.service
> +After=xenstored.service xenconsoled.service xen-init-dom0.service
>
> (This also means, if xen-init-dom0 fail, xendomains will not be started
> at all.)
>
Anyway, this looks sensible and it's what I expect. I will add in that
line.
Wei.
> --
> Anthony PERARD
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/3] systemd: fix clean target in Makefile
2014-10-22 11:22 ` Ian Campbell
@ 2014-10-22 20:23 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 13+ messages in thread
From: Konrad Rzeszutek Wilk @ 2014-10-22 20:23 UTC (permalink / raw)
To: Ian Campbell; +Cc: olaf, Wei Liu, xen-devel
On Wed, Oct 22, 2014 at 12:22:10PM +0100, Ian Campbell wrote:
> On Tue, 2014-10-21 at 10:56 +0100, Wei Liu wrote:
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>
> I just acked the first copy of this before I noticed this newer one.
> Anyway:
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> Are you going to make a case for a release exception (for some or all of
> the series) to Konrad?
I believe this is a bug-fix so it can go in anytime.
>
> > ---
> > tools/hotplug/Linux/systemd/Makefile | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/hotplug/Linux/systemd/Makefile b/tools/hotplug/Linux/systemd/Makefile
> > index 9c58b33..0c40a73 100644
> > --- a/tools/hotplug/Linux/systemd/Makefile
> > +++ b/tools/hotplug/Linux/systemd/Makefile
> > @@ -25,6 +25,7 @@ all: $(ALL_XEN_SYSTEMD)
> >
> > .PHONY: clean
> > clean:
> > + rm -f $(XEN_SYSTEMD_MODULES)
> >
> > .PHONY: install
> > install: $(ALL_XEN_SYSTEMD)
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/3] systemd: add xen-init-dom0 service
2014-10-21 9:56 ` [PATCH 2/3] systemd: add xen-init-dom0 service Wei Liu
2014-10-22 11:23 ` Ian Campbell
@ 2014-10-23 16:05 ` Anthony PERARD
2014-10-23 16:48 ` Olaf Hering
1 sibling, 1 reply; 13+ messages in thread
From: Anthony PERARD @ 2014-10-23 16:05 UTC (permalink / raw)
To: Wei Liu; +Cc: olaf, ian.campbell, xen-devel
On Tue, Oct 21, 2014 at 10:56:11AM +0100, Wei Liu wrote:
> Also prevent xenstored.service from writing Dom0 nodes The
> initialisation is now done with xen-init-dom0.
>
> Please rerun autoconf after applying this patch.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
I've tested this patch, and it works fine. It also looks good.
One would just need to adds "systemctl enable xen-init-dom0" in the
doc, if there is one.
I just have one comment below.
> ---
> tools/configure.ac | 1 +
> tools/hotplug/Linux/systemd/Makefile | 1 +
> tools/hotplug/Linux/systemd/xen-init-dom0.service.in | 14 ++++++++++++++
> tools/hotplug/Linux/systemd/xenstored.service.in | 2 --
> 4 files changed, 16 insertions(+), 2 deletions(-)
> create mode 100644 tools/hotplug/Linux/systemd/xen-init-dom0.service.in
>
> diff --git a/tools/configure.ac b/tools/configure.ac
> index f584798..62ccf47 100644
> --- a/tools/configure.ac
> +++ b/tools/configure.ac
> @@ -15,6 +15,7 @@ hotplug/Linux/init.d/xendomains
> hotplug/Linux/systemd/proc-xen.mount
> hotplug/Linux/systemd/var-lib-xenstored.mount
> hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service
> +hotplug/Linux/systemd/xen-init-dom0.service
> hotplug/Linux/systemd/xen-watchdog.service
> hotplug/Linux/systemd/xenconsoled.service
> hotplug/Linux/systemd/xendomains.service
> diff --git a/tools/hotplug/Linux/systemd/Makefile b/tools/hotplug/Linux/systemd/Makefile
> index 0c40a73..51c10fe 100644
> --- a/tools/hotplug/Linux/systemd/Makefile
> +++ b/tools/hotplug/Linux/systemd/Makefile
> @@ -14,6 +14,7 @@ XEN_SYSTEMD_SERVICE += xenconsoled.service
> XEN_SYSTEMD_SERVICE += xen-qemu-dom0-disk-backend.service
> XEN_SYSTEMD_SERVICE += xendomains.service
> XEN_SYSTEMD_SERVICE += xen-watchdog.service
> +XEN_SYSTEMD_SERVICE += xen-init-dom0.service
>
> ALL_XEN_SYSTEMD = $(XEN_SYSTEMD_MODULES) \
> $(XEN_SYSTEMD_MOUNT) \
> diff --git a/tools/hotplug/Linux/systemd/xen-init-dom0.service.in b/tools/hotplug/Linux/systemd/xen-init-dom0.service.in
> new file mode 100644
> index 0000000..e947760
> --- /dev/null
> +++ b/tools/hotplug/Linux/systemd/xen-init-dom0.service.in
> @@ -0,0 +1,14 @@
> +[Unit]
> +Description=xen-init-dom0, initialise Dom0 configuration (xenstore nodes, JSON configuration stub)
> +Requires=xenstored.socket
> +After=xenstored.service
This two lines looks weird. I think they needs to be both the same.
Right now, I think systemd is ignoring the "After=" because
xenstored.service is not yet on the list of services to start. But it
will work because as soon as xen-init-dom0 is going to try to access
xenstored, systemd is going to start it (because .socket).
So, IMHO, the right thing to do is either:
Requires=xenstored.socket
After=xenstored.socket
or:
Requires=xenstored.service
After=xenstored.service
> +ConditionPathExists=/proc/xen/capabilities
> +
> +[Service]
> +Type=oneshot
> +RemainAfterExit=true
> +ExecStartPre=/bin/grep -q control_d /proc/xen/capabilities
> +ExecStart=@LIBEXEC_BIN@/xen-init-dom0
> +
> +[Install]
> +WantedBy=multi-user.target
> diff --git a/tools/hotplug/Linux/systemd/xenstored.service.in b/tools/hotplug/Linux/systemd/xenstored.service.in
> index 013e69e..e3bf837 100644
> --- a/tools/hotplug/Linux/systemd/xenstored.service.in
> +++ b/tools/hotplug/Linux/systemd/xenstored.service.in
> @@ -17,8 +17,6 @@ ExecStartPre=/bin/grep -q control_d /proc/xen/capabilities
> ExecStartPre=-/bin/rm -f @XEN_LIB_STORED@/tdb*
> ExecStartPre=/bin/mkdir -p @XEN_RUN_DIR@
> ExecStart=/bin/sh -c "exec $XENSTORED --no-fork $XENSTORED_ARGS"
> -ExecStartPost=-@bindir@/xenstore-write "/local/domain/0/name" "Domain-0"
> -ExecStartPost=-@bindir@/xenstore-write "/local/domain/0/domid" 0
>
> [Install]
> WantedBy=multi-user.target
> --
> 1.7.10.4
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
--
Anthony PERARD
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/3] systemd: add xen-init-dom0 service
2014-10-23 16:05 ` Anthony PERARD
@ 2014-10-23 16:48 ` Olaf Hering
2014-10-23 17:01 ` Wei Liu
0 siblings, 1 reply; 13+ messages in thread
From: Olaf Hering @ 2014-10-23 16:48 UTC (permalink / raw)
To: Anthony PERARD; +Cc: Wei Liu, ian.campbell, xen-devel
On Thu, Oct 23, Anthony PERARD wrote:
> So, IMHO, the right thing to do is either:
> Requires=xenstored.socket
> After=xenstored.socket
> or:
> Requires=xenstored.service
> After=xenstored.service
I agree with that.
Olaf
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/3] systemd: add xen-init-dom0 service
2014-10-23 16:48 ` Olaf Hering
@ 2014-10-23 17:01 ` Wei Liu
0 siblings, 0 replies; 13+ messages in thread
From: Wei Liu @ 2014-10-23 17:01 UTC (permalink / raw)
To: Olaf Hering; +Cc: Anthony PERARD, Wei Liu, ian.campbell, xen-devel
On Thu, Oct 23, 2014 at 06:48:51PM +0200, Olaf Hering wrote:
> On Thu, Oct 23, Anthony PERARD wrote:
>
> > So, IMHO, the right thing to do is either:
> > Requires=xenstored.socket
> > After=xenstored.socket
> > or:
> > Requires=xenstored.service
> > After=xenstored.service
>
> I agree with that.
>
Then I (or you?) will need to fix other service files as well!
Anyway, I (or you?) should fix this as soon as possible.
Wei.
> Olaf
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2014-10-23 17:01 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-21 9:56 [PATCH 0/3] tools: systemd patches Wei Liu
2014-10-21 9:56 ` [PATCH 1/3] systemd: fix clean target in Makefile Wei Liu
2014-10-22 11:22 ` Ian Campbell
2014-10-22 20:23 ` Konrad Rzeszutek Wilk
2014-10-21 9:56 ` [PATCH 2/3] systemd: add xen-init-dom0 service Wei Liu
2014-10-22 11:23 ` Ian Campbell
2014-10-23 16:05 ` Anthony PERARD
2014-10-23 16:48 ` Olaf Hering
2014-10-23 17:01 ` Wei Liu
2014-10-21 9:56 ` [PATCH 3/3] systemd: xendomains now depends on xen-init-dom0 Wei Liu
2014-10-22 11:23 ` Ian Campbell
2014-10-22 11:57 ` Anthony PERARD
2014-10-22 12:07 ` Wei Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.