All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Geoff Levand <geoff@infradead.org>
Cc: Marc Zyngier <Marc.Zyngier@arm.com>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	Will Deacon <Will.Deacon@arm.com>,
	"christoffer.dall@linaro.org" <christoffer.dall@linaro.org>,
	"grant.likely@linaro.org" <grant.likely@linaro.org>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 06/10] arm64: Update booting.txt to reserved-memory nodes
Date: Fri, 24 Oct 2014 11:54:32 +0100	[thread overview]
Message-ID: <20141024105432.GE24265@leverpostej> (raw)
In-Reply-To: <b56c0def845535b41b6c00bffdd9d91de5ddae5c.1414099246.git.geoff@infradead.org>

On Fri, Oct 24, 2014 at 12:10:58AM +0100, Geoff Levand wrote:
> Change any reference of device tree '/memreserve/' entries in the arm64
> booting.txt to refer to 'reserved-memory nodes'.  Reserved-memory nodes
> are the preferred method of specifying reserved memory.

Per my comments on patch 5, I don't think this change is sufficient.

However, we should probably update the document to allow reserved-memory
nodes.

On an unrelated note we probably need to work out how reserved-memory
interacts with the UEFI memory map -- unmappable regions shouldn't be
described by UEFI and I hope people don't use reserved-memory as a
workaround for broken UEFI tables.

Thanks,
Mark.

> Signed-off-by: Geoff Levand <geoff@infradead.org>
> ---
>  Documentation/arm64/booting.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/arm64/booting.txt b/Documentation/arm64/booting.txt
> index f3c05b5..7446822 100644
> --- a/Documentation/arm64/booting.txt
> +++ b/Documentation/arm64/booting.txt
> @@ -196,7 +196,7 @@ following manner:
>    naturally-aligned 64-bit zero-initalised memory location.
>  
>    These CPUs should spin outside of the kernel in a reserved area of
> -  memory (communicated to the kernel by a /memreserve/ region in the
> +  memory (communicated to the kernel by a reserved-memory node in the
>    device tree) polling their cpu-release-addr location, which must be
>    contained in the reserved region.  A wfe instruction may be inserted
>    to reduce the overhead of the busy-loop and a sev will be issued by
> @@ -209,7 +209,7 @@ following manner:
>  - CPUs with a "psci" enable method should remain outside of
>    the kernel (i.e. outside of the regions of memory described to the
>    kernel in the memory node, or in a reserved area of memory described
> -  to the kernel by a /memreserve/ region in the device tree).  The
> +  to the kernel by a reserved-memory node in the device tree).  The
>    kernel will issue CPU_ON calls as described in ARM document number ARM
>    DEN 0022A ("Power State Coordination Interface System Software on ARM
>    processors") to bring CPUs into the kernel.
> -- 
> 1.9.1
> 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/10] arm64: Update booting.txt to reserved-memory nodes
Date: Fri, 24 Oct 2014 11:54:32 +0100	[thread overview]
Message-ID: <20141024105432.GE24265@leverpostej> (raw)
In-Reply-To: <b56c0def845535b41b6c00bffdd9d91de5ddae5c.1414099246.git.geoff@infradead.org>

On Fri, Oct 24, 2014 at 12:10:58AM +0100, Geoff Levand wrote:
> Change any reference of device tree '/memreserve/' entries in the arm64
> booting.txt to refer to 'reserved-memory nodes'.  Reserved-memory nodes
> are the preferred method of specifying reserved memory.

Per my comments on patch 5, I don't think this change is sufficient.

However, we should probably update the document to allow reserved-memory
nodes.

On an unrelated note we probably need to work out how reserved-memory
interacts with the UEFI memory map -- unmappable regions shouldn't be
described by UEFI and I hope people don't use reserved-memory as a
workaround for broken UEFI tables.

Thanks,
Mark.

> Signed-off-by: Geoff Levand <geoff@infradead.org>
> ---
>  Documentation/arm64/booting.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/arm64/booting.txt b/Documentation/arm64/booting.txt
> index f3c05b5..7446822 100644
> --- a/Documentation/arm64/booting.txt
> +++ b/Documentation/arm64/booting.txt
> @@ -196,7 +196,7 @@ following manner:
>    naturally-aligned 64-bit zero-initalised memory location.
>  
>    These CPUs should spin outside of the kernel in a reserved area of
> -  memory (communicated to the kernel by a /memreserve/ region in the
> +  memory (communicated to the kernel by a reserved-memory node in the
>    device tree) polling their cpu-release-addr location, which must be
>    contained in the reserved region.  A wfe instruction may be inserted
>    to reduce the overhead of the busy-loop and a sev will be issued by
> @@ -209,7 +209,7 @@ following manner:
>  - CPUs with a "psci" enable method should remain outside of
>    the kernel (i.e. outside of the regions of memory described to the
>    kernel in the memory node, or in a reserved area of memory described
> -  to the kernel by a /memreserve/ region in the device tree).  The
> +  to the kernel by a reserved-memory node in the device tree).  The
>    kernel will issue CPU_ON calls as described in ARM document number ARM
>    DEN 0022A ("Power State Coordination Interface System Software on ARM
>    processors") to bring CPUs into the kernel.
> -- 
> 1.9.1
> 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

  reply	other threads:[~2014-10-24 10:54 UTC|newest]

Thread overview: 141+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-23 23:10 [PATCH 00/10] arm64 kexec kernel patches V5 Geoff Levand
2014-10-23 23:10 ` Geoff Levand
2014-10-23 23:10 ` [PATCH 05/10] arm64: Convert dts to use reserved-memory nodes Geoff Levand
2014-10-23 23:10   ` Geoff Levand
2014-10-24 10:51   ` Mark Rutland
2014-10-24 10:51     ` Mark Rutland
2014-10-24 10:59     ` Grant Likely
2014-10-24 10:59       ` Grant Likely
2014-10-24 12:27       ` Mark Rutland
2014-10-24 12:27         ` Mark Rutland
2014-10-24 14:45         ` Grant Likely
2014-10-24 14:45           ` Grant Likely
2014-10-31 23:44         ` Geoff Levand
2014-10-31 23:44           ` Geoff Levand
2014-11-03 20:02           ` Mark Rutland
2014-11-03 20:02             ` Mark Rutland
2014-11-03 22:26           ` Rob Herring
2014-11-03 22:26             ` Rob Herring
2014-11-04 11:35             ` Mark Rutland
2014-11-04 11:35               ` Mark Rutland
2014-11-04 11:37             ` Grant Likely
2014-11-04 11:37               ` Grant Likely
2014-10-23 23:10 ` [PATCH 03/10] arm64: Add new hcall HVC_CALL_FUNC Geoff Levand
2014-10-23 23:10   ` Geoff Levand
2014-10-23 23:10 ` [PATCH 08/10] arm64/kexec: Add core kexec support Geoff Levand
2014-10-23 23:10   ` Geoff Levand
2014-10-24 10:28   ` Mark Rutland
2014-10-24 10:28     ` Mark Rutland
2014-11-13  2:19     ` Geoff Levand
2014-11-13  2:19       ` Geoff Levand
2014-11-17 16:38       ` Mark Rutland
2014-11-17 16:38         ` Mark Rutland
2014-11-17 20:20         ` Geoff Levand
2014-11-17 20:20           ` Geoff Levand
2014-11-07 11:01   ` Arun Chandran
2014-11-07 11:01     ` Arun Chandran
2014-11-12 21:54     ` Geoff Levand
2014-11-13  9:52       ` Arun Chandran
2014-11-17  3:52       ` Dave Young
2014-10-23 23:10 ` [PATCH 07/10] arm64: Move proc-macros.S to include/asm Geoff Levand
2014-10-23 23:10   ` Geoff Levand
2014-10-23 23:10 ` [PATCH 02/10] arm64: Convert hcalls to use ISS field Geoff Levand
2014-10-23 23:10   ` Geoff Levand
2014-10-23 23:10 ` [PATCH 06/10] arm64: Update booting.txt to reserved-memory nodes Geoff Levand
2014-10-23 23:10   ` Geoff Levand
2014-10-24 10:54   ` Mark Rutland [this message]
2014-10-24 10:54     ` Mark Rutland
2014-10-24 11:04     ` Grant Likely
2014-10-24 11:04       ` Grant Likely
2014-10-24 12:18       ` Mark Rutland
2014-10-24 12:18         ` Mark Rutland
2014-10-24 13:54         ` Grant Likely
2014-10-24 13:54           ` Grant Likely
2014-10-24 14:10           ` Mark Rutland
2014-10-24 14:10             ` Mark Rutland
2014-10-24 14:47             ` Grant Likely
2014-10-24 14:47               ` Grant Likely
2014-10-23 23:10 ` [PATCH 04/10] arm64: Add EL2 switch to soft_restart Geoff Levand
2014-10-23 23:10   ` Geoff Levand
2014-10-24 10:57   ` Mark Rutland
2014-10-24 10:57     ` Mark Rutland
2014-10-31 23:47     ` Geoff Levand
2014-10-31 23:47       ` Geoff Levand
2014-10-23 23:10 ` [PATCH 01/10] arm64/kvm: Fix assembler compatibility of macros Geoff Levand
2014-10-23 23:10   ` Geoff Levand
2014-10-24  9:24   ` Mark Rutland
2014-10-24  9:24     ` Mark Rutland
2014-10-27 12:13     ` Will Deacon
2014-10-27 12:13       ` Will Deacon
2014-10-27 12:45       ` Christoffer Dall
2014-10-27 12:45         ` Christoffer Dall
2014-10-31 23:06       ` [PATCH V2 " Geoff Levand
2014-10-31 23:06         ` Geoff Levand
2014-10-23 23:10 ` [PATCH 09/10] arm64/kexec: Enable kexec in the arm64 defconfig Geoff Levand
2014-10-23 23:10   ` Geoff Levand
2014-10-24 10:31   ` Mark Rutland
2014-10-24 10:31     ` Mark Rutland
2014-10-31 23:50     ` Geoff Levand
2014-10-31 23:50       ` Geoff Levand
2014-11-03 20:05       ` Mark Rutland
2014-11-03 20:05         ` Mark Rutland
2014-11-04  1:49         ` Geoff Levand
2014-11-04  1:49           ` Geoff Levand
2014-10-23 23:10 ` [PATCH 10/10] arm64/kexec: Add pr_devel output Geoff Levand
2014-10-23 23:10   ` Geoff Levand
2014-10-31  7:52 ` [PATCH 00/10] arm64 kexec kernel patches V5 Dave Young
2014-10-31  7:52   ` Dave Young
2014-10-31 23:25   ` Geoff Levand
2014-10-31 23:25     ` Geoff Levand
2014-11-06  2:01     ` Dave Young
2014-11-06  2:01       ` Dave Young
2014-11-13  8:37     ` Dave Young
2014-11-13  8:37       ` Dave Young
2014-11-13 23:50       ` Geoff Levand
2014-11-13 23:50         ` Geoff Levand
2014-11-17  3:49         ` Dave Young
2014-11-17  3:49           ` Dave Young
2014-11-03 19:46   ` Mark Rutland
2014-11-03 19:46     ` Mark Rutland
2014-11-06  1:56     ` Dave Young
2014-11-06  1:56       ` Dave Young
2014-11-06 15:08       ` Mark Rutland
2014-11-06 15:08         ` Mark Rutland
2014-11-07  0:41         ` Grant Likely
2014-11-07  0:41           ` Grant Likely
2014-11-07 10:16           ` Mark Rutland
2014-11-07 10:16             ` Mark Rutland
2014-11-07 10:41             ` Ard Biesheuvel
2014-11-07 10:41               ` Ard Biesheuvel
2014-11-07 10:45               ` Ard Biesheuvel
2014-11-07 10:45                 ` Ard Biesheuvel
2014-11-07 10:46                 ` Ard Biesheuvel
2014-11-07 10:46                   ` Ard Biesheuvel
2014-11-07 11:35               ` Mark Rutland
2014-11-07 11:35                 ` Mark Rutland
2014-11-07 11:42                 ` Ard Biesheuvel
2014-11-07 11:42                   ` Ard Biesheuvel
2014-11-07 22:34                 ` Grant Likely
2014-11-07 22:34                   ` Grant Likely
2014-11-06 12:16 ` Arun Chandran
2014-11-06 12:16   ` Arun Chandran
2014-11-06 15:28   ` Mark Rutland
2014-11-06 15:28     ` Mark Rutland
2014-11-06 16:13     ` Arun Chandran
2014-11-06 16:13       ` Arun Chandran
2014-11-06 18:25       ` Geoff Levand
2014-11-06 18:25         ` Geoff Levand
2014-11-07  6:26         ` Arun Chandran
2014-11-07  6:26           ` Arun Chandran
2014-11-06 18:39       ` Mark Rutland
2014-11-06 18:39         ` Mark Rutland
2014-11-07  6:36         ` Arun Chandran
2014-11-07  6:36           ` Arun Chandran
2014-11-10  7:17       ` Dave Young
2014-11-10  7:17         ` Dave Young
2014-11-10  8:35         ` Arun Chandran
2014-11-10  8:35           ` Arun Chandran
2014-11-10  9:24           ` Dave Young
2014-11-10  9:24             ` Dave Young
2014-11-12  9:56           ` Dave Young
2014-11-12  9:56             ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141024105432.GE24265@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=Catalin.Marinas@arm.com \
    --cc=Marc.Zyngier@arm.com \
    --cc=Will.Deacon@arm.com \
    --cc=christoffer.dall@linaro.org \
    --cc=geoff@infradead.org \
    --cc=grant.likely@linaro.org \
    --cc=kexec@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.