All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Young <dyoung@redhat.com>
To: Geoff Levand <geoff@infradead.org>
Cc: marc.zyngier@arm.com, Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	christoffer.dall@linaro.org,
	Grant Likely <grant.likely@linaro.org>,
	kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 00/10] arm64 kexec kernel patches V5
Date: Fri, 31 Oct 2014 15:52:09 +0800	[thread overview]
Message-ID: <20141031075209.GH3290@darkstar.nay.redhat.com> (raw)
In-Reply-To: <cover.1414099246.git.geoff@infradead.org>

Hi Geoff

I tested your patches. The macihne is using spin-table cpu enable method
so I tried maxcpus=1 as you suggested.

There's below issues for me, thoughts?

1. For acpi booting there's no /proc/device-tree so kexec can not find dtb
to use.

2. adding "acpi=off" to 1st kernel boot cmdline, kexec load fails with error
like below:
machine_apply_elf_rel: ERROR Unknown type: 261

I did below hack then kexec load works fine, but `kexec -e` still does not work
there's nothing more than "Disableing non-boot CPUS ...\n Bye!":

diff --git a/kexec/arch/arm64/kexec-arm64.c b/kexec/arch/arm64/kexec-arm64.c
index 9db1c07..2df24f0 100644
--- a/kexec/arch/arm64/kexec-arm64.c
+++ b/kexec/arch/arm64/kexec-arm64.c
@@ -790,6 +790,10 @@ void machine_apply_elf_rel(struct mem_ehdr *ehdr, unsigned long r_type,
 # define R_AARCH64_ABS64 257
 #endif
 
+#if !defined(R_AARCH64_PREL32)
+#define R_AARCH64_PREL32		261
+#endif
+
 #if !defined(R_AARCH64_LD_PREL_LO19)
 # define R_AARCH64_LD_PREL_LO19 273
 #endif
@@ -806,6 +810,7 @@ void machine_apply_elf_rel(struct mem_ehdr *ehdr, unsigned long r_type,
 # define R_AARCH64_CALL26 283
 #endif
 
+	uint64_t *location1 = (uint64_t *)ptr;
 	uint32_t *location = (uint32_t *)ptr;
 	uint32_t data = *location;
 	const char *type = NULL;
@@ -813,7 +818,11 @@ void machine_apply_elf_rel(struct mem_ehdr *ehdr, unsigned long r_type,
 	switch(r_type) {
 	case R_AARCH64_ABS64:
 		type = "ABS64";
-		*location += value;
+		*location1 += value;
+		break;
+	case R_AARCH64_PREL32:
+		type = "PREL32";
+		*location += value - address;
 		break;
 	case R_AARCH64_LD_PREL_LO19:
 		type = "LD_PREL_LO19";
@@ -839,7 +848,7 @@ void machine_apply_elf_rel(struct mem_ehdr *ehdr, unsigned long r_type,
 		break;
 	}
 
-	dbgprintf("%s: %s %x->%x\n", __func__, type, data, *location);
+	dbgprintf("%s: %s %x->%lx\n", __func__, type, data, (r_type == R_AARCH64_ABS64)? *location1: *location);
 }
 
 void arch_reuse_initrd(void)

Thanks
Dave

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: dyoung@redhat.com (Dave Young)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 00/10] arm64 kexec kernel patches V5
Date: Fri, 31 Oct 2014 15:52:09 +0800	[thread overview]
Message-ID: <20141031075209.GH3290@darkstar.nay.redhat.com> (raw)
In-Reply-To: <cover.1414099246.git.geoff@infradead.org>

Hi Geoff

I tested your patches. The macihne is using spin-table cpu enable method
so I tried maxcpus=1 as you suggested.

There's below issues for me, thoughts?

1. For acpi booting there's no /proc/device-tree so kexec can not find dtb
to use.

2. adding "acpi=off" to 1st kernel boot cmdline, kexec load fails with error
like below:
machine_apply_elf_rel: ERROR Unknown type: 261

I did below hack then kexec load works fine, but `kexec -e` still does not work
there's nothing more than "Disableing non-boot CPUS ...\n Bye!":

diff --git a/kexec/arch/arm64/kexec-arm64.c b/kexec/arch/arm64/kexec-arm64.c
index 9db1c07..2df24f0 100644
--- a/kexec/arch/arm64/kexec-arm64.c
+++ b/kexec/arch/arm64/kexec-arm64.c
@@ -790,6 +790,10 @@ void machine_apply_elf_rel(struct mem_ehdr *ehdr, unsigned long r_type,
 # define R_AARCH64_ABS64 257
 #endif
 
+#if !defined(R_AARCH64_PREL32)
+#define R_AARCH64_PREL32		261
+#endif
+
 #if !defined(R_AARCH64_LD_PREL_LO19)
 # define R_AARCH64_LD_PREL_LO19 273
 #endif
@@ -806,6 +810,7 @@ void machine_apply_elf_rel(struct mem_ehdr *ehdr, unsigned long r_type,
 # define R_AARCH64_CALL26 283
 #endif
 
+	uint64_t *location1 = (uint64_t *)ptr;
 	uint32_t *location = (uint32_t *)ptr;
 	uint32_t data = *location;
 	const char *type = NULL;
@@ -813,7 +818,11 @@ void machine_apply_elf_rel(struct mem_ehdr *ehdr, unsigned long r_type,
 	switch(r_type) {
 	case R_AARCH64_ABS64:
 		type = "ABS64";
-		*location += value;
+		*location1 += value;
+		break;
+	case R_AARCH64_PREL32:
+		type = "PREL32";
+		*location += value - address;
 		break;
 	case R_AARCH64_LD_PREL_LO19:
 		type = "LD_PREL_LO19";
@@ -839,7 +848,7 @@ void machine_apply_elf_rel(struct mem_ehdr *ehdr, unsigned long r_type,
 		break;
 	}
 
-	dbgprintf("%s: %s %x->%x\n", __func__, type, data, *location);
+	dbgprintf("%s: %s %x->%lx\n", __func__, type, data, (r_type == R_AARCH64_ABS64)? *location1: *location);
 }
 
 void arch_reuse_initrd(void)

Thanks
Dave

  parent reply	other threads:[~2014-10-31  7:52 UTC|newest]

Thread overview: 141+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-23 23:10 [PATCH 00/10] arm64 kexec kernel patches V5 Geoff Levand
2014-10-23 23:10 ` Geoff Levand
2014-10-23 23:10 ` [PATCH 04/10] arm64: Add EL2 switch to soft_restart Geoff Levand
2014-10-23 23:10   ` Geoff Levand
2014-10-24 10:57   ` Mark Rutland
2014-10-24 10:57     ` Mark Rutland
2014-10-31 23:47     ` Geoff Levand
2014-10-31 23:47       ` Geoff Levand
2014-10-23 23:10 ` [PATCH 01/10] arm64/kvm: Fix assembler compatibility of macros Geoff Levand
2014-10-23 23:10   ` Geoff Levand
2014-10-24  9:24   ` Mark Rutland
2014-10-24  9:24     ` Mark Rutland
2014-10-27 12:13     ` Will Deacon
2014-10-27 12:13       ` Will Deacon
2014-10-27 12:45       ` Christoffer Dall
2014-10-27 12:45         ` Christoffer Dall
2014-10-31 23:06       ` [PATCH V2 " Geoff Levand
2014-10-31 23:06         ` Geoff Levand
2014-10-23 23:10 ` [PATCH 05/10] arm64: Convert dts to use reserved-memory nodes Geoff Levand
2014-10-23 23:10   ` Geoff Levand
2014-10-24 10:51   ` Mark Rutland
2014-10-24 10:51     ` Mark Rutland
2014-10-24 10:59     ` Grant Likely
2014-10-24 10:59       ` Grant Likely
2014-10-24 12:27       ` Mark Rutland
2014-10-24 12:27         ` Mark Rutland
2014-10-24 14:45         ` Grant Likely
2014-10-24 14:45           ` Grant Likely
2014-10-31 23:44         ` Geoff Levand
2014-10-31 23:44           ` Geoff Levand
2014-11-03 20:02           ` Mark Rutland
2014-11-03 20:02             ` Mark Rutland
2014-11-03 22:26           ` Rob Herring
2014-11-03 22:26             ` Rob Herring
2014-11-04 11:35             ` Mark Rutland
2014-11-04 11:35               ` Mark Rutland
2014-11-04 11:37             ` Grant Likely
2014-11-04 11:37               ` Grant Likely
2014-10-23 23:10 ` [PATCH 08/10] arm64/kexec: Add core kexec support Geoff Levand
2014-10-23 23:10   ` Geoff Levand
2014-10-24 10:28   ` Mark Rutland
2014-10-24 10:28     ` Mark Rutland
2014-11-13  2:19     ` Geoff Levand
2014-11-13  2:19       ` Geoff Levand
2014-11-17 16:38       ` Mark Rutland
2014-11-17 16:38         ` Mark Rutland
2014-11-17 20:20         ` Geoff Levand
2014-11-17 20:20           ` Geoff Levand
2014-11-07 11:01   ` Arun Chandran
2014-11-07 11:01     ` Arun Chandran
2014-11-12 21:54     ` Geoff Levand
2014-11-13  9:52       ` Arun Chandran
2014-11-17  3:52       ` Dave Young
2014-10-23 23:10 ` [PATCH 03/10] arm64: Add new hcall HVC_CALL_FUNC Geoff Levand
2014-10-23 23:10   ` Geoff Levand
2014-10-23 23:10 ` [PATCH 07/10] arm64: Move proc-macros.S to include/asm Geoff Levand
2014-10-23 23:10   ` Geoff Levand
2014-10-23 23:10 ` [PATCH 06/10] arm64: Update booting.txt to reserved-memory nodes Geoff Levand
2014-10-23 23:10   ` Geoff Levand
2014-10-24 10:54   ` Mark Rutland
2014-10-24 10:54     ` Mark Rutland
2014-10-24 11:04     ` Grant Likely
2014-10-24 11:04       ` Grant Likely
2014-10-24 12:18       ` Mark Rutland
2014-10-24 12:18         ` Mark Rutland
2014-10-24 13:54         ` Grant Likely
2014-10-24 13:54           ` Grant Likely
2014-10-24 14:10           ` Mark Rutland
2014-10-24 14:10             ` Mark Rutland
2014-10-24 14:47             ` Grant Likely
2014-10-24 14:47               ` Grant Likely
2014-10-23 23:10 ` [PATCH 02/10] arm64: Convert hcalls to use ISS field Geoff Levand
2014-10-23 23:10   ` Geoff Levand
2014-10-23 23:10 ` [PATCH 10/10] arm64/kexec: Add pr_devel output Geoff Levand
2014-10-23 23:10   ` Geoff Levand
2014-10-23 23:10 ` [PATCH 09/10] arm64/kexec: Enable kexec in the arm64 defconfig Geoff Levand
2014-10-23 23:10   ` Geoff Levand
2014-10-24 10:31   ` Mark Rutland
2014-10-24 10:31     ` Mark Rutland
2014-10-31 23:50     ` Geoff Levand
2014-10-31 23:50       ` Geoff Levand
2014-11-03 20:05       ` Mark Rutland
2014-11-03 20:05         ` Mark Rutland
2014-11-04  1:49         ` Geoff Levand
2014-11-04  1:49           ` Geoff Levand
2014-10-31  7:52 ` Dave Young [this message]
2014-10-31  7:52   ` [PATCH 00/10] arm64 kexec kernel patches V5 Dave Young
2014-10-31 23:25   ` Geoff Levand
2014-10-31 23:25     ` Geoff Levand
2014-11-06  2:01     ` Dave Young
2014-11-06  2:01       ` Dave Young
2014-11-13  8:37     ` Dave Young
2014-11-13  8:37       ` Dave Young
2014-11-13 23:50       ` Geoff Levand
2014-11-13 23:50         ` Geoff Levand
2014-11-17  3:49         ` Dave Young
2014-11-17  3:49           ` Dave Young
2014-11-03 19:46   ` Mark Rutland
2014-11-03 19:46     ` Mark Rutland
2014-11-06  1:56     ` Dave Young
2014-11-06  1:56       ` Dave Young
2014-11-06 15:08       ` Mark Rutland
2014-11-06 15:08         ` Mark Rutland
2014-11-07  0:41         ` Grant Likely
2014-11-07  0:41           ` Grant Likely
2014-11-07 10:16           ` Mark Rutland
2014-11-07 10:16             ` Mark Rutland
2014-11-07 10:41             ` Ard Biesheuvel
2014-11-07 10:41               ` Ard Biesheuvel
2014-11-07 10:45               ` Ard Biesheuvel
2014-11-07 10:45                 ` Ard Biesheuvel
2014-11-07 10:46                 ` Ard Biesheuvel
2014-11-07 10:46                   ` Ard Biesheuvel
2014-11-07 11:35               ` Mark Rutland
2014-11-07 11:35                 ` Mark Rutland
2014-11-07 11:42                 ` Ard Biesheuvel
2014-11-07 11:42                   ` Ard Biesheuvel
2014-11-07 22:34                 ` Grant Likely
2014-11-07 22:34                   ` Grant Likely
2014-11-06 12:16 ` Arun Chandran
2014-11-06 12:16   ` Arun Chandran
2014-11-06 15:28   ` Mark Rutland
2014-11-06 15:28     ` Mark Rutland
2014-11-06 16:13     ` Arun Chandran
2014-11-06 16:13       ` Arun Chandran
2014-11-06 18:25       ` Geoff Levand
2014-11-06 18:25         ` Geoff Levand
2014-11-07  6:26         ` Arun Chandran
2014-11-07  6:26           ` Arun Chandran
2014-11-06 18:39       ` Mark Rutland
2014-11-06 18:39         ` Mark Rutland
2014-11-07  6:36         ` Arun Chandran
2014-11-07  6:36           ` Arun Chandran
2014-11-10  7:17       ` Dave Young
2014-11-10  7:17         ` Dave Young
2014-11-10  8:35         ` Arun Chandran
2014-11-10  8:35           ` Arun Chandran
2014-11-10  9:24           ` Dave Young
2014-11-10  9:24             ` Dave Young
2014-11-12  9:56           ` Dave Young
2014-11-12  9:56             ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141031075209.GH3290@darkstar.nay.redhat.com \
    --to=dyoung@redhat.com \
    --cc=catalin.marinas@arm.com \
    --cc=christoffer.dall@linaro.org \
    --cc=geoff@infradead.org \
    --cc=grant.likely@linaro.org \
    --cc=kexec@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marc.zyngier@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.