From: Mark Brown <broonie@kernel.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH v5 3/4] regulator: max77686: Add suspend disable for some LDOs
Date: Tue, 28 Oct 2014 22:31:21 +0000 [thread overview]
Message-ID: <20141028223121.GH18557@sirena.org.uk> (raw)
In-Reply-To: <1414411911-5539-4-git-send-email-k.kozlowski@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 559 bytes --]
On Mon, Oct 27, 2014 at 01:11:49PM +0100, Krzysztof Kozlowski wrote:
> @@ -247,6 +250,8 @@ static struct regulator_ops max77686_ldo_ops = {
> .set_voltage_sel = regulator_set_voltage_sel_regmap,
> .set_voltage_time_sel = regulator_set_voltage_time_sel,
> .set_suspend_mode = max77686_ldo_set_suspend_mode,
> + .set_suspend_disable = max77686_set_suspend_disable,
> + .set_suspend_enable = max77686_enable,
This looks wrong, you're using the regular enable operation as suspend
enable. How does that work without disrupting the current runtime
state?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 3/4] regulator: max77686: Add suspend disable for some LDOs
Date: Tue, 28 Oct 2014 22:31:21 +0000 [thread overview]
Message-ID: <20141028223121.GH18557@sirena.org.uk> (raw)
In-Reply-To: <1414411911-5539-4-git-send-email-k.kozlowski@samsung.com>
On Mon, Oct 27, 2014 at 01:11:49PM +0100, Krzysztof Kozlowski wrote:
> @@ -247,6 +250,8 @@ static struct regulator_ops max77686_ldo_ops = {
> .set_voltage_sel = regulator_set_voltage_sel_regmap,
> .set_voltage_time_sel = regulator_set_voltage_time_sel,
> .set_suspend_mode = max77686_ldo_set_suspend_mode,
> + .set_suspend_disable = max77686_set_suspend_disable,
> + .set_suspend_enable = max77686_enable,
This looks wrong, you're using the regular enable operation as suspend
enable. How does that work without disrupting the current runtime
state?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141028/0fc88ae1/attachment.sig>
next prev parent reply other threads:[~2014-10-28 22:31 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 12:11 [PATCH v5 0/4] regulator: max77686/trats2: Disable some regulators in suspend Krzysztof Kozlowski
2014-10-27 12:11 ` Krzysztof Kozlowski
2014-10-27 12:11 ` Krzysztof Kozlowski
[not found] ` <1414411911-5539-1-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-10-27 12:11 ` [PATCH v5 1/4] regulator: max77686: Replace hard-coded opmode values with defines Krzysztof Kozlowski
2014-10-27 12:11 ` Krzysztof Kozlowski
2014-10-27 12:11 ` Krzysztof Kozlowski
2014-10-28 22:32 ` Mark Brown
2014-10-28 22:32 ` Mark Brown
2014-10-27 12:11 ` [PATCH v5 2/4] regulator: max77686: Store opmode non-shifted Krzysztof Kozlowski
2014-10-27 12:11 ` Krzysztof Kozlowski
2014-10-27 12:11 ` Krzysztof Kozlowski
2014-10-27 13:37 ` Javier Martinez Canillas
2014-10-27 13:37 ` Javier Martinez Canillas
2014-10-27 13:45 ` Krzysztof Kozlowski
2014-10-27 13:45 ` Krzysztof Kozlowski
2014-10-28 22:32 ` Mark Brown
2014-10-28 22:32 ` Mark Brown
2014-10-27 12:11 ` [PATCH v5 4/4] ARM: dts: exynos4412-trats: Add suspend configuration for max77686 regulators Krzysztof Kozlowski
2014-10-27 12:11 ` Krzysztof Kozlowski
2014-10-27 12:11 ` Krzysztof Kozlowski
2014-10-27 12:11 ` [PATCH v5 3/4] regulator: max77686: Add suspend disable for some LDOs Krzysztof Kozlowski
2014-10-27 12:11 ` Krzysztof Kozlowski
2014-10-27 13:39 ` Javier Martinez Canillas
2014-10-27 13:39 ` Javier Martinez Canillas
2014-10-28 22:31 ` Mark Brown [this message]
2014-10-28 22:31 ` Mark Brown
2014-10-29 9:20 ` Krzysztof Kozlowski
2014-10-29 9:20 ` Krzysztof Kozlowski
2014-10-29 10:01 ` Mark Brown
2014-10-29 10:01 ` Mark Brown
2014-10-29 10:18 ` Krzysztof Kozlowski
2014-10-29 10:18 ` Krzysztof Kozlowski
2014-10-29 10:31 ` Mark Brown
2014-10-29 10:31 ` Mark Brown
2014-10-29 10:44 ` Krzysztof Kozlowski
2014-10-29 10:44 ` Krzysztof Kozlowski
2014-10-29 10:51 ` Javier Martinez Canillas
2014-10-29 10:51 ` Javier Martinez Canillas
[not found] ` <5450C6C2.2050506-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2014-10-29 10:53 ` Krzysztof Kozlowski
2014-10-29 10:53 ` Krzysztof Kozlowski
2014-10-29 10:53 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141028223121.GH18557@sirena.org.uk \
--to=broonie@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=ben-linux@fluff.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=javier.martinez@collabora.co.uk \
--cc=k.kozlowski@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.