From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH v5 3/4] regulator: max77686: Add suspend disable for some LDOs
Date: Wed, 29 Oct 2014 11:51:46 +0100 [thread overview]
Message-ID: <5450C6C2.2050506@collabora.co.uk> (raw)
In-Reply-To: <1414579442.18868.13.camel@AMDC1943>
Hello Krzysztof,
On 10/29/2014 11:44 AM, Krzysztof Kozlowski wrote:
> On śro, 2014-10-29 at 10:31 +0000, Mark Brown wrote:
>> On Wed, Oct 29, 2014 at 11:18:54AM +0100, Krzysztof Kozlowski wrote:
>> > On śro, 2014-10-29 at 10:01 +0000, Mark Brown wrote:
>>
>> > > No, this isn't suspend enable control - this is normal, standard enable
>> > > control and the device has no suspend enable control.
>>
>> > You mean that for such regulator the driver shouldn't implement
>> > suspend_enable()?
>>
>> Yes, if there is no separate control of suspend mode in hardware then of
>> course the driver shouldn't implement operations for things it doesn't
>> have.
>
> Oh, thanks! I'll send fixed patch.
>
> This means that probably the max77802 ("mirrored" driver) should be
> fixed...
>
Indeed, I had the same confusion that you had. Just to avoid duplicating work,
do you want me to send a fix or are you going to include one on your series?
> Best regards,
> Krzysztof
>
>
Best regards,
Javier
WARNING: multiple messages have this Message-ID (diff)
From: javier.martinez@collabora.co.uk (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 3/4] regulator: max77686: Add suspend disable for some LDOs
Date: Wed, 29 Oct 2014 11:51:46 +0100 [thread overview]
Message-ID: <5450C6C2.2050506@collabora.co.uk> (raw)
In-Reply-To: <1414579442.18868.13.camel@AMDC1943>
Hello Krzysztof,
On 10/29/2014 11:44 AM, Krzysztof Kozlowski wrote:
> On ?ro, 2014-10-29 at 10:31 +0000, Mark Brown wrote:
>> On Wed, Oct 29, 2014 at 11:18:54AM +0100, Krzysztof Kozlowski wrote:
>> > On ?ro, 2014-10-29 at 10:01 +0000, Mark Brown wrote:
>>
>> > > No, this isn't suspend enable control - this is normal, standard enable
>> > > control and the device has no suspend enable control.
>>
>> > You mean that for such regulator the driver shouldn't implement
>> > suspend_enable()?
>>
>> Yes, if there is no separate control of suspend mode in hardware then of
>> course the driver shouldn't implement operations for things it doesn't
>> have.
>
> Oh, thanks! I'll send fixed patch.
>
> This means that probably the max77802 ("mirrored" driver) should be
> fixed...
>
Indeed, I had the same confusion that you had. Just to avoid duplicating work,
do you want me to send a fix or are you going to include one on your series?
> Best regards,
> Krzysztof
>
>
Best regards,
Javier
next prev parent reply other threads:[~2014-10-29 10:51 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 12:11 [PATCH v5 0/4] regulator: max77686/trats2: Disable some regulators in suspend Krzysztof Kozlowski
2014-10-27 12:11 ` Krzysztof Kozlowski
2014-10-27 12:11 ` Krzysztof Kozlowski
[not found] ` <1414411911-5539-1-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-10-27 12:11 ` [PATCH v5 1/4] regulator: max77686: Replace hard-coded opmode values with defines Krzysztof Kozlowski
2014-10-27 12:11 ` Krzysztof Kozlowski
2014-10-27 12:11 ` Krzysztof Kozlowski
2014-10-28 22:32 ` Mark Brown
2014-10-28 22:32 ` Mark Brown
2014-10-27 12:11 ` [PATCH v5 2/4] regulator: max77686: Store opmode non-shifted Krzysztof Kozlowski
2014-10-27 12:11 ` Krzysztof Kozlowski
2014-10-27 12:11 ` Krzysztof Kozlowski
2014-10-27 13:37 ` Javier Martinez Canillas
2014-10-27 13:37 ` Javier Martinez Canillas
2014-10-27 13:45 ` Krzysztof Kozlowski
2014-10-27 13:45 ` Krzysztof Kozlowski
2014-10-28 22:32 ` Mark Brown
2014-10-28 22:32 ` Mark Brown
2014-10-27 12:11 ` [PATCH v5 4/4] ARM: dts: exynos4412-trats: Add suspend configuration for max77686 regulators Krzysztof Kozlowski
2014-10-27 12:11 ` Krzysztof Kozlowski
2014-10-27 12:11 ` Krzysztof Kozlowski
2014-10-27 12:11 ` [PATCH v5 3/4] regulator: max77686: Add suspend disable for some LDOs Krzysztof Kozlowski
2014-10-27 12:11 ` Krzysztof Kozlowski
2014-10-27 13:39 ` Javier Martinez Canillas
2014-10-27 13:39 ` Javier Martinez Canillas
2014-10-28 22:31 ` Mark Brown
2014-10-28 22:31 ` Mark Brown
2014-10-29 9:20 ` Krzysztof Kozlowski
2014-10-29 9:20 ` Krzysztof Kozlowski
2014-10-29 10:01 ` Mark Brown
2014-10-29 10:01 ` Mark Brown
2014-10-29 10:18 ` Krzysztof Kozlowski
2014-10-29 10:18 ` Krzysztof Kozlowski
2014-10-29 10:31 ` Mark Brown
2014-10-29 10:31 ` Mark Brown
2014-10-29 10:44 ` Krzysztof Kozlowski
2014-10-29 10:44 ` Krzysztof Kozlowski
2014-10-29 10:51 ` Javier Martinez Canillas [this message]
2014-10-29 10:51 ` Javier Martinez Canillas
[not found] ` <5450C6C2.2050506-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2014-10-29 10:53 ` Krzysztof Kozlowski
2014-10-29 10:53 ` Krzysztof Kozlowski
2014-10-29 10:53 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5450C6C2.2050506@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=b.zolnierkie@samsung.com \
--cc=ben-linux@fluff.org \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.