From: hch@infradead.org (Christoph Hellwig)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] tracing/syscalls: ignore numbers outside NR_syscalls' range
Date: Thu, 30 Oct 2014 01:26:06 -0700 [thread overview]
Message-ID: <20141030082606.GA7945@infradead.org> (raw)
In-Reply-To: <1414620418-29472-1-git-send-email-rabin@rab.in>
On Wed, Oct 29, 2014 at 11:06:58PM +0100, Rabin Vincent wrote:
> ARM has some private syscalls (for example, set_tls(2)) which lie
> outside the range of NR_syscalls. If any of these are called while
> syscall tracing is being performed, out-of-bounds array access will
> occur in the ftrace and perf sys_{enter,exit} handlers.
While this patch looks like good caution, having syscalls outside of
NR_syscalls seems like a receipe for a disaster. Can you try to fix
that issue as ell, please?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Rabin Vincent <rabin@rab.in>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] tracing/syscalls: ignore numbers outside NR_syscalls' range
Date: Thu, 30 Oct 2014 01:26:06 -0700 [thread overview]
Message-ID: <20141030082606.GA7945@infradead.org> (raw)
In-Reply-To: <1414620418-29472-1-git-send-email-rabin@rab.in>
On Wed, Oct 29, 2014 at 11:06:58PM +0100, Rabin Vincent wrote:
> ARM has some private syscalls (for example, set_tls(2)) which lie
> outside the range of NR_syscalls. If any of these are called while
> syscall tracing is being performed, out-of-bounds array access will
> occur in the ftrace and perf sys_{enter,exit} handlers.
While this patch looks like good caution, having syscalls outside of
NR_syscalls seems like a receipe for a disaster. Can you try to fix
that issue as ell, please?
next prev parent reply other threads:[~2014-10-30 8:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 22:06 [PATCH] tracing/syscalls: ignore numbers outside NR_syscalls' range Rabin Vincent
2014-10-29 22:06 ` Rabin Vincent
2014-10-30 8:26 ` Christoph Hellwig [this message]
2014-10-30 8:26 ` Christoph Hellwig
2014-10-30 10:18 ` Russell King - ARM Linux
2014-10-30 10:18 ` Russell King - ARM Linux
2014-10-30 11:10 ` Steven Rostedt
2014-10-30 11:10 ` Steven Rostedt
2014-10-30 11:14 ` Russell King - ARM Linux
2014-10-30 11:14 ` Russell King - ARM Linux
2014-10-30 11:30 ` Steven Rostedt
2014-10-30 11:30 ` Steven Rostedt
2014-10-30 11:35 ` Russell King - ARM Linux
2014-10-30 11:35 ` Russell King - ARM Linux
2014-11-03 17:08 ` Nathan Lynch
2014-11-03 17:08 ` Nathan Lynch
2014-11-03 17:58 ` Steven Rostedt
2014-11-03 17:58 ` Steven Rostedt
2014-10-30 11:52 ` Steven Rostedt
2014-10-30 11:52 ` Steven Rostedt
2014-10-30 11:55 ` Steven Rostedt
2014-10-30 11:55 ` Steven Rostedt
2014-10-31 10:01 ` Ingo Molnar
2014-10-31 10:01 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030082606.GA7945@infradead.org \
--to=hch@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.