From: Nathan_Lynch@mentor.com (Nathan Lynch)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] tracing/syscalls: ignore numbers outside NR_syscalls' range
Date: Mon, 3 Nov 2014 11:08:03 -0600 [thread overview]
Message-ID: <5457B673.1000409@mentor.com> (raw)
In-Reply-To: <20141030113523.GQ27405@n2100.arm.linux.org.uk>
On 10/30/2014 06:35 AM, Russell King - ARM Linux wrote:
> On Thu, Oct 30, 2014 at 07:30:28AM -0400, Steven Rostedt wrote:
>> On Thu, 30 Oct 2014 11:14:41 +0000
>> Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
>>
>>
>>> We have always had syscall number range of 0x900000 or so. The tracing
>>> design does not expect that. Therefore, the tracing design did not take
>>> account of ARM when it was created. Therefore, it's up to the tracing
>>> people to decide how to properly fit their ill-designed subsystem into
>>> one of the popular and well-established kernel architectures - or at
>>> least suggest a way to work around this issue.
>>>
>>
>>
>> Fine, lets define a MAX_SYSCALL_NR that is by default NR_syscalls, but
>> an architecture can override it.
>>
>> In trace_syscalls.c, where the checks are done, have this:
>>
>> #ifndef MAX_SYSCALL_NR
>> # define MAX_SYSCALL_NR NR_syscalls
>> #endif
>>
>> change all the checks to test against MAX_SYSCALL_NR instead of
>> NR_syscalls.
>>
>> Then in arch/arm/include/asm/syscall.h have:
>>
>> #define MAX_SYSCALL_NR 0xa00000
>>
>> or whatever would be the highest syscall number for ARM.
>
> Or do we just ignore the high "special" ARM syscalls and treat them (from
> the tracing point of view) as non-syscalls, avoiding the allocation of
> something around 1.2MB for the syscall bitmap. I really don't know, I
> don't use any of this tracing stuff, so it isn't something I care about.
>
> Maybe those who do use the facility should have an input here?
I checked strace and it knows about ARM's high syscalls. I wouldn't
want to go from casually using strace to digging deeper with ftrace only
to get the impression that syscalls are disappearing.
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Lynch <Nathan_Lynch@mentor.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Christoph Hellwig <hch@infradead.org>,
Rabin Vincent <rabin@rab.in>, Ingo Molnar <mingo@redhat.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] tracing/syscalls: ignore numbers outside NR_syscalls' range
Date: Mon, 3 Nov 2014 11:08:03 -0600 [thread overview]
Message-ID: <5457B673.1000409@mentor.com> (raw)
In-Reply-To: <20141030113523.GQ27405@n2100.arm.linux.org.uk>
On 10/30/2014 06:35 AM, Russell King - ARM Linux wrote:
> On Thu, Oct 30, 2014 at 07:30:28AM -0400, Steven Rostedt wrote:
>> On Thu, 30 Oct 2014 11:14:41 +0000
>> Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
>>
>>
>>> We have always had syscall number range of 0x900000 or so. The tracing
>>> design does not expect that. Therefore, the tracing design did not take
>>> account of ARM when it was created. Therefore, it's up to the tracing
>>> people to decide how to properly fit their ill-designed subsystem into
>>> one of the popular and well-established kernel architectures - or at
>>> least suggest a way to work around this issue.
>>>
>>
>>
>> Fine, lets define a MAX_SYSCALL_NR that is by default NR_syscalls, but
>> an architecture can override it.
>>
>> In trace_syscalls.c, where the checks are done, have this:
>>
>> #ifndef MAX_SYSCALL_NR
>> # define MAX_SYSCALL_NR NR_syscalls
>> #endif
>>
>> change all the checks to test against MAX_SYSCALL_NR instead of
>> NR_syscalls.
>>
>> Then in arch/arm/include/asm/syscall.h have:
>>
>> #define MAX_SYSCALL_NR 0xa00000
>>
>> or whatever would be the highest syscall number for ARM.
>
> Or do we just ignore the high "special" ARM syscalls and treat them (from
> the tracing point of view) as non-syscalls, avoiding the allocation of
> something around 1.2MB for the syscall bitmap. I really don't know, I
> don't use any of this tracing stuff, so it isn't something I care about.
>
> Maybe those who do use the facility should have an input here?
I checked strace and it knows about ARM's high syscalls. I wouldn't
want to go from casually using strace to digging deeper with ftrace only
to get the impression that syscalls are disappearing.
next prev parent reply other threads:[~2014-11-03 17:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 22:06 [PATCH] tracing/syscalls: ignore numbers outside NR_syscalls' range Rabin Vincent
2014-10-29 22:06 ` Rabin Vincent
2014-10-30 8:26 ` Christoph Hellwig
2014-10-30 8:26 ` Christoph Hellwig
2014-10-30 10:18 ` Russell King - ARM Linux
2014-10-30 10:18 ` Russell King - ARM Linux
2014-10-30 11:10 ` Steven Rostedt
2014-10-30 11:10 ` Steven Rostedt
2014-10-30 11:14 ` Russell King - ARM Linux
2014-10-30 11:14 ` Russell King - ARM Linux
2014-10-30 11:30 ` Steven Rostedt
2014-10-30 11:30 ` Steven Rostedt
2014-10-30 11:35 ` Russell King - ARM Linux
2014-10-30 11:35 ` Russell King - ARM Linux
2014-11-03 17:08 ` Nathan Lynch [this message]
2014-11-03 17:08 ` Nathan Lynch
2014-11-03 17:58 ` Steven Rostedt
2014-11-03 17:58 ` Steven Rostedt
2014-10-30 11:52 ` Steven Rostedt
2014-10-30 11:52 ` Steven Rostedt
2014-10-30 11:55 ` Steven Rostedt
2014-10-30 11:55 ` Steven Rostedt
2014-10-31 10:01 ` Ingo Molnar
2014-10-31 10:01 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5457B673.1000409@mentor.com \
--to=nathan_lynch@mentor.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.