From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] regulator: of: Add support for parsing microvolts for suspend state
Date: Mon, 3 Nov 2014 12:29:48 +0000 [thread overview]
Message-ID: <20141103122948.GI3815@sirena.org.uk> (raw)
In-Reply-To: <54549EA6.5060007@collabora.co.uk>
On Sat, Nov 01, 2014 at 09:49:42AM +0100, Javier Martinez Canillas wrote:
> On 11/01/2014 04:52 AM, Doug Anderson wrote:
> > +
> > of_node_put(suspend_np);
> > suspend_state = NULL;
> > suspend_np = NULL;
> Looks good to me.
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
If you're reviewing something please don't quote the entire patch, the
same rule applies as always - just include relevant context - and
especially don't include your one line of content at the very end of the
patch. Otherwise people have to page through the entire thing to find
what you've said (if they don't get fed up first).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141103/a691f5e7/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Doug Anderson <dianders@chromium.org>,
Heiko Stuebner <heiko@sntech.de>,
Chris Zhong <zyw@rock-chips.com>,
Andrew Bresticker <abrestic@chromium.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] regulator: of: Add support for parsing microvolts for suspend state
Date: Mon, 3 Nov 2014 12:29:48 +0000 [thread overview]
Message-ID: <20141103122948.GI3815@sirena.org.uk> (raw)
In-Reply-To: <54549EA6.5060007@collabora.co.uk>
[-- Attachment #1: Type: text/plain, Size: 644 bytes --]
On Sat, Nov 01, 2014 at 09:49:42AM +0100, Javier Martinez Canillas wrote:
> On 11/01/2014 04:52 AM, Doug Anderson wrote:
> > +
> > of_node_put(suspend_np);
> > suspend_state = NULL;
> > suspend_np = NULL;
> Looks good to me.
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
If you're reviewing something please don't quote the entire patch, the
same rule applies as always - just include relevant context - and
especially don't include your one line of content at the very end of the
patch. Otherwise people have to page through the entire thing to find
what you've said (if they don't get fed up first).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-11-03 12:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-01 3:52 [PATCH 1/2] regulator: Document binding for regulator suspend voltage Doug Anderson
2014-11-01 3:52 ` Doug Anderson
2014-11-01 3:52 ` Doug Anderson
2014-11-01 3:52 ` [PATCH 2/2] regulator: of: Add support for parsing microvolts for suspend state Doug Anderson
2014-11-01 3:52 ` Doug Anderson
2014-11-01 8:49 ` Javier Martinez Canillas
2014-11-01 8:49 ` Javier Martinez Canillas
2014-11-03 0:27 ` Chris Zhong
2014-11-03 0:27 ` Chris Zhong
2014-11-03 12:29 ` Mark Brown [this message]
2014-11-03 12:29 ` Mark Brown
2014-11-03 12:45 ` Javier Martinez Canillas
2014-11-03 12:45 ` Javier Martinez Canillas
2014-11-03 12:47 ` Mark Brown
2014-11-03 12:47 ` Mark Brown
2014-11-01 8:45 ` [PATCH 1/2] regulator: Document binding for regulator suspend voltage Javier Martinez Canillas
2014-11-01 8:45 ` Javier Martinez Canillas
2014-11-01 8:45 ` Javier Martinez Canillas
2014-11-03 0:27 ` Chris Zhong
2014-11-03 0:27 ` Chris Zhong
2014-11-03 0:27 ` Chris Zhong
2014-11-03 12:29 ` Mark Brown
2014-11-03 12:29 ` Mark Brown
2014-11-03 12:29 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103122948.GI3815@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.