From: javier.martinez@collabora.co.uk (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] regulator: of: Add support for parsing microvolts for suspend state
Date: Mon, 03 Nov 2014 13:45:15 +0100 [thread overview]
Message-ID: <545778DB.3030803@collabora.co.uk> (raw)
In-Reply-To: <20141103122948.GI3815@sirena.org.uk>
On 11/03/2014 01:29 PM, Mark Brown wrote:
>
> If you're reviewing something please don't quote the entire patch, the
> same rule applies as always - just include relevant context - and
> especially don't include your one line of content at the very end of the
> patch. Otherwise people have to page through the entire thing to find
> what you've said (if they don't get fed up first).
>
Yes, I usually add my {Review,Acked,Tested}-by tags at the end of the
commit message and remove the complete patch but since it was a 4-lines
patch I didn't think it was that bad.
Sorry about that, I will do it next time no matter the patch size.
Best regards,
Javier
WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Mark Brown <broonie@kernel.org>
Cc: Doug Anderson <dianders@chromium.org>,
Heiko Stuebner <heiko@sntech.de>,
Chris Zhong <zyw@rock-chips.com>,
Andrew Bresticker <abrestic@chromium.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] regulator: of: Add support for parsing microvolts for suspend state
Date: Mon, 03 Nov 2014 13:45:15 +0100 [thread overview]
Message-ID: <545778DB.3030803@collabora.co.uk> (raw)
In-Reply-To: <20141103122948.GI3815@sirena.org.uk>
On 11/03/2014 01:29 PM, Mark Brown wrote:
>
> If you're reviewing something please don't quote the entire patch, the
> same rule applies as always - just include relevant context - and
> especially don't include your one line of content at the very end of the
> patch. Otherwise people have to page through the entire thing to find
> what you've said (if they don't get fed up first).
>
Yes, I usually add my {Review,Acked,Tested}-by tags at the end of the
commit message and remove the complete patch but since it was a 4-lines
patch I didn't think it was that bad.
Sorry about that, I will do it next time no matter the patch size.
Best regards,
Javier
next prev parent reply other threads:[~2014-11-03 12:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-01 3:52 [PATCH 1/2] regulator: Document binding for regulator suspend voltage Doug Anderson
2014-11-01 3:52 ` Doug Anderson
2014-11-01 3:52 ` Doug Anderson
2014-11-01 3:52 ` [PATCH 2/2] regulator: of: Add support for parsing microvolts for suspend state Doug Anderson
2014-11-01 3:52 ` Doug Anderson
2014-11-01 8:49 ` Javier Martinez Canillas
2014-11-01 8:49 ` Javier Martinez Canillas
2014-11-03 0:27 ` Chris Zhong
2014-11-03 0:27 ` Chris Zhong
2014-11-03 12:29 ` Mark Brown
2014-11-03 12:29 ` Mark Brown
2014-11-03 12:45 ` Javier Martinez Canillas [this message]
2014-11-03 12:45 ` Javier Martinez Canillas
2014-11-03 12:47 ` Mark Brown
2014-11-03 12:47 ` Mark Brown
2014-11-01 8:45 ` [PATCH 1/2] regulator: Document binding for regulator suspend voltage Javier Martinez Canillas
2014-11-01 8:45 ` Javier Martinez Canillas
2014-11-01 8:45 ` Javier Martinez Canillas
2014-11-03 0:27 ` Chris Zhong
2014-11-03 0:27 ` Chris Zhong
2014-11-03 0:27 ` Chris Zhong
2014-11-03 12:29 ` Mark Brown
2014-11-03 12:29 ` Mark Brown
2014-11-03 12:29 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545778DB.3030803@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.