From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Chao Peng" <chao.p.peng@linux.intel.com>,
qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"Vadim Rozenfeld" <vrozenfe@redhat.com>,
"Laszlo Ersek" <lersek@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH] target-i386: add Intel AVX-512 support
Date: Mon, 3 Nov 2014 14:34:32 +0200 [thread overview]
Message-ID: <20141103123432.GA14587@redhat.com> (raw)
In-Reply-To: <5457679E.4030308@redhat.com>
On Mon, Nov 03, 2014 at 12:31:42PM +0100, Paolo Bonzini wrote:
>
> On 02/11/2014 11:19, Michael S. Tsirkin wrote:
> > > Add AVX512 feature bits, register definition and corresponding
> > > xsave/vmstate support.
> > >
> > > Signed-off-by: Chao Peng <chao.p.peng@linux.intel.com>
> >
> > Thanks!
> >
> > As this was first posted after soft freeze, please
> > resubmit after 2.2 is out.
> >
> > See schedule http://wiki.qemu.org/Planning/2.2
>
> Actually this is already in.
>
> While "Planning/2.2" says "all features should have patches posted on
> the mailing list", the actual page describing soft feature freeze is
> more lenient:
>
> By the date of the soft feature freeze, any non-trivial feature
> should have some code posted to the qemu-devel mailing list if it's
> targeting a given release. Major features, and in particular
> features with a high likelihood of breaking things, should already
> be in the process of being merged.
>
> This patch was fairly trivial, as it only adds a few memcpys and a
> subsection. Likelihood of breaking things is basically zero because
> AVX512 does not yet exist in silicon. Eduardo reviewed the patch
> promptly and agreed with putting it in 2.2, so that's what I did.
>
> Paolo
Oh that's fine.
I was not trying to argue, I didn't notice it was in
and thought I'm asked to merge it.
It's always a judgement call, I trust you did the right thing.
Thanks and sorry about the noise.
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, "Marcelo Tosatti" <mtosatti@redhat.com>,
qemu-devel@nongnu.org, "Vadim Rozenfeld" <vrozenfe@redhat.com>,
"Chao Peng" <chao.p.peng@linux.intel.com>,
"Laszlo Ersek" <lersek@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support
Date: Mon, 3 Nov 2014 14:34:32 +0200 [thread overview]
Message-ID: <20141103123432.GA14587@redhat.com> (raw)
In-Reply-To: <5457679E.4030308@redhat.com>
On Mon, Nov 03, 2014 at 12:31:42PM +0100, Paolo Bonzini wrote:
>
> On 02/11/2014 11:19, Michael S. Tsirkin wrote:
> > > Add AVX512 feature bits, register definition and corresponding
> > > xsave/vmstate support.
> > >
> > > Signed-off-by: Chao Peng <chao.p.peng@linux.intel.com>
> >
> > Thanks!
> >
> > As this was first posted after soft freeze, please
> > resubmit after 2.2 is out.
> >
> > See schedule http://wiki.qemu.org/Planning/2.2
>
> Actually this is already in.
>
> While "Planning/2.2" says "all features should have patches posted on
> the mailing list", the actual page describing soft feature freeze is
> more lenient:
>
> By the date of the soft feature freeze, any non-trivial feature
> should have some code posted to the qemu-devel mailing list if it's
> targeting a given release. Major features, and in particular
> features with a high likelihood of breaking things, should already
> be in the process of being merged.
>
> This patch was fairly trivial, as it only adds a few memcpys and a
> subsection. Likelihood of breaking things is basically zero because
> AVX512 does not yet exist in silicon. Eduardo reviewed the patch
> promptly and agreed with putting it in 2.2, so that's what I did.
>
> Paolo
Oh that's fine.
I was not trying to argue, I didn't notice it was in
and thought I'm asked to merge it.
It's always a judgement call, I trust you did the right thing.
Thanks and sorry about the noise.
--
MST
next prev parent reply other threads:[~2014-11-03 12:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 3:02 [PATCH] target-i386: add Intel AVX-512 support Chao Peng
2014-10-23 3:02 ` [Qemu-devel] " Chao Peng
2014-10-23 14:34 ` Paolo Bonzini
2014-10-23 14:34 ` [Qemu-devel] " Paolo Bonzini
2014-10-24 16:38 ` Eduardo Habkost
2014-10-24 16:38 ` Eduardo Habkost
2014-10-23 19:49 ` Eduardo Habkost
2014-10-23 19:49 ` Eduardo Habkost
2014-10-24 1:27 ` Chao Peng
2014-10-24 1:27 ` Chao Peng
2014-10-24 5:55 ` Paolo Bonzini
2014-10-24 5:55 ` Paolo Bonzini
2014-10-24 11:12 ` Eduardo Habkost
2014-10-24 11:12 ` Eduardo Habkost
2014-10-24 11:38 ` Paolo Bonzini
2014-10-24 11:38 ` Paolo Bonzini
2014-10-27 15:48 ` Eduardo Habkost
2014-10-27 15:48 ` Eduardo Habkost
2014-10-27 15:53 ` Paolo Bonzini
2014-10-27 15:53 ` Paolo Bonzini
2014-10-24 16:01 ` Eduardo Habkost
2014-10-24 16:01 ` Eduardo Habkost
2014-10-27 2:07 ` Chao Peng
2014-10-27 2:07 ` Chao Peng
2014-11-02 10:19 ` Michael S. Tsirkin
2014-11-02 10:19 ` [Qemu-devel] " Michael S. Tsirkin
2014-11-03 1:53 ` Chao Peng
2014-11-03 11:31 ` Paolo Bonzini
2014-11-03 11:31 ` [Qemu-devel] " Paolo Bonzini
2014-11-03 12:34 ` Michael S. Tsirkin [this message]
2014-11-03 12:34 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103123432.GA14587@redhat.com \
--to=mst@redhat.com \
--cc=afaerber@suse.de \
--cc=chao.p.peng@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=lersek@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vrozenfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.