From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Chao Peng" <chao.p.peng@linux.intel.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
"Michael S. Tsirkin" <mst@redhat.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"Vadim Rozenfeld" <vrozenfe@redhat.com>,
"Laszlo Ersek" <lersek@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support
Date: Fri, 24 Oct 2014 13:38:33 +0200 [thread overview]
Message-ID: <544A3A39.8050407@redhat.com> (raw)
In-Reply-To: <20141024111238.GG19316@thinpad.lan.raisama.net>
On 10/24/2014 01:12 PM, Eduardo Habkost wrote:
>> > I think we can keep the macros. The actual cleanup would be to have a
>> > single member for the 32 512-bit ZMM registers, instead of splitting
>> > xmm/ymmh/zmmh/zmm_hi16. This will get rid of the YMM_* and ZMM_*
>> > registers. However, we could not use simple memcpy()s to marshal in and
>> > out of the XSAVE data.
> Agreed. I don't mind keeping those macros in this patch, as this is just
> following the existing conventions in the code. Whatever we do to clean
> that up, we can do it later.
>
>> > We can do it in 2.2.
> You mean 2.3, or do you want to clean that up in this release?
I mean 2.3.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
qemu-devel@nongnu.org, "Vadim Rozenfeld" <vrozenfe@redhat.com>,
"Chao Peng" <chao.p.peng@linux.intel.com>,
"Laszlo Ersek" <lersek@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support
Date: Fri, 24 Oct 2014 13:38:33 +0200 [thread overview]
Message-ID: <544A3A39.8050407@redhat.com> (raw)
In-Reply-To: <20141024111238.GG19316@thinpad.lan.raisama.net>
On 10/24/2014 01:12 PM, Eduardo Habkost wrote:
>> > I think we can keep the macros. The actual cleanup would be to have a
>> > single member for the 32 512-bit ZMM registers, instead of splitting
>> > xmm/ymmh/zmmh/zmm_hi16. This will get rid of the YMM_* and ZMM_*
>> > registers. However, we could not use simple memcpy()s to marshal in and
>> > out of the XSAVE data.
> Agreed. I don't mind keeping those macros in this patch, as this is just
> following the existing conventions in the code. Whatever we do to clean
> that up, we can do it later.
>
>> > We can do it in 2.2.
> You mean 2.3, or do you want to clean that up in this release?
I mean 2.3.
Paolo
next prev parent reply other threads:[~2014-10-24 11:38 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 3:02 [PATCH] target-i386: add Intel AVX-512 support Chao Peng
2014-10-23 3:02 ` [Qemu-devel] " Chao Peng
2014-10-23 14:34 ` Paolo Bonzini
2014-10-23 14:34 ` [Qemu-devel] " Paolo Bonzini
2014-10-24 16:38 ` Eduardo Habkost
2014-10-24 16:38 ` Eduardo Habkost
2014-10-23 19:49 ` Eduardo Habkost
2014-10-23 19:49 ` Eduardo Habkost
2014-10-24 1:27 ` Chao Peng
2014-10-24 1:27 ` Chao Peng
2014-10-24 5:55 ` Paolo Bonzini
2014-10-24 5:55 ` Paolo Bonzini
2014-10-24 11:12 ` Eduardo Habkost
2014-10-24 11:12 ` Eduardo Habkost
2014-10-24 11:38 ` Paolo Bonzini [this message]
2014-10-24 11:38 ` Paolo Bonzini
2014-10-27 15:48 ` Eduardo Habkost
2014-10-27 15:48 ` Eduardo Habkost
2014-10-27 15:53 ` Paolo Bonzini
2014-10-27 15:53 ` Paolo Bonzini
2014-10-24 16:01 ` Eduardo Habkost
2014-10-24 16:01 ` Eduardo Habkost
2014-10-27 2:07 ` Chao Peng
2014-10-27 2:07 ` Chao Peng
2014-11-02 10:19 ` Michael S. Tsirkin
2014-11-02 10:19 ` [Qemu-devel] " Michael S. Tsirkin
2014-11-03 1:53 ` Chao Peng
2014-11-03 11:31 ` Paolo Bonzini
2014-11-03 11:31 ` [Qemu-devel] " Paolo Bonzini
2014-11-03 12:34 ` Michael S. Tsirkin
2014-11-03 12:34 ` [Qemu-devel] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544A3A39.8050407@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=chao.p.peng@linux.intel.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lersek@redhat.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vrozenfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.