Re: [PATCH 03/17] drm/tegra: dsi: Make FIFO depths host parameters

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2172 bytes --]

On Mon, Nov 03, 2014 at 12:20:24PM -0500, Sean Paul wrote:
> On Mon, Nov 3, 2014 at 4:27 AM, Thierry Reding <thierry.reding@gmail.com> wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > Rather than hardcoding them as macros, make the host and video FIFO
> > depths parameters so that they can be more easily adjusted if a new
> > generation of the Tegra SoC changes them.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> >  drivers/gpu/drm/tegra/dsi.c | 10 ++++++----
> >  1 file changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c
> > index f7874458926a..584b771d8b2f 100644
> > --- a/drivers/gpu/drm/tegra/dsi.c
> > +++ b/drivers/gpu/drm/tegra/dsi.c
> > @@ -26,9 +26,6 @@
> >  #include "dsi.h"
> >  #include "mipi-phy.h"
> >
> > -#define DSI_VIDEO_FIFO_DEPTH (1920 / 4)
> > -#define DSI_HOST_FIFO_DEPTH 64
> > -
> >  struct tegra_dsi {
> >         struct host1x_client client;
> >         struct tegra_output output;
> > @@ -54,6 +51,9 @@ struct tegra_dsi {
> >
> >         struct regulator *vdd;
> >         bool enabled;
> > +
> > +       unsigned int video_fifo_depth;
> > +       unsigned int host_fifo_depth;
> >  };
> >
> >  static inline struct tegra_dsi *
> > @@ -467,7 +467,7 @@ static int tegra_output_dsi_enable(struct tegra_output *output)
> >                 DSI_CONTROL_SOURCE(dc->pipe);
> >         tegra_dsi_writel(dsi, value, DSI_CONTROL);
> >
> > -       tegra_dsi_writel(dsi, DSI_VIDEO_FIFO_DEPTH, DSI_MAX_THRESHOLD);
> > +       tegra_dsi_writel(dsi, dsi->video_fifo_depth, DSI_MAX_THRESHOLD);
> >
> >         value = DSI_HOST_CONTROL_HS | DSI_HOST_CONTROL_CS |
> >                 DSI_HOST_CONTROL_ECC;
> > @@ -843,6 +843,8 @@ static int tegra_dsi_probe(struct platform_device *pdev)
> >                 return -ENOMEM;
> >
> >         dsi->output.dev = dsi->dev = &pdev->dev;
> > +       dsi->video_fifo_depth = 1920;
> 
> This is not functionally equivalent to what was previously being set
> (1920/4). Perhaps calling that out in the commit message might be
> appropriate?

Done.

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel