From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] mfd: MT6397: Add support for PMIC MT6397 MFD
Date: Tue, 18 Nov 2014 11:59:58 +0000 [thread overview]
Message-ID: <20141118115958.GY24004@x1> (raw)
In-Reply-To: <1416210027-5562-2-git-send-email-flora.fu@mediatek.com>
On Mon, 17 Nov 2014, Flora Fu wrote:
> Add core driver files for MT6397 MFD.
>
> Signed-off-by: Flora Fu <flora.fu@mediatek.com>
> ---
> drivers/mfd/Kconfig | 10 +
> drivers/mfd/Makefile | 1 +
> drivers/mfd/mt6397-core.c | 94 +++++++++
> drivers/mfd/mtk-pmic-wrap.h | 25 +++
> include/linux/mfd/mt6397/core.h | 27 +++
> include/linux/mfd/mt6397/registers.h | 362 +++++++++++++++++++++++++++++++++++
> 6 files changed, 519 insertions(+)
> create mode 100644 drivers/mfd/mt6397-core.c
> create mode 100644 drivers/mfd/mtk-pmic-wrap.h
> create mode 100644 include/linux/mfd/mt6397/core.h
> create mode 100644 include/linux/mfd/mt6397/registers.h
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 1456ea7..f0b3efc 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1318,6 +1318,16 @@ config MFD_STW481X
> in various ST Microelectronics and ST-Ericsson embedded
> Nomadik series.
>
> +config MFD_MT6397
> + tristate "MediaTek MT6397 PMIC Support"
> + select MFD_CORE
> + select IRQ_DOMAIN
> + help
> + Say yes here to add support for MediaTek MT6397 PMIC. This is
> + a Power Management IC. This driver provides common support for
> + accessing the device; additional drivers must be enabled in order
> + to use the functionality of the device.
> +
> menu "Multimedia Capabilities Port drivers"
> depends on ARCH_SA1100
>
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index 8bd54b1..7168193 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -177,3 +177,4 @@ obj-$(CONFIG_MFD_HI6421_PMIC) += hi6421-pmic-core.o
>
> intel-soc-pmic-objs := intel_soc_pmic_core.o intel_soc_pmic_crc.o
> obj-$(CONFIG_INTEL_SOC_PMIC) += intel-soc-pmic.o
> +obj-$(CONFIG_MFD_MT6397) += mt6397-core.o
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> new file mode 100644
> index 0000000..69cacdc
> --- /dev/null
> +++ b/drivers/mfd/mt6397-core.c
> @@ -0,0 +1,94 @@
> +/*
> + * Copyright (c) 2014 MediaTek Inc.
> + * Author: Flora.Fu <flora.fu@mediatek.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <linux/module.h>
> +#include <linux/mfd/core.h>
> +#include <linux/mfd/mt6397/core.h>
> +#include <linux/of_device.h>
> +#include "mtk-pmic-wrap.h"
> +
> +static struct mfd_cell mt6397_devs[] = {
const?
> + {
> + .name = "mt6397-clk",
> + .id = -1,
> + },
> + {
> + .name = "mt6397-rtc",
> + .id = -1,
> + },
> + {
> + .name = "mt6397-regulator",
> + .id = -1,
> + },
> + {
> + .name = "mt6397-codec",
> + .id = -1,
> + .of_compatible = "mediatek,mt6397-codec"
> + },
> +};
The .ids aren't requred here. Please remove them and put all of the
.names onto a single line, like this:
{ .name = "mt6397-clk" },
> +static int mt6397_probe(struct platform_device *pdev)
> +{
> + u32 ret;
> + struct mt6397_chip *mt6397;
> +
> + struct pmic_wrapper *wrp = dev_get_drvdata(pdev->dev.parent);
Where does this come from? This should be the top level parent.
> + mt6397 = devm_kzalloc(&pdev->dev,
> + sizeof(struct mt6397_chip), GFP_KERNEL);
sizeof(*mt6397)
> + if (!mt6397)
> + return -ENOMEM;
> +
> + mt6397->dev = &pdev->dev;
> + mt6397->regmap = wrp->regmap;
> + platform_set_drvdata(pdev, mt6397);
> +
> + ret = mfd_add_devices(mt6397->dev, -1, &mt6397_devs[0],
> + ARRAY_SIZE(mt6397_devs), NULL, 0, NULL);
> + if (ret < 0)
if (ret)
> + dev_err(mt6397->dev, "Failed to mfd_add_devices: %d\n", ret);
User doesn't care about kernel functions. Swap this out for something
for user friendly, "failed to add child devices".
> +
> + return ret;
> +}
> +
> +static int mt6397_remove(struct platform_device *pdev)
> +{
> + struct mt6397_chip *mt6397 = platform_get_drvdata(pdev);
> +
> + mfd_remove_devices(mt6397->dev);
> + return 0;
> +}
> +
> +static const struct of_device_id mt6397_of_match[] = {
> + { .compatible = "mediatek,mt6397" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, mt6397_of_match);
> +
> +static struct platform_driver mt6397_driver = {
> + .probe = mt6397_probe,
> + .remove = mt6397_remove,
> + .driver = {
> + .name = "mt6397",
> + .owner = THIS_MODULE,
Remove this, it's taken care of elsewhere.
> + .of_match_table = of_match_ptr(mt6397_of_match),
> + },
> +};
> +
> +module_platform_driver(mt6397_driver);
> +
> +MODULE_AUTHOR("Flora Fu <flora.fu@mediatek.com>");
> +MODULE_DESCRIPTION("Driver for MediaTek MT6397 PMIC");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:mt6397");
> diff --git a/drivers/mfd/mtk-pmic-wrap.h b/drivers/mfd/mtk-pmic-wrap.h
> new file mode 100644
> index 0000000..1557a9d
> --- /dev/null
> +++ b/drivers/mfd/mtk-pmic-wrap.h
> @@ -0,0 +1,25 @@
> +/*
> + * Copyright (c) 2014 MediaTek Inc.
> + * Author: Flora.Fu <flora.fu@mediatek.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
> +
> +#ifndef __MTK_PMIC_WRAP_H__
> +#define __MTK_PMIC_WRAP_H__
> +
> +struct pmic_wrapper {
> + struct platform_device *pdev;
> + void __iomem *pwrap_base;
> + void __iomem *pwrap_bridge_base;
> + struct regmap *regmap;
> +};
> +
> +#endif /* __MTK_PMIC_WRAP_H__ */
> diff --git a/include/linux/mfd/mt6397/core.h b/include/linux/mfd/mt6397/core.h
> new file mode 100644
> index 0000000..edf38c4
> --- /dev/null
> +++ b/include/linux/mfd/mt6397/core.h
> @@ -0,0 +1,27 @@
> +/*
> + * Copyright (c) 2014 MediaTek Inc.
> + * Author: Flora.Fu <flora.fu@mediatek.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
> +
> +#ifndef __MFD_MT6397_CORE_H__
> +#define __MFD_MT6397_CORE_H__
> +
> +struct mt6397_chip {
> + /* Device */
> + struct device *dev;
> +
> + /* Control interface */
> + struct regmap *regmap;
These two comments are unnecessary.
> +};
> +
> +#endif /* __MFD_MT6397_CORE_H__ */
> +
> diff --git a/include/linux/mfd/mt6397/registers.h b/include/linux/mfd/mt6397/registers.h
> new file mode 100644
> index 0000000..d1c4067
> --- /dev/null
> +++ b/include/linux/mfd/mt6397/registers.h
> @@ -0,0 +1,362 @@
> +/*
> +* Copyright (c) 2014 MediaTek Inc.
> +* Author: Flora.Fu <flora.fu@mediatek.com>
> +*
> +* This program is free software; you can redistribute it and/or modify
> +* it under the terms of the GNU General Public License version 2 as
> +* published by the Free Software Foundation.
> +*
> +* This program is distributed in the hope that it will be useful,
> +* but WITHOUT ANY WARRANTY; without even the implied warranty of
> +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +* GNU General Public License for more details.
> +*/
> +
> +#ifndef __MFD_MT6397_REGISTERS_H__
> +#define __MFD_MT6397_REGISTERS_H__
> +
> +/* PMIC Rgisters */
> +#define MT6397_CID 0x0100
Are these spaces or tabs? They should be tabs.
> +#define MT6397_TOP_CKPDN 0x0102
> +#define MT6397_TOP_CKPDN_SET 0x0104
> +#define MT6397_TOP_CKPDN_CLR 0x0106
> +#define MT6397_TOP_CKPDN2 0x0108
> +#define MT6397_TOP_CKPDN2_SET 0x010A
> +#define MT6397_TOP_CKPDN2_CLR 0x010C
> +#define MT6397_TOP_GPIO_CKPDN 0x010E
> +#define MT6397_TOP_RST_CON 0x0114
> +#define MT6397_WRP_CKPDN 0x011A
> +#define MT6397_WRP_RST_CON 0x0120
> +#define MT6397_TOP_RST_MISC 0x0126
> +#define MT6397_TOP_CKCON1 0x0128
> +#define MT6397_TOP_CKCON2 0x012A
> +#define MT6397_TOP_CKTST1 0x012C
> +#define MT6397_TOP_CKTST2 0x012E
> +#define MT6397_OC_DEG_EN 0x0130
> +#define MT6397_OC_CTL0 0x0132
> +#define MT6397_OC_CTL1 0x0134
> +#define MT6397_OC_CTL2 0x0136
> +#define MT6397_INT_RSV 0x0138
> +#define MT6397_TEST_CON0 0x013A
> +#define MT6397_TEST_CON1 0x013C
> +#define MT6397_STATUS0 0x013E
> +#define MT6397_STATUS1 0x0140
> +#define MT6397_PGSTATUS 0x0142
> +#define MT6397_CHRSTATUS 0x0144
> +#define MT6397_OCSTATUS0 0x0146
> +#define MT6397_OCSTATUS1 0x0148
> +#define MT6397_OCSTATUS2 0x014A
> +#define MT6397_HDMI_PAD_IE 0x014C
> +#define MT6397_TEST_OUT_L 0x014E
> +#define MT6397_TEST_OUT_H 0x0150
> +#define MT6397_TDSEL_CON 0x0152
> +#define MT6397_RDSEL_CON 0x0154
> +#define MT6397_GPIO_SMT_CON0 0x0156
> +#define MT6397_GPIO_SMT_CON1 0x0158
> +#define MT6397_GPIO_SMT_CON2 0x015A
> +#define MT6397_GPIO_SMT_CON3 0x015C
> +#define MT6397_DRV_CON0 0x015E
> +#define MT6397_DRV_CON1 0x0160
> +#define MT6397_DRV_CON2 0x0162
> +#define MT6397_DRV_CON3 0x0164
> +#define MT6397_DRV_CON4 0x0166
> +#define MT6397_DRV_CON5 0x0168
> +#define MT6397_DRV_CON6 0x016A
> +#define MT6397_DRV_CON7 0x016C
> +#define MT6397_DRV_CON8 0x016E
> +#define MT6397_DRV_CON9 0x0170
> +#define MT6397_DRV_CON10 0x0172
> +#define MT6397_DRV_CON11 0x0174
> +#define MT6397_DRV_CON12 0x0176
> +#define MT6397_INT_CON0 0x0178
> +#define MT6397_INT_CON1 0x017E
> +#define MT6397_INT_STATUS0 0x0184
> +#define MT6397_INT_STATUS1 0x0186
> +#define MT6397_FQMTR_CON0 0x0188
> +#define MT6397_FQMTR_CON1 0x018A
> +#define MT6397_FQMTR_CON2 0x018C
> +#define MT6397_EFUSE_DOUT_0_15 0x01C4
> +#define MT6397_EFUSE_DOUT_16_31 0x01C6
> +#define MT6397_EFUSE_DOUT_32_47 0x01C8
> +#define MT6397_EFUSE_DOUT_48_63 0x01CA
> +#define MT6397_SPI_CON 0x01CC
> +#define MT6397_TOP_CKPDN3 0x01CE
> +#define MT6397_TOP_CKCON3 0x01D4
> +#define MT6397_EFUSE_DOUT_64_79 0x01D6
> +#define MT6397_EFUSE_DOUT_80_95 0x01D8
> +#define MT6397_EFUSE_DOUT_96_111 0x01DA
> +#define MT6397_EFUSE_DOUT_112_127 0x01DC
> +#define MT6397_EFUSE_DOUT_128_143 0x01DE
> +#define MT6397_EFUSE_DOUT_144_159 0x01E0
> +#define MT6397_EFUSE_DOUT_160_175 0x01E2
> +#define MT6397_EFUSE_DOUT_176_191 0x01E4
> +#define MT6397_EFUSE_DOUT_192_207 0x01E6
> +#define MT6397_EFUSE_DOUT_208_223 0x01E8
> +#define MT6397_EFUSE_DOUT_224_239 0x01EA
> +#define MT6397_EFUSE_DOUT_240_255 0x01EC
> +#define MT6397_EFUSE_DOUT_256_271 0x01EE
> +#define MT6397_EFUSE_DOUT_272_287 0x01F0
> +#define MT6397_EFUSE_DOUT_288_303 0x01F2
> +#define MT6397_EFUSE_DOUT_304_319 0x01F4
> +#define MT6397_BUCK_CON0 0x0200
> +#define MT6397_BUCK_CON1 0x0202
> +#define MT6397_BUCK_CON2 0x0204
> +#define MT6397_BUCK_CON3 0x0206
> +#define MT6397_BUCK_CON4 0x0208
> +#define MT6397_BUCK_CON5 0x020A
> +#define MT6397_BUCK_CON6 0x020C
> +#define MT6397_BUCK_CON7 0x020E
> +#define MT6397_BUCK_CON8 0x0210
> +#define MT6397_BUCK_CON9 0x0212
> +#define MT6397_VCA15_CON0 0x0214
> +#define MT6397_VCA15_CON1 0x0216
> +#define MT6397_VCA15_CON2 0x0218
> +#define MT6397_VCA15_CON3 0x021A
> +#define MT6397_VCA15_CON4 0x021C
> +#define MT6397_VCA15_CON5 0x021E
> +#define MT6397_VCA15_CON6 0x0220
> +#define MT6397_VCA15_CON7 0x0222
> +#define MT6397_VCA15_CON8 0x0224
> +#define MT6397_VCA15_CON9 0x0226
> +#define MT6397_VCA15_CON10 0x0228
> +#define MT6397_VCA15_CON11 0x022A
> +#define MT6397_VCA15_CON12 0x022C
> +#define MT6397_VCA15_CON13 0x022E
> +#define MT6397_VCA15_CON14 0x0230
> +#define MT6397_VCA15_CON15 0x0232
> +#define MT6397_VCA15_CON16 0x0234
> +#define MT6397_VCA15_CON17 0x0236
> +#define MT6397_VCA15_CON18 0x0238
> +#define MT6397_VSRMCA15_CON0 0x023A
> +#define MT6397_VSRMCA15_CON1 0x023C
> +#define MT6397_VSRMCA15_CON2 0x023E
> +#define MT6397_VSRMCA15_CON3 0x0240
> +#define MT6397_VSRMCA15_CON4 0x0242
> +#define MT6397_VSRMCA15_CON5 0x0244
> +#define MT6397_VSRMCA15_CON6 0x0246
> +#define MT6397_VSRMCA15_CON7 0x0248
> +#define MT6397_VSRMCA15_CON8 0x024A
> +#define MT6397_VSRMCA15_CON9 0x024C
> +#define MT6397_VSRMCA15_CON10 0x024E
> +#define MT6397_VSRMCA15_CON11 0x0250
> +#define MT6397_VSRMCA15_CON12 0x0252
> +#define MT6397_VSRMCA15_CON13 0x0254
> +#define MT6397_VSRMCA15_CON14 0x0256
> +#define MT6397_VSRMCA15_CON15 0x0258
> +#define MT6397_VSRMCA15_CON16 0x025A
> +#define MT6397_VSRMCA15_CON17 0x025C
> +#define MT6397_VSRMCA15_CON18 0x025E
> +#define MT6397_VSRMCA15_CON19 0x0260
> +#define MT6397_VSRMCA15_CON20 0x0262
> +#define MT6397_VSRMCA15_CON21 0x0264
> +#define MT6397_VCORE_CON0 0x0266
> +#define MT6397_VCORE_CON1 0x0268
> +#define MT6397_VCORE_CON2 0x026A
> +#define MT6397_VCORE_CON3 0x026C
> +#define MT6397_VCORE_CON4 0x026E
> +#define MT6397_VCORE_CON5 0x0270
> +#define MT6397_VCORE_CON6 0x0272
> +#define MT6397_VCORE_CON7 0x0274
> +#define MT6397_VCORE_CON8 0x0276
> +#define MT6397_VCORE_CON9 0x0278
> +#define MT6397_VCORE_CON10 0x027A
> +#define MT6397_VCORE_CON11 0x027C
> +#define MT6397_VCORE_CON12 0x027E
> +#define MT6397_VCORE_CON13 0x0280
> +#define MT6397_VCORE_CON14 0x0282
> +#define MT6397_VCORE_CON15 0x0284
> +#define MT6397_VCORE_CON16 0x0286
> +#define MT6397_VCORE_CON17 0x0288
> +#define MT6397_VCORE_CON18 0x028A
> +#define MT6397_VGPU_CON0 0x028C
> +#define MT6397_VGPU_CON1 0x028E
> +#define MT6397_VGPU_CON2 0x0290
> +#define MT6397_VGPU_CON3 0x0292
> +#define MT6397_VGPU_CON4 0x0294
> +#define MT6397_VGPU_CON5 0x0296
> +#define MT6397_VGPU_CON6 0x0298
> +#define MT6397_VGPU_CON7 0x029A
> +#define MT6397_VGPU_CON8 0x029C
> +#define MT6397_VGPU_CON9 0x029E
> +#define MT6397_VGPU_CON10 0x02A0
> +#define MT6397_VGPU_CON11 0x02A2
> +#define MT6397_VGPU_CON12 0x02A4
> +#define MT6397_VGPU_CON13 0x02A6
> +#define MT6397_VGPU_CON14 0x02A8
> +#define MT6397_VGPU_CON15 0x02AA
> +#define MT6397_VGPU_CON16 0x02AC
> +#define MT6397_VGPU_CON17 0x02AE
> +#define MT6397_VGPU_CON18 0x02B0
> +#define MT6397_VIO18_CON0 0x0300
> +#define MT6397_VIO18_CON1 0x0302
> +#define MT6397_VIO18_CON2 0x0304
> +#define MT6397_VIO18_CON3 0x0306
> +#define MT6397_VIO18_CON4 0x0308
> +#define MT6397_VIO18_CON5 0x030A
> +#define MT6397_VIO18_CON6 0x030C
> +#define MT6397_VIO18_CON7 0x030E
> +#define MT6397_VIO18_CON8 0x0310
> +#define MT6397_VIO18_CON9 0x0312
> +#define MT6397_VIO18_CON10 0x0314
> +#define MT6397_VIO18_CON11 0x0316
> +#define MT6397_VIO18_CON12 0x0318
> +#define MT6397_VIO18_CON13 0x031A
> +#define MT6397_VIO18_CON14 0x031C
> +#define MT6397_VIO18_CON15 0x031E
> +#define MT6397_VIO18_CON16 0x0320
> +#define MT6397_VIO18_CON17 0x0322
> +#define MT6397_VIO18_CON18 0x0324
> +#define MT6397_VPCA7_CON0 0x0326
> +#define MT6397_VPCA7_CON1 0x0328
> +#define MT6397_VPCA7_CON2 0x032A
> +#define MT6397_VPCA7_CON3 0x032C
> +#define MT6397_VPCA7_CON4 0x032E
> +#define MT6397_VPCA7_CON5 0x0330
> +#define MT6397_VPCA7_CON6 0x0332
> +#define MT6397_VPCA7_CON7 0x0334
> +#define MT6397_VPCA7_CON8 0x0336
> +#define MT6397_VPCA7_CON9 0x0338
> +#define MT6397_VPCA7_CON10 0x033A
> +#define MT6397_VPCA7_CON11 0x033C
> +#define MT6397_VPCA7_CON12 0x033E
> +#define MT6397_VPCA7_CON13 0x0340
> +#define MT6397_VPCA7_CON14 0x0342
> +#define MT6397_VPCA7_CON15 0x0344
> +#define MT6397_VPCA7_CON16 0x0346
> +#define MT6397_VPCA7_CON17 0x0348
> +#define MT6397_VPCA7_CON18 0x034A
> +#define MT6397_VSRMCA7_CON0 0x034C
> +#define MT6397_VSRMCA7_CON1 0x034E
> +#define MT6397_VSRMCA7_CON2 0x0350
> +#define MT6397_VSRMCA7_CON3 0x0352
> +#define MT6397_VSRMCA7_CON4 0x0354
> +#define MT6397_VSRMCA7_CON5 0x0356
> +#define MT6397_VSRMCA7_CON6 0x0358
> +#define MT6397_VSRMCA7_CON7 0x035A
> +#define MT6397_VSRMCA7_CON8 0x035C
> +#define MT6397_VSRMCA7_CON9 0x035E
> +#define MT6397_VSRMCA7_CON10 0x0360
> +#define MT6397_VSRMCA7_CON11 0x0362
> +#define MT6397_VSRMCA7_CON12 0x0364
> +#define MT6397_VSRMCA7_CON13 0x0366
> +#define MT6397_VSRMCA7_CON14 0x0368
> +#define MT6397_VSRMCA7_CON15 0x036A
> +#define MT6397_VSRMCA7_CON16 0x036C
> +#define MT6397_VSRMCA7_CON17 0x036E
> +#define MT6397_VSRMCA7_CON18 0x0370
> +#define MT6397_VSRMCA7_CON19 0x0372
> +#define MT6397_VSRMCA7_CON20 0x0374
> +#define MT6397_VSRMCA7_CON21 0x0376
> +#define MT6397_VDRM_CON0 0x0378
> +#define MT6397_VDRM_CON1 0x037A
> +#define MT6397_VDRM_CON2 0x037C
> +#define MT6397_VDRM_CON3 0x037E
> +#define MT6397_VDRM_CON4 0x0380
> +#define MT6397_VDRM_CON5 0x0382
> +#define MT6397_VDRM_CON6 0x0384
> +#define MT6397_VDRM_CON7 0x0386
> +#define MT6397_VDRM_CON8 0x0388
> +#define MT6397_VDRM_CON9 0x038A
> +#define MT6397_VDRM_CON10 0x038C
> +#define MT6397_VDRM_CON11 0x038E
> +#define MT6397_VDRM_CON12 0x0390
> +#define MT6397_VDRM_CON13 0x0392
> +#define MT6397_VDRM_CON14 0x0394
> +#define MT6397_VDRM_CON15 0x0396
> +#define MT6397_VDRM_CON16 0x0398
> +#define MT6397_VDRM_CON17 0x039A
> +#define MT6397_VDRM_CON18 0x039C
> +#define MT6397_BUCK_K_CON0 0x039E
> +#define MT6397_BUCK_K_CON1 0x03A0
> +#define MT6397_ANALDO_CON0 0x0400
> +#define MT6397_ANALDO_CON1 0x0402
> +#define MT6397_ANALDO_CON2 0x0404
> +#define MT6397_ANALDO_CON3 0x0406
> +#define MT6397_ANALDO_CON4 0x0408
> +#define MT6397_ANALDO_CON5 0x040A
> +#define MT6397_ANALDO_CON6 0x040C
> +#define MT6397_ANALDO_CON7 0x040E
> +#define MT6397_DIGLDO_CON0 0x0410
> +#define MT6397_DIGLDO_CON1 0x0412
> +#define MT6397_DIGLDO_CON2 0x0414
> +#define MT6397_DIGLDO_CON3 0x0416
> +#define MT6397_DIGLDO_CON4 0x0418
> +#define MT6397_DIGLDO_CON5 0x041A
> +#define MT6397_DIGLDO_CON6 0x041C
> +#define MT6397_DIGLDO_CON7 0x041E
> +#define MT6397_DIGLDO_CON8 0x0420
> +#define MT6397_DIGLDO_CON9 0x0422
> +#define MT6397_DIGLDO_CON10 0x0424
> +#define MT6397_DIGLDO_CON11 0x0426
> +#define MT6397_DIGLDO_CON12 0x0428
> +#define MT6397_DIGLDO_CON13 0x042A
> +#define MT6397_DIGLDO_CON14 0x042C
> +#define MT6397_DIGLDO_CON15 0x042E
> +#define MT6397_DIGLDO_CON16 0x0430
> +#define MT6397_DIGLDO_CON17 0x0432
> +#define MT6397_DIGLDO_CON18 0x0434
> +#define MT6397_DIGLDO_CON19 0x0436
> +#define MT6397_DIGLDO_CON20 0x0438
> +#define MT6397_DIGLDO_CON21 0x043A
> +#define MT6397_DIGLDO_CON22 0x043C
> +#define MT6397_DIGLDO_CON23 0x043E
> +#define MT6397_DIGLDO_CON24 0x0440
> +#define MT6397_DIGLDO_CON25 0x0442
> +#define MT6397_DIGLDO_CON26 0x0444
> +#define MT6397_DIGLDO_CON27 0x0446
> +#define MT6397_DIGLDO_CON28 0x0448
> +#define MT6397_DIGLDO_CON29 0x044A
> +#define MT6397_DIGLDO_CON30 0x044C
> +#define MT6397_DIGLDO_CON31 0x044E
> +#define MT6397_DIGLDO_CON32 0x0450
> +#define MT6397_DIGLDO_CON33 0x045A
> +#define MT6397_SPK_CON0 0x0600
> +#define MT6397_SPK_CON1 0x0602
> +#define MT6397_SPK_CON2 0x0604
> +#define MT6397_SPK_CON3 0x0606
> +#define MT6397_SPK_CON4 0x0608
> +#define MT6397_SPK_CON5 0x060A
> +#define MT6397_SPK_CON6 0x060C
> +#define MT6397_SPK_CON7 0x060E
> +#define MT6397_SPK_CON8 0x0610
> +#define MT6397_SPK_CON9 0x0612
> +#define MT6397_SPK_CON10 0x0614
> +#define MT6397_SPK_CON11 0x0616
> +#define MT6397_AUDDAC_CON0 0x0700
> +#define MT6397_AUDBUF_CFG0 0x0702
> +#define MT6397_AUDBUF_CFG1 0x0704
> +#define MT6397_AUDBUF_CFG2 0x0706
> +#define MT6397_AUDBUF_CFG3 0x0708
> +#define MT6397_AUDBUF_CFG4 0x070A
> +#define MT6397_IBIASDIST_CFG0 0x070C
> +#define MT6397_AUDACCDEPOP_CFG0 0x070E
> +#define MT6397_AUD_IV_CFG0 0x0710
> +#define MT6397_AUDCLKGEN_CFG0 0x0712
> +#define MT6397_AUDLDO_CFG0 0x0714
> +#define MT6397_AUDLDO_CFG1 0x0716
> +#define MT6397_AUDNVREGGLB_CFG0 0x0718
> +#define MT6397_AUD_NCP0 0x071A
> +#define MT6397_AUDPREAMP_CON0 0x071C
> +#define MT6397_AUDADC_CON0 0x071E
> +#define MT6397_AUDADC_CON1 0x0720
> +#define MT6397_AUDADC_CON2 0x0722
> +#define MT6397_AUDADC_CON3 0x0724
> +#define MT6397_AUDADC_CON4 0x0726
> +#define MT6397_AUDADC_CON5 0x0728
> +#define MT6397_AUDADC_CON6 0x072A
> +#define MT6397_AUDDIGMI_CON0 0x072C
> +#define MT6397_AUDLSBUF_CON0 0x072E
> +#define MT6397_AUDLSBUF_CON1 0x0730
> +#define MT6397_AUDENCSPARE_CON0 0x0732
> +#define MT6397_AUDENCCLKSQ_CON0 0x0734
> +#define MT6397_AUDPREAMPGAIN_CON0 0x0736
> +#define MT6397_ZCD_CON0 0x0738
> +#define MT6397_ZCD_CON1 0x073A
> +#define MT6397_ZCD_CON2 0x073C
> +#define MT6397_ZCD_CON3 0x073E
> +#define MT6397_ZCD_CON4 0x0740
> +#define MT6397_ZCD_CON5 0x0742
> +#define MT6397_NCP_CLKDIV_CON0 0x0744
> +#define MT6397_NCP_CLKDIV_CON1 0x0746
> +
> +#endif /* __MFD_MT6397_REGISTERS_H__ */
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Flora Fu <flora.fu@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
Samuel Ortiz <sameo@linux.intel.com>,
Grant Likely <grant.likely@linaro.org>,
"Joe.C" <yingjoe.chen@mediatek.com>,
devicetree@vger.kernel.org,
Vladimir Murzin <vladimir.murzin@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Mark Brown <broonie@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Eddie Huang <eddie.huang@mediatek.com>,
linux-arm-kernel@lists.infradead.org,
Dongdong Cheng <dongdong.cheng@mediatek.com>,
srv_heupstream@mediatek.com, Liam Girdwood <lgirdwood@gmail.com>,
Ashwin Chaugule <ashwin.chaugule@linaro.org>,
Sascha Hauer <kernel@pengutronix.de>,
Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH 1/7] mfd: MT6397: Add support for PMIC MT6397 MFD
Date: Tue, 18 Nov 2014 11:59:58 +0000 [thread overview]
Message-ID: <20141118115958.GY24004@x1> (raw)
In-Reply-To: <1416210027-5562-2-git-send-email-flora.fu@mediatek.com>
On Mon, 17 Nov 2014, Flora Fu wrote:
> Add core driver files for MT6397 MFD.
>
> Signed-off-by: Flora Fu <flora.fu@mediatek.com>
> ---
> drivers/mfd/Kconfig | 10 +
> drivers/mfd/Makefile | 1 +
> drivers/mfd/mt6397-core.c | 94 +++++++++
> drivers/mfd/mtk-pmic-wrap.h | 25 +++
> include/linux/mfd/mt6397/core.h | 27 +++
> include/linux/mfd/mt6397/registers.h | 362 +++++++++++++++++++++++++++++++++++
> 6 files changed, 519 insertions(+)
> create mode 100644 drivers/mfd/mt6397-core.c
> create mode 100644 drivers/mfd/mtk-pmic-wrap.h
> create mode 100644 include/linux/mfd/mt6397/core.h
> create mode 100644 include/linux/mfd/mt6397/registers.h
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 1456ea7..f0b3efc 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1318,6 +1318,16 @@ config MFD_STW481X
> in various ST Microelectronics and ST-Ericsson embedded
> Nomadik series.
>
> +config MFD_MT6397
> + tristate "MediaTek MT6397 PMIC Support"
> + select MFD_CORE
> + select IRQ_DOMAIN
> + help
> + Say yes here to add support for MediaTek MT6397 PMIC. This is
> + a Power Management IC. This driver provides common support for
> + accessing the device; additional drivers must be enabled in order
> + to use the functionality of the device.
> +
> menu "Multimedia Capabilities Port drivers"
> depends on ARCH_SA1100
>
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index 8bd54b1..7168193 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -177,3 +177,4 @@ obj-$(CONFIG_MFD_HI6421_PMIC) += hi6421-pmic-core.o
>
> intel-soc-pmic-objs := intel_soc_pmic_core.o intel_soc_pmic_crc.o
> obj-$(CONFIG_INTEL_SOC_PMIC) += intel-soc-pmic.o
> +obj-$(CONFIG_MFD_MT6397) += mt6397-core.o
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> new file mode 100644
> index 0000000..69cacdc
> --- /dev/null
> +++ b/drivers/mfd/mt6397-core.c
> @@ -0,0 +1,94 @@
> +/*
> + * Copyright (c) 2014 MediaTek Inc.
> + * Author: Flora.Fu <flora.fu@mediatek.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <linux/module.h>
> +#include <linux/mfd/core.h>
> +#include <linux/mfd/mt6397/core.h>
> +#include <linux/of_device.h>
> +#include "mtk-pmic-wrap.h"
> +
> +static struct mfd_cell mt6397_devs[] = {
const?
> + {
> + .name = "mt6397-clk",
> + .id = -1,
> + },
> + {
> + .name = "mt6397-rtc",
> + .id = -1,
> + },
> + {
> + .name = "mt6397-regulator",
> + .id = -1,
> + },
> + {
> + .name = "mt6397-codec",
> + .id = -1,
> + .of_compatible = "mediatek,mt6397-codec"
> + },
> +};
The .ids aren't requred here. Please remove them and put all of the
.names onto a single line, like this:
{ .name = "mt6397-clk" },
> +static int mt6397_probe(struct platform_device *pdev)
> +{
> + u32 ret;
> + struct mt6397_chip *mt6397;
> +
> + struct pmic_wrapper *wrp = dev_get_drvdata(pdev->dev.parent);
Where does this come from? This should be the top level parent.
> + mt6397 = devm_kzalloc(&pdev->dev,
> + sizeof(struct mt6397_chip), GFP_KERNEL);
sizeof(*mt6397)
> + if (!mt6397)
> + return -ENOMEM;
> +
> + mt6397->dev = &pdev->dev;
> + mt6397->regmap = wrp->regmap;
> + platform_set_drvdata(pdev, mt6397);
> +
> + ret = mfd_add_devices(mt6397->dev, -1, &mt6397_devs[0],
> + ARRAY_SIZE(mt6397_devs), NULL, 0, NULL);
> + if (ret < 0)
if (ret)
> + dev_err(mt6397->dev, "Failed to mfd_add_devices: %d\n", ret);
User doesn't care about kernel functions. Swap this out for something
for user friendly, "failed to add child devices".
> +
> + return ret;
> +}
> +
> +static int mt6397_remove(struct platform_device *pdev)
> +{
> + struct mt6397_chip *mt6397 = platform_get_drvdata(pdev);
> +
> + mfd_remove_devices(mt6397->dev);
> + return 0;
> +}
> +
> +static const struct of_device_id mt6397_of_match[] = {
> + { .compatible = "mediatek,mt6397" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, mt6397_of_match);
> +
> +static struct platform_driver mt6397_driver = {
> + .probe = mt6397_probe,
> + .remove = mt6397_remove,
> + .driver = {
> + .name = "mt6397",
> + .owner = THIS_MODULE,
Remove this, it's taken care of elsewhere.
> + .of_match_table = of_match_ptr(mt6397_of_match),
> + },
> +};
> +
> +module_platform_driver(mt6397_driver);
> +
> +MODULE_AUTHOR("Flora Fu <flora.fu@mediatek.com>");
> +MODULE_DESCRIPTION("Driver for MediaTek MT6397 PMIC");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:mt6397");
> diff --git a/drivers/mfd/mtk-pmic-wrap.h b/drivers/mfd/mtk-pmic-wrap.h
> new file mode 100644
> index 0000000..1557a9d
> --- /dev/null
> +++ b/drivers/mfd/mtk-pmic-wrap.h
> @@ -0,0 +1,25 @@
> +/*
> + * Copyright (c) 2014 MediaTek Inc.
> + * Author: Flora.Fu <flora.fu@mediatek.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
> +
> +#ifndef __MTK_PMIC_WRAP_H__
> +#define __MTK_PMIC_WRAP_H__
> +
> +struct pmic_wrapper {
> + struct platform_device *pdev;
> + void __iomem *pwrap_base;
> + void __iomem *pwrap_bridge_base;
> + struct regmap *regmap;
> +};
> +
> +#endif /* __MTK_PMIC_WRAP_H__ */
> diff --git a/include/linux/mfd/mt6397/core.h b/include/linux/mfd/mt6397/core.h
> new file mode 100644
> index 0000000..edf38c4
> --- /dev/null
> +++ b/include/linux/mfd/mt6397/core.h
> @@ -0,0 +1,27 @@
> +/*
> + * Copyright (c) 2014 MediaTek Inc.
> + * Author: Flora.Fu <flora.fu@mediatek.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
> +
> +#ifndef __MFD_MT6397_CORE_H__
> +#define __MFD_MT6397_CORE_H__
> +
> +struct mt6397_chip {
> + /* Device */
> + struct device *dev;
> +
> + /* Control interface */
> + struct regmap *regmap;
These two comments are unnecessary.
> +};
> +
> +#endif /* __MFD_MT6397_CORE_H__ */
> +
> diff --git a/include/linux/mfd/mt6397/registers.h b/include/linux/mfd/mt6397/registers.h
> new file mode 100644
> index 0000000..d1c4067
> --- /dev/null
> +++ b/include/linux/mfd/mt6397/registers.h
> @@ -0,0 +1,362 @@
> +/*
> +* Copyright (c) 2014 MediaTek Inc.
> +* Author: Flora.Fu <flora.fu@mediatek.com>
> +*
> +* This program is free software; you can redistribute it and/or modify
> +* it under the terms of the GNU General Public License version 2 as
> +* published by the Free Software Foundation.
> +*
> +* This program is distributed in the hope that it will be useful,
> +* but WITHOUT ANY WARRANTY; without even the implied warranty of
> +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +* GNU General Public License for more details.
> +*/
> +
> +#ifndef __MFD_MT6397_REGISTERS_H__
> +#define __MFD_MT6397_REGISTERS_H__
> +
> +/* PMIC Rgisters */
> +#define MT6397_CID 0x0100
Are these spaces or tabs? They should be tabs.
> +#define MT6397_TOP_CKPDN 0x0102
> +#define MT6397_TOP_CKPDN_SET 0x0104
> +#define MT6397_TOP_CKPDN_CLR 0x0106
> +#define MT6397_TOP_CKPDN2 0x0108
> +#define MT6397_TOP_CKPDN2_SET 0x010A
> +#define MT6397_TOP_CKPDN2_CLR 0x010C
> +#define MT6397_TOP_GPIO_CKPDN 0x010E
> +#define MT6397_TOP_RST_CON 0x0114
> +#define MT6397_WRP_CKPDN 0x011A
> +#define MT6397_WRP_RST_CON 0x0120
> +#define MT6397_TOP_RST_MISC 0x0126
> +#define MT6397_TOP_CKCON1 0x0128
> +#define MT6397_TOP_CKCON2 0x012A
> +#define MT6397_TOP_CKTST1 0x012C
> +#define MT6397_TOP_CKTST2 0x012E
> +#define MT6397_OC_DEG_EN 0x0130
> +#define MT6397_OC_CTL0 0x0132
> +#define MT6397_OC_CTL1 0x0134
> +#define MT6397_OC_CTL2 0x0136
> +#define MT6397_INT_RSV 0x0138
> +#define MT6397_TEST_CON0 0x013A
> +#define MT6397_TEST_CON1 0x013C
> +#define MT6397_STATUS0 0x013E
> +#define MT6397_STATUS1 0x0140
> +#define MT6397_PGSTATUS 0x0142
> +#define MT6397_CHRSTATUS 0x0144
> +#define MT6397_OCSTATUS0 0x0146
> +#define MT6397_OCSTATUS1 0x0148
> +#define MT6397_OCSTATUS2 0x014A
> +#define MT6397_HDMI_PAD_IE 0x014C
> +#define MT6397_TEST_OUT_L 0x014E
> +#define MT6397_TEST_OUT_H 0x0150
> +#define MT6397_TDSEL_CON 0x0152
> +#define MT6397_RDSEL_CON 0x0154
> +#define MT6397_GPIO_SMT_CON0 0x0156
> +#define MT6397_GPIO_SMT_CON1 0x0158
> +#define MT6397_GPIO_SMT_CON2 0x015A
> +#define MT6397_GPIO_SMT_CON3 0x015C
> +#define MT6397_DRV_CON0 0x015E
> +#define MT6397_DRV_CON1 0x0160
> +#define MT6397_DRV_CON2 0x0162
> +#define MT6397_DRV_CON3 0x0164
> +#define MT6397_DRV_CON4 0x0166
> +#define MT6397_DRV_CON5 0x0168
> +#define MT6397_DRV_CON6 0x016A
> +#define MT6397_DRV_CON7 0x016C
> +#define MT6397_DRV_CON8 0x016E
> +#define MT6397_DRV_CON9 0x0170
> +#define MT6397_DRV_CON10 0x0172
> +#define MT6397_DRV_CON11 0x0174
> +#define MT6397_DRV_CON12 0x0176
> +#define MT6397_INT_CON0 0x0178
> +#define MT6397_INT_CON1 0x017E
> +#define MT6397_INT_STATUS0 0x0184
> +#define MT6397_INT_STATUS1 0x0186
> +#define MT6397_FQMTR_CON0 0x0188
> +#define MT6397_FQMTR_CON1 0x018A
> +#define MT6397_FQMTR_CON2 0x018C
> +#define MT6397_EFUSE_DOUT_0_15 0x01C4
> +#define MT6397_EFUSE_DOUT_16_31 0x01C6
> +#define MT6397_EFUSE_DOUT_32_47 0x01C8
> +#define MT6397_EFUSE_DOUT_48_63 0x01CA
> +#define MT6397_SPI_CON 0x01CC
> +#define MT6397_TOP_CKPDN3 0x01CE
> +#define MT6397_TOP_CKCON3 0x01D4
> +#define MT6397_EFUSE_DOUT_64_79 0x01D6
> +#define MT6397_EFUSE_DOUT_80_95 0x01D8
> +#define MT6397_EFUSE_DOUT_96_111 0x01DA
> +#define MT6397_EFUSE_DOUT_112_127 0x01DC
> +#define MT6397_EFUSE_DOUT_128_143 0x01DE
> +#define MT6397_EFUSE_DOUT_144_159 0x01E0
> +#define MT6397_EFUSE_DOUT_160_175 0x01E2
> +#define MT6397_EFUSE_DOUT_176_191 0x01E4
> +#define MT6397_EFUSE_DOUT_192_207 0x01E6
> +#define MT6397_EFUSE_DOUT_208_223 0x01E8
> +#define MT6397_EFUSE_DOUT_224_239 0x01EA
> +#define MT6397_EFUSE_DOUT_240_255 0x01EC
> +#define MT6397_EFUSE_DOUT_256_271 0x01EE
> +#define MT6397_EFUSE_DOUT_272_287 0x01F0
> +#define MT6397_EFUSE_DOUT_288_303 0x01F2
> +#define MT6397_EFUSE_DOUT_304_319 0x01F4
> +#define MT6397_BUCK_CON0 0x0200
> +#define MT6397_BUCK_CON1 0x0202
> +#define MT6397_BUCK_CON2 0x0204
> +#define MT6397_BUCK_CON3 0x0206
> +#define MT6397_BUCK_CON4 0x0208
> +#define MT6397_BUCK_CON5 0x020A
> +#define MT6397_BUCK_CON6 0x020C
> +#define MT6397_BUCK_CON7 0x020E
> +#define MT6397_BUCK_CON8 0x0210
> +#define MT6397_BUCK_CON9 0x0212
> +#define MT6397_VCA15_CON0 0x0214
> +#define MT6397_VCA15_CON1 0x0216
> +#define MT6397_VCA15_CON2 0x0218
> +#define MT6397_VCA15_CON3 0x021A
> +#define MT6397_VCA15_CON4 0x021C
> +#define MT6397_VCA15_CON5 0x021E
> +#define MT6397_VCA15_CON6 0x0220
> +#define MT6397_VCA15_CON7 0x0222
> +#define MT6397_VCA15_CON8 0x0224
> +#define MT6397_VCA15_CON9 0x0226
> +#define MT6397_VCA15_CON10 0x0228
> +#define MT6397_VCA15_CON11 0x022A
> +#define MT6397_VCA15_CON12 0x022C
> +#define MT6397_VCA15_CON13 0x022E
> +#define MT6397_VCA15_CON14 0x0230
> +#define MT6397_VCA15_CON15 0x0232
> +#define MT6397_VCA15_CON16 0x0234
> +#define MT6397_VCA15_CON17 0x0236
> +#define MT6397_VCA15_CON18 0x0238
> +#define MT6397_VSRMCA15_CON0 0x023A
> +#define MT6397_VSRMCA15_CON1 0x023C
> +#define MT6397_VSRMCA15_CON2 0x023E
> +#define MT6397_VSRMCA15_CON3 0x0240
> +#define MT6397_VSRMCA15_CON4 0x0242
> +#define MT6397_VSRMCA15_CON5 0x0244
> +#define MT6397_VSRMCA15_CON6 0x0246
> +#define MT6397_VSRMCA15_CON7 0x0248
> +#define MT6397_VSRMCA15_CON8 0x024A
> +#define MT6397_VSRMCA15_CON9 0x024C
> +#define MT6397_VSRMCA15_CON10 0x024E
> +#define MT6397_VSRMCA15_CON11 0x0250
> +#define MT6397_VSRMCA15_CON12 0x0252
> +#define MT6397_VSRMCA15_CON13 0x0254
> +#define MT6397_VSRMCA15_CON14 0x0256
> +#define MT6397_VSRMCA15_CON15 0x0258
> +#define MT6397_VSRMCA15_CON16 0x025A
> +#define MT6397_VSRMCA15_CON17 0x025C
> +#define MT6397_VSRMCA15_CON18 0x025E
> +#define MT6397_VSRMCA15_CON19 0x0260
> +#define MT6397_VSRMCA15_CON20 0x0262
> +#define MT6397_VSRMCA15_CON21 0x0264
> +#define MT6397_VCORE_CON0 0x0266
> +#define MT6397_VCORE_CON1 0x0268
> +#define MT6397_VCORE_CON2 0x026A
> +#define MT6397_VCORE_CON3 0x026C
> +#define MT6397_VCORE_CON4 0x026E
> +#define MT6397_VCORE_CON5 0x0270
> +#define MT6397_VCORE_CON6 0x0272
> +#define MT6397_VCORE_CON7 0x0274
> +#define MT6397_VCORE_CON8 0x0276
> +#define MT6397_VCORE_CON9 0x0278
> +#define MT6397_VCORE_CON10 0x027A
> +#define MT6397_VCORE_CON11 0x027C
> +#define MT6397_VCORE_CON12 0x027E
> +#define MT6397_VCORE_CON13 0x0280
> +#define MT6397_VCORE_CON14 0x0282
> +#define MT6397_VCORE_CON15 0x0284
> +#define MT6397_VCORE_CON16 0x0286
> +#define MT6397_VCORE_CON17 0x0288
> +#define MT6397_VCORE_CON18 0x028A
> +#define MT6397_VGPU_CON0 0x028C
> +#define MT6397_VGPU_CON1 0x028E
> +#define MT6397_VGPU_CON2 0x0290
> +#define MT6397_VGPU_CON3 0x0292
> +#define MT6397_VGPU_CON4 0x0294
> +#define MT6397_VGPU_CON5 0x0296
> +#define MT6397_VGPU_CON6 0x0298
> +#define MT6397_VGPU_CON7 0x029A
> +#define MT6397_VGPU_CON8 0x029C
> +#define MT6397_VGPU_CON9 0x029E
> +#define MT6397_VGPU_CON10 0x02A0
> +#define MT6397_VGPU_CON11 0x02A2
> +#define MT6397_VGPU_CON12 0x02A4
> +#define MT6397_VGPU_CON13 0x02A6
> +#define MT6397_VGPU_CON14 0x02A8
> +#define MT6397_VGPU_CON15 0x02AA
> +#define MT6397_VGPU_CON16 0x02AC
> +#define MT6397_VGPU_CON17 0x02AE
> +#define MT6397_VGPU_CON18 0x02B0
> +#define MT6397_VIO18_CON0 0x0300
> +#define MT6397_VIO18_CON1 0x0302
> +#define MT6397_VIO18_CON2 0x0304
> +#define MT6397_VIO18_CON3 0x0306
> +#define MT6397_VIO18_CON4 0x0308
> +#define MT6397_VIO18_CON5 0x030A
> +#define MT6397_VIO18_CON6 0x030C
> +#define MT6397_VIO18_CON7 0x030E
> +#define MT6397_VIO18_CON8 0x0310
> +#define MT6397_VIO18_CON9 0x0312
> +#define MT6397_VIO18_CON10 0x0314
> +#define MT6397_VIO18_CON11 0x0316
> +#define MT6397_VIO18_CON12 0x0318
> +#define MT6397_VIO18_CON13 0x031A
> +#define MT6397_VIO18_CON14 0x031C
> +#define MT6397_VIO18_CON15 0x031E
> +#define MT6397_VIO18_CON16 0x0320
> +#define MT6397_VIO18_CON17 0x0322
> +#define MT6397_VIO18_CON18 0x0324
> +#define MT6397_VPCA7_CON0 0x0326
> +#define MT6397_VPCA7_CON1 0x0328
> +#define MT6397_VPCA7_CON2 0x032A
> +#define MT6397_VPCA7_CON3 0x032C
> +#define MT6397_VPCA7_CON4 0x032E
> +#define MT6397_VPCA7_CON5 0x0330
> +#define MT6397_VPCA7_CON6 0x0332
> +#define MT6397_VPCA7_CON7 0x0334
> +#define MT6397_VPCA7_CON8 0x0336
> +#define MT6397_VPCA7_CON9 0x0338
> +#define MT6397_VPCA7_CON10 0x033A
> +#define MT6397_VPCA7_CON11 0x033C
> +#define MT6397_VPCA7_CON12 0x033E
> +#define MT6397_VPCA7_CON13 0x0340
> +#define MT6397_VPCA7_CON14 0x0342
> +#define MT6397_VPCA7_CON15 0x0344
> +#define MT6397_VPCA7_CON16 0x0346
> +#define MT6397_VPCA7_CON17 0x0348
> +#define MT6397_VPCA7_CON18 0x034A
> +#define MT6397_VSRMCA7_CON0 0x034C
> +#define MT6397_VSRMCA7_CON1 0x034E
> +#define MT6397_VSRMCA7_CON2 0x0350
> +#define MT6397_VSRMCA7_CON3 0x0352
> +#define MT6397_VSRMCA7_CON4 0x0354
> +#define MT6397_VSRMCA7_CON5 0x0356
> +#define MT6397_VSRMCA7_CON6 0x0358
> +#define MT6397_VSRMCA7_CON7 0x035A
> +#define MT6397_VSRMCA7_CON8 0x035C
> +#define MT6397_VSRMCA7_CON9 0x035E
> +#define MT6397_VSRMCA7_CON10 0x0360
> +#define MT6397_VSRMCA7_CON11 0x0362
> +#define MT6397_VSRMCA7_CON12 0x0364
> +#define MT6397_VSRMCA7_CON13 0x0366
> +#define MT6397_VSRMCA7_CON14 0x0368
> +#define MT6397_VSRMCA7_CON15 0x036A
> +#define MT6397_VSRMCA7_CON16 0x036C
> +#define MT6397_VSRMCA7_CON17 0x036E
> +#define MT6397_VSRMCA7_CON18 0x0370
> +#define MT6397_VSRMCA7_CON19 0x0372
> +#define MT6397_VSRMCA7_CON20 0x0374
> +#define MT6397_VSRMCA7_CON21 0x0376
> +#define MT6397_VDRM_CON0 0x0378
> +#define MT6397_VDRM_CON1 0x037A
> +#define MT6397_VDRM_CON2 0x037C
> +#define MT6397_VDRM_CON3 0x037E
> +#define MT6397_VDRM_CON4 0x0380
> +#define MT6397_VDRM_CON5 0x0382
> +#define MT6397_VDRM_CON6 0x0384
> +#define MT6397_VDRM_CON7 0x0386
> +#define MT6397_VDRM_CON8 0x0388
> +#define MT6397_VDRM_CON9 0x038A
> +#define MT6397_VDRM_CON10 0x038C
> +#define MT6397_VDRM_CON11 0x038E
> +#define MT6397_VDRM_CON12 0x0390
> +#define MT6397_VDRM_CON13 0x0392
> +#define MT6397_VDRM_CON14 0x0394
> +#define MT6397_VDRM_CON15 0x0396
> +#define MT6397_VDRM_CON16 0x0398
> +#define MT6397_VDRM_CON17 0x039A
> +#define MT6397_VDRM_CON18 0x039C
> +#define MT6397_BUCK_K_CON0 0x039E
> +#define MT6397_BUCK_K_CON1 0x03A0
> +#define MT6397_ANALDO_CON0 0x0400
> +#define MT6397_ANALDO_CON1 0x0402
> +#define MT6397_ANALDO_CON2 0x0404
> +#define MT6397_ANALDO_CON3 0x0406
> +#define MT6397_ANALDO_CON4 0x0408
> +#define MT6397_ANALDO_CON5 0x040A
> +#define MT6397_ANALDO_CON6 0x040C
> +#define MT6397_ANALDO_CON7 0x040E
> +#define MT6397_DIGLDO_CON0 0x0410
> +#define MT6397_DIGLDO_CON1 0x0412
> +#define MT6397_DIGLDO_CON2 0x0414
> +#define MT6397_DIGLDO_CON3 0x0416
> +#define MT6397_DIGLDO_CON4 0x0418
> +#define MT6397_DIGLDO_CON5 0x041A
> +#define MT6397_DIGLDO_CON6 0x041C
> +#define MT6397_DIGLDO_CON7 0x041E
> +#define MT6397_DIGLDO_CON8 0x0420
> +#define MT6397_DIGLDO_CON9 0x0422
> +#define MT6397_DIGLDO_CON10 0x0424
> +#define MT6397_DIGLDO_CON11 0x0426
> +#define MT6397_DIGLDO_CON12 0x0428
> +#define MT6397_DIGLDO_CON13 0x042A
> +#define MT6397_DIGLDO_CON14 0x042C
> +#define MT6397_DIGLDO_CON15 0x042E
> +#define MT6397_DIGLDO_CON16 0x0430
> +#define MT6397_DIGLDO_CON17 0x0432
> +#define MT6397_DIGLDO_CON18 0x0434
> +#define MT6397_DIGLDO_CON19 0x0436
> +#define MT6397_DIGLDO_CON20 0x0438
> +#define MT6397_DIGLDO_CON21 0x043A
> +#define MT6397_DIGLDO_CON22 0x043C
> +#define MT6397_DIGLDO_CON23 0x043E
> +#define MT6397_DIGLDO_CON24 0x0440
> +#define MT6397_DIGLDO_CON25 0x0442
> +#define MT6397_DIGLDO_CON26 0x0444
> +#define MT6397_DIGLDO_CON27 0x0446
> +#define MT6397_DIGLDO_CON28 0x0448
> +#define MT6397_DIGLDO_CON29 0x044A
> +#define MT6397_DIGLDO_CON30 0x044C
> +#define MT6397_DIGLDO_CON31 0x044E
> +#define MT6397_DIGLDO_CON32 0x0450
> +#define MT6397_DIGLDO_CON33 0x045A
> +#define MT6397_SPK_CON0 0x0600
> +#define MT6397_SPK_CON1 0x0602
> +#define MT6397_SPK_CON2 0x0604
> +#define MT6397_SPK_CON3 0x0606
> +#define MT6397_SPK_CON4 0x0608
> +#define MT6397_SPK_CON5 0x060A
> +#define MT6397_SPK_CON6 0x060C
> +#define MT6397_SPK_CON7 0x060E
> +#define MT6397_SPK_CON8 0x0610
> +#define MT6397_SPK_CON9 0x0612
> +#define MT6397_SPK_CON10 0x0614
> +#define MT6397_SPK_CON11 0x0616
> +#define MT6397_AUDDAC_CON0 0x0700
> +#define MT6397_AUDBUF_CFG0 0x0702
> +#define MT6397_AUDBUF_CFG1 0x0704
> +#define MT6397_AUDBUF_CFG2 0x0706
> +#define MT6397_AUDBUF_CFG3 0x0708
> +#define MT6397_AUDBUF_CFG4 0x070A
> +#define MT6397_IBIASDIST_CFG0 0x070C
> +#define MT6397_AUDACCDEPOP_CFG0 0x070E
> +#define MT6397_AUD_IV_CFG0 0x0710
> +#define MT6397_AUDCLKGEN_CFG0 0x0712
> +#define MT6397_AUDLDO_CFG0 0x0714
> +#define MT6397_AUDLDO_CFG1 0x0716
> +#define MT6397_AUDNVREGGLB_CFG0 0x0718
> +#define MT6397_AUD_NCP0 0x071A
> +#define MT6397_AUDPREAMP_CON0 0x071C
> +#define MT6397_AUDADC_CON0 0x071E
> +#define MT6397_AUDADC_CON1 0x0720
> +#define MT6397_AUDADC_CON2 0x0722
> +#define MT6397_AUDADC_CON3 0x0724
> +#define MT6397_AUDADC_CON4 0x0726
> +#define MT6397_AUDADC_CON5 0x0728
> +#define MT6397_AUDADC_CON6 0x072A
> +#define MT6397_AUDDIGMI_CON0 0x072C
> +#define MT6397_AUDLSBUF_CON0 0x072E
> +#define MT6397_AUDLSBUF_CON1 0x0730
> +#define MT6397_AUDENCSPARE_CON0 0x0732
> +#define MT6397_AUDENCCLKSQ_CON0 0x0734
> +#define MT6397_AUDPREAMPGAIN_CON0 0x0736
> +#define MT6397_ZCD_CON0 0x0738
> +#define MT6397_ZCD_CON1 0x073A
> +#define MT6397_ZCD_CON2 0x073C
> +#define MT6397_ZCD_CON3 0x073E
> +#define MT6397_ZCD_CON4 0x0740
> +#define MT6397_ZCD_CON5 0x0742
> +#define MT6397_NCP_CLKDIV_CON0 0x0744
> +#define MT6397_NCP_CLKDIV_CON1 0x0746
> +
> +#endif /* __MFD_MT6397_REGISTERS_H__ */
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2014-11-18 11:59 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 7:40 Add Support for MediaTek PMIC MT6397 MFD Core and Regulator Flora Fu
2014-11-17 7:40 ` Flora Fu
2014-11-17 7:40 ` [PATCH 1/7] mfd: MT6397: Add support for PMIC MT6397 MFD Flora Fu
2014-11-17 7:40 ` Flora Fu
2014-11-18 11:59 ` Lee Jones [this message]
2014-11-18 11:59 ` Lee Jones
2014-11-17 7:40 ` [PATCH 2/7] mfd: MT6397: Add regmap for MT8135 and MT6397 SoC Flora Fu
2014-11-17 7:40 ` Flora Fu
2014-11-18 11:46 ` Lee Jones
2014-11-18 11:46 ` Lee Jones
2014-11-18 13:46 ` Sascha Hauer
2014-11-18 13:46 ` Sascha Hauer
2014-11-19 17:04 ` Lee Jones
2014-11-19 17:04 ` Lee Jones
2014-11-19 17:04 ` Lee Jones
2014-11-20 9:19 ` Sascha Hauer
2014-11-20 9:19 ` Sascha Hauer
2014-11-20 9:19 ` Sascha Hauer
2014-11-20 10:38 ` Lee Jones
2014-11-20 10:38 ` Lee Jones
2014-11-20 10:38 ` Lee Jones
2014-11-17 7:40 ` [PATCH 3/7] regulator: MT6397: Add support for MT6397 regulator Flora Fu
2014-11-17 7:40 ` Flora Fu
2014-11-17 23:40 ` Mark Brown
2014-11-17 23:40 ` Mark Brown
2014-11-17 23:40 ` Mark Brown
2014-11-21 7:09 ` Flora Fu
2014-11-21 7:09 ` Flora Fu
2014-11-21 10:16 ` Mark Brown
2014-11-21 10:16 ` Mark Brown
2014-11-17 7:40 ` [PATCH 4/7] dt-bindings: Add document for MT6397 MFD Flora Fu
2014-11-17 7:40 ` Flora Fu
2014-11-17 23:31 ` Mark Brown
2014-11-17 23:31 ` Mark Brown
2014-11-17 23:31 ` Mark Brown
2014-11-17 7:40 ` [PATCH 5/7] dt-bindings: Add document for MT6397 regulator Flora Fu
2014-11-17 7:40 ` Flora Fu
2014-11-17 7:40 ` [PATCH 6/7] ARM: dts: mt8135: Add support for PMIC MT6397 MFD Flora Fu
2014-11-17 7:40 ` Flora Fu
2014-11-17 7:40 ` [PATCH 7/7] ARM: dts: mt8135: Add support for MT6397 regulator Flora Fu
2014-11-17 7:40 ` Flora Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141118115958.GY24004@x1 \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.