From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/7] dt-bindings: Add document for MT6397 MFD
Date: Mon, 17 Nov 2014 23:31:58 +0000 [thread overview]
Message-ID: <20141117233158.GD22111@sirena.org.uk> (raw)
In-Reply-To: <1416210027-5562-5-git-send-email-flora.fu@mediatek.com>
On Mon, Nov 17, 2014 at 03:40:24PM +0800, Flora Fu wrote:
> + pmic {
> + compatible = "mediatek,mt6397";
> + }
This looks like it's missing a closing brace and is just generally weird
(having a subnode like this).
> +- regulators : The regulators of mt6397
> + regulators {
> + regulator constratints.
> + refer Documentation/devicetree/bindings/regulator/regulator.txt
> + };
You need to define the set of valid regulator names and how that maps
onto the physical device, look at other regulator binding documents for
examples.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141117/80be6512/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Flora Fu <flora.fu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Matthias Brugger
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"Joe.C" <yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
Vladimir Murzin <vladimir.murzin-5wv7dgnIgG8@public.gmane.org>,
Ashwin Chaugule
<ashwin.chaugule-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Eddie Huang <eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Dongdong Cheng
<dongdong.cheng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH 4/7] dt-bindings: Add document for MT6397 MFD
Date: Mon, 17 Nov 2014 23:31:58 +0000 [thread overview]
Message-ID: <20141117233158.GD22111@sirena.org.uk> (raw)
In-Reply-To: <1416210027-5562-5-git-send-email-flora.fu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 538 bytes --]
On Mon, Nov 17, 2014 at 03:40:24PM +0800, Flora Fu wrote:
> + pmic {
> + compatible = "mediatek,mt6397";
> + }
This looks like it's missing a closing brace and is just generally weird
(having a subnode like this).
> +- regulators : The regulators of mt6397
> + regulators {
> + regulator constratints.
> + refer Documentation/devicetree/bindings/regulator/regulator.txt
> + };
You need to define the set of valid regulator names and how that maps
onto the physical device, look at other regulator binding documents for
examples.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Flora Fu <flora.fu@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Grant Likely <grant.likely@linaro.org>,
"Joe.C" <yingjoe.chen@mediatek.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Vladimir Murzin <vladimir.murzin@arm.com>,
Ashwin Chaugule <ashwin.chaugule@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
srv_heupstream@mediatek.com, Sascha Hauer <kernel@pengutronix.de>,
Eddie Huang <eddie.huang@mediatek.com>,
Dongdong Cheng <dongdong.cheng@mediatek.com>
Subject: Re: [PATCH 4/7] dt-bindings: Add document for MT6397 MFD
Date: Mon, 17 Nov 2014 23:31:58 +0000 [thread overview]
Message-ID: <20141117233158.GD22111@sirena.org.uk> (raw)
In-Reply-To: <1416210027-5562-5-git-send-email-flora.fu@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 538 bytes --]
On Mon, Nov 17, 2014 at 03:40:24PM +0800, Flora Fu wrote:
> + pmic {
> + compatible = "mediatek,mt6397";
> + }
This looks like it's missing a closing brace and is just generally weird
(having a subnode like this).
> +- regulators : The regulators of mt6397
> + regulators {
> + regulator constratints.
> + refer Documentation/devicetree/bindings/regulator/regulator.txt
> + };
You need to define the set of valid regulator names and how that maps
onto the physical device, look at other regulator binding documents for
examples.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-11-17 23:31 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 7:40 Add Support for MediaTek PMIC MT6397 MFD Core and Regulator Flora Fu
2014-11-17 7:40 ` Flora Fu
2014-11-17 7:40 ` [PATCH 1/7] mfd: MT6397: Add support for PMIC MT6397 MFD Flora Fu
2014-11-17 7:40 ` Flora Fu
2014-11-18 11:59 ` Lee Jones
2014-11-18 11:59 ` Lee Jones
2014-11-17 7:40 ` [PATCH 2/7] mfd: MT6397: Add regmap for MT8135 and MT6397 SoC Flora Fu
2014-11-17 7:40 ` Flora Fu
2014-11-18 11:46 ` Lee Jones
2014-11-18 11:46 ` Lee Jones
2014-11-18 13:46 ` Sascha Hauer
2014-11-18 13:46 ` Sascha Hauer
2014-11-19 17:04 ` Lee Jones
2014-11-19 17:04 ` Lee Jones
2014-11-19 17:04 ` Lee Jones
2014-11-20 9:19 ` Sascha Hauer
2014-11-20 9:19 ` Sascha Hauer
2014-11-20 9:19 ` Sascha Hauer
2014-11-20 10:38 ` Lee Jones
2014-11-20 10:38 ` Lee Jones
2014-11-20 10:38 ` Lee Jones
2014-11-17 7:40 ` [PATCH 3/7] regulator: MT6397: Add support for MT6397 regulator Flora Fu
2014-11-17 7:40 ` Flora Fu
2014-11-17 23:40 ` Mark Brown
2014-11-17 23:40 ` Mark Brown
2014-11-17 23:40 ` Mark Brown
2014-11-21 7:09 ` Flora Fu
2014-11-21 7:09 ` Flora Fu
2014-11-21 10:16 ` Mark Brown
2014-11-21 10:16 ` Mark Brown
2014-11-17 7:40 ` [PATCH 4/7] dt-bindings: Add document for MT6397 MFD Flora Fu
2014-11-17 7:40 ` Flora Fu
2014-11-17 23:31 ` Mark Brown [this message]
2014-11-17 23:31 ` Mark Brown
2014-11-17 23:31 ` Mark Brown
2014-11-17 7:40 ` [PATCH 5/7] dt-bindings: Add document for MT6397 regulator Flora Fu
2014-11-17 7:40 ` Flora Fu
2014-11-17 7:40 ` [PATCH 6/7] ARM: dts: mt8135: Add support for PMIC MT6397 MFD Flora Fu
2014-11-17 7:40 ` Flora Fu
2014-11-17 7:40 ` [PATCH 7/7] ARM: dts: mt8135: Add support for MT6397 regulator Flora Fu
2014-11-17 7:40 ` Flora Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141117233158.GD22111@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.