From: Jonathan Nieder <jrnieder@gmail.com>
To: Stefan Beller <sbeller@google.com>
Cc: gitster@pobox.com, sahlberg@google.com, git@vger.kernel.org,
mhagger@alum.mit.edu
Subject: Re: [PATCH 1/2] refs.c: make ref_transaction_create a wrapper for ref_transaction_update
Date: Wed, 19 Nov 2014 17:10:39 -0800 [thread overview]
Message-ID: <20141120011038.GB6527@google.com> (raw)
In-Reply-To: <1416433224-29763-2-git-send-email-sbeller@google.com>
Stefan Beller wrote:
> From: Ronnie Sahlberg <sahlberg@google.com>
>
> The ref_transaction_update function can already be used to create refs by
> passing null_sha1 as the old_sha1 parameter. Simplify by replacing
> transaction_create with a thin wrapper.
>
> Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
> refs.c | 27 ++-------------------------
> 1 file changed, 2 insertions(+), 25 deletions(-)
I feel a bit ashamed to have my sign-off peppering all these patches
that I didn't have anything to do with except preparing to send them
to the list once or twice. I'd be happier if my sign-off weren't
there.
Except for that,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
next prev parent reply other threads:[~2014-11-20 1:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 21:40 [PATCH 0/2] Breaking the ref-transactions-reflog series in smaller parts Stefan Beller
2014-11-19 21:40 ` [PATCH 1/2] refs.c: make ref_transaction_create a wrapper for ref_transaction_update Stefan Beller
2014-11-20 1:10 ` Jonathan Nieder [this message]
2014-11-20 1:12 ` Stefan Beller
2014-11-20 1:37 ` Jonathan Nieder
2014-11-20 16:00 ` Jeff King
2014-11-20 17:38 ` [PATCH v2 " Stefan Beller
2014-11-20 18:03 ` [PATCH " Jonathan Nieder
2014-11-20 18:18 ` Jeff King
2014-11-19 21:40 ` [PATCH 2/2] refs.c: make ref_transaction_delete " Stefan Beller
2014-11-20 1:11 ` Jonathan Nieder
2014-11-20 17:39 ` [PATCH v2 " Stefan Beller
2014-11-20 18:05 ` Junio C Hamano
2014-11-20 11:03 ` [PATCH 0/2] Breaking the ref-transactions-reflog series in smaller parts Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141120011038.GB6527@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=sahlberg@google.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.