From: Michael Haggerty <mhagger@alum.mit.edu>
To: Stefan Beller <sbeller@google.com>,
gitster@pobox.com, sahlberg@google.com, git@vger.kernel.org,
jrnieder@gmail.com
Subject: Re: [PATCH 0/2] Breaking the ref-transactions-reflog series in smaller parts
Date: Thu, 20 Nov 2014 12:03:33 +0100 [thread overview]
Message-ID: <546DCA85.8060806@alum.mit.edu> (raw)
In-Reply-To: <1416433224-29763-1-git-send-email-sbeller@google.com>
On 11/19/2014 10:40 PM, Stefan Beller wrote:
> so I think the patch series ref-transactions-reflog[1] sent previously to the list
> is still too large for easy review and I want to break it up more.
> So in this series we'll digest only 2 small patches, which do not seem to be
> controversial (yet;) and seem to be useful no matter how the discussion on
> the other series continues.
>
> ref_transaction_create as well as ref_transaction_delete are just special cases
> of ref_transaction_update, so let's reduce some redundant code. While this doesn't
> change code in pathes, which are supposed to be run, we do have slight changes
> in error messages starting with "BUG: ". So in the best case, the user will never
> see these messages at all.
Users should *never* see error messages starting with "BUG: ". These are
basically what the Git project uses instead of assert(). As long as we
Git developers would understand a bug report submitted by a user who
sees such an error message, their text can be changed without worries.
Both patches are
Reviewed-by: Michael Haggerty <mhagger@alum.mit.edu>
And I love that you are proceeding in smaller pieces.
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
prev parent reply other threads:[~2014-11-20 11:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 21:40 [PATCH 0/2] Breaking the ref-transactions-reflog series in smaller parts Stefan Beller
2014-11-19 21:40 ` [PATCH 1/2] refs.c: make ref_transaction_create a wrapper for ref_transaction_update Stefan Beller
2014-11-20 1:10 ` Jonathan Nieder
2014-11-20 1:12 ` Stefan Beller
2014-11-20 1:37 ` Jonathan Nieder
2014-11-20 16:00 ` Jeff King
2014-11-20 17:38 ` [PATCH v2 " Stefan Beller
2014-11-20 18:03 ` [PATCH " Jonathan Nieder
2014-11-20 18:18 ` Jeff King
2014-11-19 21:40 ` [PATCH 2/2] refs.c: make ref_transaction_delete " Stefan Beller
2014-11-20 1:11 ` Jonathan Nieder
2014-11-20 17:39 ` [PATCH v2 " Stefan Beller
2014-11-20 18:05 ` Junio C Hamano
2014-11-20 11:03 ` Michael Haggerty [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546DCA85.8060806@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=sahlberg@google.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.