From: Jeff King <peff@peff.net>
To: Stefan Beller <sbeller@google.com>
Cc: gitster@pobox.com, sahlberg@google.com, git@vger.kernel.org,
mhagger@alum.mit.edu, jrnieder@gmail.com
Subject: Re: [PATCH 1/2] refs.c: make ref_transaction_create a wrapper for ref_transaction_update
Date: Thu, 20 Nov 2014 11:00:01 -0500 [thread overview]
Message-ID: <20141120160000.GA31738@peff.net> (raw)
In-Reply-To: <1416433224-29763-2-git-send-email-sbeller@google.com>
On Wed, Nov 19, 2014 at 01:40:23PM -0800, Stefan Beller wrote:
> {
> - struct ref_update *update;
> -
> - assert(err);
> -
> - if (transaction->state != REF_TRANSACTION_OPEN)
> - die("BUG: create called for transaction that is not open");
> -
> - if (!new_sha1 || is_null_sha1(new_sha1))
> - die("BUG: create ref with null new_sha1");
> -
> - if (check_refname_format(refname, REFNAME_ALLOW_ONELEVEL)) {
> - strbuf_addf(err, "refusing to create ref with bad name %s",
> - refname);
> - return -1;
> - }
You claimed in the cover letter that only BUG messages were changed. But
I think this third one is a real user-visible message.
That being said, I think the sum total of the change to the message is
s/create/update/, and it's probably fine.
-Peff
next prev parent reply other threads:[~2014-11-20 16:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 21:40 [PATCH 0/2] Breaking the ref-transactions-reflog series in smaller parts Stefan Beller
2014-11-19 21:40 ` [PATCH 1/2] refs.c: make ref_transaction_create a wrapper for ref_transaction_update Stefan Beller
2014-11-20 1:10 ` Jonathan Nieder
2014-11-20 1:12 ` Stefan Beller
2014-11-20 1:37 ` Jonathan Nieder
2014-11-20 16:00 ` Jeff King [this message]
2014-11-20 17:38 ` [PATCH v2 " Stefan Beller
2014-11-20 18:03 ` [PATCH " Jonathan Nieder
2014-11-20 18:18 ` Jeff King
2014-11-19 21:40 ` [PATCH 2/2] refs.c: make ref_transaction_delete " Stefan Beller
2014-11-20 1:11 ` Jonathan Nieder
2014-11-20 17:39 ` [PATCH v2 " Stefan Beller
2014-11-20 18:05 ` Junio C Hamano
2014-11-20 11:03 ` [PATCH 0/2] Breaking the ref-transactions-reflog series in smaller parts Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141120160000.GA31738@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=mhagger@alum.mit.edu \
--cc=sahlberg@google.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.