From: Thierry Reding <thierry.reding@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Liviu Dudau <liviu.dudau@arm.com>,
Marc Zyngier <marc.zyngier@arm.com>,
linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] PCI: tegra: Use physical range for I/O mapping
Date: Wed, 26 Nov 2014 21:18:03 +0100 [thread overview]
Message-ID: <20141126201758.GA19624@mithrandir> (raw)
In-Reply-To: <3072281.UjpXkitFjL@wuerfel>
[-- Attachment #1: Type: text/plain, Size: 938 bytes --]
On Wed, Nov 26, 2014 at 05:55:05PM +0100, Arnd Bergmann wrote:
> On Wednesday 26 November 2014 17:21:37 Thierry Reding wrote:
> > -
> > + pci_add_resource_offset(&sys->resources, &pcie->pio, sys->io_offset);
> > pci_add_resource_offset(&sys->resources, &pcie->mem, sys->mem_offset);
> > pci_add_resource_offset(&sys->resources, &pcie->prefetch,
> > sys->mem_offset);
> >
>
> You don't set sys->io_offset anywhere, which is a bug if you have multiple
> instances of the PCI host in one system. In my draft patch, I was setting
> both io_offset and mem_offset for consistency, and while mem_offset would
> in practice be always zero (as discussed on IRC), the io_offset in fact has
> a realistic chance of being nonzero and you should definitely set it.
I was going to do that in a follow-up patch since it isn't needed to fix
this particular regression.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Liviu Dudau <liviu.dudau-5wv7dgnIgG8@public.gmane.org>,
Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>,
linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] PCI: tegra: Use physical range for I/O mapping
Date: Wed, 26 Nov 2014 21:18:03 +0100 [thread overview]
Message-ID: <20141126201758.GA19624@mithrandir> (raw)
In-Reply-To: <3072281.UjpXkitFjL@wuerfel>
[-- Attachment #1: Type: text/plain, Size: 938 bytes --]
On Wed, Nov 26, 2014 at 05:55:05PM +0100, Arnd Bergmann wrote:
> On Wednesday 26 November 2014 17:21:37 Thierry Reding wrote:
> > -
> > + pci_add_resource_offset(&sys->resources, &pcie->pio, sys->io_offset);
> > pci_add_resource_offset(&sys->resources, &pcie->mem, sys->mem_offset);
> > pci_add_resource_offset(&sys->resources, &pcie->prefetch,
> > sys->mem_offset);
> >
>
> You don't set sys->io_offset anywhere, which is a bug if you have multiple
> instances of the PCI host in one system. In my draft patch, I was setting
> both io_offset and mem_offset for consistency, and while mem_offset would
> in practice be always zero (as discussed on IRC), the io_offset in fact has
> a realistic chance of being nonzero and you should definitely set it.
I was going to do that in a follow-up patch since it isn't needed to fix
this particular regression.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-11-26 20:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 16:21 [PATCH] PCI: tegra: Use physical range for I/O mapping Thierry Reding
2014-11-26 16:21 ` Thierry Reding
2014-11-26 16:55 ` Arnd Bergmann
2014-11-26 16:55 ` Arnd Bergmann
2014-11-26 20:18 ` Thierry Reding [this message]
2014-11-26 20:18 ` Thierry Reding
2014-11-26 20:30 ` Arnd Bergmann
2014-11-26 20:30 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141126201758.GA19624@mithrandir \
--to=thierry.reding@gmail.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=marc.zyngier@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.