All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Linux Filesystem Development List <linux-fsdevel@vger.kernel.org>,
	Ext4 Developers List <linux-ext4@vger.kernel.org>,
	Linux btrfs Developers List <linux-btrfs@vger.kernel.org>,
	XFS Developers <xfs@oss.sgi.com>
Subject: Re: [PATCH-v4 1/7] vfs: split update_time() into update_time() and write_time()
Date: Thu, 27 Nov 2014 09:41:16 -0500	[thread overview]
Message-ID: <20141127144116.GA14091@thunk.org> (raw)
In-Reply-To: <20141126192328.GA20436@infradead.org>

On Wed, Nov 26, 2014 at 11:23:28AM -0800, Christoph Hellwig wrote:
> As mentioned last round please move the addition of the is_readonly
> operation to the first thing in the series, so that the ordering makes
> more sense.

OK, will fix.

> Second I think this patch is incorrect for XFS - XFS uses ->update_time
> to set the time stampst in the dinode.  These two need to be coherent
> as we can write out a dirty inode any time, so it needs to have the
> timestamp uptodate.
> 
> Third update_time now calls mark_inode_dirty unconditionally, while
> previously it wasn't called when ->update_time was set.  At least
> for XFS that's a major change in behavior as XFS never used VFS dirty
> tracking for metadata updates.

Thanks, I'll fix both of the above.

							- Ted

WARNING: multiple messages have this Message-ID (diff)
From: Theodore Ts'o <tytso@mit.edu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Linux Filesystem Development List <linux-fsdevel@vger.kernel.org>,
	Ext4 Developers List <linux-ext4@vger.kernel.org>,
	Linux btrfs Developers List <linux-btrfs@vger.kernel.org>,
	XFS Developers <xfs@oss.sgi.com>
Subject: Re: [PATCH-v4 1/7] vfs: split update_time() into update_time() and write_time()
Date: Thu, 27 Nov 2014 09:41:16 -0500	[thread overview]
Message-ID: <20141127144116.GA14091@thunk.org> (raw)
In-Reply-To: <20141126192328.GA20436@infradead.org>

On Wed, Nov 26, 2014 at 11:23:28AM -0800, Christoph Hellwig wrote:
> As mentioned last round please move the addition of the is_readonly
> operation to the first thing in the series, so that the ordering makes
> more sense.

OK, will fix.

> Second I think this patch is incorrect for XFS - XFS uses ->update_time
> to set the time stampst in the dinode.  These two need to be coherent
> as we can write out a dirty inode any time, so it needs to have the
> timestamp uptodate.
> 
> Third update_time now calls mark_inode_dirty unconditionally, while
> previously it wasn't called when ->update_time was set.  At least
> for XFS that's a major change in behavior as XFS never used VFS dirty
> tracking for metadata updates.

Thanks, I'll fix both of the above.

							- Ted

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2014-11-27 14:41 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-26 10:23 [PATCH-v4 0/7] add support for a lazytime mount option Theodore Ts'o
2014-11-26 10:23 ` Theodore Ts'o
2014-11-26 10:23 ` [PATCH-v4 1/7] vfs: split update_time() into update_time() and write_time() Theodore Ts'o
2014-11-26 10:23   ` Theodore Ts'o
2014-11-26 19:23   ` Christoph Hellwig
2014-11-26 19:23     ` Christoph Hellwig
2014-11-27 12:34     ` Jan Kara
2014-11-27 12:34       ` Jan Kara
2014-11-27 15:25       ` Christoph Hellwig
2014-11-27 15:25         ` Christoph Hellwig
2014-11-27 14:41     ` Theodore Ts'o [this message]
2014-11-27 14:41       ` Theodore Ts'o
2014-11-27 15:28       ` Christoph Hellwig
2014-11-27 15:28         ` Christoph Hellwig
2014-11-27 15:33       ` Theodore Ts'o
2014-11-27 15:33         ` Theodore Ts'o
2014-11-27 16:49         ` Christoph Hellwig
2014-11-27 16:49           ` Christoph Hellwig
2014-11-27 20:27           ` Theodore Ts'o
2014-11-27 20:27             ` Theodore Ts'o
2014-12-01  9:28             ` Christoph Hellwig
2014-12-01  9:28               ` Christoph Hellwig
2014-12-01 15:04               ` Theodore Ts'o
2014-12-01 15:04                 ` Theodore Ts'o
2014-12-01 17:18                 ` David Sterba
2014-12-01 17:18                   ` David Sterba
2014-12-02  9:20                 ` Christoph Hellwig
2014-12-02  9:20                   ` Christoph Hellwig
2014-12-02 15:09                   ` Theodore Ts'o
2014-12-02 15:09                     ` Theodore Ts'o
2014-11-26 10:23 ` [PATCH-v4 2/7] vfs: add support for a lazytime mount option Theodore Ts'o
2014-11-26 10:23   ` Theodore Ts'o
2014-11-27 13:14   ` Jan Kara
2014-11-27 13:14     ` Jan Kara
2014-11-27 20:19     ` Theodore Ts'o
2014-11-27 20:19       ` Theodore Ts'o
2014-11-28 12:41       ` Jan Kara
2014-11-28 12:41         ` Jan Kara
2014-11-27 23:00     ` Theodore Ts'o
2014-11-27 23:00       ` Theodore Ts'o
2014-11-28  5:36       ` Theodore Ts'o
2014-11-28  5:36         ` Theodore Ts'o
2014-11-28 16:24       ` Jan Kara
2014-11-28 16:24         ` Jan Kara
2014-11-26 10:23 ` [PATCH-v4 3/7] vfs: don't let the dirty time inodes get more than a day stale Theodore Ts'o
2014-11-26 10:23   ` Theodore Ts'o
2014-11-26 10:23 ` [PATCH-v4 4/7] vfs: add lazytime tracepoints for better debugging Theodore Ts'o
2014-11-26 10:23   ` Theodore Ts'o
2014-11-26 10:23 ` [PATCH-v4 5/7] vfs: add find_active_inode_nowait() function Theodore Ts'o
2014-11-26 10:23   ` Theodore Ts'o
2014-11-26 10:23 ` [PATCH-v4 6/7] ext4: add support for a lazytime mount option Theodore Ts'o
2014-11-26 10:23   ` Theodore Ts'o
2014-11-26 19:24   ` Christoph Hellwig
2014-11-26 19:24     ` Christoph Hellwig
2014-11-26 22:48   ` Dave Chinner
2014-11-26 22:48     ` Dave Chinner
2014-11-26 23:10     ` Andreas Dilger
2014-11-26 23:10       ` Andreas Dilger
2014-11-26 23:35       ` Dave Chinner
2014-11-26 23:35         ` Dave Chinner
2014-11-27 13:27         ` Jan Kara
2014-11-27 13:27           ` Jan Kara
2014-11-27 13:32           ` Jan Kara
2014-11-27 13:32             ` Jan Kara
2014-11-27 15:25             ` Theodore Ts'o
2014-11-27 15:25               ` Theodore Ts'o
2014-11-27 15:41               ` Jan Kara
2014-11-27 15:41                 ` Jan Kara
2014-11-27 20:13                 ` Theodore Ts'o
2014-11-27 20:13                   ` Theodore Ts'o
2014-11-26 10:23 ` [PATCH-v4 7/7] btrfs: add an is_readonly() so btrfs can use common code for update_time() Theodore Ts'o
2014-11-26 10:23   ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141127144116.GA14091@thunk.org \
    --to=tytso@mit.edu \
    --cc=hch@infradead.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.