From: "Michael Büsch" <m@bues.ch>
To: nick <xerofoify@gmail.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"Stefano Brivio" <stefano.brivio@polimi.it>,
"Network Development" <netdev@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
b43-dev <b43-dev@lists.infradead.org>
Subject: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c
Date: Sat, 29 Nov 2014 09:56:32 +0100 [thread overview]
Message-ID: <20141129095632.69361457@wiggum> (raw)
In-Reply-To: <54793E4E.7050602@gmail.com>
On Fri, 28 Nov 2014 22:32:30 -0500
nick <xerofoify@gmail.com> wrote:
> I don't have hardware for this driver on me, so I didn't test it. However this seems to
> be correct from my reading of the code around this function and other locking related
> to this driver.
From the current docs:
> * @set_tim: Set TIM bit. mac80211 calls this function when a TIM bit
> * must be set or cleared for a given STA. Must be atomic.
So it is not allowed to lock a mutex here.
--
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20141129/9e9fdd70/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: "Michael Büsch" <m@bues.ch>
To: nick <xerofoify@gmail.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"Stefano Brivio" <stefano.brivio@polimi.it>,
"Network Development" <netdev@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
b43-dev <b43-dev@lists.infradead.org>
Subject: Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c
Date: Sat, 29 Nov 2014 09:56:32 +0100 [thread overview]
Message-ID: <20141129095632.69361457@wiggum> (raw)
In-Reply-To: <54793E4E.7050602@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 503 bytes --]
On Fri, 28 Nov 2014 22:32:30 -0500
nick <xerofoify@gmail.com> wrote:
> I don't have hardware for this driver on me, so I didn't test it. However this seems to
> be correct from my reading of the code around this function and other locking related
> to this driver.
From the current docs:
> * @set_tim: Set TIM bit. mac80211 calls this function when a TIM bit
> * must be set or cleared for a given STA. Must be atomic.
So it is not allowed to lock a mutex here.
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-29 8:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 22:16 [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c Nicholas Krause
2014-11-28 22:16 ` Nicholas Krause
2014-11-28 22:40 ` Rafał Miłecki
2014-11-28 22:40 ` Rafał Miłecki
2014-11-28 23:21 ` Michael Büsch
2014-11-28 23:21 ` Michael Büsch
2014-11-29 3:32 ` nick
2014-11-29 3:32 ` nick
2014-11-29 8:54 ` Rafał Miłecki
2014-11-29 8:54 ` Rafał Miłecki
2014-11-29 8:56 ` Michael Büsch [this message]
2014-11-29 8:56 ` Michael Büsch
2014-11-29 9:04 ` Rafał Miłecki
2014-11-29 9:04 ` Rafał Miłecki
2014-11-29 18:09 ` nick
2014-11-29 18:09 ` nick
2014-11-29 18:54 ` Larry Finger
2014-11-29 18:54 ` Larry Finger
2014-11-29 18:54 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141129095632.69361457@wiggum \
--to=m@bues.ch \
--cc=b43-dev@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefano.brivio@polimi.it \
--cc=xerofoify@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.