All of lore.kernel.org
 help / color / mirror / Atom feed
From: nick <xerofoify@gmail.com>
To: "Rafał Miłecki" <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"Michael Büsch" <m@bues.ch>
Cc: Network Development
	<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Linux Kernel Mailing List
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Stefano Brivio
	<stefano.brivio-hl5o88x/ua9eoWH0uzbU5w@public.gmane.org>,
	b43-dev
	<b43-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c
Date: Sat, 29 Nov 2014 13:09:09 -0500	[thread overview]
Message-ID: <547A0BC5.2080005@gmail.com> (raw)
In-Reply-To: <CACna6ryjZ-LY06wAMzoL77Wca3McUUT+VYsO4EPO87NqjBnaNw@mail.gmail.com>

Sorry about that, next time I will be more careful.
Nick

On 2014-11-29 04:04 AM, Rafa? Mi?ecki wrote:
> On 29 November 2014 at 09:56, Michael B?sch <m@bues.ch> wrote:
>> On Fri, 28 Nov 2014 22:32:30 -0500
>> nick <xerofoify@gmail.com> wrote:
>>
>>> I don't have hardware for this driver on me, so I didn't test it. However this seems to
>>> be correct from my reading of the code around this function and other locking related
>>> to this driver.
>>
>> From the current docs:
>>
>>>  * @set_tim: Set TIM bit. mac80211 calls this function when a TIM bit
>>>  *      must be set or cleared for a given STA. Must be atomic.
>>
>> So it is not allowed to lock a mutex here.
> 
> Nicholas please be more careful with your patches. It seems your patch
> is wrong, you didn't check the docs and you didn't even say in the
> first place that it wasn't tested. You could at least submit with with
> RFT tag or sth.
> 

WARNING: multiple messages have this Message-ID (diff)
From: nick <xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Rafał Miłecki" <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"Michael Büsch" <m@bues.ch>
Cc: Network Development
	<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Linux Kernel Mailing List
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Stefano Brivio
	<stefano.brivio-hl5o88x/ua9eoWH0uzbU5w@public.gmane.org>,
	b43-dev
	<b43-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c
Date: Sat, 29 Nov 2014 13:09:09 -0500	[thread overview]
Message-ID: <547A0BC5.2080005@gmail.com> (raw)
In-Reply-To: <CACna6ryjZ-LY06wAMzoL77Wca3McUUT+VYsO4EPO87NqjBnaNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Sorry about that, next time I will be more careful.
Nick

On 2014-11-29 04:04 AM, Rafał Miłecki wrote:
> On 29 November 2014 at 09:56, Michael Büsch <m@bues.ch> wrote:
>> On Fri, 28 Nov 2014 22:32:30 -0500
>> nick <xerofoify@gmail.com> wrote:
>>
>>> I don't have hardware for this driver on me, so I didn't test it. However this seems to
>>> be correct from my reading of the code around this function and other locking related
>>> to this driver.
>>
>> From the current docs:
>>
>>>  * @set_tim: Set TIM bit. mac80211 calls this function when a TIM bit
>>>  *      must be set or cleared for a given STA. Must be atomic.
>>
>> So it is not allowed to lock a mutex here.
> 
> Nicholas please be more careful with your patches. It seems your patch
> is wrong, you didn't check the docs and you didn't even say in the
> first place that it wasn't tested. You could at least submit with with
> RFT tag or sth.
> 

_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev

  reply	other threads:[~2014-11-29 18:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-28 22:16 [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c Nicholas Krause
2014-11-28 22:16 ` Nicholas Krause
2014-11-28 22:40 ` Rafał Miłecki
2014-11-28 22:40   ` Rafał Miłecki
2014-11-28 23:21   ` Michael Büsch
2014-11-28 23:21     ` Michael Büsch
2014-11-29  3:32     ` nick
2014-11-29  3:32       ` nick
2014-11-29  8:54       ` Rafał Miłecki
2014-11-29  8:54         ` Rafał Miłecki
2014-11-29  8:56       ` Michael Büsch
2014-11-29  8:56         ` Michael Büsch
2014-11-29  9:04         ` Rafał Miłecki
2014-11-29  9:04           ` Rafał Miłecki
2014-11-29 18:09           ` nick [this message]
2014-11-29 18:09             ` nick
2014-11-29 18:54             ` Larry Finger
2014-11-29 18:54               ` Larry Finger
2014-11-29 18:54               ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547A0BC5.2080005@gmail.com \
    --to=xerofoify@gmail.com \
    --cc=b43-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=m@bues.ch \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=stefano.brivio-hl5o88x/ua9eoWH0uzbU5w@public.gmane.org \
    --cc=zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.