From: b.galvani@gmail.com (Beniamino Galvani)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 2/4] ARM: mediatek: Add sysirq interrupt polarity support
Date: Sat, 29 Nov 2014 18:40:31 +0100 [thread overview]
Message-ID: <20141129174030.GA4696@gmail.com> (raw)
In-Reply-To: <1416902662-19281-3-git-send-email-yingjoe.chen@mediatek.com>
On Tue, Nov 25, 2014 at 04:04:20PM +0800, Yingjoe Chen wrote:
> Mediatek SoCs have interrupt polarity support in sysirq which
> allows to invert polarity for given interrupt. Add this support
> using hierarchy irq domain.
>
> [...]
>
> +static int __init mtk_sysirq_of_init(struct device_node *node,
> + struct device_node *parent)
> +{
> + struct irq_domain *domain, *domain_parent;
> + struct mtk_sysirq_chip_data *chip_data;
> + int ret = 0;
> +
> + domain_parent = irq_find_host(parent);
> + if (!domain_parent) {
> + pr_err("mtk_sysirq: interrupt-parent not found\n");
> + return -EINVAL;
> + }
> +
> + chip_data = kzalloc(sizeof(*chip_data), GFP_KERNEL);
> + if (!chip_data)
> + return -ENOMEM;
> +
> + chip_data->intpol_base = of_io_request_and_map(node, 0, "intpol");
> + if (!chip_data->intpol_base) {
Hi,
you should use IS_ERR() to check the return value here.
Beniamino
WARNING: multiple messages have this Message-ID (diff)
From: Beniamino Galvani <b.galvani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Yingjoe Chen <yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
Jiang Liu <jiang.liu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>,
Boris BREZILLON
<boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
hc.yen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
yh.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Yijing Wang <wangyijing-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Matthias Brugger
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
nathan.chung-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
yingjoe.chen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v8 2/4] ARM: mediatek: Add sysirq interrupt polarity support
Date: Sat, 29 Nov 2014 18:40:31 +0100 [thread overview]
Message-ID: <20141129174030.GA4696@gmail.com> (raw)
In-Reply-To: <1416902662-19281-3-git-send-email-yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
On Tue, Nov 25, 2014 at 04:04:20PM +0800, Yingjoe Chen wrote:
> Mediatek SoCs have interrupt polarity support in sysirq which
> allows to invert polarity for given interrupt. Add this support
> using hierarchy irq domain.
>
> [...]
>
> +static int __init mtk_sysirq_of_init(struct device_node *node,
> + struct device_node *parent)
> +{
> + struct irq_domain *domain, *domain_parent;
> + struct mtk_sysirq_chip_data *chip_data;
> + int ret = 0;
> +
> + domain_parent = irq_find_host(parent);
> + if (!domain_parent) {
> + pr_err("mtk_sysirq: interrupt-parent not found\n");
> + return -EINVAL;
> + }
> +
> + chip_data = kzalloc(sizeof(*chip_data), GFP_KERNEL);
> + if (!chip_data)
> + return -ENOMEM;
> +
> + chip_data->intpol_base = of_io_request_and_map(node, 0, "intpol");
> + if (!chip_data->intpol_base) {
Hi,
you should use IS_ERR() to check the return value here.
Beniamino
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Beniamino Galvani <b.galvani@gmail.com>
To: Yingjoe Chen <yingjoe.chen@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Jason Cooper <jason@lakedaemon.net>,
Thomas Gleixner <tglx@linutronix.de>,
Jiang Liu <jiang.liu@linux.intel.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Boris BREZILLON <boris.brezillon@free-electrons.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Russell King <linux@arm.linux.org.uk>,
Pawel Moll <pawel.moll@arm.com>,
srv_heupstream@mediatek.com, devicetree@vger.kernel.org,
hc.yen@mediatek.com, yh.chen@mediatek.com,
linux-kernel@vger.kernel.org, Yijing Wang <wangyijing@huawei.com>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
nathan.chung@mediatek.com, Sascha Hauer <kernel@pengutronix.de>,
Grant Likely <grant.likely@linaro.org>,
eddie.huang@mediatek.com, yingjoe.chen@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 2/4] ARM: mediatek: Add sysirq interrupt polarity support
Date: Sat, 29 Nov 2014 18:40:31 +0100 [thread overview]
Message-ID: <20141129174030.GA4696@gmail.com> (raw)
In-Reply-To: <1416902662-19281-3-git-send-email-yingjoe.chen@mediatek.com>
On Tue, Nov 25, 2014 at 04:04:20PM +0800, Yingjoe Chen wrote:
> Mediatek SoCs have interrupt polarity support in sysirq which
> allows to invert polarity for given interrupt. Add this support
> using hierarchy irq domain.
>
> [...]
>
> +static int __init mtk_sysirq_of_init(struct device_node *node,
> + struct device_node *parent)
> +{
> + struct irq_domain *domain, *domain_parent;
> + struct mtk_sysirq_chip_data *chip_data;
> + int ret = 0;
> +
> + domain_parent = irq_find_host(parent);
> + if (!domain_parent) {
> + pr_err("mtk_sysirq: interrupt-parent not found\n");
> + return -EINVAL;
> + }
> +
> + chip_data = kzalloc(sizeof(*chip_data), GFP_KERNEL);
> + if (!chip_data)
> + return -ENOMEM;
> +
> + chip_data->intpol_base = of_io_request_and_map(node, 0, "intpol");
> + if (!chip_data->intpol_base) {
Hi,
you should use IS_ERR() to check the return value here.
Beniamino
next prev parent reply other threads:[~2014-11-29 17:40 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 8:04 [PATCH v8 0/4] ARM: mediatek: Add support for interrupt polarity Yingjoe Chen
2014-11-25 8:04 ` Yingjoe Chen
2014-11-25 8:04 ` Yingjoe Chen
2014-11-25 8:04 ` [PATCH v8 1/4] irqchip: gic: Support hierarchy irq domain Yingjoe Chen
2014-11-25 8:04 ` Yingjoe Chen
2014-11-25 8:04 ` Yingjoe Chen
2014-11-25 11:27 ` Marc Zyngier
2014-11-25 11:27 ` Marc Zyngier
2014-11-25 11:27 ` Marc Zyngier
2014-12-02 13:27 ` Geert Uytterhoeven
2014-12-02 13:27 ` Geert Uytterhoeven
2014-12-02 13:27 ` Geert Uytterhoeven
2014-12-02 13:27 ` Geert Uytterhoeven
2014-12-02 13:37 ` Marc Zyngier
2014-12-02 13:37 ` Marc Zyngier
2014-12-02 13:37 ` Marc Zyngier
2014-12-02 13:37 ` Marc Zyngier
2014-12-02 13:55 ` Geert Uytterhoeven
2014-12-02 13:55 ` Geert Uytterhoeven
2014-12-02 13:55 ` Geert Uytterhoeven
2014-12-02 13:55 ` Geert Uytterhoeven
2014-12-02 14:12 ` Marc Zyngier
2014-12-02 14:12 ` Marc Zyngier
2014-12-02 14:12 ` Marc Zyngier
2014-12-02 14:12 ` Marc Zyngier
2014-11-25 8:04 ` [PATCH v8 2/4] ARM: mediatek: Add sysirq interrupt polarity support Yingjoe Chen
2014-11-25 8:04 ` Yingjoe Chen
2014-11-25 8:04 ` Yingjoe Chen
2014-11-29 17:40 ` Beniamino Galvani [this message]
2014-11-29 17:40 ` Beniamino Galvani
2014-11-29 17:40 ` Beniamino Galvani
2014-12-01 14:09 ` Yingjoe Chen
2014-12-01 14:09 ` Yingjoe Chen
2014-12-01 14:09 ` Yingjoe Chen
2014-11-25 8:04 ` [PATCH v8 3/4] ARM: mediatek: Add sysirq in mt6589/mt8135/mt8127 dtsi Yingjoe Chen
2014-11-25 8:04 ` Yingjoe Chen
2014-11-25 8:04 ` Yingjoe Chen
2014-11-27 13:31 ` Yingjoe Chen
2014-11-27 13:31 ` Yingjoe Chen
2014-11-27 13:31 ` Yingjoe Chen
2014-12-25 2:11 ` Yingjoe Chen
2014-12-25 2:11 ` Yingjoe Chen
2014-12-25 2:11 ` Yingjoe Chen
2015-01-02 10:16 ` Matthias Brugger
2015-01-02 10:16 ` Matthias Brugger
2015-01-02 10:16 ` Matthias Brugger
2014-11-25 8:04 ` [PATCH v8 4/4] dt-bindings: add bindings for mediatek sysirq Yingjoe Chen
2014-11-25 8:04 ` Yingjoe Chen
2014-11-25 8:04 ` Yingjoe Chen
2014-11-26 8:08 ` [PATCH v8 0/4] ARM: mediatek: Add support for interrupt polarity Jason Cooper
2014-11-26 8:08 ` Jason Cooper
2014-11-26 8:08 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141129174030.GA4696@gmail.com \
--to=b.galvani@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.