From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: "pagupta@redhat.com" <pagupta@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH RFC v4 net-next 0/5] virtio_net: enabling tx interrupts
Date: Tue, 2 Dec 2014 12:08:07 +0200 [thread overview]
Message-ID: <20141202100806.GA8056@redhat.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1CA007CC@AcuExch.aculab.com>
On Tue, Dec 02, 2014 at 10:00:06AM +0000, David Laight wrote:
> From: Jason Wang
> > > On Mon, Dec 01, 2014 at 06:17:03PM +0800, Jason Wang wrote:
> > >> Hello:
> > >>
> > >> We used to orphan packets before transmission for virtio-net. This
> > >> breaks
> > >> socket accounting and can lead serveral functions won't work, e.g:
> > >>
> > >> - Byte Queue Limit depends on tx completion nofication to work.
> > >> - Packet Generator depends on tx completion nofication for the last
> > >> transmitted packet to complete.
> > >> - TCP Small Queue depends on proper accounting of sk_wmem_alloc to
> > >> work.
> > >>
> > >> This series tries to solve the issue by enabling tx interrupts. To
> > >> minize
> > >> the performance impacts of this, several optimizations were used:
> > >>
> > >> - In guest side, virtqueue_enable_cb_delayed() was used to delay the tx
> > >> interrupt untile 3/4 pending packets were sent.
>
> Doesn't that give problems for intermittent transmits?
>
> ...
>
> David
>
No because it has not effect in that case.
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: "'Jason Wang'" <jasowang@redhat.com>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"pagupta@redhat.com" <pagupta@redhat.com>
Subject: Re: [PATCH RFC v4 net-next 0/5] virtio_net: enabling tx interrupts
Date: Tue, 2 Dec 2014 12:08:07 +0200 [thread overview]
Message-ID: <20141202100806.GA8056@redhat.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1CA007CC@AcuExch.aculab.com>
On Tue, Dec 02, 2014 at 10:00:06AM +0000, David Laight wrote:
> From: Jason Wang
> > > On Mon, Dec 01, 2014 at 06:17:03PM +0800, Jason Wang wrote:
> > >> Hello:
> > >>
> > >> We used to orphan packets before transmission for virtio-net. This
> > >> breaks
> > >> socket accounting and can lead serveral functions won't work, e.g:
> > >>
> > >> - Byte Queue Limit depends on tx completion nofication to work.
> > >> - Packet Generator depends on tx completion nofication for the last
> > >> transmitted packet to complete.
> > >> - TCP Small Queue depends on proper accounting of sk_wmem_alloc to
> > >> work.
> > >>
> > >> This series tries to solve the issue by enabling tx interrupts. To
> > >> minize
> > >> the performance impacts of this, several optimizations were used:
> > >>
> > >> - In guest side, virtqueue_enable_cb_delayed() was used to delay the tx
> > >> interrupt untile 3/4 pending packets were sent.
>
> Doesn't that give problems for intermittent transmits?
>
> ...
>
> David
>
No because it has not effect in that case.
--
MST
next prev parent reply other threads:[~2014-12-02 10:08 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 10:17 [PATCH RFC v4 net-next 0/5] virtio_net: enabling tx interrupts Jason Wang
2014-12-01 10:17 ` Jason Wang
2014-12-01 10:17 ` [PATCH RFC v4 net-next 1/5] virtio_net: enable tx interrupt Jason Wang
2014-12-01 10:17 ` Jason Wang
2014-12-01 10:35 ` Michael S. Tsirkin
2014-12-01 10:35 ` Michael S. Tsirkin
2014-12-02 3:09 ` Jason Wang
2014-12-02 3:09 ` Jason Wang
2014-12-19 7:32 ` Qin Chuanyu
2014-12-19 7:32 ` Qin Chuanyu
2014-12-19 7:32 ` Qin Chuanyu
2014-12-19 10:02 ` Jason Wang
2014-12-19 10:02 ` Jason Wang
2014-12-01 10:17 ` [PATCH RFC v4 net-next 2/5] virtio_net: bql Jason Wang
2014-12-01 10:17 ` Jason Wang
2014-12-01 10:17 ` [PATCH RFC v4 net-next 3/5] virtio-net: optimize free_old_xmit_skbs stats Jason Wang
2014-12-01 10:17 ` Jason Wang
2014-12-01 10:17 ` [PATCH RFC v4 net-next 4/5] virtio-net: add basic interrupt coalescing support Jason Wang
2014-12-01 10:17 ` Jason Wang
2014-12-01 10:17 ` [PATCH RFC v4 net-next 5/5] vhost_net: " Jason Wang
2014-12-01 10:17 ` Jason Wang
2014-12-01 10:42 ` [PATCH RFC v4 net-next 0/5] virtio_net: enabling tx interrupts Michael S. Tsirkin
2014-12-01 10:42 ` Michael S. Tsirkin
2014-12-02 3:15 ` Jason Wang
2014-12-02 3:15 ` Jason Wang
2014-12-02 8:07 ` Jason Wang
2014-12-02 8:07 ` Jason Wang
2014-12-02 9:43 ` Michael S. Tsirkin
2014-12-02 9:43 ` Michael S. Tsirkin
2014-12-02 9:51 ` Jason Wang
2014-12-02 9:51 ` Jason Wang
2014-12-02 9:55 ` Michael S. Tsirkin
2014-12-02 9:55 ` Michael S. Tsirkin
2014-12-02 10:08 ` Pankaj Gupta
2014-12-02 10:11 ` Michael S. Tsirkin
2014-12-02 10:11 ` Michael S. Tsirkin
2014-12-02 10:08 ` Pankaj Gupta
2014-12-02 10:00 ` David Laight
2014-12-02 10:00 ` David Laight
2014-12-02 10:08 ` Michael S. Tsirkin [this message]
2014-12-02 10:08 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141202100806.GA8056@redhat.com \
--to=mst@redhat.com \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pagupta@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.