From: Wolfram Sang <wsa@the-dreams.de>
To: Doug Anderson <dianders@chromium.org>
Cc: "Addy Ke" <addy.ke@rock-chips.com>,
"Max Schwarz" <max.schwarz@online.de>,
"Heiko Stübner" <heiko@sntech.de>,
"Olof Johansson" <olof@lixom.net>,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"Eddie Cai" <cf@rock-chips.com>,
"Jianqun Xu" <xjq@rock-chips.com>,
"Tao Huang" <huangtao@rock-chips.com>, Chris <zyw@rock-chips.com>,
姚智情 <yzq@rock-chips.com>, "han jiang" <hj@rock-chips.com>,
"Kever Yang" <kever.yang@rock-chips.com>,
"Lin Huang" <hl@rock-chips.com>, caesar <caesar.wang@rock-c>
Subject: Re: [PATCH v2] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C spec
Date: Thu, 4 Dec 2014 19:40:46 +0100 [thread overview]
Message-ID: <20141204184046.GL7944@katana> (raw)
In-Reply-To: <CAD=FV=X5inPWZakhgDX0dX=1CWXygEi3_AH9FVFWXYT3LZA5bg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 639 bytes --]
> If you don't read all the below, my belief is that we should simply
> rename the strings in Addy's patch. We should change "rise-ns" to
> "i2c-scl-rising-time" and "fall-ns" to "i2c-scl-falling-time".
> Wolfram: can you confirm this is OK? I'm voting to leave the "-ns"
> off the end of both to avoid asymmetry.
New binding should have the "-ns" suffix, right? So, I'd vote to add the
suffix to the new bindings and deprecate the ones used in the designware
driver: "i2c-scl-rising-time-ns" and "i2c-scl-falling-time-ns"
It might be a little more work now, but it will help us in the future,
because it is the correct way to do it.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C spec
Date: Thu, 4 Dec 2014 19:40:46 +0100 [thread overview]
Message-ID: <20141204184046.GL7944@katana> (raw)
In-Reply-To: <CAD=FV=X5inPWZakhgDX0dX=1CWXygEi3_AH9FVFWXYT3LZA5bg@mail.gmail.com>
> If you don't read all the below, my belief is that we should simply
> rename the strings in Addy's patch. We should change "rise-ns" to
> "i2c-scl-rising-time" and "fall-ns" to "i2c-scl-falling-time".
> Wolfram: can you confirm this is OK? I'm voting to leave the "-ns"
> off the end of both to avoid asymmetry.
New binding should have the "-ns" suffix, right? So, I'd vote to add the
suffix to the new bindings and deprecate the ones used in the designware
driver: "i2c-scl-rising-time-ns" and "i2c-scl-falling-time-ns"
It might be a little more work now, but it will help us in the future,
because it is the correct way to do it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141204/f3578831/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Doug Anderson <dianders@chromium.org>
Cc: "Addy Ke" <addy.ke@rock-chips.com>,
"Max Schwarz" <max.schwarz@online.de>,
"Heiko Stübner" <heiko@sntech.de>,
"Olof Johansson" <olof@lixom.net>,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"Eddie Cai" <cf@rock-chips.com>,
"Jianqun Xu" <xjq@rock-chips.com>,
"Tao Huang" <huangtao@rock-chips.com>, Chris <zyw@rock-chips.com>,
姚智情 <yzq@rock-chips.com>, "han jiang" <hj@rock-chips.com>,
"Kever Yang" <kever.yang@rock-chips.com>,
"Lin Huang" <hl@rock-chips.com>,
caesar <caesar.wang@rock-chips.com>,
"Shunqian Zheng" <zhengsq@rock-chips.com>
Subject: Re: [PATCH v2] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C spec
Date: Thu, 4 Dec 2014 19:40:46 +0100 [thread overview]
Message-ID: <20141204184046.GL7944@katana> (raw)
In-Reply-To: <CAD=FV=X5inPWZakhgDX0dX=1CWXygEi3_AH9FVFWXYT3LZA5bg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 639 bytes --]
> If you don't read all the below, my belief is that we should simply
> rename the strings in Addy's patch. We should change "rise-ns" to
> "i2c-scl-rising-time" and "fall-ns" to "i2c-scl-falling-time".
> Wolfram: can you confirm this is OK? I'm voting to leave the "-ns"
> off the end of both to avoid asymmetry.
New binding should have the "-ns" suffix, right? So, I'd vote to add the
suffix to the new bindings and deprecate the ones used in the designware
driver: "i2c-scl-rising-time-ns" and "i2c-scl-falling-time-ns"
It might be a little more work now, but it will help us in the future,
because it is the correct way to do it.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-12-04 18:40 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 8:11 [PATCH] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C spec Addy Ke
2014-11-06 8:11 ` Addy Ke
2014-11-06 8:11 ` Addy Ke
2014-12-02 23:02 ` Doug Anderson
2014-12-02 23:02 ` Doug Anderson
[not found] ` <1415261514-4051-1-git-send-email-addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-12-03 2:37 ` [PATCH v2] " Addy Ke
2014-12-03 2:37 ` Addy Ke
2014-12-03 2:37 ` Addy Ke
[not found] ` <1417574237-4328-1-git-send-email-addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-12-03 5:13 ` Doug Anderson
2014-12-03 5:13 ` Doug Anderson
2014-12-03 5:13 ` Doug Anderson
2014-12-03 11:15 ` Wolfram Sang
2014-12-03 11:15 ` Wolfram Sang
2014-12-03 11:15 ` Wolfram Sang
2014-12-03 17:53 ` Doug Anderson
2014-12-03 17:53 ` Doug Anderson
2014-12-03 17:53 ` Doug Anderson
2014-12-04 18:40 ` Wolfram Sang [this message]
2014-12-04 18:40 ` Wolfram Sang
2014-12-04 18:40 ` Wolfram Sang
2014-12-04 18:43 ` Doug Anderson
2014-12-04 18:43 ` Doug Anderson
2014-12-04 18:43 ` Doug Anderson
[not found] ` <CAD=FV=Vp3hwxbDzb+FUhNXy8qW8fTCkgd67jRDV3foT0o9HQuQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-04 19:03 ` Wolfram Sang
2014-12-04 19:03 ` Wolfram Sang
2014-12-04 19:03 ` Wolfram Sang
2014-12-05 19:31 ` Doug Anderson
2014-12-05 19:31 ` Doug Anderson
2014-12-05 19:31 ` Doug Anderson
2014-12-08 2:59 ` [PATCH v3] " Addy Ke
2014-12-08 2:59 ` Addy Ke
2014-12-08 2:59 ` Addy Ke
2014-12-08 8:52 ` Uwe Kleine-König
2014-12-08 8:52 ` Uwe Kleine-König
[not found] ` <20141208085202.GA13486-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-12-08 17:13 ` Doug Anderson
2014-12-08 17:13 ` Doug Anderson
2014-12-08 17:13 ` Doug Anderson
[not found] ` <CAD=FV=V=PDPiDhDmd+j8ePsF43EvuFP-LxKgMKo7ZRBzSMyOJA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-08 17:34 ` Wolfram Sang
2014-12-08 17:34 ` Wolfram Sang
2014-12-08 17:34 ` Wolfram Sang
2014-12-08 18:53 ` Doug Anderson
2014-12-08 18:53 ` Doug Anderson
2014-12-08 18:53 ` Doug Anderson
2014-12-08 20:04 ` Uwe Kleine-König
2014-12-08 20:04 ` Uwe Kleine-König
2014-12-08 20:04 ` Uwe Kleine-König
[not found] ` <1418007589-3688-1-git-send-email-addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-12-08 3:06 ` addy ke
2014-12-08 3:06 ` addy ke
2014-12-08 3:06 ` addy ke
2014-12-11 6:00 ` [PATCH v4] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C specification Addy Ke
2014-12-11 6:00 ` Addy Ke
2014-12-11 6:00 ` Addy Ke
[not found] ` <1418277650-25215-1-git-send-email-addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-12-11 7:47 ` Uwe Kleine-König
2014-12-11 7:47 ` Uwe Kleine-König
2014-12-11 7:47 ` Uwe Kleine-König
2014-12-11 11:02 ` [PATCH v5] " Addy Ke
2014-12-11 11:02 ` Addy Ke
2014-12-11 19:22 ` Doug Anderson
2014-12-11 19:22 ` Doug Anderson
2014-12-11 19:22 ` Doug Anderson
[not found] ` <1418295760-19639-1-git-send-email-addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-01-13 11:42 ` Wolfram Sang
2015-01-13 11:42 ` Wolfram Sang
2015-01-13 11:42 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141204184046.GL7944@katana \
--to=wsa@the-dreams.de \
--cc=addy.ke@rock-chips.com \
--cc=caesar.wang@rock-c \
--cc=cf@rock-chips.com \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=hj@rock-chips.com \
--cc=hl@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kever.yang@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=max.schwarz@online.de \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=xjq@rock-chips.com \
--cc=yzq@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.