All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Doug Anderson <dianders@chromium.org>
Cc: "Wolfram Sang" <wsa@the-dreams.de>,
	"Addy Ke" <addy.ke@rock-chips.com>,
	"Max Schwarz" <max.schwarz@online.de>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Olof Johansson" <olof@lixom.net>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Kumar Gala" <galak@codeaurora.org>,
	"Tao Huang" <huangtao@rock-chips.com>,
	"Lin Huang" <hl@rock-chips.com>, 姚智情 <yzq@rock-chips.com>,
	Chris <zyw@rock-chips.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Kever Yang" <kever.yang@rock-chips.com>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	"Jianqun Xu" <xjq@rock-chips.com>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	caesar <caesar.wang@rock-chips.com>,
	"Eddie Cai" <cf@rock-chips.com>, "Han Jiang" <hj@rock-chips.com>,
	"Shunqian Zheng" <zhengsq@rock-chips>
Subject: Re: [PATCH v3] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C spec
Date: Mon, 8 Dec 2014 21:04:15 +0100	[thread overview]
Message-ID: <20141208200415.GC13486@pengutronix.de> (raw)
In-Reply-To: <CAD=FV=WQypHthEDPGUqVX3kzfFBSdj4H+_QY_=WYA3R77H+WiQ@mail.gmail.com>

Hello,

On Mon, Dec 08, 2014 at 10:53:44AM -0800, Doug Anderson wrote:
> So just to summarize for Addy, I think you're being asked to spin one more time.
> 
> 1. Update the patch description as per Uwe.  Fix other typos pointed out by him.
> 
> 2. Since you're spinning anyway, adjust "i2c" capitalization to "I2C".
> 
> 3. If you agree with Uwe, rename spec_max_data_hold_ns to
> spec_data_valid_ns.  If not, we should debate in a followup patch.
> 
> 4. If you think spec_data_hold_buffer_ns could be better represented
> in another way (should this be i2c-sda-falling-time-ns"?), please do
> so.  If not, we should debate in a followup patch.
Sounds all reasonable. I'd not address 3 and 4 in this patch, but do
this in separate one. (That's what I intended from the beginning, just
failed to point that out explicitly.)

Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

WARNING: multiple messages have this Message-ID (diff)
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C spec
Date: Mon, 8 Dec 2014 21:04:15 +0100	[thread overview]
Message-ID: <20141208200415.GC13486@pengutronix.de> (raw)
In-Reply-To: <CAD=FV=WQypHthEDPGUqVX3kzfFBSdj4H+_QY_=WYA3R77H+WiQ@mail.gmail.com>

Hello,

On Mon, Dec 08, 2014 at 10:53:44AM -0800, Doug Anderson wrote:
> So just to summarize for Addy, I think you're being asked to spin one more time.
> 
> 1. Update the patch description as per Uwe.  Fix other typos pointed out by him.
> 
> 2. Since you're spinning anyway, adjust "i2c" capitalization to "I2C".
> 
> 3. If you agree with Uwe, rename spec_max_data_hold_ns to
> spec_data_valid_ns.  If not, we should debate in a followup patch.
> 
> 4. If you think spec_data_hold_buffer_ns could be better represented
> in another way (should this be i2c-sda-falling-time-ns"?), please do
> so.  If not, we should debate in a followup patch.
Sounds all reasonable. I'd not address 3 and 4 in this patch, but do
this in separate one. (That's what I intended from the beginning, just
failed to point that out explicitly.)

Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Doug Anderson <dianders@chromium.org>
Cc: "Wolfram Sang" <wsa@the-dreams.de>,
	"Addy Ke" <addy.ke@rock-chips.com>,
	"Max Schwarz" <max.schwarz@online.de>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Olof Johansson" <olof@lixom.net>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Kumar Gala" <galak@codeaurora.org>,
	"Tao Huang" <huangtao@rock-chips.com>,
	"Lin Huang" <hl@rock-chips.com>, 姚智情 <yzq@rock-chips.com>,
	Chris <zyw@rock-chips.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Kever Yang" <kever.yang@rock-chips.com>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	"Jianqun Xu" <xjq@rock-chips.com>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	caesar <caesar.wang@rock-chips.com>,
	"Eddie Cai" <cf@rock-chips.com>, "Han Jiang" <hj@rock-chips.com>,
	"Shunqian Zheng" <zhengsq@rock-chips.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C spec
Date: Mon, 8 Dec 2014 21:04:15 +0100	[thread overview]
Message-ID: <20141208200415.GC13486@pengutronix.de> (raw)
In-Reply-To: <CAD=FV=WQypHthEDPGUqVX3kzfFBSdj4H+_QY_=WYA3R77H+WiQ@mail.gmail.com>

Hello,

On Mon, Dec 08, 2014 at 10:53:44AM -0800, Doug Anderson wrote:
> So just to summarize for Addy, I think you're being asked to spin one more time.
> 
> 1. Update the patch description as per Uwe.  Fix other typos pointed out by him.
> 
> 2. Since you're spinning anyway, adjust "i2c" capitalization to "I2C".
> 
> 3. If you agree with Uwe, rename spec_max_data_hold_ns to
> spec_data_valid_ns.  If not, we should debate in a followup patch.
> 
> 4. If you think spec_data_hold_buffer_ns could be better represented
> in another way (should this be i2c-sda-falling-time-ns"?), please do
> so.  If not, we should debate in a followup patch.
Sounds all reasonable. I'd not address 3 and 4 in this patch, but do
this in separate one. (That's what I intended from the beginning, just
failed to point that out explicitly.)

Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  reply	other threads:[~2014-12-08 20:04 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-06  8:11 [PATCH] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C spec Addy Ke
2014-11-06  8:11 ` Addy Ke
2014-11-06  8:11 ` Addy Ke
2014-12-02 23:02 ` Doug Anderson
2014-12-02 23:02   ` Doug Anderson
     [not found] ` <1415261514-4051-1-git-send-email-addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-12-03  2:37   ` [PATCH v2] " Addy Ke
2014-12-03  2:37     ` Addy Ke
2014-12-03  2:37     ` Addy Ke
     [not found]     ` <1417574237-4328-1-git-send-email-addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-12-03  5:13       ` Doug Anderson
2014-12-03  5:13         ` Doug Anderson
2014-12-03  5:13         ` Doug Anderson
2014-12-03 11:15       ` Wolfram Sang
2014-12-03 11:15         ` Wolfram Sang
2014-12-03 11:15         ` Wolfram Sang
2014-12-03 17:53         ` Doug Anderson
2014-12-03 17:53           ` Doug Anderson
2014-12-03 17:53           ` Doug Anderson
2014-12-04 18:40           ` Wolfram Sang
2014-12-04 18:40             ` Wolfram Sang
2014-12-04 18:40             ` Wolfram Sang
2014-12-04 18:43             ` Doug Anderson
2014-12-04 18:43               ` Doug Anderson
2014-12-04 18:43               ` Doug Anderson
     [not found]               ` <CAD=FV=Vp3hwxbDzb+FUhNXy8qW8fTCkgd67jRDV3foT0o9HQuQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-04 19:03                 ` Wolfram Sang
2014-12-04 19:03                   ` Wolfram Sang
2014-12-04 19:03                   ` Wolfram Sang
2014-12-05 19:31                   ` Doug Anderson
2014-12-05 19:31                     ` Doug Anderson
2014-12-05 19:31                     ` Doug Anderson
2014-12-08  2:59   ` [PATCH v3] " Addy Ke
2014-12-08  2:59     ` Addy Ke
2014-12-08  2:59     ` Addy Ke
     [not found]     ` <1418007589-3688-1-git-send-email-addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-12-08  3:06       ` addy ke
2014-12-08  3:06         ` addy ke
2014-12-08  3:06         ` addy ke
2014-12-11  6:00       ` [PATCH v4] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C specification Addy Ke
2014-12-11  6:00         ` Addy Ke
2014-12-11  6:00         ` Addy Ke
     [not found]         ` <1418277650-25215-1-git-send-email-addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-12-11  7:47           ` Uwe Kleine-König
2014-12-11  7:47             ` Uwe Kleine-König
2014-12-11  7:47             ` Uwe Kleine-König
2014-12-11 11:02         ` [PATCH v5] " Addy Ke
2014-12-11 11:02           ` Addy Ke
2014-12-11 19:22           ` Doug Anderson
2014-12-11 19:22             ` Doug Anderson
2014-12-11 19:22             ` Doug Anderson
     [not found]           ` <1418295760-19639-1-git-send-email-addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-01-13 11:42             ` Wolfram Sang
2015-01-13 11:42               ` Wolfram Sang
2015-01-13 11:42               ` Wolfram Sang
2014-12-08  8:52     ` [PATCH v3] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C spec Uwe Kleine-König
2014-12-08  8:52       ` Uwe Kleine-König
     [not found]       ` <20141208085202.GA13486-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-12-08 17:13         ` Doug Anderson
2014-12-08 17:13           ` Doug Anderson
2014-12-08 17:13           ` Doug Anderson
     [not found]           ` <CAD=FV=V=PDPiDhDmd+j8ePsF43EvuFP-LxKgMKo7ZRBzSMyOJA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-08 17:34             ` Wolfram Sang
2014-12-08 17:34               ` Wolfram Sang
2014-12-08 17:34               ` Wolfram Sang
2014-12-08 18:53               ` Doug Anderson
2014-12-08 18:53                 ` Doug Anderson
2014-12-08 18:53                 ` Doug Anderson
2014-12-08 20:04                 ` Uwe Kleine-König [this message]
2014-12-08 20:04                   ` Uwe Kleine-König
2014-12-08 20:04                   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141208200415.GC13486@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=addy.ke@rock-chips.com \
    --cc=caesar.wang@rock-chips.com \
    --cc=cf@rock-chips.com \
    --cc=dianders@chromium.org \
    --cc=galak@codeaurora.org \
    --cc=heiko@sntech.de \
    --cc=hj@rock-chips.com \
    --cc=hl@rock-chips.com \
    --cc=huangtao@rock-chips.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kever.yang@rock-chips.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=max.schwarz@online.de \
    --cc=olof@lixom.net \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=wsa@the-dreams.de \
    --cc=xjq@rock-chips.com \
    --cc=yzq@rock-chips.com \
    --cc=zhengsq@rock-chips \
    --cc=zyw@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.