From: Vinod Koul <vinod.koul@intel.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Mark Brown <broonie@kernel.org>,
linux@arm.linux.org.uk, nsekhar@ti.com, arnd@arndb.de,
khilman@deeprootsystems.com, Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
ulf.hansson@linaro.org, chris@printf.net,
linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
linux-spi@vger.kernel.org, linux-omap@vger.kernel.org,
Tony Lindgren <tony@atomide.com>,
dmaengine@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: edma: Split up header file to platform_data and API file
Date: Mon, 8 Dec 2014 18:19:17 +0530 [thread overview]
Message-ID: <20141208124917.GI16827@intel.com> (raw)
In-Reply-To: <1417084891-17990-4-git-send-email-peter.ujfalusi@ti.com>
On Thu, Nov 27, 2014 at 12:41:31PM +0200, Peter Ujfalusi wrote:
> include/linux/platform_data/ is not a correct place to keep the API
> definitions for edma, it is meant to be only for the pdata for the device.
> Clean up this by moving the API to include/linux/edma.h
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> arch/arm/common/edma.c | 3 +-
> arch/arm/mach-davinci/devices.c | 1 +
> arch/arm/mach-davinci/include/mach/da8xx.h | 1 +
> drivers/dma/edma.c | 2 +-
> include/linux/edma.h | 153 +++++++++++++++++++++++++++++
> include/linux/platform_data/edma.h | 148 ++--------------------------
> sound/soc/davinci/davinci-pcm.h | 1 +
> 7 files changed, 165 insertions(+), 144 deletions(-)
> create mode 100644 include/linux/edma.h
I was hoping that this will have delete for platform_data/edma.h, do we
still need that and why shouldn't we get rid of this :)
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: edma: Split up header file to platform_data and API file
Date: Mon, 8 Dec 2014 18:19:17 +0530 [thread overview]
Message-ID: <20141208124917.GI16827@intel.com> (raw)
In-Reply-To: <1417084891-17990-4-git-send-email-peter.ujfalusi@ti.com>
On Thu, Nov 27, 2014 at 12:41:31PM +0200, Peter Ujfalusi wrote:
> include/linux/platform_data/ is not a correct place to keep the API
> definitions for edma, it is meant to be only for the pdata for the device.
> Clean up this by moving the API to include/linux/edma.h
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> arch/arm/common/edma.c | 3 +-
> arch/arm/mach-davinci/devices.c | 1 +
> arch/arm/mach-davinci/include/mach/da8xx.h | 1 +
> drivers/dma/edma.c | 2 +-
> include/linux/edma.h | 153 +++++++++++++++++++++++++++++
> include/linux/platform_data/edma.h | 148 ++--------------------------
> sound/soc/davinci/davinci-pcm.h | 1 +
> 7 files changed, 165 insertions(+), 144 deletions(-)
> create mode 100644 include/linux/edma.h
I was hoping that this will have delete for platform_data/edma.h, do we
still need that and why shouldn't we get rid of this :)
--
~Vinod
next prev parent reply other threads:[~2014-12-08 12:49 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 10:41 [PATCH 0/3] ARM: edma: Correct header file usage Peter Ujfalusi
2014-11-27 10:41 ` Peter Ujfalusi
2014-11-27 10:41 ` Peter Ujfalusi
2014-11-27 10:41 ` Peter Ujfalusi
[not found] ` <1417084891-17990-1-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
2014-11-27 10:41 ` [PATCH 1/3] ASoC: davinci-evm: Do not include edma headers Peter Ujfalusi
2014-11-27 10:41 ` Peter Ujfalusi
2014-11-27 10:41 ` Peter Ujfalusi
2014-11-27 10:41 ` Peter Ujfalusi
2014-11-27 10:58 ` Mark Brown
2014-11-27 10:58 ` Mark Brown
2014-11-27 10:58 ` Mark Brown
2014-11-27 10:41 ` [PATCH 2/3] ARM: edma: Rename header file for dmaengine filter function definition Peter Ujfalusi
2014-11-27 10:41 ` Peter Ujfalusi
2014-11-27 10:41 ` Peter Ujfalusi
2014-11-27 11:14 ` Arnd Bergmann
2014-11-27 11:14 ` Arnd Bergmann
2014-11-27 14:23 ` Peter Ujfalusi
2014-11-27 14:23 ` Peter Ujfalusi
2014-11-27 14:23 ` Peter Ujfalusi
2014-11-27 14:50 ` Arnd Bergmann
2014-11-27 14:50 ` Arnd Bergmann
2014-11-27 14:50 ` Arnd Bergmann
2014-11-27 18:46 ` Peter Ujfalusi
2014-11-27 18:46 ` Peter Ujfalusi
2014-11-27 18:46 ` Peter Ujfalusi
2014-11-27 18:46 ` Peter Ujfalusi
[not found] ` <54777174.4070203-l0cyMroinI0@public.gmane.org>
2014-11-27 21:52 ` Arnd Bergmann
2014-11-27 21:52 ` Arnd Bergmann
2014-11-27 21:52 ` Arnd Bergmann
2014-11-28 7:16 ` Peter Ujfalusi
2014-11-28 7:16 ` Peter Ujfalusi
2014-11-28 7:16 ` Peter Ujfalusi
2014-11-28 10:51 ` Arnd Bergmann
2014-11-28 10:51 ` Arnd Bergmann
2014-11-28 11:48 ` Peter Ujfalusi
2014-11-28 11:48 ` Peter Ujfalusi
2014-11-28 11:48 ` Peter Ujfalusi
2014-11-28 10:57 ` Ulf Hansson
2014-11-28 10:57 ` Ulf Hansson
2014-11-27 10:41 ` [PATCH 3/3] ARM: edma: Split up header file to platform_data and API file Peter Ujfalusi
2014-11-27 10:41 ` Peter Ujfalusi
2014-11-27 10:41 ` Peter Ujfalusi
2014-12-08 12:49 ` Vinod Koul [this message]
2014-12-08 12:49 ` Vinod Koul
[not found] ` <20141208124917.GI16827-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-12-08 13:16 ` Arnd Bergmann
2014-12-08 13:16 ` Arnd Bergmann
2014-12-08 13:16 ` Arnd Bergmann
2014-12-30 13:17 ` Peter Ujfalusi
2014-12-30 13:17 ` Peter Ujfalusi
2014-12-30 13:17 ` Peter Ujfalusi
2015-01-22 1:40 ` Olof Johansson
2015-01-22 1:40 ` Olof Johansson
2015-01-26 7:29 ` Peter Ujfalusi
2015-01-26 7:29 ` Peter Ujfalusi
2015-01-26 7:29 ` Peter Ujfalusi
2015-01-14 9:51 ` [PATCH 0/3] ARM: edma: Correct header file usage Sekhar Nori
2015-01-14 9:51 ` Sekhar Nori
2015-01-14 9:51 ` Sekhar Nori
2015-01-14 9:51 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141208124917.GI16827@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=chris@printf.net \
--cc=dmaengine@vger.kernel.org \
--cc=khilman@deeprootsystems.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nsekhar@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.