From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: alsa-devel@alsa-project.org, linux@arm.linux.org.uk,
vinod.koul@intel.com, nsekhar@ti.com, linux-spi@vger.kernel.org,
linux-mmc@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, khilman@deeprootsystems.com,
Tony Lindgren <tony@atomide.com>, Mark Brown <broonie@kernel.org>,
chris@printf.net, dmaengine@vger.kernel.org,
ulf.hansson@linaro.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] ARM: edma: Rename header file for dmaengine filter function definition
Date: Fri, 28 Nov 2014 09:16:24 +0200 [thread overview]
Message-ID: <54782148.6040108@ti.com> (raw)
In-Reply-To: <4859328.eEV7jzKEaA@wuerfel>
On 11/27/2014 11:52 PM, Arnd Bergmann wrote:
> On Thursday 27 November 2014 20:46:12 Peter Ujfalusi wrote:
>>
>> I see. With this series I did not planed to fix all edma related issues, just
>> as a start clean up the related header files. I would rather not add fixes to
>> mmc, spi, etc drivers since while you have valid point it is not in the scope
>> of this series.
>> Can we do the changes you are suggesting in an incremental manner?
>
> Sure, but I'd leave the existing filter function declaration alone then
> and not move it, since we wouldn't want to keep it in the long run.
but if you want to reference the filter function (which is in
drivers/dma/edma.c) in arch/arm/mach-davinci/ directory, we will need it.
Don't we?
If I leave the header as it is, then how would we clean up the edma headers? I
would not put the API definitions for the arch code into the same file as we
have the filter definition.
>
> Arnd
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Péter
WARNING: multiple messages have this Message-ID (diff)
From: peter.ujfalusi@ti.com (Peter Ujfalusi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: edma: Rename header file for dmaengine filter function definition
Date: Fri, 28 Nov 2014 09:16:24 +0200 [thread overview]
Message-ID: <54782148.6040108@ti.com> (raw)
In-Reply-To: <4859328.eEV7jzKEaA@wuerfel>
On 11/27/2014 11:52 PM, Arnd Bergmann wrote:
> On Thursday 27 November 2014 20:46:12 Peter Ujfalusi wrote:
>>
>> I see. With this series I did not planed to fix all edma related issues, just
>> as a start clean up the related header files. I would rather not add fixes to
>> mmc, spi, etc drivers since while you have valid point it is not in the scope
>> of this series.
>> Can we do the changes you are suggesting in an incremental manner?
>
> Sure, but I'd leave the existing filter function declaration alone then
> and not move it, since we wouldn't want to keep it in the long run.
but if you want to reference the filter function (which is in
drivers/dma/edma.c) in arch/arm/mach-davinci/ directory, we will need it.
Don't we?
If I leave the header as it is, then how would we clean up the edma headers? I
would not put the API definitions for the arch code into the same file as we
have the filter definition.
>
> Arnd
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
P?ter
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: <linux-arm-kernel@lists.infradead.org>,
<alsa-devel@alsa-project.org>, <linux-omap@vger.kernel.org>,
<linux@arm.linux.org.uk>, <vinod.koul@intel.com>,
<linux-mmc@vger.kernel.org>, <nsekhar@ti.com>,
Liam Girdwood <lgirdwood@gmail.com>,
<linux-kernel@vger.kernel.org>, <khilman@deeprootsystems.com>,
Tony Lindgren <tony@atomide.com>, Mark Brown <broonie@kernel.org>,
<chris@printf.net>, <dmaengine@vger.kernel.org>,
<ulf.hansson@linaro.org>, <linux-spi@vger.kernel.org>
Subject: Re: [PATCH 2/3] ARM: edma: Rename header file for dmaengine filter function definition
Date: Fri, 28 Nov 2014 09:16:24 +0200 [thread overview]
Message-ID: <54782148.6040108@ti.com> (raw)
In-Reply-To: <4859328.eEV7jzKEaA@wuerfel>
On 11/27/2014 11:52 PM, Arnd Bergmann wrote:
> On Thursday 27 November 2014 20:46:12 Peter Ujfalusi wrote:
>>
>> I see. With this series I did not planed to fix all edma related issues, just
>> as a start clean up the related header files. I would rather not add fixes to
>> mmc, spi, etc drivers since while you have valid point it is not in the scope
>> of this series.
>> Can we do the changes you are suggesting in an incremental manner?
>
> Sure, but I'd leave the existing filter function declaration alone then
> and not move it, since we wouldn't want to keep it in the long run.
but if you want to reference the filter function (which is in
drivers/dma/edma.c) in arch/arm/mach-davinci/ directory, we will need it.
Don't we?
If I leave the header as it is, then how would we clean up the edma headers? I
would not put the API definitions for the arch code into the same file as we
have the filter definition.
>
> Arnd
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Péter
next prev parent reply other threads:[~2014-11-28 7:16 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 10:41 [PATCH 0/3] ARM: edma: Correct header file usage Peter Ujfalusi
2014-11-27 10:41 ` Peter Ujfalusi
2014-11-27 10:41 ` Peter Ujfalusi
2014-11-27 10:41 ` Peter Ujfalusi
[not found] ` <1417084891-17990-1-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
2014-11-27 10:41 ` [PATCH 1/3] ASoC: davinci-evm: Do not include edma headers Peter Ujfalusi
2014-11-27 10:41 ` Peter Ujfalusi
2014-11-27 10:41 ` Peter Ujfalusi
2014-11-27 10:41 ` Peter Ujfalusi
2014-11-27 10:58 ` Mark Brown
2014-11-27 10:58 ` Mark Brown
2014-11-27 10:58 ` Mark Brown
2014-11-27 10:41 ` [PATCH 2/3] ARM: edma: Rename header file for dmaengine filter function definition Peter Ujfalusi
2014-11-27 10:41 ` Peter Ujfalusi
2014-11-27 10:41 ` Peter Ujfalusi
2014-11-27 11:14 ` Arnd Bergmann
2014-11-27 11:14 ` Arnd Bergmann
2014-11-27 14:23 ` Peter Ujfalusi
2014-11-27 14:23 ` Peter Ujfalusi
2014-11-27 14:23 ` Peter Ujfalusi
2014-11-27 14:50 ` Arnd Bergmann
2014-11-27 14:50 ` Arnd Bergmann
2014-11-27 14:50 ` Arnd Bergmann
2014-11-27 18:46 ` Peter Ujfalusi
2014-11-27 18:46 ` Peter Ujfalusi
2014-11-27 18:46 ` Peter Ujfalusi
2014-11-27 18:46 ` Peter Ujfalusi
[not found] ` <54777174.4070203-l0cyMroinI0@public.gmane.org>
2014-11-27 21:52 ` Arnd Bergmann
2014-11-27 21:52 ` Arnd Bergmann
2014-11-27 21:52 ` Arnd Bergmann
2014-11-28 7:16 ` Peter Ujfalusi [this message]
2014-11-28 7:16 ` Peter Ujfalusi
2014-11-28 7:16 ` Peter Ujfalusi
2014-11-28 10:51 ` Arnd Bergmann
2014-11-28 10:51 ` Arnd Bergmann
2014-11-28 11:48 ` Peter Ujfalusi
2014-11-28 11:48 ` Peter Ujfalusi
2014-11-28 11:48 ` Peter Ujfalusi
2014-11-28 10:57 ` Ulf Hansson
2014-11-28 10:57 ` Ulf Hansson
2014-11-27 10:41 ` [PATCH 3/3] ARM: edma: Split up header file to platform_data and API file Peter Ujfalusi
2014-11-27 10:41 ` Peter Ujfalusi
2014-11-27 10:41 ` Peter Ujfalusi
2014-12-08 12:49 ` Vinod Koul
2014-12-08 12:49 ` Vinod Koul
[not found] ` <20141208124917.GI16827-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-12-08 13:16 ` Arnd Bergmann
2014-12-08 13:16 ` Arnd Bergmann
2014-12-08 13:16 ` Arnd Bergmann
2014-12-30 13:17 ` Peter Ujfalusi
2014-12-30 13:17 ` Peter Ujfalusi
2014-12-30 13:17 ` Peter Ujfalusi
2015-01-22 1:40 ` Olof Johansson
2015-01-22 1:40 ` Olof Johansson
2015-01-26 7:29 ` Peter Ujfalusi
2015-01-26 7:29 ` Peter Ujfalusi
2015-01-26 7:29 ` Peter Ujfalusi
2015-01-14 9:51 ` [PATCH 0/3] ARM: edma: Correct header file usage Sekhar Nori
2015-01-14 9:51 ` Sekhar Nori
2015-01-14 9:51 ` Sekhar Nori
2015-01-14 9:51 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54782148.6040108@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=chris@printf.net \
--cc=dmaengine@vger.kernel.org \
--cc=khilman@deeprootsystems.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nsekhar@ti.com \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.