* nokia_h4p on 3.16+
@ 2014-12-08 20:47 ` Pavel Machek
0 siblings, 0 replies; 8+ messages in thread
From: Pavel Machek @ 2014-12-08 20:47 UTC (permalink / raw)
To: linux-arm-kernel
Hi!
It seems commit:
commit bd5dc09f557547399cd44d0a1224df7ff64e4a6b
Author: Felipe Balbi <balbi@ti.com>
Date: Wed Apr 23 09:58:28 2014 -0500
serial: fix UART_IIR_ID
UART IRQ Identification bitfield is 3
bits long (bits 3:1) but current mask only
masks 2 bits. Fix it.
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
breaks bluetooth driver on n900. (drivers/staging/nokia_h4p).
Pali, you may want to revert the patch.
That is good news, because reverting it on 3.18-rcX brings h4p back,
too (and as machine boots on nfsroot, debugging should be possible.)
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: nokia_h4p on 3.16+
2014-12-08 20:47 ` Pavel Machek
@ 2014-12-08 20:50 ` Pali Rohár
-1 siblings, 0 replies; 8+ messages in thread
From: Pali Rohár @ 2014-12-08 20:50 UTC (permalink / raw)
To: Pavel Machek
Cc: sre, sre, kernel list, linux-arm-kernel, linux-omap, tony,
khilman, aaro.koskinen, freemangordon, balbi, Greg KH, marcel,
Ivaylo Dimitrov
[-- Attachment #1: Type: Text/Plain, Size: 927 bytes --]
On Monday 08 December 2014 21:47:35 Pavel Machek wrote:
> Hi!
>
> It seems commit:
>
> commit bd5dc09f557547399cd44d0a1224df7ff64e4a6b
> Author: Felipe Balbi <balbi@ti.com>
> Date: Wed Apr 23 09:58:28 2014 -0500
>
> serial: fix UART_IIR_ID
>
> UART IRQ Identification bitfield is 3
> bits long (bits 3:1) but current mask only
> masks 2 bits. Fix it.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> breaks bluetooth driver on n900. (drivers/staging/nokia_h4p).
>
> Pali, you may want to revert the patch.
>
> That is good news, because reverting it on 3.18-rcX brings h4p
> back, too (and as machine boots on nfsroot, debugging should
> be possible.)
>
> Best regards,
> Pavel
Hi! this is good news.
CCing new freemangordon's @gmail address.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* nokia_h4p on 3.16+
@ 2014-12-08 20:50 ` Pali Rohár
0 siblings, 0 replies; 8+ messages in thread
From: Pali Rohár @ 2014-12-08 20:50 UTC (permalink / raw)
To: linux-arm-kernel
On Monday 08 December 2014 21:47:35 Pavel Machek wrote:
> Hi!
>
> It seems commit:
>
> commit bd5dc09f557547399cd44d0a1224df7ff64e4a6b
> Author: Felipe Balbi <balbi@ti.com>
> Date: Wed Apr 23 09:58:28 2014 -0500
>
> serial: fix UART_IIR_ID
>
> UART IRQ Identification bitfield is 3
> bits long (bits 3:1) but current mask only
> masks 2 bits. Fix it.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> breaks bluetooth driver on n900. (drivers/staging/nokia_h4p).
>
> Pali, you may want to revert the patch.
>
> That is good news, because reverting it on 3.18-rcX brings h4p
> back, too (and as machine boots on nfsroot, debugging should
> be possible.)
>
> Best regards,
> Pavel
Hi! this is good news.
CCing new freemangordon's @gmail address.
--
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141208/0f5d40aa/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: nokia_h4p on 3.16+
2014-12-08 20:47 ` Pavel Machek
@ 2014-12-08 22:06 ` Pali Rohár
-1 siblings, 0 replies; 8+ messages in thread
From: Pali Rohár @ 2014-12-08 22:06 UTC (permalink / raw)
To: Pavel Machek
Cc: sre, sre, kernel list, linux-arm-kernel, linux-omap, tony,
khilman, aaro.koskinen, freemangordon, balbi, Greg KH, marcel
[-- Attachment #1: Type: Text/Plain, Size: 917 bytes --]
On Monday 08 December 2014 21:47:35 Pavel Machek wrote:
> Hi!
>
> It seems commit:
>
> commit bd5dc09f557547399cd44d0a1224df7ff64e4a6b
> Author: Felipe Balbi <balbi@ti.com>
> Date: Wed Apr 23 09:58:28 2014 -0500
>
> serial: fix UART_IIR_ID
>
> UART IRQ Identification bitfield is 3
> bits long (bits 3:1) but current mask only
> masks 2 bits. Fix it.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> breaks bluetooth driver on n900. (drivers/staging/nokia_h4p).
>
> Pali, you may want to revert the patch.
>
> That is good news, because reverting it on 3.18-rcX brings h4p
> back, too (and as machine boots on nfsroot, debugging should
> be possible.)
>
> Best regards,
> Pavel
Reverted in linux-n900 git tree in v3.18-rc6-n900 branch.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* nokia_h4p on 3.16+
@ 2014-12-08 22:06 ` Pali Rohár
0 siblings, 0 replies; 8+ messages in thread
From: Pali Rohár @ 2014-12-08 22:06 UTC (permalink / raw)
To: linux-arm-kernel
On Monday 08 December 2014 21:47:35 Pavel Machek wrote:
> Hi!
>
> It seems commit:
>
> commit bd5dc09f557547399cd44d0a1224df7ff64e4a6b
> Author: Felipe Balbi <balbi@ti.com>
> Date: Wed Apr 23 09:58:28 2014 -0500
>
> serial: fix UART_IIR_ID
>
> UART IRQ Identification bitfield is 3
> bits long (bits 3:1) but current mask only
> masks 2 bits. Fix it.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> breaks bluetooth driver on n900. (drivers/staging/nokia_h4p).
>
> Pali, you may want to revert the patch.
>
> That is good news, because reverting it on 3.18-rcX brings h4p
> back, too (and as machine boots on nfsroot, debugging should
> be possible.)
>
> Best regards,
> Pavel
Reverted in linux-n900 git tree in v3.18-rc6-n900 branch.
--
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141208/688fd333/attachment-0001.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: nokia_h4p on 3.16+
2014-12-08 20:47 ` Pavel Machek
@ 2014-12-08 22:10 ` Pali Rohár
-1 siblings, 0 replies; 8+ messages in thread
From: Pali Rohár @ 2014-12-08 22:10 UTC (permalink / raw)
To: Pavel Machek
Cc: sre, sre, kernel list, linux-arm-kernel, linux-omap, tony,
khilman, aaro.koskinen, freemangordon, balbi, Greg KH, marcel
[-- Attachment #1: Type: Text/Plain, Size: 1018 bytes --]
On Monday 08 December 2014 21:47:35 Pavel Machek wrote:
> Hi!
>
> It seems commit:
>
> commit bd5dc09f557547399cd44d0a1224df7ff64e4a6b
> Author: Felipe Balbi <balbi@ti.com>
> Date: Wed Apr 23 09:58:28 2014 -0500
>
> serial: fix UART_IIR_ID
>
> UART IRQ Identification bitfield is 3
> bits long (bits 3:1) but current mask only
> masks 2 bits. Fix it.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> breaks bluetooth driver on n900. (drivers/staging/nokia_h4p).
>
> Pali, you may want to revert the patch.
>
> That is good news, because reverting it on 3.18-rcX brings h4p
> back, too (and as machine boots on nfsroot, debugging should
> be possible.)
>
> Best regards,
> Pavel
Pavel, maybe there is some unhandled iir value in function
static irqreturn_t hci_h4p_interrupt(int irq, void *data)
which cause that driver is not working?
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* nokia_h4p on 3.16+
@ 2014-12-08 22:10 ` Pali Rohár
0 siblings, 0 replies; 8+ messages in thread
From: Pali Rohár @ 2014-12-08 22:10 UTC (permalink / raw)
To: linux-arm-kernel
On Monday 08 December 2014 21:47:35 Pavel Machek wrote:
> Hi!
>
> It seems commit:
>
> commit bd5dc09f557547399cd44d0a1224df7ff64e4a6b
> Author: Felipe Balbi <balbi@ti.com>
> Date: Wed Apr 23 09:58:28 2014 -0500
>
> serial: fix UART_IIR_ID
>
> UART IRQ Identification bitfield is 3
> bits long (bits 3:1) but current mask only
> masks 2 bits. Fix it.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> breaks bluetooth driver on n900. (drivers/staging/nokia_h4p).
>
> Pali, you may want to revert the patch.
>
> That is good news, because reverting it on 3.18-rcX brings h4p
> back, too (and as machine boots on nfsroot, debugging should
> be possible.)
>
> Best regards,
> Pavel
Pavel, maybe there is some unhandled iir value in function
static irqreturn_t hci_h4p_interrupt(int irq, void *data)
which cause that driver is not working?
--
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141208/9712e5a3/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread